> The JDK codebase re-created many variants of checkIndex(`grep -I -r
> 'cehckIndex' jdk/`). A notable variant is java.nio.Buffer.checkIndex, which
> annotated with @IntrinsicCandidate and it only has a corresponding C1
> intrinsic version.
>
> In fact, there is an utility method
>
> Please review this PR that intents to make sealed classes a final feature in
> Java. This PR contains compiler and VM changes. In line with similar PRs,
> which has made preview features final, this one is mostly removing preview
> related comments from APIs plus options in test cases. Please
Update module summary, add a few existing properties and features into the
tables.
-
Commit messages:
- 8265248: Implementation Specific Properties: change prefix, plus add
existing properties
Changes: https://git.openjdk.java.net/jdk/pull/3644/files
Webrev:
Intel Short Vector Math Library (SVML) based intrinsics in native x86 assembly
provide optimized implementation for Vector API transcendental and
trigonometric methods.
These methods are built into a separate library instead of being part of
libjvm.so or jvm.dll.
The following changes are
On Fri, 16 Apr 2021 20:30:15 GMT, Rafael Winterhalter
wrote:
>> To allow agents the definition of auxiliary classes, an API is needed to
>> allow this. Currently, this is often achieved by using `sun.misc.Unsafe` or
>> `jdk.internal.misc.Unsafe` ever since the `defineClass` method was removed
On Thu, 22 Apr 2021 20:59:22 GMT, Phil Race wrote:
> Delete some duplicates
This pull request has now been integrated.
Changeset: b84f6901
Author:Phil Race
URL: https://git.openjdk.java.net/jdk/commit/b84f6901
Stats: 4 lines in 1 file changed: 0 ins; 4 del; 0 mod
8265793:
Delete some duplicates
-
Commit messages:
- 8265793: Remove duplicate jtreg TEST.groups references for some client tests
Changes: https://git.openjdk.java.net/jdk/pull/3642/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=3642=00
Issue:
On Thu, 22 Apr 2021 20:59:22 GMT, Phil Race wrote:
> Delete some duplicates
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3642
On Thu, 22 Apr 2021 10:13:32 GMT, Patrick Concannon
wrote:
>> I was able to find (with IntelliJ IDEA help) few more places to improve
>>
>> java.time 27 warnings
>> class Clock 2 warnings
>> class FixedClock 1 warning
>> method equals(Object)
On Thu, 22 Apr 2021 17:38:43 GMT, Naoto Sato wrote:
>> Please review the changes for the subject issue. This has been suggested in
>> a recent discussion thread for the JEP 400
>> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
>> A CSR has also been
On Thu, 22 Apr 2021 16:29:35 GMT, Roger Riggs wrote:
>> Then `charset()` in the shared secret would return `null`. Would that
>> suffice your case?
>
> I read lines 575-587 as initializing CHARSET regardless of whether the
> Console was created.
OK, revived the charset() method.
> Please review the changes for the subject issue. This has been suggested in
> a recent discussion thread for the JEP 400
> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
> A CSR has also been drafted, and comments are welcome
>
Mandy,
thanks for the confirmation we'll not have follow-up jdkXXinternals :)
Let me know if you have a spare minute to fix it some time soon,
otherwise I'll be happy to assist.
-Aleksei
On 22/04/2021 20:00, Mandy Chung wrote:
> Hi Aleksei,
>
> Looks like is a bug. "JDK removed internal API"
Hi Aleksei,
Looks like is a bug. "JDK removed internal API" is the intended
description as it indicates that a non-existent API is referenced.
I created https://bugs.openjdk.java.net/browse/JDK-8265773 to fix this.
thanks
Mandy
On 4/22/21 4:21 AM, Aleksei Voitylov wrote:
Hi,
JDK-8213909
On Thu, 22 Apr 2021 16:11:16 GMT, Naoto Sato wrote:
>> Not always, for example, if stderr was redirected to a terminal but not
>> stdin and stdout.
>> The istty check is only true if both stdin and stdout are ttys.
>
> Then `charset()` in the shared secret would return `null`. Would that
On Tue, 20 Apr 2021 23:37:15 GMT, Joe Darcy wrote:
> During the recent review of JDK-8228988, I noticed again the comments in the
> annotation parser about support for the pre-GA annotation format used before
> JDK 5.0 shipped. During the development of annotations, there was a late
> change
On Wed, 21 Apr 2021 13:13:16 GMT, Jim Laskey wrote:
>> Move makeXXXSpilterator from public (@hidden) to protected. No API ch
>
> Jim Laskey has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by
On Thu, 22 Apr 2021 16:03:12 GMT, Roger Riggs wrote:
>> Would the singleton `Console.cons` be instantiated in your use case? It is
>> created only when isatty() (or Windows' equivalent) in the native code
>> returns true.
>
> Not always, for example, if stderr was redirected to a terminal but
On Wed, 21 Apr 2021 22:38:32 GMT, Erik Gahlin wrote:
>> Jaroslav Bachorik has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix event metadata
>
> I wonder if something similar to below could be added to
> jdk.jfr.internal.Utils:
>
>
On Thu, 22 Apr 2021 15:42:02 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/io/Console.java line 597:
>>
>>> 595: return null;
>>> 596: }
>>> 597: });
>>
>> Please keep the charset() method and return CHARSET.
>>
>> I'm looking at a use case
On Fri, 16 Apr 2021 20:30:15 GMT, Rafael Winterhalter
wrote:
>> To allow agents the definition of auxiliary classes, an API is needed to
>> allow this. Currently, this is often achieved by using `sun.misc.Unsafe` or
>> `jdk.internal.misc.Unsafe` ever since the `defineClass` method was removed
> With this change it becomes possible to surface various cgroup level metrics
> (available via `jdk.internal.platform.Metrics`) as JFR events.
>
> Only a subset of the metrics exposed by `jdk.internal.platform.Metrics` is
> turned into JFR events to start with.
> * CPU related metrics
> *
On Thu, 22 Apr 2021 15:18:11 GMT, Roger Riggs wrote:
>> Naoto Sato has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 13 additional
>> commits
On Thu, 22 Apr 2021 at 13:58, Remi Forax wrote:
> I would like to preserve the invariant that, when calling a method on a
> Collection/iterator, an UnsupportedOperationException only occurs when trying
> to mutate that collection.
> If we are ok with that, this means that addFirst can not be a
On Tue, 20 Apr 2021 22:35:00 GMT, Naoto Sato wrote:
>> Please review the changes for the subject issue. This has been suggested in
>> a recent discussion thread for the JEP 400
>> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
>> A CSR has also been
On Thu, 25 Mar 2021 08:19:24 GMT, Fabian Meumertzheim
wrote:
> Adds missing @throws declarations for ArithmeticException to the public
> function
> java.math.BigDecimal#stripTrailingZeros
> as well as the private helper functions
> java.math.BigDecimal#createAndStripZerosToMatchScale(long, int,
On Thu, 25 Mar 2021 08:19:24 GMT, Fabian Meumertzheim
wrote:
> Adds missing @throws declarations for ArithmeticException to the public
> function
> java.math.BigDecimal#stripTrailingZeros
> as well as the private helper functions
> java.math.BigDecimal#createAndStripZerosToMatchScale(long, int,
> On Apr 22, 2021, at 7:41 AM, Andy Herrick wrote:
>
>
> On 4/21/2021 6:15 PM, Michael Hall wrote:
>> Reverted to Jdk 16 and temporarily couldn’t figure out why AppleScript
>> wasn’t working again.
>>
>> I needed to provide an entitlement. At jpackage 16 I found I needed to do
>> this
On Wed, 7 Apr 2021 18:49:36 GMT, Raffaello Giulietti
wrote:
> (Changed to new branch in personal fork)
>
> Please review these small tweaks.
> For background information see
> [1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075822.html)
>
> Greetings
> Raffaello
This
On Wed, 21 Apr 2021 13:13:16 GMT, Jim Laskey wrote:
>> Move makeXXXSpilterator from public (@hidden) to protected. No API ch
>
> Jim Laskey has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by
- Mail original -
> De: "Stuart Marks"
> À: "Remi Forax"
> Cc: "core-libs-dev"
> Envoyé: Mercredi 21 Avril 2021 19:38:23
> Objet: Re: ReversibleCollection proposal
> On 4/19/21 4:05 PM, fo...@univ-mlv.fr wrote:
>>> * There's a useful clump of semantics here, combined with sensible
On Tue, 20 Apr 2021 23:37:15 GMT, Joe Darcy wrote:
> During the recent review of JDK-8228988, I noticed again the comments in the
> annotation parser about support for the pre-GA annotation format used before
> JDK 5.0 shipped. During the development of annotations, there was a late
> change
- Mail original -
> De: "Stephen Colebourne"
> À: "core-libs-dev"
> Envoyé: Jeudi 22 Avril 2021 00:14:10
> Objet: Re: ReversibleCollection proposal
> On Wed, 21 Apr 2021 at 18:39, Stuart Marks wrote:
>> The value being provided here is that the ReversibleCollection interface
>>
On 4/21/2021 6:15 PM, Michael Hall wrote:
Reverted to Jdk 16 and temporarily couldn’t figure out why AppleScript wasn’t
working again.
I needed to provide an entitlement. At jpackage 16 I found I needed to do this
differently with a .entitlements file in the resources directory, as
I
- Mail original -
> De: "Stuart Marks"
> À: "Remi Forax"
> Cc: "core-libs-dev"
> Envoyé: Mercredi 21 Avril 2021 20:53:25
> Objet: Re: [External] : Re: ReversibleCollection proposal
> On 4/19/21 2:01 PM, Remi Forax wrote:
>> - Mail original -
>> Thinking a little bit about your
Hi,
JDK-8213909 [1] (since JDK 12, backported into 11.0.11), aside from
bringing great additions to transitive module analysis, introduced a
slight change in output of jdeps:
jdk-11.0.11/bin/jdeps -s reactor-core-3.4.5.jar
reactor-core-3.4.5.jar -> jdk8internals
reactor-core-3.4.5.jar ->
On Wed, 21 Apr 2021 13:02:06 GMT, Andrey Turbanov
wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
>>
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a rebase. The incremental
On Wed, 24 Mar 2021 09:56:16 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
This pull request has now been integrated.
Changeset:
On Thu, 22 Apr 2021 08:19:53 GMT, Nick Gasson wrote:
> macOS on Apple silicon uses slightly different ABI conventions to the
> standard AArch64 ABI. The differences are outlined in [1]. In
> particular in the standard (AAPCS) ABI, variadic arguments may be passed
> in either registers or on
macOS on Apple silicon uses slightly different ABI conventions to the
standard AArch64 ABI. The differences are outlined in [1]. In
particular in the standard (AAPCS) ABI, variadic arguments may be passed
in either registers or on the stack following the normal calling
convention. To handle
41 matches
Mail list logo
