Re: RFR: JDK-8265496: improve null check in DeflaterOutputStream/InflaterInputStream [v2]

2021-04-25 Thread Vyom Tewari
On Mon, 26 Apr 2021 02:36:54 GMT, Hamlin Li wrote: >> code like below will create Deflater before null check, although it's not a >> real mem leak, but it's better to do null check before new Deflater. >> >> try { >> DeflaterOutputStream dos = new

Re: RFR: JDK-8265496: improve null check in DeflaterOutputStream/InflaterInputStream [v2]

2021-04-25 Thread Hamlin Li
> code like below will create Deflater before null check, although it's not a > real mem leak, but it's better to do null check before new Deflater. > > try { > DeflaterOutputStream dos = new DeflaterOutputStream(null); > } catch (NullPointerException e) { >

RFR: JDK-8265496: improve null check in DeflaterOutputStream/InflaterInputStream

2021-04-25 Thread Hamlin Li
code like below will create Deflater before null check, although it's not a real mem leak, but it's better to do null check before new Deflater. try { DeflaterOutputStream dos = new DeflaterOutputStream(null); } catch (NullPointerException e) { passed =

Re: Proposal to add JavaScript platform to jpackage

2021-04-25 Thread Andrew Oliver
While I agree it is a somewhat different platform than Linux, Mac, or Windows, I do think the web is a platform worth targeting. And when seen through just a slightly different lens, it is more like the others than it might first seem: On the platform: * It is difficult for users to run Java

Re: ReversibleCollection proposal

2021-04-25 Thread Peter Levart
On 4/23/21 8:33 AM, Stuart Marks wrote: This is what I intended anyway, ie that its OK for "first" to work on an unordered collection, just that addFirst() has very weak semantics wrt first-ness. "Ensures that this collection contains the specified element(optional operation). This has the

RFR: 8265474: Dubious 'null' assignment in CompactByteArray.expand

2021-04-25 Thread Andrey Turbanov
I propose to remove 'null' assignment of field CompactByteArray.values in `expand` method. In the next statement this field is overridden with another value - `tempArray`. This code was there from initial load of OpenJDK sources. I believe it was just leftovers from development phase of this

Re: RFR: 4926314: Optimize Reader.read(CharBuffer) [v9]

2021-04-25 Thread Philippe Marschall
On Fri, 16 Apr 2021 17:00:16 GMT, Brian Burkhalter wrote: >> Philippe Marschall has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 15 commits: >> >> - Merge master >> - Fix bug in CharArrayReader and add unit test >> - Clean up

Re: RFR: 4926314: Optimize Reader.read(CharBuffer) [v10]

2021-04-25 Thread Philippe Marschall
> Implement three optimiztations for Reader.read(CharBuffer) > > * Add a code path for heap buffers in Reader#read to use the backing array > instead of allocating a new one. > * Change the code path for direct buffers in Reader#read to limit the > intermediate allocation to

Re: RFR: 8265248: Implementation Specific Properties: change prefix, plus add existing properties

2021-04-25 Thread Lance Andersen
On Fri, 23 Apr 2021 00:41:17 GMT, Joe Wang wrote: > Update module summary, add a few existing properties and features into the > tables. Good morning Joe, The changes look good based on the discussions we have had about the change and the property documentation is more convenient to find

Re: RFR: 8048199: Replace anonymous inner classes with lambdas, where applicable, in JNDI [v2]

2021-04-25 Thread YassinHajaj
On Mon, 12 Apr 2021 16:12:17 GMT, Daniel Fuchs wrote: >> Conor Cleary has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Update copyright headers >> - Tidied up lambdas > >

Re: RFR: 8037397: RegEx pattern matching loses character class after intersection (&&) operator [v2]

2021-04-25 Thread YassinHajaj
On Fri, 2 Apr 2021 15:44:23 GMT, Ian Graves wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixing missing space > > Tagging with CSR because this will impact a long-standing (buggy) behavior. Hi @igraves , If you