On Wed, 28 Apr 2021 22:24:31 GMT, Naoto Sato wrote:
> After some internal discussion, we thought it was good to expose the native
> environment's default character encoding, which Charset.defaultCharset() is
> currently based on. This way applications will have a better migration path
> after
On Thu, 29 Apr 2021 00:37:37 GMT, Joe Wang wrote:
>> After some internal discussion, we thought it was good to expose the native
>> environment's default character encoding, which Charset.defaultCharset() is
>> currently based on. This way applications will have a better migration path
>> afte
> The JDK codebase re-created many variants of checkIndex(`grep -I -r
> 'cehckIndex' jdk/`). A notable variant is java.nio.Buffer.checkIndex, which
> annotated with @IntrinsicCandidate and it only has a corresponding C1
> intrinsic version.
>
> In fact, there is an utility method
> `jdk.intern
> The JDK codebase re-created many variants of checkIndex(`grep -I -r
> 'cehckIndex' jdk/`). A notable variant is java.nio.Buffer.checkIndex, which
> annotated with @IntrinsicCandidate and it only has a corresponding C1
> intrinsic version.
>
> In fact, there is an utility method
> `jdk.intern
On Wed, 28 Apr 2021 17:32:18 GMT, Igor Veresov wrote:
> Do we need to keep this flag?
Exactly, the flag should be removed.
Thanks,
Yang
-
PR: https://git.openjdk.java.net/jdk/pull/3615
On Wed, 28 Apr 2021 01:20:24 GMT, Yasumasa Suenaga wrote:
> We can see compiler warnings in jni_util.c as following on GCC 11. `buf`
> should be initialized.
This pull request has now been integrated.
Changeset: 4a9f2319
Author:Yasumasa Suenaga
URL:
https://git.openjdk.java.net/jdk
On Wed, 28 Apr 2021 22:24:31 GMT, Naoto Sato wrote:
> After some internal discussion, we thought it was good to expose the native
> environment's default character encoding, which Charset.defaultCharset() is
> currently based on. This way applications will have a better migration path
> after
On Wed, 28 Apr 2021 21:10:33 GMT, Maurizio Cimadamore
wrote:
> I just did a test:
>
> ```
> public class TestLookup {
> public static void main(String[] args) throws Throwable {
> MethodHandle handle =
> MethodHandles.lookup().findVirtual(CLinker.class, "downcallHandle",
> MethodT
I looked through a few libraries and found some methods where the option #2
proposal for Steam might be useful. If the JDK had constructors for ArrayList,
HashSet and other collection types that take arrays this method would work
there as well.
> default > R to(Function function)
> {
>retu
After some internal discussion, we thought it was good to expose the native
environment's default character encoding, which Charset.defaultCharset() is
currently based on. This way applications will have a better migration path
after the [JEP 400](https://openjdk.java.net/jeps/400) is implemente
On Wed, 28 Apr 2021 18:44:18 GMT, Daniel Fuchs wrote:
>> I think the method is called during module bootstrap - I don't think there
>> is a race in practice. This method is also called in other parts of
>> ModuleBootstrap. The code you allude to is called during initialization of
>> the Illega
On Wed, 28 Apr 2021 20:40:49 GMT, Mandy Chung wrote:
> > To be clear - by aliasing you mean when the @CallerSensitive implementation
> > is called with invokeinterface - so, e.g. doing
> > `MethodHandles.lookup().findVirtual(CLinker.class, ...)` right?
>
> Yes. The caller would be java.base if
> Intel Short Vector Math Library (SVML) based intrinsics in native x86
> assembly provide optimized implementation for Vector API transcendental and
> trigonometric methods.
> These methods are built into a separate library instead of being part of
> libjvm.so or jvm.dll.
>
> The following cha
On Wed, 28 Apr 2021 20:38:47 GMT, Maurizio Cimadamore
wrote:
> To be clear - by aliasing you mean when the @CallerSensitive implementation
> is called with invokeinterface - so, e.g. doing
> `MethodHandles.lookup().findVirtual(CLinker.class, ...)` right?
Yes. The caller would be java.base i
On Wed, 28 Apr 2021 18:33:36 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Wed, 28 Apr 2021 19:02:57 GMT, Daniel Fuchs wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address first batch of review comments
>
> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemoryA
On Tue, 27 Apr 2021 18:55:53 GMT, Brian Burkhalter wrote:
>> Please consider this request to correct a minor problem with the
>> optimization added for JDK-4926314. The change is to attempt to read the
>> number of elements remaining in the target buffer unless that number is
>> non-positive i
On Wed, 28 Apr 2021 10:42:54 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Wed, 28 Apr 2021 18:19:14 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/jdk/internal/module/IllegalNativeAccessChecker.java
>> line 78:
>>
>>> 76: int index = 0;
>>> 77: // the system property is removed after decoding
>>> 78: String value = getAndRe
On Wed, 28 Apr 2021 18:26:30 GMT, Maurizio Cimadamore
wrote:
> test/jdk/jdk/internal/reflect/CallerSensitive/CheckCSMs.java
Yes that's the test. That test misses to catch your case where aliasing may be
possible.
-
PR: https://git.openjdk.java.net/jdk/pull/3699
On Wed, 28 Apr 2021 17:53:44 GMT, Daniel Fuchs wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address first batch of review comments
>
> src/java.base/share/classes/jdk/internal/module/IllegalNativeAccessCh
On Wed, 28 Apr 2021 18:23:41 GMT, Mandy Chung wrote:
> > I believe that we had to move @CallerSensitive out of interfaces because
> > there was a test that was checking that @cs was not put on "virtual"
> > methods.
>
> Good if we do have such test. We need to re-examine this with the security
On Wed, 28 Apr 2021 10:42:54 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull request
On Wed, 28 Apr 2021 17:32:04 GMT, Roger Riggs wrote:
>> Good question. Given that the earlier changes in the whole set
>> (impl-specific properties) were backported, I assumed this would too, to be
>> complete. Code consistency and clean backport may exceed the benefit of a
>> more advanced co
> Update module summary, add a few existing properties and features into the
> tables.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
replace isAssignableFrom with instanceof
-
Changes:
- all: https://git.openjdk.java.ne
On Wed, 28 Apr 2021 18:07:32 GMT, Daniel Fuchs wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address first batch of review comments
>
> src/java.base/share/classes/jdk/internal/module/IllegalNativeAccessCh
On Wed, 28 Apr 2021 18:02:03 GMT, Mandy Chung wrote:
> I reviewed the `--enable-native-access` related change that looks fine.
>
> > Access to restricted methods from any other module not in the list is
> > disallowed and will result in an IllegalAccessException.
>
> I think you meant to say `
On Wed, 28 Apr 2021 10:42:54 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Wed, 28 Apr 2021 10:42:54 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Wed, 28 Apr 2021 01:11:38 GMT, Mandy Chung wrote:
> jdeps should print "JDK removed internal APIs" to give an informative
> description when a JDK internal API that is being referenced has been
> removed. JDK-8213909 incorrectly changed it to print `jdk8internals`.
>
> An example output is
On Fri, 23 Apr 2021 03:50:54 GMT, Yi Yang wrote:
>> The JDK codebase re-created many variants of checkIndex(`grep -I -r
>> 'cehckIndex' jdk/`). A notable variant is java.nio.Buffer.checkIndex, which
>> annotated with @IntrinsicCandidate and it only has a corresponding C1
>> intrinsic version.
On Wed, 28 Apr 2021 17:25:46 GMT, Joe Wang wrote:
>> src/java.xml/share/classes/com/sun/org/apache/xalan/internal/utils/XMLSecurityManager.java
>> line 264:
>>
>>> 262: int temp;
>>> 263: if (Integer.class.isAssignableFrom(value.getClass())) {
>>> 264: te
On Wed, 28 Apr 2021 10:42:54 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Wed, 28 Apr 2021 16:21:00 GMT, Roger Riggs wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update the CSR. See Update 03 in the CSR
>
> src/java.xml/share/classes/com/sun/org/apache/xalan/internal/utils/XMLSecurityM
On Wed, 28 Apr 2021 16:57:25 GMT, Ian Graves wrote:
>> 8266155: Convert java.base to use Stream.toList()
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removing redundant imports
Marked as reviewed by chegar (Reviewer).
--
On Wed, 28 Apr 2021 16:58:50 GMT, Naoto Sato wrote:
> This new regression test was introduced with the Console::charset(), but it
> fails on ubuntu platforms assuming its locales/encoding incorrectly. To not
> make false-alarm/noise on test runs, this fix minimizes the tests not
> depending on
On Wed, 28 Apr 2021 16:58:50 GMT, Naoto Sato wrote:
> This new regression test was introduced with the Console::charset(), but it
> fails on ubuntu platforms assuming its locales/encoding incorrectly. To not
> make false-alarm/noise on test runs, this fix minimizes the tests not
> depending on
This new regression test was introduced with the Console::charset(), but it
fails on ubuntu platforms assuming its locales/encoding incorrectly. To not
make false-alarm/noise on test runs, this fix minimizes the tests not depending
on the underlying OS's environment variables.
-
Co
On Wed, 28 Apr 2021 16:57:25 GMT, Ian Graves wrote:
>> 8266155: Convert java.base to use Stream.toList()
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removing redundant imports
Marked as reviewed by iris (Reviewer).
> 8266155: Convert java.base to use Stream.toList()
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Removing redundant imports
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3734/files
- new: https://git.openj
On Tue, 27 Apr 2021 23:07:33 GMT, Joe Wang wrote:
>> Update module summary, add a few existing properties and features into the
>> tables.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update the CSR. See Update 03 in the CS
On Wed, 28 Apr 2021 13:47:43 GMT, Maurizio Cimadamore
wrote:
>> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/CLinker.java
>> line 270:
>>
>>> 268:
>>> 269: /**
>>> 270: * Converts a Java string into a null-terminated C string, using
>>> the platform's default charse
On Wed, 28 Apr 2021 15:41:31 GMT, Chris Hegarty wrote:
>> 8266155: Convert java.base to use Stream.toList()
>
> src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 6788:
>
>> 6786: }
>> 6787:
>> 6788: /**
>
> I think the import of Collectors can be dropped in this file
On Tue, 27 Apr 2021 21:34:02 GMT, Ian Graves wrote:
> 8266155: Convert java.base to use Stream.toList()
Marked as reviewed by chegar (Reviewer).
src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 6788:
> 6786: }
> 6787:
> 6788: /**
I think the import of Collectors c
On Wed, 28 Apr 2021 15:29:20 GMT, Brian Burkhalter wrote:
>> Please consider this request to modify `Reader.read(CharBuffer)` to check
>> whether the buffer is read-only before reading any characters from the
>> character stream. This can happen now if the buffer is read-only. Character
>> are
> Please consider this request to modify `Reader.read(CharBuffer)` to check
> whether the buffer is read-only before reading any characters from the
> character stream. This can happen now if the buffer is read-only. Character
> are first read thereby advancing the stream before an attempt is ma
On Fri, 23 Apr 2021 19:48:47 GMT, Kim Barrett wrote:
> Please review this change to the String Deduplication facility. It is being
> changed to use OopStorage to hold weak references to relevant objects,
> rather than bespoke data structures requiring dedicated processing phases by
> supporting
On Mon, 19 Apr 2021 15:07:16 GMT, Fernando Guallini
wrote:
> Refactor the following shell tests to java:
> test/jdk/java/lang/RuntimeTests/shutdown/ShutdownHooks.sh
> test/jdk/java/lang/Runtime/exec/SetCwd.java
>
> In addition, the test SetCwd was running itself in separate java subprocesses
>
On 4/28/21 7:19 AM, Stuart Marks wrote:
On 4/27/21 9:17 AM, Anthony Vanelverdinghe wrote:
On Tuesday, April 27, 2021 11:25 CEST, Peter Levart
wrote:
Now just some of my thoughts about the proposal:
- SortedSet.addFirst/.addLast - I think an operation that would be used
in situations like:
On Wed, 28 Apr 2021 12:47:36 GMT, Chris Hegarty wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address first batch of review comments
>
> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/CLinke
On Wed, 28 Apr 2021 13:08:26 GMT, Chris Hegarty wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address first batch of review comments
>
> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/Memory
On Mon, 19 Apr 2021 15:07:16 GMT, Fernando Guallini
wrote:
> Refactor the following shell tests to java:
> test/jdk/java/lang/RuntimeTests/shutdown/ShutdownHooks.sh
> test/jdk/java/lang/Runtime/exec/SetCwd.java
>
> In addition, the test SetCwd was running itself in separate java subprocesses
>
Hi,
(I think the first version of this message never went through, so here it
goes just in case)
I just read quickly the proposal and it made me think about another common
issue. I wonder if we could tackle it as well.
I will call it the "find the first element when there is only one" problem.
It
On Wed, 28 Apr 2021 10:42:54 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Wed, 28 Apr 2021 01:20:24 GMT, Yasumasa Suenaga wrote:
> We can see compiler warnings in jni_util.c as following on GCC 11. `buf`
> should be initialized.
Seems ok.
src/java.base/share/native/libjava/jni_util.c line 465:
> 463: {
> 464: int len = (int)strlen(str);
> 465: jchar buf[
- Mail original -
> De: "Stuart Marks"
> À: "Remi Forax"
> Cc: "core-libs-dev"
> Envoyé: Vendredi 23 Avril 2021 08:56:53
> Objet: Re: ReversibleCollection proposal
>> An API can not use ReversibleCollection as parameter before all the
>> implementations of Collection that have an orderi
- Mail original -
> De: "Stuart Marks"
> À: "Peter Levart"
> Cc: "core-libs-dev" , "Stephen Colebourne"
>
> Envoyé: Mercredi 28 Avril 2021 02:04:22
> Objet: Re: ReversibleCollection proposal
> On 4/27/21 2:25 AM, Peter Levart wrote:
>> Right, I'm persuaded. Now if only the problems of
On Wed, 28 Apr 2021 09:10:37 GMT, Chris Hegarty wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address first batch of review comments
>
> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/Resour
On Wed, 28 Apr 2021 09:06:29 GMT, Chris Hegarty wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address first batch of review comments
>
> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/Resour
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull request
On Wed, 28 Apr 2021 09:25:01 GMT, Andrew Haley wrote:
> Re monotonicity: all is not necessarily lost. There's a theorem due to
> Ferguson and Brightman which says that
>
> ```
> if
> abs(f(m+) - f(m))
> eps < ---
> abs(f(m+)) + abs(f(m))'
>
> for all m, the a
On Wed, 28 Apr 2021 09:06:29 GMT, Chris Hegarty wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk.java.
On Mon, 26 Apr 2021 17:10:13 GMT, Maurizio Cimadamore
wrote:
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.jav
On 4/28/21 2:04 AM, Stuart Marks wrote:
Binary compatibility is important. And I guess there is a variant of
the proposal that includes ReversibleCollection and ReversibleSet and
is binary compatible.
Yes, the source incompatibilities with the types seem to involve type
inference (e.g., use
On Tue, 27 Apr 2021 18:40:24 GMT, Alan Bateman wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk.java.n
On Wed, 28 Apr 2021 01:11:38 GMT, Mandy Chung wrote:
> jdeps should print "JDK removed internal APIs" to give an informative
> description when a JDK internal API that is being referenced has been
> removed. JDK-8213909 incorrectly changed it to print `jdk8internals`.
>
> An example output is
On Mon, 19 Apr 2021 14:05:31 GMT, Сергей Цыпанов
wrote:
> As discussed in https://github.com/openjdk/jdk/pull/3464 we can clean-up
> null-checks remaining after
> [8142968](https://bugs.openjdk.java.net/browse/JDK-8142968) as
> Class.getPackageName() never returns null.
Oh, now I see my mist
68 matches
Mail list logo
