On Sat, 1 May 2021 23:00:05 GMT, Joe Darcy wrote:
> 8244146: javac changes for JEP 306
src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties
line 1769:
> 1767: compiler.warn.strictfp=\
> 1768: as of release 17, all floating-point expressions are evaluated
>
On Sat, 1 May 2021 23:00:05 GMT, Joe Darcy wrote:
> 8244146: javac changes for JEP 306
src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java line
1704:
> 1702: if (Feature.REDUNDANT_STRICTFP.allowedInSource(source))
> 1703: result = result & ~STRICTFP;
>
On 5/1/21 5:57 AM, fo...@univ-mlv.fr wrote:
I suppose the performance issue comes from the fact that traversing a
LinkedHahSet is slow because it's a linked list ?
You can replace a LinkedHashSet by a List + Set, the List keeps the values in
order, the Set avoids duplicates.
Using a
On Fri, 30 Apr 2021 04:22:37 GMT, Alexander Matveev
wrote:
> jpackage should specify architecture for produced PKG files via
> hostArchitectures="x86_x64 or arm64". aarch64 installer will be installable
> on x64 without specifying hostArchitectures which is not correct and if
> install on
The line of discussion here was introduced by Remi, who was making an argument of
the form "introducing a type cannot solve this particular problem, therefore,
introducing a new type is not useful at all." I was providing an example of where
the new type is useful as a method parameter. That's
On Sat, 1 May 2021 23:00:05 GMT, Joe Darcy wrote:
> 8244146: javac changes for JEP 306
For core-libs, under JEP 306 strictfp would be a no-op under 17. Therefore, the
few uses of the strictfp modifier in the base module can be removed.
-
PR:
On Tue, 4 May 2021 20:45:43 GMT, Lance Andersen wrote:
> Hi all,
>
> This fix addresses a change in TestNG behavior for the Before/AfterGroups
> annotations that was introduced via
> https://github.com/cbeust/testng/pull/2167. The tests have been verified
> against the latest TestNG
On Tue, 4 May 2021 22:49:22 GMT, Lance Andersen wrote:
>> Ah. I was just thinking of consistency with other tests. Up to you.
>
> I think your milage will vary depending on the author and the IDE being used.
> My primary concern was to address the issue for the failing test and
> Intellij
On Tue, 4 May 2021 22:44:18 GMT, Brian Burkhalter wrote:
>> That's IntelliJ magic. I can update if you prefer and can let IntelliJ
>> optimize all of the imports
>
> Ah. I was just thinking of consistency with other tests. Up to you.
I think your milage will vary depending on the author and
On Tue, 4 May 2021 22:42:57 GMT, Lance Andersen wrote:
>> test/jdk/java/io/InputStream/NullInputStream.java line 33:
>>
>>> 31: import java.io.InputStream;
>>> 32:
>>> 33: import static org.testng.Assert.*;
>>
>> Would it not be more standard to put the new imports just after this import?
>>
On Tue, 4 May 2021 22:36:29 GMT, Brian Burkhalter wrote:
>> Hi all,
>>
>> This fix addresses a change in TestNG behavior for the Before/AfterGroups
>> annotations that was introduced via
>> https://github.com/cbeust/testng/pull/2167. The tests have been verified
>> against the latest
On Tue, 4 May 2021 20:45:43 GMT, Lance Andersen wrote:
> Hi all,
>
> This fix addresses a change in TestNG behavior for the Before/AfterGroups
> annotations that was introduced via
> https://github.com/cbeust/testng/pull/2167. The tests have been verified
> against the latest TestNG
> If the given Path represents a file, use the overload of read defined
> in FileChannel that accepts an explicit position and avoid serializing
> reads.
>
> Note: The underlying NIO implementation is not required to implement
> FileChannel.read(ByteBuffer, long) concurrently; Windows still
On Wed, 28 Apr 2021 21:11:26 GMT, Sandhya Viswanathan
wrote:
>> This PR contains Short Vector Math Library support related changes for
>> [JEP-414 Vector API (Second Incubator)](https://openjdk.java.net/jeps/414),
>> in preparation for when targeted.
>>
>> Intel Short Vector Math Library
Hi all,
This fix addresses a change in TestNG behavior for the Before/AfterGroups
annotations that was introduced via
https://github.com/cbeust/testng/pull/2167. The tests have been verified
against the latest TestNG release and continue to run with the current TestNG
release used by
On Tue, 4 May 2021 21:09:59 GMT, Jim Laskey wrote:
> RandomTestCoverage.java was overlooked when doing local test. Apologies.
This pull request has now been integrated.
Changeset: f00b70e2
Author:Jim Laskey
URL:
On Tue, 4 May 2021 21:09:59 GMT, Jim Laskey wrote:
> RandomTestCoverage.java was overlooked when doing local test. Apologies.
Good to clean those out.
-
Marked as reviewed by rriggs (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/3867
RandomTestCoverage.java was overlooked when doing local test. Apologies.
-
Commit messages:
- Adjust testing for API removal
Changes: https://git.openjdk.java.net/jdk/pull/3867/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=3867=00
Issue:
On Tue, 4 May 2021 19:01:45 GMT, Brian Burkhalter wrote:
>> Only regular files this far. Are there any particular special files which
>> would be of interest?
>
> On `/proc/cpuinfo` for example, `fstat()` succeeds but `st_size` in `struct
> stat` is zero. The correct position is however
> Please consider this request to override the `java.io.InputStream` methods
> `readAllBytes()` and `readNBytes(int)` in `FileInputStream` with more
> performant implementations. The method overrides attempt to read all
> requested bytes into a single array of the required size rather than
>
On Fri, 30 Apr 2021 15:25:13 GMT, Andy Herrick wrote:
> JDK-8266227: Fix help text for --mac-signing-keychain
This pull request has now been integrated.
Changeset: c53dee74
Author:Andy Herrick
URL:
https://git.openjdk.java.net/jdk/commit/c53dee7480858811c32ac718f5a27a00e3483a38
Hi Suminda,
as I explained back in February, I already experimented blending
Schubfach with a variant of Grisu back in 2018. Contrary to my
expectations, I observed noticeable performance drops wrt pure
Schubfach. I didn't explore any further, but I think that the more
complex control logic
On Tue, 4 May 2021 17:46:15 GMT, Brian Burkhalter wrote:
>> src/java.base/share/classes/java/io/FileInputStream.java line 342:
>>
>>> 340:
>>> 341: private native long length() throws IOException;
>>> 342: private native long position() throws IOException;
>>
>> Can you confirm that
On Tue, 4 May 2021 14:07:18 GMT, Alan Bateman wrote:
>> Please consider this request to override the `java.io.InputStream` methods
>> `readAllBytes()` and `readNBytes(int)` in `FileInputStream` with more
>> performant implementations. The method overrides attempt to read all
>> requested
On Wed, 28 Apr 2021 22:24:31 GMT, Naoto Sato wrote:
> After some internal discussion, we thought it was good to expose the native
> environment's default character encoding, which Charset.defaultCharset() is
> currently based on. This way applications will have a better migration path
> after
On Thu, 29 Apr 2021 21:13:38 GMT, Paul Sandoz wrote:
> This PR contains API and implementation changes for [JEP-414 Vector API
> (Second Incubator)](https://openjdk.java.net/jeps/414), in preparation for
> when targeted.
>
> Enhancements are made to the API for the support of operations on
This PR contains API and implementation changes for [JEP-414 Vector API (Second
Incubator)](https://openjdk.java.net/jeps/414), in preparation for when
targeted.
Enhancements are made to the API for the support of operations on characters,
such as for UTF-8 character decoding. Specifically,
Hello,
I hope everything is well with you.
Due to other commitments this work has stalled.
I was planning to implement:
- fast to string conversion
- fast string parsing
- fast formatting
- fast search
- fast sort
- fast templating
- fast buffers
The code I have done so far is here:
On Fri, 30 Apr 2021 15:25:13 GMT, Andy Herrick wrote:
> JDK-8266227: Fix help text for --mac-signing-keychain
Marked as reviewed by asemenyuk (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3819
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull
On Tue, 4 May 2021 12:01:44 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/jdk/internal/module/IllegalNativeAccessChecker.java
>> line 34:
>>
>>> 32: import java.util.Set;
>>> 33:
>>> 34: public final class IllegalNativeAccessChecker {
>>
>> Are you sure about the name of
On Tue, 4 May 2021 12:05:15 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
On Tue, 4 May 2021 13:07:34 GMT, Jason Zaugg wrote:
> If the given Path represents a file, use the overload of read defined
> in FileChannel that accepts an explicit position and avoid serializing
> reads.
>
> Note: The underlying NIO implementation is not required to implement
>
On Mon, 3 May 2021 20:33:23 GMT, Brian Burkhalter wrote:
> Please consider this request to override the `java.io.InputStream` methods
> `readAllBytes()` and `readNBytes(int)` in `FileInputStream` with more
> performant implementations. The method overrides attempt to read all
> requested
On Tue, 4 May 2021 09:05:38 GMT, Athijegannathan Sundararajan
wrote:
> Instead of BufferReference class, Map.Entry is used as pair implementation.
> This avoids the metaspace leak seen via thread local.
looks OK to me.
-
Marked as reviewed by vtewari (Committer).
PR:
On Thu, 15 Apr 2021 12:48:35 GMT, Jim Laskey wrote:
> No longer needed
This pull request has now been integrated.
Changeset: 770dfc1e
Author:Jim Laskey
URL:
https://git.openjdk.java.net/jdk/commit/770dfc1ec4fe28bc73612c8b0dd8423dd49e1597
Stats: 25 lines in 1 file changed: 0
On Tue, 4 May 2021 12:07:15 GMT, Jim Laskey wrote:
>> No longer needed
>
> Jim Laskey has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains seven commits:
>
> - Merge branch 'master' into 8265279
> - RandomGeneratorFactory.all(Class
If the given Path represents a file, use the overload of read defined
in FileChannel that accepts an explicit position and avoid serializing
reads.
Note: The underlying NIO implementation is not required to implement
FileChannel.read(ByteBuffer, long) concurrently; Windows still appears
to lock,
On Fri, 30 Apr 2021 15:25:13 GMT, Andy Herrick wrote:
> JDK-8266227: Fix help text for --mac-signing-keychain
I updated the bug Description to point out that text formatting and other minor
wording changes are being applied to the help
-
PR:
On Fri, 23 Apr 2021 19:48:47 GMT, Kim Barrett wrote:
> Please review this change to the String Deduplication facility. It is being
> changed to use OopStorage to hold weak references to relevant objects,
> rather than bespoke data structures requiring dedicated processing phases by
> supporting
> No longer needed
Jim Laskey has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains seven commits:
- Merge branch 'master' into 8265279
- RandomGeneratorFactory.all(Class category) no longer needed
- Remove extraneous references to
On Tue, 4 May 2021 08:12:23 GMT, Alan Bateman wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Revert bad change in benchmark copyright
>> - Do not apply optimized bound check if accessed offset/length do
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull
On Tue, 13 Apr 2021 16:33:21 GMT, Jim Laskey wrote:
> Move makeXXXSpilterator from public (@hidden) to protected. No API ch
This pull request has now been integrated.
Changeset: 05e60174
Author:Jim Laskey
URL:
> Move makeXXXSpilterator from public (@hidden) to protected. No API ch
Jim Laskey has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains 10 additional
On Tue, 4 May 2021 09:05:38 GMT, Athijegannathan Sundararajan
wrote:
> Instead of BufferReference class, Map.Entry is used as pair implementation.
> This avoids the metaspace leak seen via thread local.
Marked as reviewed by jlaskey (Reviewer).
-
PR:
On Mon, 3 May 2021 22:52:21 GMT, Alexander Matveev wrote:
>> jpackage should specify architecture for produced PKG files via
>> hostArchitectures="x86_x64 or arm64". aarch64 installer will be installable
>> on x64 without specifying hostArchitectures which is not correct and if
>> install on
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull
On Tue, 4 May 2021 08:20:43 GMT, Alan Bateman wrote:
> Just to double, there is no way to enable native access for modules in module
> layers (other than the boot layer), right?
No, at the moment it is not possible to enable native access programmatically.
We will explore something along
Instead of BufferReference class, Map.Entry is used as pair implementation.
This avoids the metaspace leak seen via thread local.
-
Commit messages:
- added comment. generics cleanup.
- 8260621: (jrtfs) ThreadLocal memory leak in ImageBufferCache when using jrtfs
Changes:
On Fri, 30 Apr 2021 15:20:42 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
52 matches
Mail list logo
