Re: RFR: 8265783: Create a separate library for x86 Intel SVML assembly intrinsics [v4]

2021-05-14 Thread Sandhya Viswanathan
> This PR contains Short Vector Math Library support related changes for > [JEP-414 Vector API (Second Incubator)](https://openjdk.java.net/jeps/414), > in preparation for when targeted. > > Intel Short Vector Math Library (SVML) based intrinsics in native x86 > assembly provide optimized

Re: RFR: 8265783: Create a separate library for x86 Intel SVML assembly intrinsics [v3]

2021-05-14 Thread Sandhya Viswanathan
> This PR contains Short Vector Math Library support related changes for > [JEP-414 Vector API (Second Incubator)](https://openjdk.java.net/jeps/414), > in preparation for when targeted. > > Intel Short Vector Math Library (SVML) based intrinsics in native x86 > assembly provide optimized

RFR: 8267190: Optimize Vector API test operations

2021-05-14 Thread Sandhya Viswanathan
Vector API test operations (IS_DEFAULT, IS_FINITE, IS_INFINITE, IS_NAN and IS_NEGATIVE) are computed in three steps: 1) reinterpreting the floating point vectors as integral vectors (int/long) 2) perform the test in integer domain to get a int/long mask 3) reinterpret the int/long mask as

Integrated: 8249395: (macos) jpackage tests timeout on MacPro5_1 systems

2021-05-14 Thread Alexander Matveev
On Fri, 14 May 2021 04:24:42 GMT, Alexander Matveev wrote: > Looks like it is similar to JDK-8236282, except for "hdiutil create". Based > on call stack from failed test we launched "hdiutil create" and were waiting > for it to terminate while reading output from it. However, based on process

Re: JEP draft: Scope Locals

2021-05-14 Thread Brian Goetz
The lifecycle is bounded by the duration of the Runnable passed to the `run()` method. In the simple case, with no inheritance and no snapshotting:     ScopedLocal.where(x, xExpr).run(r) the lifecycle of the binding starts when we enter r, and ends when we return from r. With snapshotting,

Re: RFR: 8254598: StringDedupTable should use OopStorage [v5]

2021-05-14 Thread Kim Barrett
On Fri, 14 May 2021 12:40:46 GMT, Zhengyu Gu wrote: >> Kim Barrett has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 10 commits: >> >> - Merge branch 'master' into new_dedup2 >> - fix shenandoah merge >> - Merge branch 'master'

Integrated: 8254598: StringDedupTable should use OopStorage

2021-05-14 Thread Kim Barrett
On Fri, 23 Apr 2021 19:48:47 GMT, Kim Barrett wrote: > Please review this change to the String Deduplication facility. It is being > changed to use OopStorage to hold weak references to relevant objects, > rather than bespoke data structures requiring dedicated processing phases by > supporting

Re: RFR: 8254598: StringDedupTable should use OopStorage [v5]

2021-05-14 Thread Kim Barrett
> Please review this change to the String Deduplication facility. It is being > changed to use OopStorage to hold weak references to relevant objects, > rather than bespoke data structures requiring dedicated processing phases by > supporting GCs. > > (The Shenandoah update was contributed by

Re: RFR: 8249395: (macos) jpackage tests timeout on MacPro5_1 systems

2021-05-14 Thread Alexey Semenyuk
On Fri, 14 May 2021 04:24:42 GMT, Alexander Matveev wrote: > Looks like it is similar to JDK-8236282, except for "hdiutil create". Based > on call stack from failed test we launched "hdiutil create" and were waiting > for it to terminate while reading output from it. However, based on process

Re: Integrated: 8267180: Typo in copyright header for HashesTest

2021-05-14 Thread Joe Wang
On Fri, 14 May 2021 17:44:20 GMT, Lance Andersen wrote: > Please review this fix for a typo in the copyright header in HashTest which > the jdk-tier1 does not catch > > Best > Lance Marked as reviewed by joehw (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4034

Integrated: 8267180: Typo in copyright header for HashesTest

2021-05-14 Thread Lance Andersen
On Fri, 14 May 2021 17:44:20 GMT, Lance Andersen wrote: > Please review this fix for a typo in the copyright header in HashTest which > the jdk-tier1 does not catch > > Best > Lance This pull request has now been integrated. Changeset: 5eda812f Author:Lance Andersen URL:

Re: Integrated: 8267180: Typo in copyright header for HashesTest

2021-05-14 Thread Naoto Sato
On Fri, 14 May 2021 17:44:20 GMT, Lance Andersen wrote: > Please review this fix for a typo in the copyright header in HashTest which > the jdk-tier1 does not catch > > Best > Lance Marked as reviewed by naoto (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4034

Integrated: 8267180: Typo in copyright header for HashesTest

2021-05-14 Thread Lance Andersen
Please review this fix for a typo in the copyright header in HashTest which the jdk-tier1 does not catch Best Lance - Commit messages: - Typo in copyright header for HashesTest Changes: https://git.openjdk.java.net/jdk/pull/4034/files Webrev:

Re: Integrated: 8267180: Typo in copyright header for HashesTest

2021-05-14 Thread Daniel D . Daugherty
On Fri, 14 May 2021 17:44:20 GMT, Lance Andersen wrote: > Please review this fix for a typo in the copyright header in HashTest which > the jdk-tier1 does not catch > > Best > Lance Thumbs up. This is a trivial change. - Marked as reviewed by dcubed (Reviewer). PR:

Integrated: 8266461: tools/jmod/hashes/HashesTest.java fails: static @Test methods

2021-05-14 Thread Lance Andersen
On Thu, 13 May 2021 10:49:21 GMT, Lance Andersen wrote: > HI all, > > Please review the fix to HashesTest.java to support running on TestNG 7.4. > > The fix adds a no-arg constructor which TestNG requires. > > The change allows the test to run with the current jtreg as well as the >

Re: RFR: 8264777: Overload optimized FileInputStream::readAllBytes [v7]

2021-05-14 Thread Daniel Fuchs
On Mon, 10 May 2021 17:54:52 GMT, Brian Burkhalter wrote: >> Please consider this request to override the `java.io.InputStream` methods >> `readAllBytes()` and `readNBytes(int)` in `FileInputStream` with more >> performant implementations. The method overrides attempt to read all >> requested

Re: RFR: 8264777: Overload optimized FileInputStream::readAllBytes [v7]

2021-05-14 Thread Brian Burkhalter
On Mon, 10 May 2021 17:54:52 GMT, Brian Burkhalter wrote: >> Please consider this request to override the `java.io.InputStream` methods >> `readAllBytes()` and `readNBytes(int)` in `FileInputStream` with more >> performant implementations. The method overrides attempt to read all >> requested

Re: RFR: 8249395: (macos) jpackage tests timeout on MacPro5_1 systems

2021-05-14 Thread Andy Herrick
On Fri, 14 May 2021 04:24:42 GMT, Alexander Matveev wrote: > Looks like it is similar to JDK-8236282, except for "hdiutil create". Based > on call stack from failed test we launched "hdiutil create" and were waiting > for it to terminate while reading output from it. However, based on process

Re: JEP draft: Scope Locals

2021-05-14 Thread Andrew Haley
On 5/14/21 3:45 PM, Brian Goetz wrote: > Where I think the JEP draft (the exposition, not the feature design) > could be improved is to make the relationship to TL more clear.  IMO, > this is a "more modern" TL design; it addresses the same primary use > cases, without the unconstrained

Re: JEP draft: Scope Locals

2021-05-14 Thread Brian Goetz
Its simpler than you're making it.  Think of the motivating use cases for ThreadLocal, such as when a container calls into user code, and the user code calls back into the container, and we need to keep track of {transaction, security, etc} context, and it is impractical to pass them all

Integrated: 8266291: (jrtfs) Calling Files.exists may break the JRT filesystem

2021-05-14 Thread Athijegannathan Sundararajan
On Fri, 14 May 2021 05:39:10 GMT, Athijegannathan Sundararajan wrote: > Problematic paths that start with /modules/modules prefix are handled properly This pull request has now been integrated. Changeset: af4cd04c Author:Athijegannathan Sundararajan URL:

Re: RFR: 8266291: (jrtfs) Calling Files.exists may break the JRT filesystem [v2]

2021-05-14 Thread Athijegannathan Sundararajan
> Problematic paths that start with /modules/modules prefix are handled properly Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision: edited comment as per code review. - Changes: - all:

Re: JEP draft: Scope Locals

2021-05-14 Thread Alan Snyder
The essence of the example seems to be that the callback is supporting multiple client contexts and when called needs to act relative to the specific client context. The callback does not get a parameter identifying the client context because the library that calls it does not know anything

Re: RFR: 8254598: StringDedupTable should use OopStorage [v4]

2021-05-14 Thread Zhengyu Gu
On Fri, 14 May 2021 04:31:59 GMT, Kim Barrett wrote: >> Please review this change to the String Deduplication facility. It is being >> changed to use OopStorage to hold weak references to relevant objects, >> rather than bespoke data structures requiring dedicated processing phases by >>

Integrated: 8266622: Optimize Class.descriptorString() and Class.getCanonicalName0()

2021-05-14 Thread Сергей Цыпанов
On Thu, 6 May 2021 15:20:23 GMT, Сергей Цыпанов wrote: > Hello, from discussion in https://github.com/openjdk/jdk/pull/3464 and > https://github.com/openjdk/jdk/pull/2212 it appears, that in `j.l.Class` > expressions like > > String str = baseName.replace('.', '/') + '/' + name; > > are not

Re: RFR: 8266291: (jrtfs) Calling Files.exists may break the JRT filesystem

2021-05-14 Thread Alan Bateman
On Fri, 14 May 2021 05:39:10 GMT, Athijegannathan Sundararajan wrote: > Problematic paths that start with /modules/modules prefix are handled properly Marked as reviewed by alanb (Reviewer). src/java.base/share/classes/jdk/internal/jimage/ImageReader.java line 475: > 473: } >

Re: RFR: 8266461: tools/jmod/hashes/HashesTest.java fails: static @Test methods [v5]

2021-05-14 Thread Lance Andersen
> HI all, > > Please review the fix to HashesTest.java to support running on TestNG 7.4. > > The fix adds a no-arg constructor which TestNG requires. > > The change allows the test to run with the current jtreg as well as the > upcoming jtreg > > > Best > Lance Lance Andersen has updated

Re: RFR: 8266461: tools/jmod/hashes/HashesTest.java fails: static @Test methods [v4]

2021-05-14 Thread Lance Andersen
On Fri, 14 May 2021 08:02:29 GMT, Alan Bateman wrote: >> Lance Andersen has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Adjust imports and spacing > > test/jdk/tools/jmod/hashes/HashesTest.java line 389: > >> 387:

Re: RFR: 8266851: Implement JEP 403: Strongly Encapsulate JDK Internals [v3]

2021-05-14 Thread Alan Bateman
On Thu, 13 May 2021 23:07:07 GMT, Mark Reinhold wrote: >> Please review this implementation of JEP 403 >> (https://openjdk.java.net/jeps/403). >> Alan Bateman is the original author of almost all of it. Passes tiers 1-3 >> on >> {linux,macos,windows}-x64 and {linux,macos}-aarch64. > > Mark

Re: JEP draft: Scope Locals

2021-05-14 Thread Andrew Haley
On 5/13/21 4:59 PM, Alan Snyder wrote: > > >> On May 13, 2021, at 2:03 AM, Andrew Haley wrote: >> >> On 5/12/21 8:12 PM, Alan Snyder wrote: >>> From the motivation section: >>> So you want to invoke a method |X| in a library that later calls back into your code. In your callback you

Re: RFR: 8266461: tools/jmod/hashes/HashesTest.java fails: static @Test methods [v4]

2021-05-14 Thread Alan Bateman
On Thu, 13 May 2021 20:38:20 GMT, Lance Andersen wrote: >> HI all, >> >> Please review the fix to HashesTest.java to support running on TestNG 7.4. >> >> The fix adds a no-arg constructor which TestNG requires. >> >> The change allows the test to run with the current jtreg as well as the

Re: RFR: 8263087: Add a MethodHandle combinator that switches over a set of MethodHandles

2021-05-14 Thread Claes Redestad
On Thu, 8 Apr 2021 18:51:21 GMT, Jorn Vernee wrote: > This patch adds a `tableSwitch` combinator that can be used to switch over a > set of method handles given an index, with a fallback in case the index is > out of bounds, much like the `tableswitch` bytecode. Here is a description of > how

Re: [External] : Re: ReversibleCollection proposal

2021-05-14 Thread dfranken . jdk
In reading all of the messages in this discussion, it becomes clear to me that this is not a trivial change, because we are mostly hindered by the Collection API as it currently exists. Adding interfaces seems like the correct OOP way to do things, but it may hinder adoption, because we have to

Re: RFR: 8266291: (jrtfs) Calling Files.exists may break the JRT filesystem

2021-05-14 Thread Claes Redestad
On Fri, 14 May 2021 05:39:10 GMT, Athijegannathan Sundararajan wrote: > Problematic paths that start with /modules/modules prefix are handled properly LGTM - Marked as reviewed by redestad (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4022

Integrated: 8265605: Cannot call BootLoader::loadClassOrNull before initPhase2

2021-05-14 Thread Ioi Lam
On Wed, 12 May 2021 05:51:14 GMT, Ioi Lam wrote: > This bug was discovered during the development of > [JDK-6824466](https://bugs.openjdk.java.net/browse/JDK-6824466): when CDS is > enabled, if `BootLoader::loadClassOrNull` is called before `initPhase2`, it > would trigger the initialization

Re: RFR: 8265605: Cannot call BootLoader::loadClassOrNull before initPhase2 [v3]

2021-05-14 Thread Ioi Lam
On Thu, 13 May 2021 06:19:47 GMT, Alan Bateman wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> cleaned up ClassLoaders.setArchivedServicesCatalog > > Marked as reviewed by alanb (Reviewer). Thanks @AlanBateman and