Re: RFR: 8266310: deadlock while loading the JNI code [v5]

On Fri, 21 May 2021 15:49:09 GMT, Aleksei Voitylov wrote: >> Please review this PR which fixes the deadlock in ClassLoader between the >> two lock objects - a lock object associated with the class being loaded, and >> the ClassLoader.loadedLibraryNames hash map, locked during the native >>

Re: RFR: 8267587: Update java.util to use enhanced switch [v6]

On Wed, 26 May 2021 02:22:42 GMT, Tagir F. Valeev wrote: >> Inspired by PR#4088. Most of the changes are done automatically using >> IntelliJ IDEA refactoring. Some manual adjustments are also performed, >> including indentations, moving comments, extracting common cast out of >> switch

Re: RFR: 8267587: Update java.util to use enhanced switch [v5]

On Tue, 25 May 2021 16:52:06 GMT, Brian Goetz wrote: >> Tagir F. Valeev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More vertical alignment > > src/java.base/share/classes/java/util/JapaneseImperialCalendar.java line 1371: > >>

Re: RFR: 8267587: Update java.util to use enhanced switch [v6]

On Wed, 26 May 2021 02:22:42 GMT, Tagir F. Valeev wrote: >> Inspired by PR#4088. Most of the changes are done automatically using >> IntelliJ IDEA refactoring. Some manual adjustments are also performed, >> including indentations, moving comments, extracting common cast out of >> switch

Re: RFR: 8267587: Update java.util to use enhanced switch [v6]

> Inspired by PR#4088. Most of the changes are done automatically using > IntelliJ IDEA refactoring. Some manual adjustments are also performed, > including indentations, moving comments, extracting common cast out of switch > expression branches, etc. > > I also noticed that there are some

Re: RFR: 8267587: Update java.util to use enhanced switch [v5]

On Tue, 25 May 2021 16:47:15 GMT, Brian Goetz wrote: >> Tagir F. Valeev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More vertical alignment > > src/java.base/share/classes/java/util/Calendar.java line 1507: > >> 1505:

Re: RFR: 8267587: Update java.util to use enhanced switch [v5]

On Tue, 25 May 2021 15:51:38 GMT, Chris Hegarty wrote: >> Tagir F. Valeev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More vertical alignment > > src/java.base/share/classes/java/util/Calendar.java line 1507: > >> 1505:

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions [v3]

On Tue, 25 May 2021 21:43:36 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.io`, >> `java.math`, and `java.text` packages to make use of the switch expressions? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated

Integrated: 8267452: Delegate forEachRemaining in Spliterators.iterator()

On Thu, 20 May 2021 10:16:28 GMT, Tagir F. Valeev wrote: > Sometimes, `Spliterator::forEachRemaining` has much more optimized > implementation, compared to `Spliterator::tryAdvance`. For example, if a > `Stream::spliterator` called for a stream that has intermediate operations, >

Re: RFR: 8267452: Delegate forEachRemaining in Spliterators.iterator() [v3]

> Sometimes, `Spliterator::forEachRemaining` has much more optimized > implementation, compared to `Spliterator::tryAdvance`. For example, if a > `Stream::spliterator` called for a stream that has intermediate operations, > `tryAdvance()` may buffer intermediate elements while

Re: RFR: 8267452: Delegate forEachRemaining in Spliterators.iterator() [v2]

On Tue, 25 May 2021 15:49:55 GMT, Paul Sandoz wrote: >> Tagir F. Valeev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Test: formatting; tests for empty spliterator > > Oops i missed the bit about testing in the description. That's

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions [v3]

On Tue, 25 May 2021 21:43:36 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.io`, >> `java.math`, and `java.text` packages to make use of the switch expressions? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated

Re: RFR: 8264859: Implement Context-Specific Deserialization Filters [v9]

On Tue, 25 May 2021 21:45:33 GMT, Roger Riggs wrote: >> JEP 415: Context-specific Deserialization Filters extends the >> deserialization filtering mechanisms with more flexible and customizable >> protections against malicious deserialization. See JEP 415: >>

Re: RFR: 8264859: Implement Context-Specific Deserialization Filters [v8]

On Tue, 25 May 2021 15:46:37 GMT, Roger Riggs wrote: >> JEP 415: Context-specific Deserialization Filters extends the >> deserialization filtering mechanisms with more flexible and customizable >> protections against malicious deserialization. See JEP 415: >>

Re: RFR: 8267123: Remove RMI Activation

On Tue, 25 May 2021 18:04:45 GMT, Stuart Marks wrote: > This is the implementation of [JEP 407](https://openjdk.java.net/jeps/407). > > This is a fairly straightforward removal of this component. > - Activation implementation classes removed > - Activation tests removed > - adjustments to

Re: RFR: 8187649: ArrayIndexOutOfBoundsException in java.util.JapaneseImperialCalendar

On Tue, 25 May 2021 16:40:53 GMT, Naoto Sato wrote: > Please review the fix. The issue was informed yesterday by @amaembo that it > offends some code analysis tools. > Although the fix is to change the condition error, it turned out that > `JapaneseImperialCalendar.roll()` did not work for

RFR: 8267123: Remove RMI Activation

This is the implementation of [JEP 407](https://openjdk.java.net/jeps/407). This is a fairly straightforward removal of this component. - Activation implementation classes removed - Activation tests removed - adjustments to various comments to remove references to Activation - adjustments to

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions [v3]

On Tue, 25 May 2021 18:54:48 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.io`, >> `java.math`, and `java.text` packages to make use of the switch expressions? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions [v3]

> Hi, > > Could someone please review my code for updating the code in the `java.io`, > `java.math`, and `java.text` packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request incrementally with one additional commit since the

Integrated: 8267403: tools/jpackage/share/FileAssociationsTest.java#id0 failed with "Error: Bundler "Mac PKG Package" (pkg) failed to produce a package"

On Fri, 21 May 2021 04:34:22 GMT, Alexander Matveev wrote: > Looks like another issue similar to hdiutil (JDK-8249395) when process is > gone, but we still waiting for it. I was not able to reproduce this issue by > running test or pkgbuild separately and conclusion was made based on logs. >

Re: RFR: 8265783: Create a separate library for x86 Intel SVML assembly intrinsics [v15]

> This PR contains Short Vector Math Library support related changes for > [JEP-414 Vector API (Second Incubator)](https://openjdk.java.net/jeps/414), > in preparation for when targeted. > > Intel Short Vector Math Library (SVML) based intrinsics in native x86 > assembly provide optimized

Re: RFR: 8264859: Implement Context-Specific Deserialization Filters [v9]

> JEP 415: Context-specific Deserialization Filters extends the deserialization > filtering mechanisms with more flexible and customizable protections against > malicious deserialization. See JEP 415: https://openjdk.java.net/jeps/415. > The `java.io.ObjectInputFilter` and

Re: RFR: 8264859: Implement Context-Specific Deserialization Filters [v7]

On Tue, 25 May 2021 11:18:15 GMT, Chris Hegarty wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Move merge and rejectUndecidedClass methods to OIF.Config >> As default methods on OIF, their implementations were

Re: RFR: 8265783: Create a separate library for x86 Intel SVML assembly intrinsics [v14]

> This PR contains Short Vector Math Library support related changes for > [JEP-414 Vector API (Second Incubator)](https://openjdk.java.net/jeps/414), > in preparation for when targeted. > > Intel Short Vector Math Library (SVML) based intrinsics in native x86 > assembly provide optimized

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions [v2]

On Tue, 25 May 2021 14:57:22 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.io`, >> `java.math`, and `java.text` packages to make use of the switch expressions? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated

Re: RFR: 8267587: Update java.util to use enhanced switch [v5]

On Tue, 25 May 2021 11:49:18 GMT, Tagir F. Valeev wrote: >> Inspired by PR#4088. Most of the changes are done automatically using >> IntelliJ IDEA refactoring. Some manual adjustments are also performed, >> including indentations, moving comments, extracting common cast out of >> switch

Re: RFR: 4511638: Double.toString(double) sometimes produces incorrect results [v2]

On Fri, 16 Apr 2021 11:30:32 GMT, Raffaello Giulietti wrote: >> Hello, >> >> here's a PR for a patch submitted on March 2020 >> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was >> a thing. >> >> The patch has been edited to adhere to OpenJDK code conventions about

Re: RFR: 8191441: (Process) add Readers and Writer access to java.lang.Process streams [v4]

> Methods are added to java.lang.Process to read and write characters and lines > from and to a spawned Process. > The Charset used to encode and decode characters to bytes can be specified or > use the > operating system native encoding as is available from the "native.encoding" > system

RFR: 8187649: ArrayIndexOutOfBoundsException in java.util.JapaneseImperialCalendar

Please review the fix. The issue was informed yesterday by @amaembo that it offends some code analysis tools. Although the fix is to change the condition error, it turned out that `JapaneseImperialCalendar.roll()` did not work for `WEEK_OF_MONTH` and `DAY_OF_MONTH`. There was an inherent issue

Re: RFR: 8267587: Update java.util to use enhanced switch [v5]

On Tue, 25 May 2021 11:49:18 GMT, Tagir F. Valeev wrote: >> Inspired by PR#4088. Most of the changes are done automatically using >> IntelliJ IDEA refactoring. Some manual adjustments are also performed, >> including indentations, moving comments, extracting common cast out of >> switch

Reminder RFR: 4511638: Double.toString(double) sometimes produces incorrect results

Hi, a reminder to keep PR [1] alive and to invite interested reviewers to comment it. The corresponding CSR is in [2] Greetings Raffaello --- [1] https://github.com/openjdk/jdk/pull/3402 [2] https://bugs.openjdk.java.net/browse/JDK-8202555

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions

In the last hunk, you convert case Collator.IDENTICAL: toAddTo.append('='); break; case Collator.TERTIARY: toAddTo.append(','); break; case Collator.SECONDARY: toAddTo.append(';'); break; case Collator.PRIMARY: toAddTo.append('<'); break; case RESET:

Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v4]

On Tue, 25 May 2021 16:00:43 GMT, Rémi Forax wrote: > > The reason for this integer (which is not a constant in the case of this > > switch) is to restart the matching in case guards fail to "match". > > Considering the example here: > > ``` > > class Example { > > void example(Object

Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v4]

On Tue, 25 May 2021 14:22:57 GMT, Jan Lahoda wrote: > The reason for this integer (which is not a constant in the case of this > switch) is to restart the matching in case guards fail to "match". > Considering the example here: > > ``` > class Example { > void example(Object o) { >

Re: RFR: 8264859: Implement Context-Specific Deserialization Filters [v3]

On Tue, 25 May 2021 09:14:38 GMT, Chris Hegarty wrote: >> The spec/code is forthcoming. >> ii) is sufficient to prevent ambiguity in which filter is used throughout >> the Java runtime; >>though it requires a bit of package-private plumbing. >> >> i) is too limiting. It should be

Re: RFR: 8267403: tools/jpackage/share/FileAssociationsTest.java#id0 failed with "Error: Bundler "Mac PKG Package" (pkg) failed to produce a package"

On Fri, 21 May 2021 04:34:22 GMT, Alexander Matveev wrote: > Looks like another issue similar to hdiutil (JDK-8249395) when process is > gone, but we still waiting for it. I was not able to reproduce this issue by > running test or pkgbuild separately and conclusion was made based on logs. >

Re: RFR: 8267587: Update java.util to use enhanced switch [v5]

On Tue, 25 May 2021 11:49:18 GMT, Tagir F. Valeev wrote: >> Inspired by PR#4088. Most of the changes are done automatically using >> IntelliJ IDEA refactoring. Some manual adjustments are also performed, >> including indentations, moving comments, extracting common cast out of >> switch

Re: RFR: 8267452: Delegate forEachRemaining in Spliterators.iterator() [v2]

On Mon, 24 May 2021 07:15:34 GMT, Tagir F. Valeev wrote: >> Sometimes, `Spliterator::forEachRemaining` has much more optimized >> implementation, compared to `Spliterator::tryAdvance`. For example, if a >> `Stream::spliterator` called for a stream that has intermediate operations, >>

Re: RFR: 8264859: Implement Context-Specific Deserialization Filters [v8]

> JEP 415: Context-specific Deserialization Filters extends the deserialization > filtering mechanisms with more flexible and customizable protections against > malicious deserialization. See JEP 415: https://openjdk.java.net/jeps/415. > The `java.io.ObjectInputFilter` and

Re: RFR: 8265768 [aarch64] Use glibc libm impl for dlog, dlog10, dexp iff 2.29 or greater on AArch64.

On Thu, 15 Apr 2021 08:33:47 GMT, gregcawthorne wrote: > Glibc 2.29 onwards provides optimised versions of log,log10,exp. > These functions have an accuracy of 0.9ulp or better in glibc > 2.29. > > Therefore this patch adds code to parse, store and check > the runtime glibcs version in

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions [v2]

On Tue, 25 May 2021 14:53:44 GMT, Patrick Concannon wrote: >> src/java.base/share/classes/java/io/StreamTokenizer.java line 795: >> >>> 793: * case statements >>> 794: */ >>> 795: if (ttype < 256 && ((ctype[ttype] & CT_QUOTE) != 0)) { >> >>

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions [v2]

On Tue, 25 May 2021 14:57:22 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.io`, >> `java.math`, and `java.text` packages to make use of the switch expressions? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions [v2]

On Tue, 25 May 2021 12:43:00 GMT, Naoto Sato wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >>

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions [v2]

On Tue, 25 May 2021 12:31:38 GMT, Chris Hegarty wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >>

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions [v2]

On Tue, 25 May 2021 13:16:00 GMT, Daniel Fuchs wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >>

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions [v2]

> Hi, > > Could someone please review my code for updating the code in the `java.io`, > `java.math`, and `java.text` packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase.

Re: RFR: 8265768 [aarch64] Use glibc libm impl for dlog, dlog10, dexp iff 2.29 or greater on AArch64.

Greg, what's your email address? Everything I try bounces. -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671

Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v4]

On Tue, 25 May 2021 14:13:55 GMT, Rémi Forax wrote: > 7: iconst_0 < this zero @forax as far as I understood this will be a value of parameter `startIndex` in `java.lang.runtime. SwitchBootstraps.doSwitch`  Please correct me @lahodaj if I'm wrong. - PR:

Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v4]

On Tue, 25 May 2021 14:13:55 GMT, Rémi Forax wrote: > > Thanks Evgeny, I'll take a look. > > @forax, do you mean why there is "0" in: > > 11: invokedynamic #13, 0 > > ? > > Not this one, the one on the stack. > > 7: iconst_0 < this zero > 8: istore_3 > 9: aload_2 > 10: iload_3 > 11:

Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v4]

On Tue, 25 May 2021 12:20:02 GMT, Jan Lahoda wrote: > Thanks Evgeny, I'll take a look. > > @forax, do you mean why there is "0" in: > 11: invokedynamic #13, 0 > ? Not this one, the one on the stack. 7: iconst_0 < this zero 8: istore_3 9: aload_2 10: iload_3 11: invokedynamic #13, 0 //

Re: RFR: 8263561: Re-examine uses of LinkedList [v4]

> The usage of `LinkedList` is senseless and can be replaced with either > `ArrayList` or `ArrayDeque` which are both more compact and effective. > > jdk:tier1 and jdk:tier2 are both ok Сергей Цыпанов has updated the pull request with a new target base due to a merge or a rebase. The

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions

On Tue, 25 May 2021 09:37:58 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my code for updating the code in the `java.io`, > `java.math`, and `java.text` packages to make use of the switch expressions? > > Kind regards, > Patrick

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions

On Tue, 25 May 2021 09:37:58 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my code for updating the code in the `java.io`, > `java.math`, and `java.text` packages to make use of the switch expressions? > > Kind regards, > Patrick

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions

On Tue, 25 May 2021 09:37:58 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my code for updating the code in the `java.io`, > `java.math`, and `java.text` packages to make use of the switch expressions? > > Kind regards, > Patrick

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions

On Tue, 25 May 2021 09:37:58 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my code for updating the code in the `java.io`, > `java.math`, and `java.text` packages to make use of the switch expressions? > > Kind regards, > Patrick

Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v4]

On Wed, 19 May 2021 08:00:12 GMT, Jan Lahoda wrote: >> This is a preview of a patch implementing JEP 406: Pattern Matching for >> switch (Preview): >> https://bugs.openjdk.java.net/browse/JDK-8213076 >> >> The current draft of the specification is here: >>

Re: RFR: 8267403: tools/jpackage/share/FileAssociationsTest.java#id0 failed with "Error: Bundler "Mac PKG Package" (pkg) failed to produce a package"

On Fri, 21 May 2021 04:34:22 GMT, Alexander Matveev wrote: > Looks like another issue similar to hdiutil (JDK-8249395) when process is > gone, but we still waiting for it. I was not able to reproduce this issue by > running test or pkgbuild separately and conclusion was made based on logs. >

Re: RFR: 8263561: Re-examine uses of LinkedList [v3]

> The usage of `LinkedList` is senseless and can be replaced with either > `ArrayList` or `ArrayDeque` which are both more compact and effective. > > jdk:tier1 and jdk:tier2 are both ok Сергей Цыпанов has updated the pull request incrementally with one additional commit since the last

RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions

Hi, Could someone please review my code for updating the code in the `java.io`, `java.math`, and `java.text` packages to make use of the switch expressions? Kind regards, Patrick - Commit messages: - 8267670: Update java.io, java.math, and java.text to use switch expressions

Integrated: 8267612; Declare package-private VarHandle.AccessMode/AccessType counts

On Mon, 24 May 2021 11:26:51 GMT, Claes Redestad wrote: > Slightly reduce VarHandle startup overhead by introducing package-private > COUNT constants for two enums This pull request has now been integrated. Changeset: 66b190e1 Author:Claes Redestad URL:

Re: RFR: 8267587: Update java.util to use enhanced switch [v5]

> Inspired by PR#4088. Most of the changes are done automatically using > IntelliJ IDEA refactoring. Some manual adjustments are also performed, > including indentations, moving comments, extracting common cast out of switch > expression branches, etc. > > I also noticed that there are some

Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v4]

- Mail original - > De: "Evgeny Mandrikov" > À: "build-dev" , "compiler-dev" > , "core-libs-dev" > , "javadoc-dev" > Envoyé: Mardi 25 Mai 2021 11:32:03 > Objet: Re: RFR: 8262891: Compiler implementation for Pattern Matching for > switch (Preview) [v4] > On Mon, 17 May 2021 19:01:01

Re: RFR: 8264859: Implement Context-Specific Deserialization Filters [v7]

On Mon, 24 May 2021 21:57:50 GMT, Roger Riggs wrote: >> JEP 415: Context-specific Deserialization Filters extends the >> deserialization filtering mechanisms with more flexible and customizable >> protections against malicious deserialization. See JEP 415: >>

Re: RFR: 8267587: Update java.util to use enhanced switch [v3]

On Tue, 25 May 2021 10:31:33 GMT, Patrick Concannon wrote: >> Tagir F. Valeev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Indent some lines to make GitHub diff happier > >

Re: RFR: 8267587: Update java.util to use enhanced switch [v4]

> Inspired by PR#4088. Most of the changes are done automatically using > IntelliJ IDEA refactoring. Some manual adjustments are also performed, > including indentations, moving comments, extracting common cast out of switch > expression branches, etc. > > I also noticed that there are some

Re: RFR: 8267587: Update java.util to use enhanced switch [v3]

On Tue, 25 May 2021 06:01:49 GMT, Tagir F. Valeev wrote: >> Inspired by PR#4088. Most of the changes are done automatically using >> IntelliJ IDEA refactoring. Some manual adjustments are also performed, >> including indentations, moving comments, extracting common cast out of >> switch

Re: RFR: 8264859: Implement Context-Specific Deserialization Filters [v7]

On Mon, 24 May 2021 21:57:50 GMT, Roger Riggs wrote: >> JEP 415: Context-specific Deserialization Filters extends the >> deserialization filtering mechanisms with more flexible and customizable >> protections against malicious deserialization. See JEP 415: >>

Re: RFR: 8195129: System.load() fails to load from unicode paths [v2]

> Character strings within JVM are produced and consumed in several formats. > Strings come from/to Java in the UTF8 format and POSIX APIs (like fprintf() > or dlopen()) consume strings also in UTF8. On Windows, however, the situation > is far less simple: some new(er) APIs expect UTF16

Re: RFR: 8265768 [aarch64] Use glibc libm impl for dlog, dlog10, dexp iff 2.29 or greater on AArch64.

On Thu, 15 Apr 2021 08:33:47 GMT, gregcawthorne wrote: > Glibc 2.29 onwards provides optimised versions of log,log10,exp. > These functions have an accuracy of 0.9ulp or better in glibc > 2.29. > > Therefore this patch adds code to parse, store and check > the runtime glibcs version in

Re: RFR: 8267612; Declare package-private VarHandle.AccessMode/AccessType counts [v2]

On Mon, 24 May 2021 22:49:05 GMT, Claes Redestad wrote: >> Slightly reduce VarHandle startup overhead by introducing package-private >> COUNT constants for two enums > > Claes Redestad has updated the pull request incrementally with one additional > commit since the last revision: > > Mandy

Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v4]

On Mon, 17 May 2021 19:01:01 GMT, Jan Lahoda wrote: >> Good work. There's a lot to take in here. I think overall, it holds up well >> - I like how case labels have been extended to accommodate for patterns. In >> the front-end, I think there are some questions over the split between Attr >>

Re: RFR: 8264859: Implement Context-Specific Deserialization Filters [v3]

On Mon, 24 May 2021 15:09:26 GMT, Roger Riggs wrote: > i) is too limiting. It should be possible for an application to check whether > a filter factory has been provided on the command line (by calling > getSerialFilterFactory) and if not setting the factory itself. It may also > want to

Integrated: 8267110: Update java.util to use instanceof pattern variable

On Tue, 18 May 2021 10:37:21 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my code for updating the code in the `java.util` > package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick This pull request has now been integrated. Changeset:

Re: RFR: 8266310: deadlock while loading the JNI code [v5]

On 25/05/2021 04:44, David Holmes wrote: > On 25/05/2021 7:53 am, Aleksei Voitylov wrote: >> On Mon, 24 May 2021 06:24:15 GMT, David Holmes >> wrote: >> Aleksei Voitylov has updated the pull request incrementally with one additional commit since the last revision:    fix

Re: RFR: 8191441: (Process) add Readers and Writer access to java.lang.Process streams [v3]

On Mon, 24 May 2021 00:33:06 GMT, Roger Riggs wrote: >> Methods are added to java.lang.Process to read and write characters and >> lines from and to a spawned Process. >> The Charset used to encode and decode characters to bytes can be specified >> or use the >> operating system native

Re: RFR: 8263561: Re-examine uses of LinkedList [v2]

> The usage of `LinkedList` is senseless and can be replaced with either > `ArrayList` or `ArrayDeque` which are both more compact and effective. > > jdk:tier1 and jdk:tier2 are both ok Сергей Цыпанов has refreshed the contents of this pull request, and previous commits have been removed. The

Re: RFR: 8195129: System.load() fails to load from unicode paths

On Mon, 24 May 2021 16:43:09 GMT, Maxim Kartashev wrote: > Character strings within JVM are produced and consumed in several formats. > Strings come from/to Java in the UTF8 format and POSIX APIs (like fprintf() > or dlopen()) consume strings also in UTF8. On Windows, however, the situation

Re: RFR: 8191441: (Process) add Readers and Writer access to java.lang.Process streams [v3]

On Mon, 24 May 2021 01:21:09 GMT, Roger Riggs wrote: > On the question of process termination behavior, I'm not sure what can be > said that could be specification. > The implementations vary between Mac, Linux, and Windows; with the common > thread > to avoid losing process output. But this

Re: RFR: 8224243: Make AccessibleObject a sealed class [v3]

On Mon, 24 May 2021 21:54:09 GMT, Joe Darcy wrote: >> Conceptually, AccessbileObject is a sealed class with a protected >> constructor stating >> >> Constructor: only used by the Java Virtual Machine. >> >> With the language now supporting sealed classes, the AccessbileObject should >>

Re: RFR: 8267587: Update java.util to use enhanced switch [v3]

On Tue, 25 May 2021 03:48:41 GMT, Tagir F. Valeev wrote: >> src/java.base/share/classes/java/util/regex/CharPredicates.java line 217: >> >>> 215: case "WORD" -> WORD(); >>> 216: default -> null; >>> 217: }; >> >> This file has lots of changes which are difficult

Re: RFR: 8267587: Update java.util to use enhanced switch [v3]

> Inspired by PR#4088. Most of the changes are done automatically using > IntelliJ IDEA refactoring. Some manual adjustments are also performed, > including indentations, moving comments, extracting common cast out of switch > expression branches, etc. > > I also noticed that there are some