On Wed, 26 May 2021 17:58:06 GMT, Roger Riggs wrote:
> Process is abstract. Is there any use for these new methods to be overridden?
> Perhaps they should be final.
It's not clear to me that it is useful to extend Process outside of the JDK.
Testing, wrapping, ...? It feels like this class wan
> With the introduction of `toList()`, preserving the SIZED characteristics in
> more cases becomes more important. This patch preserves SIZED on `skip()` and
> `limit()` operations, so now every combination of
> `map/mapToX/boxed/asXyzStream/skip/limit/sorted` preserves size, and
> `toList()`,
On Mon, 24 May 2021 19:51:04 GMT, Paul Sandoz wrote:
>> Tagir F. Valeev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Trailing whitespace removed
>
> src/java.base/share/classes/java/util/stream/AbstractPipeline.java line 471:
>
>> 46
On Tue, 25 May 2021 18:04:45 GMT, Stuart Marks wrote:
> This is the implementation of [JEP 407](https://openjdk.java.net/jeps/407).
>
> This is a fairly straightforward removal of this component.
> - Activation implementation classes removed
> - Activation tests removed
> - adjustments to var
On Tue, 25 May 2021 09:45:34 GMT, Maxim Kartashev
wrote:
>> Character strings within JVM are produced and consumed in several formats.
>> Strings come from/to Java in the UTF8 format and POSIX APIs (like fprintf()
>> or dlopen()) consume strings also in UTF8. On Windows, however, the
>> situa
On Tue, 25 May 2021 09:45:34 GMT, Maxim Kartashev
wrote:
>> Character strings within JVM are produced and consumed in several formats.
>> Strings come from/to Java in the UTF8 format and POSIX APIs (like fprintf()
>> or dlopen()) consume strings also in UTF8. On Windows, however, the
>> situa
On 27/05/2021 6:59 am, Gerard Ziemski wrote:
On Tue, 25 May 2021 09:45:34 GMT, Maxim Kartashev
wrote:
I tried verifying the test on **macOS** by running:
`jtreg -nr -va -jdk:./build/macosx-x86_64-server-fastdebug/images/jdk
test/hotspot/jtreg/runtime/jni/loadLibraryUnicode`
and I get:
`TEST
On Wed, 26 May 2021 22:02:36 GMT, Brent Christian wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Editorial updates to review comments.
>> Simplify the builtin filter factory implementation.
>> Add atomic update
On Fri, 21 May 2021 15:49:09 GMT, Aleksei Voitylov
wrote:
>> Please review this PR which fixes the deadlock in ClassLoader between the
>> two lock objects - a lock object associated with the class being loaded, and
>> the ClassLoader.loadedLibraryNames hash map, locked during the native
>> li
On Wed, 26 May 2021 16:48:53 GMT, Roger Riggs wrote:
>> JEP 415: Context-specific Deserialization Filters extends the
>> deserialization filtering mechanisms with more flexible and customizable
>> protections against malicious deserialization. See JEP 415:
>> https://openjdk.java.net/jeps/415
> JEP 415: Context-specific Deserialization Filters extends the deserialization
> filtering mechanisms with more flexible and customizable protections against
> malicious deserialization. See JEP 415: https://openjdk.java.net/jeps/415.
> The `java.io.ObjectInputFilter` and `java.io.ObjectInputSt
On Wed, 26 May 2021 01:28:17 GMT, Roger Riggs wrote:
> The class `test/lib/jtreg/SkippedException.java` is missing a
> serialVersionUID causing additional noise in compiler output of tests.
This pull request has now been integrated.
Changeset: 0fc7c8d1
Author:Roger Riggs
URL:
https
On Tue, 25 May 2021 16:53:28 GMT, Roger Riggs wrote:
>> Methods are added to java.lang.Process to read and write characters and
>> lines from and to a spawned Process.
>> The Charset used to encode and decode characters to bytes can be specified
>> or use the
>> operating system native encoding
> JEP 415: Context-specific Deserialization Filters extends the deserialization
> filtering mechanisms with more flexible and customizable protections against
> malicious deserialization. See JEP 415: https://openjdk.java.net/jeps/415.
> The `java.io.ObjectInputFilter` and `java.io.ObjectInputSt
On Tue, 25 May 2021 09:45:34 GMT, Maxim Kartashev
wrote:
>> Character strings within JVM are produced and consumed in several formats.
>> Strings come from/to Java in the UTF8 format and POSIX APIs (like fprintf()
>> or dlopen()) consume strings also in UTF8. On Windows, however, the
>> situa
On Thu, 13 May 2021 17:14:36 GMT, Mark Reinhold wrote:
> Please review this implementation of JEP 403
> (https://openjdk.java.net/jeps/403).
> Alan Bateman is the original author of almost all of it. Passes tiers 1-3 on
> {linux,macos,windows}-x64 and {linux,macos}-aarch64.
This pull request
On Tue, 25 May 2021 16:14:56 GMT, Jan Lahoda wrote:
> I'd like to note this is a preview feature - we can change the desugaring. At
> the same time, I don't think this does not work with sub-patterns (those can
> be easily desugared to guards, I think).
Yes, but in that case the classcheck du
On Tue, 25 May 2021 18:04:45 GMT, Stuart Marks wrote:
> This is the implementation of [JEP 407](https://openjdk.java.net/jeps/407).
>
> This is a fairly straightforward removal of this component.
> - Activation implementation classes removed
> - Activation tests removed
> - adjustments to var
On Wed, 26 May 2021 17:52:36 GMT, Jan Lahoda wrote:
>> This is a preview of a patch implementing JEP 406: Pattern Matching for
>> switch (Preview):
>> https://bugs.openjdk.java.net/browse/JDK-8213076
>>
>> The current draft of the specification is here:
>> http://cr.openjdk.java.net/~gbierman/j
On Fri, 23 Apr 2021 00:41:17 GMT, Joe Wang wrote:
> Update module summary, add a few existing properties and features into the
> tables.
This pull request has now been integrated.
Changeset: 8c4719a5
Author:Joe Wang
URL:
https://git.openjdk.java.net/jdk/commit/8c4719a58834dddcea39d
On Wed, 26 May 2021 17:52:31 GMT, Roger Riggs wrote:
>> The class `test/lib/jtreg/SkippedException.java` is missing a
>> serialVersionUID causing additional noise in compiler output of tests.
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last
On Tue, 25 May 2021 16:40:53 GMT, Naoto Sato wrote:
> Please review the fix. The issue was informed yesterday by @amaembo that it
> offends some code analysis tools.
> Although the fix is to change the condition error, it turned out that
> `JapaneseImperialCalendar.roll()` did not work for `WEE
On Tue, 25 May 2021 18:04:45 GMT, Stuart Marks wrote:
> This is the implementation of [JEP 407](https://openjdk.java.net/jeps/407).
>
> This is a fairly straightforward removal of this component.
> - Activation implementation classes removed
> - Activation tests removed
> - adjustments to var
On Mon, 24 May 2021 06:23:59 GMT, Joe Wang wrote:
>> Update module summary, add a few existing properties and features into the
>> tables.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Consolidated impl specific properties;
On Wed, 26 May 2021 17:52:31 GMT, Roger Riggs wrote:
>> The class `test/lib/jtreg/SkippedException.java` is missing a
>> serialVersionUID causing additional noise in compiler output of tests.
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last
On Tue, 25 May 2021 16:53:28 GMT, Roger Riggs wrote:
>> Methods are added to java.lang.Process to read and write characters and
>> lines from and to a spawned Process.
>> The Charset used to encode and decode characters to bytes can be specified
>> or use the
>> operating system native encoding
> This is a preview of a patch implementing JEP 406: Pattern Matching for
> switch (Preview):
> https://bugs.openjdk.java.net/browse/JDK-8213076
>
> The current draft of the specification is here:
> http://cr.openjdk.java.net/~gbierman/jep406/jep406-20210430/specs/patterns-switch-jls.html
>
> A
> The class `test/lib/jtreg/SkippedException.java` is missing a
> serialVersionUID causing additional noise in compiler output of tests.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Removed unintended classfile
-
Chan
On Tue, 25 May 2021 23:25:41 GMT, Brent Christian wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Editorial updates
>> Updated java.security properties to include jdk.serialFilterFactory
>> Added test cases to S
On Wed, 26 May 2021 06:35:46 GMT, Peter Levart wrote:
>> src/java.base/share/classes/java/io/ObjectInputStream.java line 1265:
>>
>>> 1263: * must return a non-null filter. It is not permitted to remove
>>> filtering once established.
>>> 1264: * See the {@linkplain ObjectInputFilter
> JEP 415: Context-specific Deserialization Filters extends the deserialization
> filtering mechanisms with more flexible and customizable protections against
> malicious deserialization. See JEP 415: https://openjdk.java.net/jeps/415.
> The `java.io.ObjectInputFilter` and `java.io.ObjectInputSt
On Tue, 25 May 2021 21:53:26 GMT, Brent Christian wrote:
>> Roger Riggs has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Moved utility filter methods to be static on ObjectInputFilter
>>Rearranged the class javadoc of OIF to describ
On Mon, 17 May 2021 16:55:35 GMT, Naoto Sato wrote:
> Please review the changes to the subject issue. java.util.Locale class has a
> long-standing issue for those obsolete ISO 639 languages where its
> normalization ends up in the obsolete codes. This change intends to flip the
> normalization
On Mon, 24 May 2021 06:23:59 GMT, Joe Wang wrote:
>> Update module summary, add a few existing properties and features into the
>> tables.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Consolidated impl specific properties;
On Wed, 26 May 2021 01:28:17 GMT, Roger Riggs wrote:
> The class `test/lib/jtreg/SkippedException.java` is missing a
> serialVersionUID causing additional noise in compiler output of tests.
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4197
The class `test/lib/jtreg/SkippedException.java` is missing a serialVersionUID
causing additional noise in compiler output of tests.
-
Commit messages:
- Added serialVersionUID to jtreg.SkippedException to eliminate compilation
warnings
Changes: https://git.openjdk.java.net/jdk/pu
On Wed, 26 May 2021 07:55:53 GMT, Athijegannathan Sundararajan
wrote:
> FileVisitOption.FOLLOW_LINKS used. Test extended for file symlinks case.
This pull request has now been integrated.
Changeset: bf8d4a8e
Author:Athijegannathan Sundararajan
URL:
https://git.openjdk.java.net/jdk/
> Hi,
>
> Could someone please review my code for updating the code in the `java.io`,
> `java.math`, and `java.text` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a rebase. The
> Hi,
>
> Could someone please review my code for updating the code in the `java.io`,
> `java.math`, and `java.text` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request incrementally with one
additional commit since the las
On Wed, 26 May 2021 07:55:53 GMT, Athijegannathan Sundararajan
wrote:
> FileVisitOption.FOLLOW_LINKS used. Test extended for file symlinks case.
It strikes me a bit unusual to be following sym links here but okay.
-
Marked as reviewed by alanb (Reviewer).
PR: https://git.openjdk.
On Wed, 26 May 2021 09:39:44 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.io`,
>> `java.math`, and `java.text` packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated
> Hi,
>
> Could someone please review my code for updating the code in the `java.io`,
> `java.math`, and `java.text` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a rebase. The
On Wed, 26 May 2021 09:05:34 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.io`,
>> `java.math`, and `java.text` packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated
> Hi,
>
> Could someone please review my code for updating the code in the `java.io`,
> `java.math`, and `java.text` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request incrementally with one
additional commit since the las
On Tue, 25 May 2021 15:18:46 GMT, Chris Hegarty wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>>
FileVisitOption.FOLLOW_LINKS used. Test extended for file symlinks case.
-
Commit messages:
- 8267583: jmod fails on symlink to class file
Changes: https://git.openjdk.java.net/jdk/pull/4202/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4202&range=00
Issue: https://
On Fri, 21 May 2021 15:49:09 GMT, Aleksei Voitylov
wrote:
>> Please review this PR which fixes the deadlock in ClassLoader between the
>> two lock objects - a lock object associated with the class being loaded, and
>> the ClassLoader.loadedLibraryNames hash map, locked during the native
>> li
47 matches
Mail list logo
