RFR: 8268222: javax/xml/jaxp/unittest/transform/Bug6216226Test.java failed, cannot delete file

Revert changes in StreamResult.java made through https://github.com/openjdk/jdk/pull/4318 since it was creating a file stream on behalf of the Transformer, which resulted in a leaking file handle because the Transformer would only close files it opened. This change instead replace the

Re: RFR: 8267630: Start of release updates for JDK 18 [v3]

> 8267630: Start of release updates for JDK 18 Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last

Re: RFR: 8268151: Vector API toShuffle optimization [v2]

On Thu, 3 Jun 2021 18:40:09 GMT, Sandhya Viswanathan wrote: >> src/hotspot/share/opto/vectornode.cpp line 1246: >> >>> 1244: return new VectorLoadMaskNode(value, out_vt); >>> 1245: } else if (is_vector_shuffle) { >>> 1246: if (!is_shuffle_to_vector()) { >> >> Hi

Re: RFR: 8268151: Vector API toShuffle optimization [v2]

On Thu, 3 Jun 2021 21:43:19 GMT, Sandhya Viswanathan wrote: >> The Vector API toShuffle method can be optimized using existing vector >> conversion intrinsic. >> >> The following changes are made: >> 1) vector.toShuffle java implementation is changed to call >> VectorSupport.convert. >> 2)

Re: RFR: 8195129: System.load() fails to load from unicode paths [v3]

On Thu, 3 Jun 2021 17:48:59 GMT, Naoto Sato wrote: >> Right; I changed the code in NativeLibraries.c to pass down true UTF-8 >> instead of "modified UTF-8". Please, take a look. > > I am not sure we can pass non `modified UTF-8` through `JVM_LoadLibrary()`. > Probably some VM folks can

Integrated: 8268224: Cleanup references to "strictfp" in core lib comments

On Fri, 4 Jun 2021 01:04:39 GMT, Joe Darcy wrote: > With the right baseline this time, as noticed by John Rose, after JEP 306 > removing non-strict floating-point was integrated, a few stale references > were left to "strictfp" and "value sets" in core library comments. This > changeset

Re: RFR: 8268224: Cleanup references to "strictfp" in core lib comments [v2]

> With the right baseline this time, as noticed by John Rose, after JEP 306 > removing non-strict floating-point was integrated, a few stale references > were left to "strictfp" and "value sets" in core library comments. This > changeset removes those stray references. Joe Darcy has updated

Re: RFR: 8268224: Cleanup references to "strictfp" in core lib comments

On Fri, 4 Jun 2021 01:04:39 GMT, Joe Darcy wrote: > With the right baseline this time, as noticed by John Rose, after JEP 306 > removing non-strict floating-point was integrated, a few stale references > were left to "strictfp" and "value sets" in core library comments. This > changeset

Re: RFR: 8174222: LambdaMetafactory: validate inputs and improve documentation [v2]

On Thu, 3 Jun 2021 20:40:23 GMT, Dan Smith wrote: >> Standardizes and better specifies the errors thrown by LambdaMetafactory, >> including for inputs that would not be generated by javac. >> >> Does some renaming of core parameters/fields to better reflect their purpose. >> >> In the

Re: RFR: 8268224: Cleanup references to "strictfp" in core lib comments

On Fri, 4 Jun 2021 01:04:39 GMT, Joe Darcy wrote: > With the right baseline this time, as noticed by John Rose, after JEP 306 > removing non-strict floating-point was integrated, a few stale references > were left to "strictfp" and "value sets" in core library comments. This > changeset

RFR: 8268224: Cleanup references to "strictfp" in core lib comments

With the right baseline this time, as noticed by John Rose, after JEP 306 removing non-strict floating-point was integrated, a few stale references were left to "strictfp" and "value sets" in core library comments. This changeset removes those stray references. - Commit messages:

Re: [External] : Re: RFR: 8199318: add idempotent copy operation for Map.Entry

> De: "John Rose" > À: "Remi Forax" > Cc: "Peter Levart" , "Rémi Forax" > , "core-libs-dev" > Envoyé: Vendredi 4 Juin 2021 02:05:41 > Objet: Re: [External] : Re: RFR: 8199318: add idempotent copy operation for > Map.Entry > On Jun 3, 2021, at 3:17 PM, [ mailto:fo...@univ-mlv.fr |

Re: RFR: 8174222: LambdaMetafactory: validate inputs and improve documentation [v2]

On Thu, 3 Jun 2021 20:40:23 GMT, Dan Smith wrote: >> Standardizes and better specifies the errors thrown by LambdaMetafactory, >> including for inputs that would not be generated by javac. >> >> Does some renaming of core parameters/fields to better reflect their purpose. >> >> In the

Re: RFR: 8267630: Start of release updates for JDK 18 [v2]

> 8267630: Start of release updates for JDK 18 Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last

Re: [External] : Re: RFR: 8199318: add idempotent copy operation for Map.Entry

On Jun 3, 2021, at 3:17 PM, fo...@univ-mlv.fr wrote: De: "John Rose" mailto:r.r...@oracle.com>> À: "Remi Forax" mailto:fo...@univ-mlv.fr>> Cc: "Peter Levart" mailto:peter.lev...@gmail.com>>, "Rémi Forax"

Re: RFR: 8174222: LambdaMetafactory: validate inputs and improve documentation [v2]

Yes, the CSR should be re-reviewed before the change goes in. I've changed the CSR status to indicate it needs another review. -Joe On 6/3/2021 4:07 PM, Mandy Chung wrote: On Thu, 3 Jun 2021 20:40:23 GMT, Dan Smith wrote: Standardizes and better specifies the errors thrown by

Re: RFR: 8174222: LambdaMetafactory: validate inputs and improve documentation [v2]

On Thu, 3 Jun 2021 20:40:23 GMT, Dan Smith wrote: >> Standardizes and better specifies the errors thrown by LambdaMetafactory, >> including for inputs that would not be generated by javac. >> >> Does some renaming of core parameters/fields to better reflect their purpose. >> >> In the

Re: RFR: 8174222: LambdaMetafactory: validate inputs and improve documentation [v2]

On Thu, 3 Jun 2021 20:40:23 GMT, Dan Smith wrote: >> Standardizes and better specifies the errors thrown by LambdaMetafactory, >> including for inputs that would not be generated by javac. >> >> Does some renaming of core parameters/fields to better reflect their purpose. >> >> In the

Re: RFR: 8268151: Vector API toShuffle optimization [v2]

On Thu, 3 Jun 2021 22:01:12 GMT, Paul Sandoz wrote: >> Sandhya Viswanathan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Implement review comments > > Java changes look good. @PaulSandoz Thanks a lot for the review. -

Re: RFR: 8199318: add idempotent copy operation for Map.Entry

> De: "John Rose" > À: "Remi Forax" < fo...@univ-mlv.fr > > Cc: "Peter Levart" < peter.lev...@gmail.com >, "Rémi Forax" < > fo...@openjdk.java.net >, "core-libs-dev" < core-libs-dev@openjdk.java.net > > Envoyé: Jeudi 3 Juin 2021 22:51:28 > Objet: Re: RFR: 8199318: add idempotent copy operation

Re: RFR: 8268151: Vector API toShuffle optimization [v2]

On Thu, 3 Jun 2021 21:43:19 GMT, Sandhya Viswanathan wrote: >> The Vector API toShuffle method can be optimized using existing vector >> conversion intrinsic. >> >> The following changes are made: >> 1) vector.toShuffle java implementation is changed to call >> VectorSupport.convert. >> 2)

Integrated: 8267939: Clarify the specification of iterator and spliterator forEachRemaining

On Tue, 1 Jun 2021 19:54:59 GMT, Paul Sandoz wrote: > The specification of `forEachRemaining`, accepting a primitive functional > interface, on the primitive iterators is updated to be the same as for > `Iterator.forEachRemaining`, specifically the following is added: > > > * > *

Withdrawn: 8236569: -Xss not multiple of 4K does not work for the main thread on macOS

On Fri, 28 May 2021 21:55:24 GMT, Henry Jen wrote: > …d on macOS > > This patch simply round up the specified stack size to multiple of the system > page size. > > Test is trivial, simply run java with -Xss option against following code. On > MacOS, before the fix, running with `-Xss159k`

Re: RFR: 8236569: -Xss not multiple of 4K does not work for the main thread on macOS

On Fri, 28 May 2021 21:55:24 GMT, Henry Jen wrote: > …d on macOS > > This patch simply round up the specified stack size to multiple of the system > page size. > > Test is trivial, simply run java with -Xss option against following code. On > MacOS, before the fix, running with `-Xss159k`

Re: RFR: 8266846: Add java.time.InstantSource [v6]

On Thu, 3 Jun 2021 20:59:24 GMT, Stephen Colebourne wrote: >> 8266846: Add java.time.InstantSource > > Stephen Colebourne has updated the pull request incrementally with one > additional commit since the last revision: > > 8266846: Add java.time.InstantSource Marked as reviewed by naoto

Re: RFR: 8266846: Add java.time.InstantSource [v6]

On Thu, 3 Jun 2021 20:59:24 GMT, Stephen Colebourne wrote: >> 8266846: Add java.time.InstantSource > > Stephen Colebourne has updated the pull request incrementally with one > additional commit since the last revision: > > 8266846: Add java.time.InstantSource Marked as reviewed by darcy

Re: RFR: 8199318: add idempotent copy operation for Map.Entry

> De: "John Rose" > À: "Remi Forax" > Cc: "Peter Levart" , "Rémi Forax" > , "core-libs-dev" > Envoyé: Jeudi 3 Juin 2021 22:51:28 > Objet: Re: RFR: 8199318: add idempotent copy operation for Map.Entry > On Jun 3, 2021, at 12:46 PM, Remi Forax < [ mailto:fo...@univ-mlv.fr | > fo...@univ-mlv.fr ]

Re: RFR: 8268151: Vector API toShuffle optimization [v2]

On Thu, 3 Jun 2021 02:31:51 GMT, Xiaohong Gong wrote: >> Sandhya Viswanathan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Implement review comments > > src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Byte128Vector.java >

Re: RFR: 8268151: Vector API toShuffle optimization [v2]

> The Vector API toShuffle method can be optimized using existing vector > conversion intrinsic. > > The following changes are made: > 1) vector.toShuffle java implementation is changed to call > VectorSupport.convert. > 2) The conversion intrinsic (inline_vector_convert()) in

Re: RFR: 8266846: Add java.time.InstantSource [v6]

On Thu, 3 Jun 2021 20:59:24 GMT, Stephen Colebourne wrote: >> 8266846: Add java.time.InstantSource > > Stephen Colebourne has updated the pull request incrementally with one > additional commit since the last revision: > > 8266846: Add java.time.InstantSource Marked as reviewed by rriggs

Re: RFR: 8236569: -Xss not multiple of 4K does not work for the main thread on macOS

On Mon, 31 May 2021 20:23:53 GMT, Vladimir Kempik wrote: >> src/java.base/macosx/native/libjli/java_md_macosx.m line 727: >> >>> 725: >>> 726: static size_t alignUp(size_t stack_size) { >>> 727: long page_size = sysconf(_SC_PAGESIZE); >> >> In hotspot we use `getpagesize()`. There is also

Integrated: 8266019: StreamResult(File) writes to incorrect file path if # is part of the file path

On Wed, 2 Jun 2021 18:17:43 GMT, Joe Wang wrote: > Special characters are different in File and URI. Treat File input as File > using FileInputStream instead of converting to an URI, but fall back to URI > in case of error for compatibility (in error handling). This pull request has now been

Re: RFR: 8266846: Add java.time.InstantSource [v6]

> 8266846: Add java.time.InstantSource Stephen Colebourne has updated the pull request incrementally with one additional commit since the last revision: 8266846: Add java.time.InstantSource - Changes: - all: https://git.openjdk.java.net/jdk/pull/4016/files - new:

Re: RFR: 8199318: add idempotent copy operation for Map.Entry

On Jun 3, 2021, at 12:46 PM, Remi Forax mailto:fo...@univ-mlv.fr>> wrote: I kind of regret that the compiler does not provide automatically an implementation of compareTo if the record implements Comparable. People sucks at writing compareTo and the resulting bugs are hard to find/reproduce.

Re: RFR: 8268129: LibraryLookup::ofDefault leaks symbols from loaded libraries [v7]

> This patch overhauls the library loading mechanism used by the Foreign Linker > API. We realized that, while handy, the *default* lookup abstraction > (`LibraryLookup::ofDefault`) was behaving inconsistentlt across platforms. > > This patch replaces `LibraryLookup` with a simpler

Integrated: 8267995: Add reference to JVMS class file format in Lookup::defineHiddenClass

On Thu, 3 Jun 2021 18:21:31 GMT, Mandy Chung wrote: > Trivial javadoc change to add a reference to JVMS 4.1 in > `Lookup::defineHiddenClass` such that the reference like `this_class` would > be referred to JVMS for details. This pull request has now been integrated. Changeset: b9558655

Re: RFR: 8174222: LambdaMetafactory: validate inputs and improve documentation [v2]

> Standardizes and better specifies the errors thrown by LambdaMetafactory, > including for inputs that would not be generated by javac. > > Does some renaming of core parameters/fields to better reflect their purpose. > > In the implementation, stops using ACC_BRIDGE for any methods, which is

Re: RFR: 8174222: LambdaMetafactory: validate inputs and improve documentation

On Thu, 3 Jun 2021 20:03:53 GMT, Dan Smith wrote: > Standardizes and better specifies the errors thrown by LambdaMetafactory, > including for inputs that would not be generated by javac. > > Does some renaming of core parameters/fields to better reflect their purpose. > > In the

RFR: 8174222: LambdaMetafactory: validate inputs and improve documentation

Standardizes and better specifies the errors thrown by LambdaMetafactory, including for inputs that would not be generated by javac. Does some renaming of core parameters/fields to better reflect their purpose. In the implementation, stops using ACC_BRIDGE for any methods, which is not a good

Integrated: 8265783: Create a separate library for x86 Intel SVML assembly intrinsics

On Thu, 22 Apr 2021 19:07:28 GMT, Sandhya Viswanathan wrote: > This PR contains Short Vector Math Library support related changes for > [JEP-414 Vector API (Second Incubator)](https://openjdk.java.net/jeps/414), > in preparation for when targeted. > > Intel Short Vector Math Library (SVML)

Re: RFR: 8199318: add idempotent copy operation for Map.Entry

- Mail original - > De: "Peter Levart" > À: "Rémi Forax" , "core-libs-dev" > > Envoyé: Jeudi 3 Juin 2021 20:49:05 > Objet: Re: RFR: 8199318: add idempotent copy operation for Map.Entry > On 02/06/2021 19:24, Rémi Forax wrote: >> I foolishly hoped that nobody would subclass a class with

Integrated: JDK-8267598: jpackage removes system libraries from java.library.path

On Wed, 26 May 2021 11:26:24 GMT, Andy Herrick wrote: > JDK-8267598: jpackage removes system libraries from java.library.path This pull request has now been integrated. Changeset: af3df630 Author:Andy Herrick URL:

Comment on JDK-826722: SoftReference not cleared on OutOfMemoryError: Requested array size exceeds VM limit

Hi, upon reading [1] I tried a similar scenario, but where OOME are caused by "Java heap space" exhaustion rather than by VM limits. import java.lang.ref.SoftReference; import java.text.DecimalFormat; import java.util.ArrayList; public class Softly { public static void main(String[]

Re: RFR: 8199318: add idempotent copy operation for Map.Entry

On 02/06/2021 19:24, Rémi Forax wrote: I foolishly hoped that nobody would subclass a class with `Immutable` in its name, oh boy i was wrong:) There's nothing wrong in subclassing an immutable class. As long as the subclass keeps being immutable. Was it subclassed and made mutable by

Re: RFR: 8268151: Vector API toShuffle optimization

On Thu, 3 Jun 2021 02:27:35 GMT, Xiaohong Gong wrote: >> The Vector API toShuffle method can be optimized using existing vector >> conversion intrinsic. >> >> The following changes are made: >> 1) vector.toShuffle java implementation is changed to call >> VectorSupport.convert. >> 2) The

Re: RFR: 8267995: Add reference to JVMS class file format in Lookup::defineHiddenClass

On Thu, 3 Jun 2021 18:21:31 GMT, Mandy Chung wrote: > Trivial javadoc change to add a reference to JVMS 4.1 in > `Lookup::defineHiddenClass` such that the reference like `this_class` would > be referred to JVMS for details. Marked as reviewed by darcy (Reviewer). - PR:

RFR: 8267995: Add reference to JVMS class file format in Lookup::defineHiddenClass

Trivial javadoc change to add a reference to JVMS 4.1 in `Lookup::defineHiddenClass` such that the reference like `this_class` would be referred to JVMS for details. - Commit messages: - 8267995: Add reference to JVMS class file format in Lookup::defineHiddenClass Changes:

Re: RFR: 8268129: LibraryLookup::ofDefault leaks symbols from loaded libraries [v6]

On Thu, 3 Jun 2021 16:43:51 GMT, Maurizio Cimadamore wrote: >> This patch overhauls the library loading mechanism used by the Foreign >> Linker API. We realized that, while handy, the *default* lookup abstraction >> (`LibraryLookup::ofDefault`) was behaving inconsistentlt across platforms. >>

Re: RFR: JDK-8267598: jpackage removes system libraries from java.library.path [v2]

On Thu, 3 Jun 2021 16:07:13 GMT, Andy Herrick wrote: >> JDK-8267598: jpackage removes system libraries from java.library.path > > Andy Herrick has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by

Re: RFR: 8263512: [macos_aarch64] issues with calling va_args functions from invoke_native [v3]

On Thu, 3 Jun 2021 03:28:56 GMT, Nick Gasson wrote: >> macOS on Apple silicon uses slightly different ABI conventions to the >> standard AArch64 ABI. The differences are outlined in [1]. In >> particular in the standard (AAPCS) ABI, variadic arguments may be passed >> in either registers or on

Re: RFR: 8195129: System.load() fails to load from unicode paths [v3]

On Thu, 3 Jun 2021 06:59:01 GMT, Maxim Kartashev wrote: >> test/hotspot/jtreg/runtime/jni/loadLibraryUnicode/LoadLibraryUnicodeTest.java >> line 42: >> >>> 40: String nativePathSetting = "-Dtest.nativepath=" + >>> getSystemProperty("test.nativepath"); >>> 41: ProcessBuilder

Re: RFR: 8265783: Create a separate library for x86 Intel SVML assembly intrinsics [v17]

> This PR contains Short Vector Math Library support related changes for > [JEP-414 Vector API (Second Incubator)](https://openjdk.java.net/jeps/414), > in preparation for when targeted. > > Intel Short Vector Math Library (SVML) based intrinsics in native x86 > assembly provide optimized

Re: RFR: 8195129: System.load() fails to load from unicode paths [v3]

On Thu, 3 Jun 2021 06:55:26 GMT, Maxim Kartashev wrote: >> src/hotspot/os/windows/os_windows.cpp line 1491: >> >>> 1489: static errno_t convert_UTF8_to_UTF16(char const* utf8_str, LPWSTR* >>> utf16_str) { >>> 1490: return convert_to_UTF16(utf8_str, CP_UTF8, utf16_str); >>> 1491: } >> >>

Re: RFR: 8268124: Update java.lang to use switch expressions [v3]

On Thu, 3 Jun 2021 11:01:02 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.lang` >> packages to make use of the switch expressions? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull request

Re: RFR: 8268124: Update java.lang to use switch expressions [v3]

On Thu, 3 Jun 2021 11:01:02 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.lang` >> packages to make use of the switch expressions? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull request

Re: RFR: 8268129: LibraryLookup::ofDefault leaks symbols from loaded libraries [v6]

> This patch overhauls the library loading mechanism used by the Foreign Linker > API. We realized that, while handy, the *default* lookup abstraction > (`LibraryLookup::ofDefault`) was behaving inconsistentlt across platforms. > > This patch replaces `LibraryLookup` with a simpler

Re: RFR: 8268129: LibraryLookup::ofDefault leaks symbols from loaded libraries [v5]

> This patch overhauls the library loading mechanism used by the Foreign Linker > API. We realized that, while handy, the *default* lookup abstraction > (`LibraryLookup::ofDefault`) was behaving inconsistentlt across platforms. > > This patch replaces `LibraryLookup` with a simpler

Withdrawn: 8264896: Remove redundant '& 0xFF' from int-to-byte cast

On Thu, 4 Mar 2021 12:16:29 GMT, Сергей Цыпанов wrote: > When we do > > byte b1 = (byte) (value & 0xFF); > > we keep from int only 1 lower byte and exactly the same can be achieved with > plain cast. See the test below: > > public class Main { > public static void main(String[] args)

Integrated: 8268131: 2 java/foreign tests timed out

On Wed, 2 Jun 2021 21:20:53 GMT, Maurizio Cimadamore wrote: > This patch increases time out for both TestUpcall and TestDowncall. These > tests were already long-running, but with JEP-412, they were beefed up even > more, so now they time out on some debug builds. > > This patch also address

Re: RFR: 8268131: 2 java/foreign tests timed out

On Wed, 2 Jun 2021 21:20:53 GMT, Maurizio Cimadamore wrote: > This patch increases time out for both TestUpcall and TestDowncall. These > tests were already long-running, but with JEP-412, they were beefed up even > more, so now they time out on some debug builds. > > This patch also address

Re: RFR: 8268131: 2 java/foreign tests timed out [v2]

> This patch increases time out for both TestUpcall and TestDowncall. These > tests were already long-running, but with JEP-412, they were beefed up even > more, so now they time out on some debug builds. > > This patch also address a minor issue in TestResourceScope which can > sometimes lead

Integrated: 8268077: java.util.List missing from Collections Framework Overview

On Tue, 1 Jun 2021 19:51:39 GMT, Raffaello Giulietti wrote: > Trivial changes to this non-normative document. This pull request has now been integrated. Changeset: 5405f983 Author:Raffaello Giulietti Committer: Stuart Marks URL:

Re: RFR: JDK-8267598: jpackage removes system libraries from java.library.path [v2]

> JDK-8267598: jpackage removes system libraries from java.library.path Andy Herrick has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional

Re: RFR: 8268131: 2 java/foreign tests timed out

On Wed, 2 Jun 2021 21:20:53 GMT, Maurizio Cimadamore wrote: > This patch increases time out for both TestUpcall and TestDowncall. These > tests were already long-running, but with JEP-412, they were beefed up even > more, so now they time out on some debug builds. > > This patch also address

Integrated: 8266317: Vector API enhancements

On Thu, 29 Apr 2021 21:13:38 GMT, Paul Sandoz wrote: > This PR contains API and implementation changes for [JEP-414 Vector API > (Second Incubator)](https://openjdk.java.net/jeps/414), in preparation for > when targeted. > > Enhancements are made to the API for the support of operations on

Re: RFR: 8268124: Update java.lang to use switch expressions [v3]

On Thu, 3 Jun 2021 11:01:02 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.lang` >> packages to make use of the switch expressions? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull request

Re: Some questions about String interning for primitives

Hi Dave, Have you seen the related thread about Integer.toString()? https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-April/076454.html Allocation is cheap and short lived object storage is quick to be reclaimed. What's missing is data about the cost vs savings in real applications.

Re: RFR: JDK-8268150: tier2: test/jdk/tools/jpackage/junit/junit.java needs updating for jtreg 6

On Thu, 3 Jun 2021 00:47:45 GMT, Jonathan Gibbons wrote: > Please review a small test fix, to include hamcrest.jar, as required by the > latest version of JUnit in jtreg 6. looks fine - PR: https://git.openjdk.java.net/jdk/pull/4328

Re: RFR: JDK-8267936: PreserveAllAnnotations option isn't tested

Hi Peter, On 3/06/2021 6:52 pm, Peter Levart wrote: On Thu, 3 Jun 2021 07:31:14 GMT, David Holmes wrote: The code is confusing because it gives no indication that it is aware that runtime invisible annotations could be present: /** * Parses the annotations described by the specified byte

Re: RFR: 8267630: Start of release updates for JDK 18

On Mon, 24 May 2021 22:35:04 GMT, Joe Darcy wrote: > 8267630: Start of release updates for JDK 18 Build change looks good. Please be aware of the incoming change https://bugs.openjdk.java.net/browse/JDK-8263468 which will add another version field to version-numbers.conf, which may need to

Re: RFR: JDK-8266254: Update to use jtreg 6 [v2]

On Wed, 2 Jun 2021 20:15:55 GMT, Jonathan Gibbons wrote: >> Please review the change to update to using jtreg 6. >> >> The primary change is to the jib-profiles.js file, which specifies the >> version of jtreg to use, for those systems that rely on this file. In >> addition, the

Re: RFR: 8268124: Update java.lang to use switch expressions [v3]

On Thu, 3 Jun 2021 11:01:02 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.lang` >> packages to make use of the switch expressions? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull request

Re: RFR: 8268124: Update java.lang to use switch expressions [v3]

On Thu, 3 Jun 2021 10:57:16 GMT, Patrick Concannon wrote: > My mistake. I've replaced the colon now with the lambda operator. Drive by comment, in term of name, `->` is the arrow operator not the lambda operator. - lambda = parameters + arrow + code - arrow case = case + arrow + code The

Re: RFR: 8268124: Update java.lang to use switch expressions [v3]

On Wed, 2 Jun 2021 16:06:42 GMT, Rémi Forax wrote: >> Patrick Concannon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8268124: small refactoring; fixed misplaced comment and added missing >> lambda operator > >

Re: RFR: 8268124: Update java.lang to use switch expressions [v3]

> Hi, > > Could someone please review my code for updating the code in the `java.lang` > packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request incrementally with one additional commit since the last revision: 8268124:

Re: RFR: 8268124: Update java.lang to use switch expressions [v3]

On Wed, 2 Jun 2021 16:43:25 GMT, Naoto Sato wrote: >> Patrick Concannon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8268124: small refactoring; fixed misplaced comment and added missing >> lambda operator > >

Re: RFR: 8268124: Update java.lang to use switch expressions [v2]

> Hi, > > Could someone please review my code for updating the code in the `java.lang` > packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev

Re: RFR: 8268131: 2 java/foreign tests timed out

On Wed, 2 Jun 2021 21:20:53 GMT, Maurizio Cimadamore wrote: > This patch increases time out for both TestUpcall and TestDowncall. These > tests were already long-running, but with JEP-412, they were beefed up even > more, so now they time out on some debug builds. > > This patch also address

Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v10]

> This is a preview of a patch implementing JEP 406: Pattern Matching for > switch (Preview): > https://bugs.openjdk.java.net/browse/JDK-8213076 > > The current draft of the specification is here: > http://cr.openjdk.java.net/~gbierman/jep406/jep406-20210430/specs/patterns-switch-jls.html > > A

Re: RFR: JDK-8267936: PreserveAllAnnotations option isn't tested

On Thu, 3 Jun 2021 07:31:14 GMT, David Holmes wrote: > > > The code is confusing because it gives no indication that it is aware > > > that runtime invisible annotations could be present: > > > /** > > > * Parses the annotations described by the specified byte array. > > > * resolving constant

Re: RFR: 8199318: add idempotent copy operation for Map.Entry [v2]

On Wed, 2 Jun 2021 17:54:06 GMT, Stuart Marks wrote: >> I'm fixing this along with a couple intertwined issues. >> >> 1. Add Map.Entry::copyOf as an idempotent copy operation. >> >> 2. Clarify that AbstractMap.SimpleImmutableEntry is itself unmodifiable (not >> really immutable) but that

Re: RFR: JDK-8267936: PreserveAllAnnotations option isn't tested

On Tue, 1 Jun 2021 09:30:40 GMT, Jaroslav Tulach wrote: > There doesn't seem to be much support for the complete changes in #4245. To > get at least something useful from that endeavor I have extracted the test > for existing behavior of `-XX:+PreserveAllAnnotations` and I am offering it >

Some questions about String interning for primitives

Dear readers, Apologies in advance if these questions have been asked and discussed before or if they are on the wrong mailing list, maybe they are more suited for project Valhalla, I'm not sure. I was wondering if it would be possible / feasible to intern primitive values and byte arrays and

Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v9]

> This is a preview of a patch implementing JEP 406: Pattern Matching for > switch (Preview): > https://bugs.openjdk.java.net/browse/JDK-8213076 > > The current draft of the specification is here: > http://cr.openjdk.java.net/~gbierman/jep406/jep406-20210430/specs/patterns-switch-jls.html > > A

Re: RFR: JDK-8267936: PreserveAllAnnotations option isn't tested

On 3/06/2021 4:49 pm, Peter Levart wrote: On Wed, 2 Jun 2021 22:44:10 GMT, David Holmes wrote: I think this is not deliberate. Since `rawAnnotations` may end up having any of the following: - `RuntimeVisibleAnnotations` (when there were just `RUNTIME` annotation usages compiled into the

Re: RFR: JDK-8267936: PreserveAllAnnotations option isn't tested

On Wed, 2 Jun 2021 22:47:13 GMT, David Holmes wrote: > On 3/06/2021 2:54 am, Joe Darcy wrote: > > > If the reflection runtime doesn't implement the semantics of > > -XX+PreserveAllAnnotations, I suggest deprecating/obsoleting/etc. that > > option now. > > I have to agree with Joe now. I

Re: RFR: 8195129: System.load() fails to load from unicode paths [v3]

On Tue, 1 Jun 2021 18:42:34 GMT, Naoto Sato wrote: >> Maxim Kartashev has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Coding style-related corrections. >> - Corrected the test to use Platform.sharedLibraryExt() > >

Re: RFR: 8195129: System.load() fails to load from unicode paths [v3]

On Tue, 1 Jun 2021 18:24:05 GMT, Naoto Sato wrote: >> Maxim Kartashev has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Coding style-related corrections. >> - Corrected the test to use Platform.sharedLibraryExt() > >

Re: RFR: 8195129: System.load() fails to load from unicode paths [v4]

> Character strings within JVM are produced and consumed in several formats. > Strings come from/to Java in the UTF8 format and POSIX APIs (like fprintf() > or dlopen()) consume strings also in UTF8. On Windows, however, the situation > is far less simple: some new(er) APIs expect UTF16

Re: RFR: JDK-8267936: PreserveAllAnnotations option isn't tested

On Wed, 2 Jun 2021 22:44:10 GMT, David Holmes wrote: > > I think this is not deliberate. Since `rawAnnotations` may end up having > > any of the following: > > - `RuntimeVisibleAnnotations` (when there were just `RUNTIME` annotation > > usages compiled into the class or

Re: RFR: 8267630: Start of release updates for JDK 18

On Mon, 24 May 2021 22:35:04 GMT, Joe Darcy wrote: > 8267630: Start of release updates for JDK 18 Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4175