On Wed, 9 Jun 2021 08:53:40 GMT, Yi Yang wrote:
>> The JDK codebase re-created many variants of checkIndex(`grep -I -r
>> 'cehckIndex' jdk/`). A notable variant is java.nio.Buffer.checkIndex, which
>> annotated with @IntrinsicCandidate and it only has a corresponding C1
>> intrinsic version.
On Wed, 9 Jun 2021 08:53:40 GMT, Yi Yang wrote:
>> The JDK codebase re-created many variants of checkIndex(`grep -I -r
>> 'cehckIndex' jdk/`). A notable variant is java.nio.Buffer.checkIndex, which
>> annotated with @IntrinsicCandidate and it only has a corresponding C1
>> intrinsic version.
On Sat, 12 Jun 2021 06:50:48 GMT, Thomas Stuefe wrote:
> This change removed a product flag so I wonder how it could be integrated
> without a CSR?
It's a diagnostic product flag, so it’ okay to remove it without issuing CSR.
But I am not 100% sure.
@dholmes-ora, do you have any comment
On Sat, 12 Jun 2021 06:29:50 GMT, Volker Simonis wrote:
> This change removed a product flag so I wonder how it could be integrated
> without a CSR?
And if the intention was to remove it, should it not have been marked as
obsolete first?
-
PR:
On Wed, 9 Jun 2021 08:53:40 GMT, Yi Yang wrote:
>> The JDK codebase re-created many variants of checkIndex(`grep -I -r
>> 'cehckIndex' jdk/`). A notable variant is java.nio.Buffer.checkIndex, which
>> annotated with @IntrinsicCandidate and it only has a corresponding C1
>> intrinsic version.