Re: RFR: 8268276: Base64 Decoding optimization for x86 using AVX-512 [v5]

2021-06-18 Thread Sandhya Viswanathan
On Fri, 18 Jun 2021 22:12:11 GMT, Scott Gibbons wrote: >> Add the Base64 Decode intrinsic for x86 to utilize AVX-512 for acceleration. >> Also allows for performance improvement for non-AVX-512 enabled platforms. >> Due to the nature of MIME-encoded inputs, modify the intrinsic signature to >

Integrated: Merge jdk17

2021-06-18 Thread Jesper Wilhelmsson
On Fri, 18 Jun 2021 22:17:41 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 17 -> JDK 18 This pull request has now been integrated. Changeset: b7d78a5b Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/b7d78a5b661e2b00f271298db3b6cc873cf754e7 Stats: 12229

Re: RFR: Merge jdk17 [v2]

2021-06-18 Thread Jesper Wilhelmsson
> Forwardport JDK 17 -> JDK 18 Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 46 commits: - Merge - 8267042: bug in monitor locking/unlocking on ARM32 C1 due to uninitialized BasicObjectLock::_displaced_header

Re: RFR: 8268974: jpackage fails to handle --dest option containing "bin" folder

2021-06-18 Thread Alexander Matveev
On Fri, 18 Jun 2021 22:46:24 GMT, Alexey Semenyuk wrote: > GetApplicationHomeFromDll() fails if the path to libjli.so contains "bin" > component (/tmp/bin/HelloWorld/lib/runtime/lib/libjli.so). TruncatePath() > looks for "/bin/" first in "/tmp/bin/HelloWorld/lib/runtime/lib/libjli.so" > string

RFR: 8268974: jpackage fails to handle --dest option containing "bin" folder

2021-06-18 Thread Alexey Semenyuk
GetApplicationHomeFromDll() fails if the path to libjli.so contains "bin" component (/tmp/bin/HelloWorld/lib/runtime/lib/libjli.so). TruncatePath() looks for "/bin/" first in "/tmp/bin/HelloWorld/lib/runtime/lib/libjli.so" string and then it looks for "/lib/". But this is wrong order as it shoul

Withdrawn: 8200559: Java agents doing instrumentation need a means to define auxiliary classes

2021-06-18 Thread duke
On Fri, 16 Apr 2021 13:44:16 GMT, Rafael Winterhalter wrote: > To allow agents the definition of auxiliary classes, an API is needed to > allow this. Currently, this is often achieved by using `sun.misc.Unsafe` or > `jdk.internal.misc.Unsafe` ever since the `defineClass` method was removed >

Re: [jdk17] RFR: JDK-8268826: Cleanup Override in Context-Specific Deserialization Filters

2021-06-18 Thread Brent Christian
On Wed, 16 Jun 2021 20:22:17 GMT, Roger Riggs wrote: > Remove the unnecessary special case "OVERRIDE" in jdk.serialFilterFactory > property. > Fix description in the example of a filter allowing platform classes. > Suppress some warnings about use of SecurityManager in tests. OVERRIDE is also m

RFR: Merge jdk17

2021-06-18 Thread Jesper Wilhelmsson
Forwardport JDK 17 -> JDK 18 - Commit messages: - Merge - 8268316: Typo in JFR jdk.Deserialization event - 8268638: semaphores of AsyncLogWriter may be broken when JVM is exiting. - 8264775: ClhsdbFindPC still fails with java.lang.RuntimeException: 'In java stack' missing from st

Re: RFR: 8268276: Base64 Decoding optimization for x86 using AVX-512 [v5]

2021-06-18 Thread Scott Gibbons
> Add the Base64 Decode intrinsic for x86 to utilize AVX-512 for acceleration. > Also allows for performance improvement for non-AVX-512 enabled platforms. > Due to the nature of MIME-encoded inputs, modify the intrinsic signature to > accept an additional parameter (isMIME) for fast-path MIME d

Re: RFR: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML [v2]

2021-06-18 Thread Joe Wang
On Fri, 18 Jun 2021 20:27:13 GMT, Naoto Sato wrote: >> Masanori Yano has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reflect the review comments > > src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/ToHTMLStream.java

Re: RFR: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML [v2]

2021-06-18 Thread Naoto Sato
On Fri, 18 Jun 2021 04:56:06 GMT, Masanori Yano wrote: >> Hi all, >> >> Could you please review the 8268457 bug fixes? >> >> The problem is that ToHTMLStream applies processing for non-surrogate pairs >> to the surrogate pair. >> This fix changes the processing for non-surrogate pairs to the e

Re: RFR: 8268873: Unnecessary Vector usage in java.base

2021-06-18 Thread Sean Mullan
On Mon, 14 Jun 2021 11:34:50 GMT, Andrey Turbanov wrote: > Usage of thread-safe collection `Vector` is unnecessary. It's recommended to > use `ArrayList` if a thread-safe implementation is not needed. > I checked only places where `Vector` was used as local variable. The change to `PKCS7::veri

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} where possible [v2]

2021-06-18 Thread Paul Sandoz
On Fri, 18 Jun 2021 05:54:01 GMT, Yi Yang wrote: >> After JDK-8265518(#3615), it's possible to replace all variants of >> checkIndex by >> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in >> the whole JDK codebase. > > Yi Yang has updated the pull request incrementally

Re: RFR: 8265891: (ch) InputStream returned by Channels.newInputStream should override transferTo

2021-06-18 Thread Brian Burkhalter
On Jun 18, 2021, at 6:36 AM, Alan Bateman mailto:al...@openjdk.java.net>> wrote: Adding an override of transferTo may require new tests. @bplb Do you if we have good tests for all the scenarios where input stream returned by Channels.newInputStream is the source? There are not a lot of tests

Re: RFR: 8266054: VectorAPI rotate operation optimization [v8]

2021-06-18 Thread Jatin Bhateja
On Tue, 8 Jun 2021 10:29:44 GMT, Jatin Bhateja wrote: >> Current VectorAPI Java side implementation expresses rotateLeft and >> rotateRight operation using following operations:- >> >> vec1 = lanewise(VectorOperators.LSHL, n) >> vec2 = lanewise(VectorOperators.LSHR, n) >> res = lane

Re: [jdk17] RFR: JDK-8266310: deadlock between System.loadLibrary and JNI FindClass loading another class

2021-06-18 Thread Mandy Chung
On Fri, 18 Jun 2021 09:50:49 GMT, Aleksei Voitylov wrote: > Resubmitting the following PR https://github.com/openjdk/jdk/pull/3976 > against JDK17. > > This fixes the deadlock in ClassLoader between the two lock objects - a lock > object associated with the class being loaded, and the > Clas

[jdk17] Integrated: 8265073: XML transformation and indentation when using xml:space

2021-06-18 Thread Joe Wang
On Thu, 17 Jun 2021 16:13:49 GMT, Joe Wang wrote: > The issue was that the attribute was processed before the variable was set > (e.g. m_preserveSpaces.push). Reversing the order fixed it. This pull request has now been integrated. Changeset: 7e03cf29 Author:Joe Wang URL: https://g

Re: [jdk17] RFR: 8268766: Desugaring of pattern matching enum switch should be improved [v3]

2021-06-18 Thread Maurizio Cimadamore
On Fri, 18 Jun 2021 13:23:57 GMT, Jan Lahoda wrote: >> Currently, an enum switch with patterns is desugared in a very non-standard, >> and potentially slow, way. It would be better to use the standard >> `typeSwitch` bootstrap to classify the enum constants. The bootstrap needs >> to accept en

Re: [jdk17] RFR: 8268766: Desugaring of pattern matching enum switch should be improved [v2]

2021-06-18 Thread Maurizio Cimadamore
On Fri, 18 Jun 2021 09:47:29 GMT, Rémi Forax wrote: >> This is to represent cases like: >> >> E sel = null; >> switch (sel) { >> case A -> {} >> case E e && "B".equals(e.name()) -> {} >> case C -> {} >> case E e -> {} >>

[jdk17] Integrated: 8266518: Refactor and expand scatter/gather tests

2021-06-18 Thread Paul Sandoz
On Mon, 14 Jun 2021 16:26:17 GMT, Paul Sandoz wrote: > Refactor scatter/gather tests to be included in the load/store test classes > and expand to support access between `ShortVector` and and `char[]`, and > access between `ByteVector` and `boolean[]`. > > Vector tests pass on linux-x64 linux-

Re: RFR: 8265891: (ch) InputStream returned by Channels.newInputStream should override transferTo

2021-06-18 Thread Alan Bateman
On Sun, 30 May 2021 17:30:56 GMT, Markus KARG wrote: > This PR-*draft* is **work in progress** and an invitation to discuss a > possible solution for issue > [JDK-8265891](https://bugs.openjdk.java.net/browse/JDK-8265891). It is *not > yet* intended for a final review. > > As proposed in JDK

Re: [jdk17] RFR: 8268766: Desugaring of pattern matching enum switch should be improved [v3]

2021-06-18 Thread Jan Lahoda
> Currently, an enum switch with patterns is desugared in a very non-standard, > and potentially slow, way. It would be better to use the standard > `typeSwitch` bootstrap to classify the enum constants. The bootstrap needs to > accept enum constants as labels in order to allow this. A complicat

[jdk17] RFR: JDK-8266310: deadlock between System.loadLibrary and JNI FindClass loading another class

2021-06-18 Thread Aleksei Voitylov
Resubmitting the following PR https://github.com/openjdk/jdk/pull/3976 against JDK17. This fixes the deadlock in ClassLoader between the two lock objects - a lock object associated with the class being loaded, and the ClassLoader.loadedLibraryNames hash map, locked during the native library loa

Re: [jdk17] RFR: 8268766: Desugaring of pattern matching enum switch should be improved [v2]

2021-06-18 Thread Rémi Forax
On Fri, 18 Jun 2021 09:08:04 GMT, Jan Lahoda wrote: >> src/java.base/share/classes/java/lang/runtime/SwitchBootstraps.java line 222: >> >>> 220: String invocationName, >>> 221: MethodType invocationType, >>> 222:

Re: [jdk17] RFR: 8268766: Desugaring of pattern matching enum switch should be improved [v2]

2021-06-18 Thread Jan Lahoda
On Thu, 17 Jun 2021 21:21:14 GMT, Maurizio Cimadamore wrote: > Very good piece of work. I like all the code that can be removed because of > this. Thanks! > > I assume that the new code only kicks in if there's at least a pattern in the > switch, otherwise we fallback to legacy translation

Re: [jdk17] RFR: 8268766: Desugaring of pattern matching enum switch should be improved [v2]

2021-06-18 Thread Jan Lahoda
On Thu, 17 Jun 2021 21:56:21 GMT, Rémi Forax wrote: >> Jan Lahoda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Creating a new bootstrap method for (pattern matching) enum switches, as >> suggested. > > src/java.base/share/classes/jav

Re: [jdk17] RFR: 8268766: Desugaring of pattern matching enum switch should be improved [v2]

2021-06-18 Thread Jan Lahoda
On Thu, 17 Jun 2021 21:03:58 GMT, Maurizio Cimadamore wrote: >> Jan Lahoda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Creating a new bootstrap method for (pattern matching) enum switches, as >> suggested. > > src/java.base/share/c

Re: RFR: 8265891: (ch) InputStream returned by Channels.newInputStream should override transferTo

2021-06-18 Thread Markus KARG
On Thu, 17 Jun 2021 20:08:08 GMT, Michael Bien wrote: >> This PR-*draft* is **work in progress** and an invitation to discuss a >> possible solution for issue >> [JDK-8265891](https://bugs.openjdk.java.net/browse/JDK-8265891). It is *not >> yet* intended for a final review. >> >> As proposed