> After JDK-8265518(#3615), it's possible to replace all variants of checkIndex
> by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
> the whole JDK codebase.
Yi Yang has updated the pull request incrementally with one additional commit
since the last revision:
On Wed, 23 Jun 2021 00:31:55 GMT, Scott Gibbons
wrote:
>> Add the Base64 Decode intrinsic for x86 to utilize AVX-512 for acceleration.
>> Also allows for performance improvement for non-AVX-512 enabled platforms.
>> Due to the nature of MIME-encoded inputs, modify the intrinsic signature to
On Wed, 23 Jun 2021 00:21:57 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 17 -> JDK 18
This pull request has now been integrated.
Changeset: b6cfca8a
Author:Jesper Wilhelmsson
URL:
https://git.openjdk.java.net/jdk/commit/b6cfca8a89810c7ed63ebc34ed9855b66ebcb5d9
Stats: 1931
> Forwardport JDK 17 -> JDK 18
Jesper Wilhelmsson has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 59 commits:
- Merge
- 8268290: Improve LockFreeQueue<> utility
Reviewed-by: iwalulya, tschatzl
- 8264941: Remove
On Tue, 22 Jun 2021 21:59:43 GMT, Alexander Matveev
wrote:
> Looks like another "Resource busy" issue similar to recent fixes for "hdiutil
> convert" and "hdiutil detach". Workaround in same way by repeating "create"
> command. Modified RetryExecutor to pass write to file flag, otherwise
>
> Add the Base64 Decode intrinsic for x86 to utilize AVX-512 for acceleration.
> Also allows for performance improvement for non-AVX-512 enabled platforms.
> Due to the nature of MIME-encoded inputs, modify the intrinsic signature to
> accept an additional parameter (isMIME) for fast-path MIME
Forwardport JDK 17 -> JDK 18
-
Commit messages:
- Merge
- 8268404: [TESTBUG] tools/jpackage/windows/WinInstallerIconTest.java failed
"AssertionError: Failed: Check icon"
- 8267652: c2 loop unrolling by 8 results in reading memory past array
- 8267399: C2:
Augment the specification of `java.io.File.createTempFile(String,String,File)`
to clarify its behavior with respect to the `File` parameter `directory`.
-
Commit messages:
- Merge
- 4847239: (spec) File.createTempFile() should make it clear that it doesn't
create the temporary
Looks like another "Resource busy" issue similar to recent fixes for "hdiutil
convert" and "hdiutil detach". Workaround in same way by repeating "create"
command. Modified RetryExecutor to pass write to file flag, otherwise "hdiutil
create" might deadlock.
Also, repeat is done only for creating
On Tue, 22 Jun 2021 20:47:55 GMT, Scott Gibbons
wrote:
>> Add the Base64 Decode intrinsic for x86 to utilize AVX-512 for acceleration.
>> Also allows for performance improvement for non-AVX-512 enabled platforms.
>> Due to the nature of MIME-encoded inputs, modify the intrinsic signature to
Updated AllModulesCommandTest to use dynamic port launching debuggee.
Parsing debuggee listening address functionality is required in several tests
(and we have other tests which need to be fixed the same way), so moved the
code to new class in jdk.test.lib
-
Commit messages:
-
On Tue, 22 Jun 2021 20:47:55 GMT, Scott Gibbons
wrote:
>> Add the Base64 Decode intrinsic for x86 to utilize AVX-512 for acceleration.
>> Also allows for performance improvement for non-AVX-512 enabled platforms.
>> Due to the nature of MIME-encoded inputs, modify the intrinsic signature to
> Add the Base64 Decode intrinsic for x86 to utilize AVX-512 for acceleration.
> Also allows for performance improvement for non-AVX-512 enabled platforms.
> Due to the nature of MIME-encoded inputs, modify the intrinsic signature to
> accept an additional parameter (isMIME) for fast-path MIME
On Tue, 22 Jun 2021 19:41:55 GMT, Jan Lahoda wrote:
>> Currently, an enum switch with patterns is desugared in a very non-standard,
>> and potentially slow, way. It would be better to use the standard
>> `typeSwitch` bootstrap to classify the enum constants. The bootstrap needs
>> to accept
> Sufficient permissions missing if this code was ever to run with
> SecurityManager.
>
> Cleanest approach appears to be use of InnocuousThread to create the
> cleaner/poller threads.
> Test case coverage extended to cover the SecurityManager scenario.
>
> Reviewer request: @valeriepeng
On Tue, 22 Jun 2021 17:50:05 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review the second half of my update for the `java.time`
>> package to make use of switch expressions?
>>
>> This PR was split into two parts due to the large number of files affected.
>>
>> Kind
> Currently, an enum switch with patterns is desugared in a very non-standard,
> and potentially slow, way. It would be better to use the standard
> `typeSwitch` bootstrap to classify the enum constants. The bootstrap needs to
> accept enum constants as labels in order to allow this. A
On Fri, 18 Jun 2021 14:35:42 GMT, Maurizio Cimadamore
wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updating javadoc, code and tests as suggested.
>
>
On Mon, 21 Jun 2021 20:21:58 GMT, Andy Herrick wrote:
> …t.java failed "AssertionError: Failed: Check icon"
This pull request has now been integrated.
Changeset: 35e4c272
Author:Andy Herrick
URL:
https://git.openjdk.java.net/jdk17/commit/35e4c2720df64ea6cb68ba8fb62aeeb0562c2907
On Tue, 22 Jun 2021 18:01:46 GMT, Chris Hegarty wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update copyright in BasicObjectsTest
>
> src/java.base/share/classes/java/util/Objects.java line 492:
>
>> 490:
On Tue, 22 Jun 2021 17:50:05 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review the second half of my update for the `java.time`
>> package to make use of switch expressions?
>>
>> This PR was split into two parts due to the large number of files affected.
>>
>> Kind
On Tue, 22 Jun 2021 16:18:11 GMT, Roger Riggs wrote:
>> Add java.util.Objects.newIdentity to supply a unique object with identity.
>> This is a replacement code can be used today for the traditional new
>> Object() idiom, which will be deprecated under Project Valhalla.
>> Refer to [JEP 401:
On Tue, 22 Jun 2021 02:58:28 GMT, Yi Yang wrote:
> I found that after solving the problem that Preconditions cannot be used
> during the VM startup, a series of functions such as
> String.checkIndex/checkOffset/.. can also be harmlessly replaced, but this
> changeset is somewhat large and may
On Tue, 22 Jun 2021 09:58:55 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.time`
>> packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request with a new
On Tue, 22 Jun 2021 16:18:11 GMT, Roger Riggs wrote:
>> Add java.util.Objects.newIdentity to supply a unique object with identity.
>> This is a replacement code can be used today for the traditional new
>> Object() idiom, which will be deprecated under Project Valhalla.
>> Refer to [JEP 401:
On Tue, 22 Jun 2021 16:07:12 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review the second half of my update for the `java.time`
>> package to make use of switch expressions?
>>
>> This PR was split into two parts due to the large number of files affected.
>>
>> Kind
> Hi,
>
> Could someone please review the second half of my update for the `java.time`
> package to make use of switch expressions?
>
> This PR was split into two parts due to the large number of files affected.
>
> Kind regards,
>
> Patrick
Patrick Concannon has updated the pull request
On Tue, 22 Jun 2021 09:58:55 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.time`
>> packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request with a new
On Tue, 22 Jun 2021 16:07:12 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review the second half of my update for the `java.time`
>> package to make use of switch expressions?
>>
>> This PR was split into two parts due to the large number of files affected.
>>
>> Kind
On Tue, 22 Jun 2021 09:58:55 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.time`
>> packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request with a new
On Tue, 22 Jun 2021 04:22:34 GMT, Ian Graves wrote:
> 8268664: The documentation of the Scanner.hasNextLine is incorrect
Associated CSR also Reviewed.
-
Marked as reviewed by iris (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/4547
On Tue, 22 Jun 2021 16:18:11 GMT, Roger Riggs wrote:
>> Add java.util.Objects.newIdentity to supply a unique object with identity.
>> This is a replacement code can be used today for the traditional new
>> Object() idiom, which will be deprecated under Project Valhalla.
>> Refer to [JEP 401:
On Tue, 22 Jun 2021 04:22:34 GMT, Ian Graves wrote:
> 8268664: The documentation of the Scanner.hasNextLine is incorrect
+1
-
Marked as reviewed by bpb (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/4547
On Tue, 22 Jun 2021 16:18:11 GMT, Roger Riggs wrote:
>> Add java.util.Objects.newIdentity to supply a unique object with identity.
>> This is a replacement code can be used today for the traditional new
>> Object() idiom, which will be deprecated under Project Valhalla.
>> Refer to [JEP 401:
On Tue, 22 Jun 2021 16:07:12 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review the second half of my update for the `java.time`
>> package to make use of switch expressions?
>>
>> This PR was split into two parts due to the large number of files affected.
>>
>> Kind
> Add java.util.Objects.newIdentity to supply a unique object with identity.
> This is a replacement code can be used today for the traditional new Object()
> idiom, which will be deprecated under Project Valhalla.
> Refer to [JEP 401: Primitive Objects
>
> Add java.util.Objects.newIdentity to supply a unique object with identity.
> This is a replacement code can be used today for the traditional new Object()
> idiom, which will be deprecated under Project Valhalla.
> Refer to [JEP 401: Primitive Objects
>
On Tue, 22 Jun 2021 15:40:12 GMT, Aleksei Efimov wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8269124: Added missing brace; fixed build issue
>
> src/java.base/share/classes/java/time/Instant.java line
> Hi,
>
> Could someone please review the second half of my update for the `java.time`
> package to make use of switch expressions?
>
> This PR was split into two parts due to the large number of files affected.
>
> Kind regards,
>
> Patrick
Patrick Concannon has updated the pull request
On Tue, 22 Jun 2021 10:50:17 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review the second half of my update for the `java.time`
> package to make use of switch expressions?
>
> This PR was split into two parts due to the large number of files affected.
>
> Kind regards,
>
On Tue, 22 Jun 2021 12:34:04 GMT, Andy Herrick wrote:
>> …t.java failed "AssertionError: Failed: Check icon"
>
> Andy Herrick has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8268404: [TESTBUG]
On Wed, 16 Jun 2021 12:20:48 GMT, Jorn Vernee wrote:
> Upstream fix for 8268230 to mainline JDK.
>
> Prior review thread can be found here:
> https://github.com/openjdk/panama-foreign/pull/554
>
> Testing: jdk_foreign test suite on Windows and Linux (WSL).
This pull request has now been
> Remove the unnecessary special case "OVERRIDE" in jdk.serialFilterFactory
> property.
> Fix description in the example of a filter allowing platform classes.
> Suppress some warnings about use of SecurityManager in tests.
Roger Riggs has updated the pull request incrementally with one
On Tue, 22 Jun 2021 10:50:17 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review the second half of my update for the `java.time`
> package to make use of switch expressions?
>
> This PR was split into two parts due to the large number of files affected.
>
> Kind regards,
>
On Tue, 22 Jun 2021 10:50:17 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review the second half of my update for the `java.time`
> package to make use of switch expressions?
>
> This PR was split into two parts due to the large number of files affected.
>
> Kind regards,
>
On Tue, 22 Jun 2021 09:58:55 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.time`
>> packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request with a new
On Tue, 22 Jun 2021 04:22:34 GMT, Ian Graves wrote:
> 8268664: The documentation of the Scanner.hasNextLine is incorrect
LGTM
-
Marked as reviewed by rriggs (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/4547
Sufficient permissions missing if this code was ever to run with
SecurityManager.
Cleanest approach appears to be use of InnocuousThread to create the
cleaner/poller threads.
Test case coverage extended to cover the SecurityManager scenario.
Reviewer request: @valeriepeng
-
On Mon, 14 Jun 2021 11:34:50 GMT, Andrey Turbanov
wrote:
> Usage of thread-safe collection `Vector` is unnecessary. It's recommended to
> use `ArrayList` if a thread-safe implementation is not needed.
> I checked only places where `Vector` was used as local variable.
Marked as reviewed by
On Tue, 22 Jun 2021 12:01:07 GMT, Sean Coffey wrote:
> Sufficient permissions missing if this code was ever to run with
> SecurityManager.
>
> Cleanest approach appears to be use of InnocuousThread to create the
> cleaner/poller threads.
> Test case coverage extended to cover the
On Tue, 22 Jun 2021 12:01:07 GMT, Sean Coffey wrote:
> Sufficient permissions missing if this code was ever to run with
> SecurityManager.
>
> Cleanest approach appears to be use of InnocuousThread to create the
> cleaner/poller threads.
> Test case coverage extended to cover the
On Mon, 21 Jun 2021 22:56:32 GMT, Andy Herrick wrote:
>> test/jdk/tools/jpackage/windows/WinInstallerIconTest.java line 75:
>>
>>> 73:
>>> 74: // Create another installer with custom icon.
>>> 75: long size3 = createInstaller(customIcon, "WithCustom3Icon");
>>
>> The test
> …t.java failed "AssertionError: Failed: Check icon"
Andy Herrick has updated the pull request incrementally with one additional
commit since the last revision:
JDK-8268404: [TESTBUG] tools/jpackage/windows/WinInstallerIconTest.java
failed "AssertionError: Failed: Check icon"
-
Sufficient permissions missing if this code was ever to run with
SecurityManager.
Cleanest approach appears to be use of InnocuousThread to create the
cleaner/poller threads.
Test case coverage extended to cover the SecurityManager scenario.
Reviewer request: @valeriepeng
-
Hi,
Could someone please review the second half of my update for the `java.time`
package to make use of switch expressions?
This PR was split into two parts due to the large number of files affected.
Kind regards,
Patrick
-
Commit messages:
- 8269124: Update java.time to use
On Thu, 17 Jun 2021 13:51:27 GMT, Daniel Fuchs wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>>
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev
On Wed, 16 Jun 2021 10:58:22 GMT, Stephen Colebourne
wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four
58 matches
Mail list logo
