On Mon, 12 Jul 2021 15:36:29 GMT, Andrew Haley wrote:
> And with longer strings, M1 and ThunderX2:
>
> ```
> Benchmark (diff_pos) (size) Mode Cnt
> Score Error Units
> StringCompare.compareLLDiffStrings10231024 avgt3
>
Hi all,
this pull request contains a backport of commit 07e90524 from the openjdk/jdk
repository.
The commit being backported was authored by Yi Yang on 13 Jul 2021 and was
reviewed by Mandy Chung.
Thanks!
-
Commit messages:
- Backport 07e90524576f159fc16523430f1db62327c89a3b
C
On Thu, 8 Jul 2021 03:12:24 GMT, Yi Yang wrote:
>> After JDK-8265518(#3615), it's possible to replace all variants of
>> checkIndex by
>> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
>> the whole JDK codebase.
>
> Yi Yang has refreshed the contents of this pull req
On Wed, 16 Jun 2021 08:08:47 GMT, Yi Yang wrote:
> After JDK-8265518(#3615), it's possible to replace all variants of checkIndex
> by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
> the whole JDK codebase.
This pull request has now been integrated.
Changeset: afe95
On Thu, 8 Jul 2021 02:32:45 GMT, Yi Yang wrote:
> Generated lambda class can not access protected static method of the target
> class. The following exception is thrown when executing the attached
> reproducible program:
>
>
> Exception in thread "main" java.lang.IllegalAccessError: class
>
On Mon, 12 Jul 2021 02:57:26 GMT, Yi Yang wrote:
>> Generated lambda class can not access protected static method of the target
>> class. The following exception is thrown when executing the attached
>> reproducible program:
>>
>>
>> Exception in thread "main" java.lang.IllegalAccessError: cl
On Mon, 12 Jul 2021 14:26:23 GMT, Jim Laskey wrote:
> Random.AbstractSplittableGenerator is an internal class that should not be
> exposed in a public API.
Marked as reviewed by bpb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/243
On Mon, 12 Jul 2021 14:26:23 GMT, Jim Laskey wrote:
> Random.AbstractSplittableGenerator is an internal class that should not be
> exposed in a public API.
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/243
On Thu, 8 Jul 2021 03:12:24 GMT, Yi Yang wrote:
>> After JDK-8265518(#3615), it's possible to replace all variants of
>> checkIndex by
>> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
>> the whole JDK codebase.
>
> Yi Yang has refreshed the contents of this pull req
Please consider this proposal to add some test coverage comparing `Math` and
`StrictMath` results of `pow()`.
-
Commit messages:
- 8211002: test/jdk/java/lang/Math/PowTests.java skips testing for
non-corner-case values
Changes: https://git.openjdk.java.net/jdk/pull/4758/files
Web
On Thu, 8 Jul 2021 19:47:26 GMT, Markus Grönlund wrote:
> Greetings,
>
> Object.finalize() was deprecated in JDK9. There is an ongoing effort to
> replace and mitigate Object.finalize() uses in the JDK libraries; please see
> https://bugs.openjdk.java.net/browse/JDK-8253568 for more informatio
> Please review this PR that is fixing a mismatch between the implementation
> for method `java.lang.constant.DynamicCallSiteDesc::withArgs` and its
> implementation. I made a mistake while working on a recent CSR
> [JDK-8224985](https://bugs.openjdk.java.net/browse/JDK-8224985) and fixed the
>
On Mon, 12 Jul 2021 18:02:54 GMT, Vicente Romero wrote:
>> Please review this PR that is fixing a mismatch between the implementation
>> for method `java.lang.constant.DynamicCallSiteDesc::withArgs` and its
>> implementation. I made a mistake while working on a recent CSR
>> [JDK-8224985](http
> Please consider this change to make the `float` and `double` versions of
> `java.lang.Math.abs()` branch-free.
Brian Burkhalter has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous content
> Please review this PR that is fixing a mismatch between the implementation
> for method `java.lang.constant.DynamicCallSiteDesc::withArgs` and its
> implementation. I made a mistake while working on a recent CSR
> [JDK-8224985](https://bugs.openjdk.java.net/browse/JDK-8224985) and fixed the
>
On Mon, 12 Jul 2021 02:57:26 GMT, Yi Yang wrote:
>> Generated lambda class can not access protected static method of the target
>> class. The following exception is thrown when executing the attached
>> reproducible program:
>>
>>
>> Exception in thread "main" java.lang.IllegalAccessError: cl
On Mon, 12 Jul 2021 17:11:01 GMT, Mandy Chung wrote:
>> Please review this PR that is fixing a mismatch between the implementation
>> for method `java.lang.constant.DynamicCallSiteDesc::withArgs` and its
>> implementation. I made a mistake while working on a recent CSR
>> [JDK-8224985](https:/
On Sat, 10 Jul 2021 19:03:36 GMT, Vicente Romero wrote:
> Please review this PR that is fixing a mismatch between the implementation
> for method `java.lang.constant.DynamicCallSiteDesc::withArgs` and its
> implementation. I made a mistake while working on a recent CSR
> [JDK-8224985](https://
On Fri, 9 Jul 2021 15:01:15 GMT, Maurizio Cimadamore
wrote:
> After some more investigation, I have been able to at least partially
> reproduce on my Linux box. While I can't get to same slowdown as we're seeing
> in test machines, I did notice that in fastdebug mode, TestUpcall is a lot
> sl
On Fri, 9 Oct 2020 16:14:59 GMT, Ignasi Marimon-Clos
wrote:
> The API Docs for `BigDecimal` introduce the meaning of `scale`. The current
> writeup can be missleading when presenting the meaning of a `scale` value
> that's negative. Hopefully, with this PR, the sentence is more clear.
>
> The
On Mon, 12 Jul 2021 05:21:34 GMT, Yi Yang wrote:
> I'm not familiar with the review process of core-lib group. Is it sufficient
> for merging with one approval? Should I have more reviews for this? 🤔
It depends on the change.
For this patch, it's good to get another reviewer to look through it
On Sat, 10 Jul 2021 19:03:36 GMT, Vicente Romero wrote:
> Please review this PR that is fixing a mismatch between the implementation
> for method `java.lang.constant.DynamicCallSiteDesc::withArgs` and its
> implementation. I made a mistake while working on a recent CSR
> [JDK-8224985](https://
On Thu, 8 Jul 2021 21:23:00 GMT, Naoto Sato wrote:
> This is an implementation for the `JEP 400: UTF-8 by Default`. The gist of
> the changes is `Charset.defaultCharset()` returning `UTF-8` and
> `file.encoding` system property being added in the spec, but another notable
> modification is in
On Mon, 12 Jul 2021 09:14:25 GMT, Wang Huang wrote:
>> Dear all,
>> Can you do me a favor to review this patch. This patch use `ldp` to
>> implement String.compareTo.
>>
>> * We add a JMH test case
>> * Here is the result of this test case
>>
>> Benchmark |(
On Mon, 12 Jul 2021 09:14:25 GMT, Wang Huang wrote:
>> Dear all,
>> Can you do me a favor to review this patch. This patch use `ldp` to
>> implement String.compareTo.
>>
>> * We add a JMH test case
>> * Here is the result of this test case
>>
>> Benchmark |(
Random.AbstractSplittableGenerator is an internal class that should not be
exposed in a public API.
-
Commit messages:
- Remove public exposure of AbstractSplittableGenerator
Changes: https://git.openjdk.java.net/jdk17/pull/243/files
Webrev: https://webrevs.openjdk.java.net/?repo=
On Fri, 9 Oct 2020 16:14:59 GMT, Ignasi Marimon-Clos
wrote:
> The API Docs for `BigDecimal` introduce the meaning of `scale`. The current
> writeup can be missleading when presenting the meaning of a `scale` value
> that's negative. Hopefully, with this PR, the sentence is more clear.
>
> The
> Dear all,
> Can you do me a favor to review this patch. This patch use `ldp` to
> implement String.compareTo.
>
> * We add a JMH test case
> * Here is the result of this test case
>
> Benchmark|(size)| Mode| Cnt|Score | Error |Units
> ---
On Fri, 9 Jul 2021 09:15:18 GMT, Andrew Haley wrote:
> I'm quite tempted to approve this. It looks generally better, simpler, and
> easier to understand than what we have today. However, the improvement isn't
> great, and I suspect is mostly because of the reduction in traffic between
> Base a
29 matches
Mail list logo
