Re: RFR: 8265891: (ch) InputStream returned by Channels.newInputStream should override transferTo [v3]

2021-07-21 Thread Markus KARG
On Fri, 2 Jul 2021 06:20:29 GMT, Markus KARG wrote: >> This PR-*draft* is **work in progress** and an invitation to discuss a >> possible solution for issue >> [JDK-8265891](https://bugs.openjdk.java.net/browse/JDK-8265891). It is *not >> yet* intended for a final review. >> >> As proposed

Re: [EXTERNAL] Re: jpackage on MacOS - ./Contents/Contents/app/myapp.cfg file not found

2021-07-21 Thread Bruno Borges
Thanks Andy. The issue regarding .cfg file not being found is indeed fixed in 17, and solves this particular problem I found. From: core-libs-dev on behalf of Andy Herrick Date: Wednesday, July 21, 2021 at 1:57 PM To: core-libs-dev@openjdk.java.net Subject: [EXTERNAL] Re: jpackage on MacOS

JNI WeakGlobalRefs

2021-07-21 Thread Hans Boehm
Is this an appropriate list to discuss JNI? I'm concerned that the current semantics of JNI WeakGlobalRefs are still dangerous in a very subtle way that is hidden in the spec. The current (14+) spec says: “Weak global references are related to Java phantom references

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v3]

2021-07-21 Thread Ian Graves
> 8199594: Add doc describing how (?x) ignores spaces in character classes Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Rewording repetitive phrase - Changes: - all: https://git.openjdk.java.net/jdk/pull/4618/files

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v2]

2021-07-21 Thread Ian Graves
On Wed, 21 Jul 2021 21:30:01 GMT, Lance Andersen wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> delete errant line > > src/java.base/share/classes/java/util/regex/Pattern.java line 758: > >> 756: *group just

Integrated: Merge jdk17

2021-07-21 Thread Jesper Wilhelmsson
On Wed, 21 Jul 2021 23:52:53 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 17 -> JDK 18 This pull request has now been integrated. Changeset: c36755de Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/c36755dedf1a0d7ce0aeadd401e0c70ff84185e7 Stats: 517

Re: RFR: Merge jdk17 [v2]

2021-07-21 Thread Jesper Wilhelmsson
> Forwardport JDK 17 -> JDK 18 Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 282 commits: - Merge - 8271015: Split cds/SharedBaseAddress.java test into smaller parts Reviewed-by: ccheung, minqi -

jpackage on MacOS - ./Contents/Contents/app/myapp.cfg file not found

2021-07-21 Thread Bruno Borges
Hi all, Been trying to use Java 16.0.1 to produce a PKG for the fx2048 [1] game, and the generated app-image comes with a binary launcher that tries to load the .cfg file from the wrong directory. Anyone seen this problem? fx2048.app/Contents/MacOS master -> origin/master ✔

RFR: Merge jdk17

2021-07-21 Thread Jesper Wilhelmsson
Forwardport JDK 17 -> JDK 18 - Commit messages: - Merge - 8266347: assert(Dependencies::is_concrete_root_method(fm, ctxk) == Dependencies::is_concrete_method(m, ctxk)) failed: mismatch - 8264066: Enhance compiler validation - 8265201: JarFile.getInputStream not validating

Re: JNI WeakGlobalRefs

2021-07-21 Thread David Holmes
Hi Hans, On 22/07/2021 7:54 am, Hans Boehm wrote: Is this an appropriate list to discuss JNI? No - hotspot-dev (to get runtime and GC folk) is the place to discuss JNI. Thanks, David I'm concerned that the current semantics of JNI WeakGlobalRefs are still dangerous in a very subtle way

Re: jpackage on MacOS - ./Contents/Contents/app/myapp.cfg file not found

2021-07-21 Thread Michael Hall
> On Jul 21, 2021, at 3:57 PM, Andy Herrick wrote: > > Looks like an instance of: JDK-8260335 > : [macos] Running app > using relative path causes problems (fixed in jdk17 build b09) > > you can try builds from https://jdk.java.net/17/ to

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v2]

2021-07-21 Thread Ian Graves
On Wed, 21 Jul 2021 20:22:04 GMT, Pavel Rappo wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> delete errant line > > src/java.base/share/classes/java/util/regex/Pattern.java line 833: > >> 831: * Comments

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v2]

2021-07-21 Thread Lance Andersen
On Wed, 21 Jul 2021 21:25:18 GMT, Ian Graves wrote: >> 8199594: Add doc describing how (?x) ignores spaces in character classes > > Ian Graves has updated the pull request incrementally with one additional > commit since the last revision: > > delete errant line

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v2]

2021-07-21 Thread Ian Graves
> 8199594: Add doc describing how (?x) ignores spaces in character classes Ian Graves has updated the pull request incrementally with one additional commit since the last revision: delete errant line - Changes: - all: https://git.openjdk.java.net/jdk/pull/4618/files - new:

Re: jpackage on MacOS - ./Contents/Contents/app/myapp.cfg file not found

2021-07-21 Thread Andy Herrick
Looks like an instance of: JDK-8260335 : [macos] Running app using relative path causes problems (fixed in jdk17 build b09) you can try builds from https://jdk.java.net/17/ to confirm fix. /Andy On 7/21/2021 4:46 PM, Bruno Borges wrote: Hi

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes

2021-07-21 Thread Iris Clark
On Mon, 28 Jun 2021 20:50:42 GMT, Ian Graves wrote: > 8199594: Add doc describing how (?x) ignores spaces in character classes Changes match corresponding, approved CSR. - Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4618

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes

2021-07-21 Thread Naoto Sato
On Mon, 28 Jun 2021 20:50:42 GMT, Ian Graves wrote: > 8199594: Add doc describing how (?x) ignores spaces in character classes Marked as reviewed by naoto (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4618

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes

2021-07-21 Thread Joe Darcy
On Mon, 28 Jun 2021 20:50:42 GMT, Ian Graves wrote: > 8199594: Add doc describing how (?x) ignores spaces in character classes Marked as reviewed by darcy (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4618

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes

2021-07-21 Thread Pavel Rappo
On Mon, 28 Jun 2021 20:50:42 GMT, Ian Graves wrote: > 8199594: Add doc describing how (?x) ignores spaces in character classes src/java.base/share/classes/java/util/regex/Pattern.java line 833: > 831: * Comments mode can also be enabled via the embedded flag > 832: *

Re: RFR: 8214761: Bug in parallel Kahan summation implementation [v2]

2021-07-21 Thread Ian Graves
> 8214761: Bug in parallel Kahan summation implementation Ian Graves has updated the pull request incrementally with three additional commits since the last revision: - Updates with more test coverage - stashing - Stashing - Changes: - all: