> This reimplements core reflection with method handles.
>
> For `Constructor::newInstance` and `Method::invoke`, the new implementation
> uses `MethodHandle`. For `Field` accessor, the new implementation uses
> `VarHandle`.For the first few invocations of one of these reflective
>
> 8214761: Bug in parallel Kahan summation implementation
Ian Graves has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains six additional commits since the
On Fri, 27 Aug 2021 13:12:33 GMT, Maurizio Cimadamore
wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove separate accessor for static vs instance method
>>
>> There is no effective difference when using
On Tue, 31 Aug 2021 17:14:05 GMT, Mandy Chung wrote:
>> This reimplements core reflection with method handles.
>>
>> For `Constructor::newInstance` and `Method::invoke`, the new implementation
>> uses `MethodHandle`. For `Field` accessor, the new implementation uses
>> `VarHandle`.For
On Tue, 31 Aug 2021 19:44:08 GMT, Daniel D. Daugherty
wrote:
> Trivial fixes to reduce the noise in the JDK18 CI:
> JDK-8273197 ProblemList 2 jtools tests due to JDK-8273187
> JDK-8273198 ProblemList
> java/lang/instrument/BootClassPath/BootClassPathTest.sh due to JDK-8273188
>
> These
On Tue, 31 Aug 2021 19:44:08 GMT, Daniel D. Daugherty
wrote:
> Trivial fixes to reduce the noise in the JDK18 CI:
> JDK-8273197 ProblemList 2 jtools tests due to JDK-8273187
> JDK-8273198 ProblemList
> java/lang/instrument/BootClassPath/BootClassPathTest.sh due to JDK-8273188
>
> These
Trivial fixes to reduce the noise in the JDK18 CI:
JDK-8273197 ProblemList 2 jtools tests due to JDK-8273187
JDK-8273198 ProblemList java/lang/instrument/BootClassPath/BootClassPathTest.sh
due to JDK-8273188
These failures happen in Tier5 so I'm ProblemListing them now to give @naotoj
time to
On Mon, 30 Aug 2021 19:28:11 GMT, Kevin Rushforth wrote:
>> Сергей Цыпанов has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8273140: Fix copyright year
>
> src/java.desktop/share/classes/sun/font/EAttribute.java line 2:
>
>> 1: /*
>> 2:
> Just a very tiny clean-up.
>
> There are some places in JDK code base where we call
> `Enum.class.getEnumConstants()` to get all the values of the referenced
> `enum`. This is excessive, less-readable and slower than just calling
> `Enum.values()` as in `getEnumConstants()` we have volatile
Using jarIndex for Hibench, there is an unexpected behavior with the exception
"Exception in thread "main"
org.apache.hadoop.fs.UnsupportedFileSystemException: No FileSystem for scheme
"hdfs"".
After investigating it, it is related to the usage of ServiceLoader with
JarIndex.
The below stack
This change will disable JARs signed with algorithms using SHA-1 by default,
and treat them as unsigned. This applies to the algorithms used to digest,
sign, and optionally timestamp the JAR. It also applies to the signature and
digest algorithms of the certificates in the certificate chain of
There's one important to keep in mind: escaping.
To ensure we're reading the properties correctly, we want to write them
using Properties.
Although the /META-INF/maven///pom.properties is
very predictable, others are not.
For example the maven-shade-plugin can rewrite properties files for
On Tue, 31 Aug 2021 09:40:14 GMT, xpbob
wrote:
> 8273169: java/util/regex/NegativeArraySize.java failed after JDK-8271302
This pull request has now been integrated.
Changeset: 683e30db
Author:bobpengxie
Committer: Sergey Bylokhov
URL:
On Tue, 31 Aug 2021 16:01:39 GMT, Maurizio Cimadamore
wrote:
> Please throw a "Reflection" somewhere :-) - e.g. "ReflectionInvokerBuilder"
Done. I'm fine with that.
-
PR: https://git.openjdk.java.net/jdk/pull/5027
> This reimplements core reflection with method handles.
>
> For `Constructor::newInstance` and `Method::invoke`, the new implementation
> uses `MethodHandle`. For `Field` accessor, the new implementation uses
> `VarHandle`.For the first few invocations of one of these reflective
>
On Tue, 31 Aug 2021 09:40:14 GMT, xpbob
wrote:
> 8273169: java/util/regex/NegativeArraySize.java failed after JDK-8271302
Marked as reviewed by serb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5315
On Thu, 26 Aug 2021 15:35:44 GMT, Paul Sandoz wrote:
> May i suggest that we add some JavaDoc to `ensureClassInitialized` describing
> the two cases of the calling thread is the initialization thread or not.
This is a good suggestion that also applies to `Lookup::ensureInitialized`. I
On Wed, 25 Aug 2021 22:05:24 GMT, Vladimir Ivanov wrote:
> Get rid of WeakReference-based logic in
> DirectMethodHandle::checkInitialized() and reimplement it with
> `Unsafe::ensureClassInitialized()`/`shouldBeInitialized()`.
>
> The key observation is that `Unsafe::ensureClassInitialized()`
On Sat, 28 Aug 2021 13:18:37 GMT, Claes Redestad wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @dfuch comments
>
> Seems OK.
Thanks @cl4es @magicus @dfuch for the review!
-
PR:
On Fri, 27 Aug 2021 23:12:52 GMT, Ioi Lam wrote:
> When the classlist is generated using build.tools.classlist.HelloClasslist,
> its contents may be non-deterministic due to Java thread execution order.
>
> We should sort the generated classlist to make the JDK image's contents more
>
On Tue, 31 Aug 2021 07:22:17 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/java/lang/Math.java line 1501:
>>
>>> 1499: // if the signs are the same and modulo not zero, round up
>>> 1500: if ((x ^ y) >= 0 && (q * y != x)) {
>>> 1501: return q + 1;
On Mon, 30 Aug 2021 16:56:20 GMT, Mandy Chung wrote:
> What about `InvokerBuilder` (it creates either MHInvoker or VHInvoker)?
Please throw a "Reflection" somewhere :-) - e.g. "ReflectionInvokerBuilder"
-
PR: https://git.openjdk.java.net/jdk/pull/5027
On Tue, 31 Aug 2021 02:08:48 GMT, Weijun Wang wrote:
>> This change modifies the default value of the `java.security.manager` system
>> property from "allow" to "disallow". This means unless it's explicitly set
>> to "allow", any call to `System.setSecurityManager()` would throw an UOE.
>>
>>
> This reimplements core reflection with method handles.
>
> For `Constructor::newInstance` and `Method::invoke`, the new implementation
> uses `MethodHandle`. For `Field` accessor, the new implementation uses
> `VarHandle`.For the first few invocations of one of these reflective
>
On Thu, 29 Jul 2021 23:27:32 GMT, Brian Burkhalter wrote:
> Add methods `floorDivExact(int,int)` and `floorDivExact(long,long)` to
> `java.lang.Math` and `java.lang.StrictMath`.
This pull request has now been integrated.
Changeset: e5518528
Author:Brian Burkhalter
URL:
BTW it is probably not a good idea to overwrite Properties (for example to get
a defined store order). Especially since changes in the past already broke
this. However the attached discussion shows that people do need insert-order
and/or alphabetical ordered properties — maybe a more general
On Tue, 31 Aug 2021 02:08:48 GMT, Weijun Wang wrote:
>> This change modifies the default value of the `java.security.manager` system
>> property from "allow" to "disallow". This means unless it's explicitly set
>> to "allow", any call to `System.setSecurityManager()` would throw an UOE.
>>
>>
Hello Magnus,
On 30/08/21 5:29 pm, Magnus Ihse Bursie wrote:
On 2021-08-28 17:16, Alan Bateman wrote:
On 28/08/2021 05:45, Jaikiran Pai wrote:
I hadn't considered the system property approach to switch to old
behaviour in my proposals, so this is a very good input and I
personally think
On Tue, 31 Aug 2021 02:08:48 GMT, Weijun Wang wrote:
>> This change modifies the default value of the `java.security.manager` system
>> property from "allow" to "disallow". This means unless it's explicitly set
>> to "allow", any call to `System.setSecurityManager()` would throw an UOE.
>>
>>
On Sat, 28 Aug 2021 13:21:24 GMT, Claes Redestad wrote:
> Refactor to improve inlining, which helps some microbenchmarks exer
> StringBuilder.append(String)
This pull request has now been integrated.
Changeset: 98fa5335
Author:Claes Redestad
URL:
On Mon, 30 Aug 2021 11:49:49 GMT, Claes Redestad wrote:
>> Refactor to improve inlining, which helps some microbenchmarks exer
>> StringBuilder.append(String)
>
> Claes Redestad has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Simplify and
On Tue, 31 Aug 2021 09:40:14 GMT, xpbob
wrote:
> 8273169: java/util/regex/NegativeArraySize.java failed after JDK-8271302
LGTM
Thanks for fixing it.
-
Marked as reviewed by jiefu (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5315
8273169: java/util/regex/NegativeArraySize.java failed after JDK-8271302
-
Commit messages:
- 8273169: java/util/regex/NegativeArraySize.java failed after JDK-8271302
Changes: https://git.openjdk.java.net/jdk/pull/5315/files
Webrev:
On Mon, 30 Aug 2021 15:52:05 GMT, Ian Graves wrote:
>> 8271302: Regex Test Refresh
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removing some notes re JUnit5
https://bugs.openjdk.java.net/browse/JDK-8273169
I'd like to
On Tue, 31 Aug 2021 01:05:05 GMT, Ioi Lam wrote:
>> When the classlist is generated using build.tools.classlist.HelloClasslist,
>> its contents may be non-deterministic due to Java thread execution order.
>>
>> We should sort the generated classlist to make the JDK image's contents more
>>
On Mon, 30 Aug 2021 15:52:05 GMT, Ian Graves wrote:
>> 8271302: Regex Test Refresh
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removing some notes re JUnit5
Looks like it was missed that the test fails oi a github
On Mon, 30 Aug 2021 22:25:09 GMT, Brian Burkhalter wrote:
>> Please review this PR to add officially endorsed `ceilDiv()` and `ceilMod()`
>> methods do `j.l.[Strict]Math`.
>>
>> Beside adding fresh tests to `test/jdk/java/lang/Math/DivModTests.java`,
>> this PR also corrects small typos in it
37 matches
Mail list logo
