On Wed, 15 Sep 2021 10:02:19 GMT, Aleksey Shipilev wrote:
> As the follow-up for Zero-specific JDK-8273494, we might want to clean up
> build system logic for all VM variants: stop impersonating "server" VMs for
> all of them. This basically leaves "core" and "custom" variants to be handled
>
On Wed, 15 Sep 2021 10:02:19 GMT, Aleksey Shipilev wrote:
> As the follow-up for Zero-specific JDK-8273494, we might want to clean up
> build system logic for all VM variants: stop impersonating "server" VMs for
> all of them. This basically leaves "core" and "custom" variants to be handled
>
On Mon, 20 Sep 2021 13:01:29 GMT, Roger Riggs wrote:
>> The intermittent test in java/lang/ProcessBuilder/Basic.java has identified
>> unexpected messages from a child Java VM
>> as the cause of the test failure. Attempts to control the output of the
>> child VM have failed, the VM is unrepent
Thank you Joe. That link helped. I have now moved the CSR to the next state.
-Jaikiran
On 21/09/21 9:28 am, Joseph D. Darcy wrote:
Hello Jaikiran,
The CSR is in Draft state. As discussed in the CSR wiki
(https://wiki.openjdk.java.net/display/csr/Main), the request needs to
be moved by the as
Hello Jaikiran,
The CSR is in Draft state. As discussed in the CSR wiki
(https://wiki.openjdk.java.net/display/csr/Main), the request needs to
be moved by the assignee to either Finalized or Proposed state to
request the CSR review the request.
HTH,
-Joe
On 9/20/2021 8:46 PM, Jaikiran Pai
On Sat, 18 Sep 2021 03:52:17 GMT, Jaikiran Pai wrote:
>> The commit in this PR implements the proposal for enhancement that was
>> discussed in the core-libs-dev mailing list recently[1], for
>> https://bugs.openjdk.java.net/browse/JDK-8231640
>>
>> At a high level - the `store()` APIs in `Pro
On Tue, 21 Sep 2021 02:06:47 GMT, Joe Darcy wrote:
> Fix of a typo in the javadoc of StringBuilder,readObject, as previously
> reported to core-libs-dev:
>
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-September/081277.html
This pull request has now been integrated.
Changeset:
On Tue, 21 Sep 2021 02:06:47 GMT, Joe Darcy wrote:
> Fix of a typo in the javadoc of StringBuilder,readObject, as previously
> reported to core-libs-dev:
>
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-September/081277.html
Marked as reviewed by bpb (Reviewer).
-
P
Fix of a typo in the javadoc of StringBuilder,readObject, as previously
reported to core-libs-dev:
https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-September/081277.html
-
Commit messages:
- Fix for JDK-8274031.
Changes: https://git.openjdk.java.net/jdk/pull/5592/files
On 9/8/2021 1:28 PM, Andrey Turbanov wrote:
Hello.
I found a confusing javadoc of the method java.lang.StringBuilder#readObject:
"readObject is called to restore the state of the StringBuffer from a stream."
I believe there should be "StringBuilder" instead of "StringBuffer".
Agreed; filed
I've made an
application image with jpackage. I've moved the default location of the
runtime in the application image
...
If I keep the runtime in $APPDIR\runtime, things don't fail in this way.
If it works when using the default location of the Java runtime and no
other changes, I'd guess
This is likely not the right place to ask this (sorry).. but I'm trying to
get info to write a bug report and want to make sure I'm not doing
something stupid first.
I've created a JRE image from JDK 17 with jlink. I've made an
application image with jpackage. I've moved the default location of
On Mon, 20 Sep 2021 18:17:29 GMT, Lance Andersen wrote:
>> Hi all,
>>
>> Please review this patch which addresses the issue where Zip FS will throw a
>> UOE instead of returning null when Files.getFileAttributeView() is invoked
>> and the view not supported.
>>
>> Mach5 tiers1 - tier3 are
On Mon, 20 Sep 2021 18:17:29 GMT, Lance Andersen wrote:
>> Hi all,
>>
>> Please review this patch which addresses the issue where Zip FS will throw a
>> UOE instead of returning null when Files.getFileAttributeView() is invoked
>> and the view not supported.
>>
>> Mach5 tiers1 - tier3 are
On Wed, 1 Sep 2021 01:05:32 GMT, Mandy Chung wrote:
>> This reimplements core reflection with method handles.
>>
>> For `Constructor::newInstance` and `Method::invoke`, the new implementation
>> uses `MethodHandle`. For `Field` accessor, the new implementation uses
>> `VarHandle`.For the
> Hi all,
>
> Please review this patch which addresses the issue where Zip FS will throw a
> UOE instead of returning null when Files.getFileAttributeView() is invoked
> and the view not supported.
>
> Mach5 tiers1 - tier3 are clean.
>
> Best
> Lance
Lance Andersen has updated the pull req
> Hi all,
>
> Please review this patch which addresses the issue where Zip FS will throw a
> UOE instead of returning null when Files.getFileAttributeView() is invoked
> and the view not supported.
>
> Mach5 tiers1 - tier3 are clean.
>
> Best
> Lance
Lance Andersen has updated the pull req
On Mon, 20 Sep 2021 17:05:33 GMT, Severin Gehwolf wrote:
>> Hi all,
>>
>> Please review this patch which addresses the issue where Zip FS will throw a
>> UOE instead of returning null when Files.getFileAttributeView() is invoked
>> and the view not supported.
>>
>> Mach5 tiers1 - tier3 are
On Mon, 20 Sep 2021 11:28:10 GMT, Alan Bateman wrote:
>> Hi all,
>>
>> Please review this patch which addresses the issue where Zip FS will throw a
>> UOE instead of returning null when Files.getFileAttributeView() is invoked
>> and the view not supported.
>>
>> Mach5 tiers1 - tier3 are cl
On Sun, 19 Sep 2021 15:34:44 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this patch which addresses the issue where Zip FS will throw a
> UOE instead of returning null when Files.getFileAttributeView() is invoked
> and the view not supported.
>
> Mach5 tiers1 - tier3 are clean.
On Sun, 19 Sep 2021 15:34:44 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this patch which addresses the issue where Zip FS will throw a
> UOE instead of returning null when Files.getFileAttributeView() is invoked
> and the view not supported.
>
> Mach5 tiers1 - tier3 are clean.
On Mon, 20 Sep 2021 16:09:14 GMT, Daniel Fuchs wrote:
>> Julia Boes has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 12 commits:
>>
>> - Merge branch 'master' into simpleserver
>> - check isHidden, isSymlink, isReadable for all p
On Mon, 20 Sep 2021 15:28:05 GMT, Julia Boes wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an implementation class whose main meth
On Wed, 8 Sep 2021 13:00:17 GMT, Erik Gahlin wrote:
> Hi,
>
> Could I have a review of change that prevents invalid Java identifiers or
> type names in JFR events. For rationale and compatibility issues see the CSR
> request. The only change to java.base is making
> jdk.modules.internal.Check
Thanks for reporting.
Filed: https://bugs.openjdk.java.net/browse/JDK-8274003
-Sundar
From: core-libs-dev on behalf of Andrey
Turbanov
Sent: 20 September 2021 20:49
To: core-libs-dev
Subject: Condition is always false in 'ProcessHandleImpl.Info#toString'
H
> This change implements a simple web server that can be run on the
> command-line with `java -m jdk.httpserver`.
>
> This is facilitated by adding an entry point for the `jdk.httpserver` module,
> an implementation class whose main method is run when the above command is
> executed. This is th
Hello.
I found suspicious code in the method java.lang.ProcessHandleImpl.Info#toString
https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/ProcessHandleImpl.java#L645
```
StringBuilder sb = new StringBuilder(60);
sb.append('[');
if (user != null) {
sb.append("user:
On Thu, 19 Aug 2021 15:15:31 GMT, Aleksey Shipilev wrote:
> See the bug report for more details. I would appreciate if people with their
> corporate testing systems would run this through their systems to avoid
> surprises. (ping @RealCLanger, @iignatev).
This pull request has now been integra
On Fri, 3 Sep 2021 09:10:20 GMT, Aleksey Shipilev wrote:
> During the review of JDK-8272914 that added hotspot:tier{2,3} groups,
> @iignatev suggested to create tier4 groups that capture all tests not in
> tiers{1,2,3}.
>
> Caveats:
> - I excluded `applications` from `hotspot:tier4`, because
On Thu, 16 Sep 2021 01:08:45 GMT, Naoto Sato wrote:
> Fixing failing regression tests caused by the JEP 400: UTF-8 by Default.
>
> `JcmdOutputEncodingTest` test case uses `file.encoding=UTF-8` in `C` locale.
> The output from the agent library is in `UTF-8` so it succeeded before the
> JEP has
On Wed, 8 Sep 2021 13:00:17 GMT, Erik Gahlin wrote:
> Hi,
>
> Could I have a review of change that prevents invalid Java identifiers or
> type names in JFR events. For rationale and compatibility issues see the CSR
> request. The only change to java.base is making
> jdk.modules.internal.Check
On Sat, 18 Sep 2021 03:52:17 GMT, Jaikiran Pai wrote:
>> The commit in this PR implements the proposal for enhancement that was
>> discussed in the core-libs-dev mailing list recently[1], for
>> https://bugs.openjdk.java.net/browse/JDK-8231640
>>
>> At a high level - the `store()` APIs in `Pro
> The intermittent test in java/lang/ProcessBuilder/Basic.java has identified
> unexpected messages from a child Java VM
> as the cause of the test failure. Attempts to control the output of the
> child VM have failed, the VM is unrepentant .
>
> There is no functionality in the child except to
On Wed, 15 Sep 2021 10:02:19 GMT, Aleksey Shipilev wrote:
> As the follow-up for Zero-specific JDK-8273494, we might want to clean up
> build system logic for all VM variants: stop impersonating "server" VMs for
> all of them. This basically leaves "core" and "custom" variants to be handled
>
On Sun, 19 Sep 2021 15:34:44 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this patch which addresses the issue where Zip FS will throw a
> UOE instead of returning null when Files.getFileAttributeView() is invoked
> and the view not supported.
>
> Mach5 tiers1 - tier3 are clean.
On Wed, 15 Sep 2021 10:02:19 GMT, Aleksey Shipilev wrote:
> As the follow-up for Zero-specific JDK-8273494, we might want to clean up
> build system logic for all VM variants: stop impersonating "server" VMs for
> all of them. This basically leaves "core" and "custom" variants to be handled
>
Hi all,
Please review this patch which addresses the issue where Zip FS will throw a
UOE instead of returning null when Files.getFileAttributeView() is invoked
and the view not supported.
Mach5 tiers1 - tier3 are clean.
Best
Lance
-
Commit messages:
- Add Cleanup Method
- ad
On Mon, 20 Sep 2021 09:52:45 GMT, Andrew Dinn wrote:
>> Andrew, can you help us to approve this?
>
> I agree with Andrew Haley that this patch is not going to make an improvement
> for anything but a very small number of applications. Processing of strings
> over a few 10s of bytes is rare. On
On Mon, 30 Aug 2021 06:26:01 GMT, Wang Huang wrote:
>> Dear all,
>> Can you do me a favor to review this patch. This patch use `ldp` to
>> implement String.compareTo.
>>
>> * We add a JMH test case
>> * Here is the result of this test case
>>
>> Benchmark |(
On Fri, 17 Sep 2021 07:13:24 GMT, Wu Yan wrote:
>> It's fine. I don't think it'll affect any real programs, so it's rather
>> pointless. I don't know if that's any reason not to approve it.
>
> Andrew, can you help us to approve this?
I agree with Andrew Haley that this patch is not going to ma
On Thu, 19 Aug 2021 15:15:31 GMT, Aleksey Shipilev wrote:
> See the bug report for more details. I would appreciate if people with their
> corporate testing systems would run this through their systems to avoid
> surprises. (ping @RealCLanger, @iignatev).
Ok, let's try!
-
PR: htt
On Fri, 17 Sep 2021 06:59:09 GMT, Aleksey Shipilev wrote:
>> During the review of JDK-8272914 that added hotspot:tier{2,3} groups,
>> @iignatev suggested to create tier4 groups that capture all tests not in
>> tiers{1,2,3}.
>>
>> Caveats:
>> - I excluded `applications` from `hotspot:tier4`,
42 matches
Mail list logo