Re: RFR: JDK-8274840: Update OS detection code to recognize Windows 11

2021-10-07 Thread Matthias Baesken
On Thu, 7 Oct 2021 11:20:57 GMT, Matthias Baesken wrote: > The OS detection code of the JDK/JVM should recognize the new Windows 11. For > details see : > > https://docs.microsoft.com/en-us/windows/release-health/windows11-release-information > OS build number is : 22000.194 for 21H2 (original

Integrated: JDK-8274840: Update OS detection code to recognize Windows 11

2021-10-07 Thread Matthias Baesken
On Thu, 7 Oct 2021 11:20:57 GMT, Matthias Baesken wrote: > The OS detection code of the JDK/JVM should recognize the new Windows 11. For > details see : > > https://docs.microsoft.com/en-us/windows/release-health/windows11-release-information > OS build number is : 22000.194 for 21H2 (original

Re: RFR: 8268129: LibraryLookup::ofDefault leaks symbols from loaded libraries

2021-10-07 Thread Cheng Jin
On Wed, 2 Jun 2021 20:13:34 GMT, Maurizio Cimadamore wrote: >> This patch overhauls the library loading mechanism used by the Foreign >> Linker API. We realized that, while handy, the *default* lookup abstraction >> (`LibraryLookup::ofDefault`) was behaving inconsistentlt across platforms. >>

Re: Throwable not thrown. In sun.reflect.generics.parser.SignatureParser#parseBounds

2021-10-07 Thread David Holmes
On 8/10/2021 6:10 am, Andrey Turbanov wrote: Hello. I found suspicious code in the method sun.reflect.generics.parser.SignatureParser#parseBounds https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/sun/reflect/generics/parser/SignatureParser.java#L532 Method 'error' called wi

Re: ideas about making static shared pool for skip buffers for InputStream and Reader

2021-10-07 Thread Xeno Amess
each for each class... byte[] and char[] of course cannot mix...at least, cannt mix from java side. I'm not that sure if such black magic can do on jvm side. I don't think it can. It is not safe to open the containing pool to another class either... java have no friend-class system like cpp Bri

Re: RFR: 8274864: Remove Amman/Cairo hacks in ZoneInfoFile

2021-10-07 Thread Iris Clark
On Thu, 7 Oct 2021 21:30:22 GMT, Naoto Sato wrote: > While working on tzdata2021c update, I noticed there is a dead code in > `sun.util.calendar.ZoneInfoFile`, which was used to tweak the rules for > `endOfDay` for certain cases. These are no longer needed as JDK's code is > already capable of

Re: ideas about making static shared pool for skip buffers for InputStream and Reader

2021-10-07 Thread Xeno Amess
each for each class... byte[] and char[] of course cannot mix...at least, cannt mix from java side. I'm not that sure if such black magic can do on jvm side. I don't think it can. It is not safe to open the containing pool to another class either... java have no friend-class system like cpp Xen

Re: RFR: JDK-8274930: sun/tools/jps/TestJps.java can fail with long VM arguments string

2021-10-07 Thread Serguei Spitsyn
On Thu, 7 Oct 2021 21:46:47 GMT, Alex Menkov wrote: > The fix adds "-XX:PerfMaxStringConstLength" argument running target app > (default is 1024, 8K should be enough for any environments) LGTM. Thanks, Serguei - Marked as reviewed by sspitsyn (Reviewer). PR: https://git.openjdk.j

RFR: JDK-8274930: sun/tools/jps/TestJps.java can fail with long VM arguments string

2021-10-07 Thread Alex Menkov
The fix adds "-XX:PerfMaxStringConstLength" argument running target app (default is 1024, 8K should be enough for any environments) - Commit messages: - JDK-8274930 Changes: https://git.openjdk.java.net/jdk/pull/5858/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5858

Re: ideas about making static shared pool for skip buffers for InputStream and Reader

2021-10-07 Thread Brian Burkhalter
Re-directing to the appropriate mailing list, core-libs-dev; please exclude jdk-dev from any reply. How can they be shared when they are different data types, viz., byte vs. char? On Oct 7, 2021, at 2:26 PM, Xeno Amess mailto:xenoam...@gmail.com>> wrote: I just wonder, if it worthy to create s

RFR: 8274864: Remove Amman/Cairo hacks in ZoneInfoFile

2021-10-07 Thread Naoto Sato
While working on tzdata2021c update, I noticed there is a dead code in `sun.util.calendar.ZoneInfoFile`, which was used to tweak the rules for `endOfDay` for certain cases. These are no longer needed as JDK's code is already capable of dealing with transitions beyond the end of the day. ---

Throwable not thrown. In sun.reflect.generics.parser.SignatureParser#parseBounds

2021-10-07 Thread Andrey Turbanov
Hello. I found suspicious code in the method sun.reflect.generics.parser.SignatureParser#parseBounds https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/sun/reflect/generics/parser/SignatureParser.java#L532 Method 'error' called without 'throw'. And the returned value is just i

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v6]

2021-10-07 Thread iaroslavski
On Wed, 6 Oct 2021 21:21:29 GMT, iaroslavski wrote: >> Sorting: >> >> - adopt radix sort for sequential and parallel sorts on >> int/long/float/double arrays (almost random and length > 6K) >> - fix tryMergeRuns() to better handle case when the last run is a single >> element >> - minor javad

Re: RFR: 8274879: Replace uses of StringBuffer with StringBuilder within java.base classes

2021-10-07 Thread Naoto Sato
On Thu, 9 Sep 2021 06:50:21 GMT, Andrey Turbanov wrote: > StringBuffer is a legacy synchronized class. There are more modern > alternatives which perform better: > 1. Plain String concatenation should be preferred > 2. StringBuilder is a direct replacement to StringBuffer which generally have

Integrated: 8274407: (tz) Update Timezone Data to 2021c

2021-10-07 Thread Naoto Sato
On Wed, 6 Oct 2021 01:24:49 GMT, Naoto Sato wrote: > This PR is to upgrade the time zone data in the JDK to IANA's tzdata2021c > level. Note that the tz data is "as is", as released by IANA. No `merged > links` are retracted. > The PR also fixes two issues along with the 2021c upgrade. This pu

RFR: 8271737: Only normalize the cached user.dir property once

2021-10-07 Thread Evgeny Astigeevich
The change completes the fix of [JDK-8198997](https://bugs.openjdk.java.net/browse/JDK-8198997) which has added normalisation in a constructor but not removed it from the get method. - Commit messages: - 8271737: Only normalize the cached user.dir property once Changes: https://gi

Re: RFR: JDK-8274840: Update OS detection code to recognize Windows 11

2021-10-07 Thread David Holmes
On Thu, 7 Oct 2021 11:20:57 GMT, Matthias Baesken wrote: > The OS detection code of the JDK/JVM should recognize the new Windows 11. For > details see : > > https://docs.microsoft.com/en-us/windows/release-health/windows11-release-information > OS build number is : 22000.194 for 21H2 (original

Re: RFR: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI [v2]

2021-10-07 Thread Aleksei Efimov
> This change implements a new service provider interface for host name and > address resolution, so that java.net.InetAddress API can make use of > resolvers other than the platform's built-in resolver. > > The following API classes are added to `java.net.spi` package to facilitate > this: > -

Re: RFR: JDK-8274840: Update OS detection code to recognize Windows 11

2021-10-07 Thread Christoph Langer
On Thu, 7 Oct 2021 11:20:57 GMT, Matthias Baesken wrote: > The OS detection code of the JDK/JVM should recognize the new Windows 11. For > details see : > > https://docs.microsoft.com/en-us/windows/release-health/windows11-release-information > OS build number is : 22000.194 for 21H2 (original

RFR: JDK-8274840: Update OS detection code to recognize Windows 11

2021-10-07 Thread Matthias Baesken
The OS detection code of the JDK/JVM should recognize the new Windows 11. For details see : https://docs.microsoft.com/en-us/windows/release-health/windows11-release-information OS build number is : 22000.194 for 21H2 (original release) Please review the following small patch ! (patch comes ori

RFR: 8274879: Replace uses of StringBuffer with StringBuilder within java.base classes

2021-10-07 Thread Andrey Turbanov
StringBuffer is a legacy synchronized class. There are more modern alternatives which perform better: 1. Plain String concatenation should be preferred 2. StringBuilder is a direct replacement to StringBuffer which generally have better performance In [JDK-8264029](https://bugs.openjdk.java.net/