I don't think it is a perfect solution to combine the close operation
with the terminator operation, because there are similar issues
in the intermediate operation.
Consider this use case (for example only):
try (var stream = Files.list(path)
.flatMap(dir -> {
try {
On Sun, 3 Oct 2021 11:00:25 GMT, Tagir F. Valeev wrote:
> Currently, when the stream holds a resource, it's necessary to wrap it with
> try-with-resources. This undermines the compact and fluent style of stream
> API calls. For example, if we want to get the `List` of files inside the
>
Hello!
> I am not really sure we’ve gotten the right idiom here yet. I’d like to slow
> down a bit before making an API decision.
>
> What id suggest is capturing the proposed api and spec on list, and let’s let
> this sit and bake for a bit longer. My sense is that something better may
>
> This PR improves the performance of vector operations that accept masks on
> architectures that support masking in hardware, specifically Intel AVX512 and
> ARM SVE.
>
> On architectures that do not support masking in hardware the same technique
> as before is applied to most operations,
PS See https://github.com/openjdk/jdk/pull/5973
-Joe
On 10/14/2021 1:53 PM, Joseph D. Darcy wrote:
On 10/14/2021 10:23 AM, Michael Bien wrote:
is this the right mailing list for javax.lang.model.* discussions?
The compiler-dev list would be appropriate as well, but core-libs will
work.
On Fri, 15 Oct 2021 20:19:31 GMT, Vladimir Kozlov wrote:
> > > How you verified correctness of results? I suggest to extend
> > > `test/jdk//java/lang/Math/MultiplicationTests.java` test to cover
> > > unsigned method.
> >
> >
> > Tests for unsignedMultiplyHigh were already added in
> >
On Wed, 13 Oct 2021 17:43:29 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review the fix to address a javadoc issue for the Deflater::deflate
> methods that were added as part of JDK-6341887 that could throw a
> ReadOnlyBufferException.
>
> The` @throws ` clause for
On Thu, 14 Oct 2021 15:50:28 GMT, Naoto Sato wrote:
> Fixing a regression in which `file.encoding` was initialized by
> `sprops->encoding` instead of `sprops->sun_jnu_encoding` on non macOS
> platforms. tier1-3 tests passed on all platforms.
This pull request has now been integrated.
On Fri, 15 Oct 2021 19:19:13 GMT, Vamsi Parasa wrote:
> > How you verified correctness of results? I suggest to extend
> > `test/jdk//java/lang/Math/MultiplicationTests.java` test to cover unsigned
> > method.
>
> Tests for unsignedMultiplyHigh were already added in
>
On Fri, 15 Oct 2021 18:51:44 GMT, Andrey Turbanov wrote:
> Non-static classes hold a link to their parent classes, which can be avoided.
src/java.prefs/macosx/classes/java/util/prefs/MacOSXPreferencesFile.java line
102:
> 100: }
> 101:
> 102: private class SyncTask extends TimerTask
Non-static classes hold a link to their parent classes, which can be avoided.
-
Commit messages:
- [PATCH] Change nested classes in java.prefs to static nested classes
Changes: https://git.openjdk.java.net/jdk/pull/5971/files
Webrev:
On Fri, 15 Oct 2021 09:30:18 GMT, Mitsuru Kariya wrote:
>> Fix `SerialBlob.setBytes(long pos, byte[] bytes, int offset, int length)` in
>> the following cases:
>>
>> 1. `pos - 1 + bytes.length - offset > this.length() && pos - 1 + length <=
>> this.length()`
>>The original implementation
On Fri, 15 Oct 2021 16:14:25 GMT, Andrew Haley wrote:
>> Optimize the new Math.unsignedMultiplyHigh using the x86 mul instruction.
>> This change show 1.87X improvement on a micro benchmark.
>
> src/hotspot/share/opto/mulnode.cpp line 468:
>
>> 466: }
>> 467:
>> 468:
>>
On Fri, 15 Oct 2021 18:45:41 GMT, Vladimir Kozlov wrote:
> How you verified correctness of results? I suggest to extend
> `test/jdk//java/lang/Math/MultiplicationTests.java` test to cover unsigned
> method.
Tests for unsignedMultiplyHigh were already added in
On Wed, 13 Oct 2021 18:55:10 GMT, Vamsi Parasa wrote:
> Optimize the new Math.unsignedMultiplyHigh using the x86 mul instruction.
> This change show 1.87X improvement on a micro benchmark.
How you verified correctness of results?
I suggest to extend
On Fri, 15 Oct 2021 09:27:54 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> Object.finalize() was deprecated in JDK9. There is an ongoing effort to
>> replace and mitigate Object.finalize() uses in the JDK libraries; please see
>> https://bugs.openjdk.java.net/browse/JDK-8253568 for more
On Wed, 13 Oct 2021 21:08:41 GMT, Joe Darcy wrote:
> After a refinement to the checks under development in #5709, the new checks
> examine array types of serial fields and warn if the underlying component
> type is not serializable. Per the JLS, all array types are serializable, but
> if the
On Tue, 12 Oct 2021 15:43:24 GMT, Aleksei Efimov wrote:
>> This change implements a new service provider interface for host name and
>> address resolution, so that java.net.InetAddress API can make use of
>> resolvers other than the platform's built-in resolver.
>>
>> The following API
On Wed, 13 Oct 2021 18:55:10 GMT, Vamsi Parasa wrote:
> Optimize the new Math.unsignedMultiplyHigh using the x86 mul instruction.
> This change show 1.87X improvement on a micro benchmark.
test/micro/org/openjdk/bench/java/lang/MathBench.java line 547:
> 545: return
On Fri, 15 Oct 2021 16:54:58 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-419 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
> This PR contains the API and implementation changes for JEP-419 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/419
Maurizio Cimadamore has updated the pull
On Sun, 10 Oct 2021 20:25:43 GMT, Joe Darcy wrote:
> The java.io.ObjectInputStream and java.io.ObjectOuputStream classes are part
> of the serialization feature. These classes contain brief descriptions of
> some of the methods serializable classes can define to interact with the
>
On Wed, 13 Oct 2021 18:55:10 GMT, Vamsi Parasa wrote:
> Optimize the new Math.unsignedMultiplyHigh using the x86 mul instruction.
> This change show 1.87X improvement on a micro benchmark.
src/hotspot/share/opto/mulnode.cpp line 468:
> 466: }
> 467:
> 468:
>
On Wed, 13 Oct 2021 18:55:10 GMT, Vamsi Parasa wrote:
> Optimize the new Math.unsignedMultiplyHigh using the x86 mul instruction.
> This change show 1.87X improvement on a micro benchmark.
The `java.lang.Math` change looks good, of course. On the rest I cannot comment
but it is good to see
On Tue, 12 Oct 2021 15:43:24 GMT, Aleksei Efimov wrote:
>> This change implements a new service provider interface for host name and
>> address resolution, so that java.net.InetAddress API can make use of
>> resolvers other than the platform's built-in resolver.
>>
>> The following API
On Thu, 14 Oct 2021 16:05:19 GMT, Mandy Chung wrote:
>> src/java.base/share/classes/jdk/internal/reflect/DirectMethodHandleAccessor.java
>> line 86:
>>
>>> 84: }
>>> 85:
>>> 86: private static final int PARAM_COUNT_MASK = 0x00FF;
>>
>> Is this packing logic required? I get it that it
On Sun, 10 Oct 2021 20:25:43 GMT, Joe Darcy wrote:
> The java.io.ObjectInputStream and java.io.ObjectOuputStream classes are part
> of the serialization feature. These classes contain brief descriptions of
> some of the methods serializable classes can define to interact with the
>
On Fri, 15 Oct 2021 07:17:52 GMT, Сергей Цыпанов wrote:
> It looks like we cannot use `Long.hashCode(long)` for
> `java.rmi.server.ObjID.hashCode()` due to specification:
> https://docs.oracle.com/en/java/javase/17/docs/api/java.rmi/java/rmi/server/ObjID.html#hashCode().
Marked as reviewed by
Optimize the new Math.unsignedMultiplyHigh using the x86 mul instruction. This
change show 1.87X improvement on a micro benchmark.
-
Commit messages:
- fix typo in function name
- 8275167: x86 intrinsic for unsignedMultiplyHigh
Changes:
On Fri, 15 Oct 2021 11:43:53 GMT, Pavel Rappo wrote:
>> It looks like we cannot use `Long.hashCode(long)` for
>> `java.rmi.server.ObjID.hashCode()` due to specification:
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.rmi/java/rmi/server/ObjID.html#hashCode().
>
> It's important to
On Fri, 15 Oct 2021 07:17:52 GMT, Сергей Цыпанов wrote:
> It looks like we cannot use `Long.hashCode(long)` for
> `java.rmi.server.ObjID.hashCode()` due to JavaDoc:
> https://docs.oracle.com/en/java/javase/17/docs/api/java.rmi/java/rmi/server/ObjID.html#hashCode().
It's important to be
On Thu, 14 Oct 2021 02:08:45 GMT, Wu Yan wrote:
>> Hi,
>> Please help me review the change to enhance getting time zone ID from
>> /etc/localtime on linux.
>>
>> We use `realpath` instead of `readlink` to obtain the link name of
>> /etc/localtime, because `readlink` can only read the value
On Thu, 14 Oct 2021 21:43:27 GMT, Coleen Phillimore wrote:
>> Markus Grönlund has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR.
>
>
On Thu, 14 Oct 2021 22:36:30 GMT, Markus Grönlund wrote:
>> src/hotspot/share/jfr/support/jfrSymbolTable.hpp line 68:
>>
>>> 66: template class,
>>> typename, size_t>
>>> 67: friend class HashTableHost;
>>> 68: typedef HashTableHost>> JfrSymbolTable> SymbolTable;
>>
>> Oh here it is.
> Fix `SerialBlob.setBytes(long pos, byte[] bytes, int offset, int length)` in
> the following cases:
>
> 1. `pos - 1 + bytes.length - offset > this.length() && pos - 1 + length <=
> this.length()`
>The original implementation throws `ArrayIndexOutOfBoundsException` but
> this case should
> Greetings,
>
> Object.finalize() was deprecated in JDK9. There is an ongoing effort to
> replace and mitigate Object.finalize() uses in the JDK libraries; please see
> https://bugs.openjdk.java.net/browse/JDK-8253568 for more information.
>
> We also like to assist users in replacing and
On 10/4/21 12:57, Сергей Цыпанов wrote:
in the code of HashSet(Collection) we have an optimization opportunity:
public HashSet(Collection c) {
map = new HashMap<>(Math.max((int) (c.size()/.75f) + 1, 16));
addAll(c);
}
instead of using addAll() inherited from j.u.Collection we can use
On Thu, 14 Oct 2021 16:51:42 GMT, Raffaello Giulietti
wrote:
> All have the form 2^q*10^(-k)
not quite, for example 0x1.3eaba12cap-804 = 2251808225167717/2^855 is not
of this form, but these cases come from the continued fraction expansion of
2^q*10^(-k).
-
PR:
On Fri, 16 Apr 2021 11:30:32 GMT, Raffaello Giulietti
wrote:
>> Hello,
>>
>> here's a PR for a patch submitted on March 2020
>> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was
>> a thing.
>>
>> The patch has been edited to adhere to OpenJDK code conventions about
On Fri, 15 Oct 2021 07:17:52 GMT, Сергей Цыпанов wrote:
> It looks like we cannot use `Long.hashCode(long)` for
> `java.rmi.server.ObjID.hashCode()` due to JavaDoc:
> https://docs.oracle.com/en/java/javase/17/docs/api/java.rmi/java/rmi/server/ObjID.html#hashCode().
@stuart-marks FYI
It looks like we cannot use `Long.hashCode(long)` for
`java.rmi.server.ObjID.hashCode()` due to JavaDoc:
https://docs.oracle.com/en/java/javase/17/docs/api/java.rmi/java/rmi/server/ObjID.html#hashCode().
-
Commit messages:
- 8275293: A change done with JDK-8268764 mismatches the
41 matches
Mail list logo
