This should be the last core libraries cleanup of non-serializable
non-transient instance fields ahead of the upcoming javac lint warnings:
https://mail.openjdk.java.net/pipermail/jdk-dev/2021-October/006166.html
-
Commit messages:
- JDK-8275688: Suppress warnings on
On Thu, 21 Oct 2021 01:06:33 GMT, Joe Darcy wrote:
> Another serialization warnings cleanup; this time in java.rmi.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6055
On Thu, 21 Oct 2021 01:06:33 GMT, Joe Darcy wrote:
> Another serialization warnings cleanup; this time in java.rmi.
Marked as reviewed by bpb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6055
On Wed, 20 Oct 2021 03:13:07 GMT, Nick Gasson wrote:
> AArch64 changes look ok apart from some minor comments.
Thank you @nick-arm for the review! All your comments have been addressed.
-
PR: https://git.openjdk.java.net/jdk/pull/5873
On Wed, 20 Oct 2021 19:02:30 GMT, Naoto Sato wrote:
>> During the review of JEP 400, a proposal to provide an overloaded method to
>> `Charset.forName()` was suggested
>> [[1]](https://github.com/openjdk/jdk/pull/4733#discussion_r669693954). This
>> PR is to implement the proposal. A CSR is
Another serialization warnings cleanup; this time in java.rmi.
-
Commit messages:
- JDK-8275686: Suppress warnings on non-serializable non-transient instance
fields in java.rmi
Changes: https://git.openjdk.java.net/jdk/pull/6055/files
Webrev:
On Wed, 13 Oct 2021 18:55:10 GMT, Vamsi Parasa wrote:
> Optimize the new Math.unsignedMultiplyHigh using the x86 mul instruction.
> This change show 1.87X improvement on a micro benchmark.
This pull request has now been integrated.
Changeset: af7c56b8
Author:vamsi-parasa
Committer:
On Wed, 20 Oct 2021 22:14:33 GMT, Vladimir Kozlov wrote:
> Tests passed. You can integrate changes.
Thanks Vladimir! What are the next steps to integrate the change?
-
PR: https://git.openjdk.java.net/jdk/pull/5933
On Tue, 19 Oct 2021 20:34:55 GMT, Vamsi Parasa wrote:
>> Optimize the new Math.unsignedMultiplyHigh using the x86 mul instruction.
>> This change show 1.87X improvement on a micro benchmark.
>
> Vamsi Parasa has updated the pull request incrementally with one additional
> commit since the last
The ObjectInputStream.GetField method `get(String name, Object val)` should
have been throwing
a ClassNotFoundException if the class was not found. Instead the
implementation was returning null.
A design error does not allow the `get(String name, Object val)` method to
throw CNFE as it
On Wed, 20 Oct 2021 19:02:30 GMT, Naoto Sato wrote:
>> During the review of JEP 400, a proposal to provide an overloaded method to
>> `Charset.forName()` was suggested
>> [[1]](https://github.com/openjdk/jdk/pull/4733#discussion_r669693954). This
>> PR is to implement the proposal. A CSR is
On Wed, 20 Oct 2021 19:02:30 GMT, Naoto Sato wrote:
>> During the review of JEP 400, a proposal to provide an overloaded method to
>> `Charset.forName()` was suggested
>> [[1]](https://github.com/openjdk/jdk/pull/4733#discussion_r669693954). This
>> PR is to implement the proposal. A CSR is
On Wed, 20 Oct 2021 18:58:34 GMT, Alan Bateman wrote:
>> Thanks, Joe. Moved that explanation into the `fallback` param, which I
>> initially intended.
>
> The java.nio.charset package has the usual "Unless otherwise noted, passing a
> null argument ..." so if fallback is allowed to be null
On Tue, 19 Oct 2021 20:34:55 GMT, Vamsi Parasa wrote:
>> Optimize the new Math.unsignedMultiplyHigh using the x86 mul instruction.
>> This change show 1.87X improvement on a micro benchmark.
>
> Vamsi Parasa has updated the pull request incrementally with one additional
> commit since the last
On Wed, 20 Oct 2021 18:37:05 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Moved the null sentence into @param tag.
>
> src/java.base/share/classes/java/nio/charset/Charset.java line 545:
>
>> 543:
On Wed, 20 Oct 2021 18:56:22 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/nio/charset/Charset.java line 545:
>>
>>> 543: * @return A charset object for the named charset, or {@code
>>> fallback}
>>> 544: * in case the charset object for the named charset is
> During the review of JEP 400, a proposal to provide an overloaded method to
> `Charset.forName()` was suggested
> [[1]](https://github.com/openjdk/jdk/pull/4733#discussion_r669693954). This
> PR is to implement the proposal. A CSR is also drafted as
>
On Wed, 20 Oct 2021 11:52:38 GMT, Aleksei Efimov wrote:
>> This change implements a new service provider interface for host name and
>> address resolution, so that java.net.InetAddress API can make use of
>> resolvers other than the platform's built-in resolver.
>>
>> The following API
On Wed, 20 Oct 2021 17:23:36 GMT, Naoto Sato wrote:
> During the review of JEP 400, a proposal to provide an overloaded method to
> `Charset.forName()` was suggested
> [[1]](https://github.com/openjdk/jdk/pull/4733#discussion_r669693954). This
> PR is to implement the proposal. A CSR is also
On Wed, 20 Oct 2021 11:52:38 GMT, Aleksei Efimov wrote:
>> This change implements a new service provider interface for host name and
>> address resolution, so that java.net.InetAddress API can make use of
>> resolvers other than the platform's built-in resolver.
>>
>> The following API
On Tue, 19 Oct 2021 20:34:55 GMT, Vamsi Parasa wrote:
>> Optimize the new Math.unsignedMultiplyHigh using the x86 mul instruction.
>> This change show 1.87X improvement on a micro benchmark.
>
> Vamsi Parasa has updated the pull request incrementally with one additional
> commit since the last
On Fri, 15 Oct 2021 20:19:31 GMT, Vladimir Kozlov wrote:
>>> How you verified correctness of results? I suggest to extend
>>> `test/jdk//java/lang/Math/MultiplicationTests.java` test to cover unsigned
>>> method.
>>
>> Tests for unsignedMultiplyHigh were already added in
>>
During the review of JEP 400, a proposal to provide an overloaded method to
`Charset.forName()` was suggested
[[1]](https://github.com/openjdk/jdk/pull/4733#discussion_r669693954). This PR
is to implement the proposal. A CSR is also drafted as
https://bugs.openjdk.java.net/browse/JDK-8275348
On Wed, 20 Oct 2021 00:04:08 GMT, Ivan Šipka wrote:
> cc @ctornqvi
Marked as reviewed by iignatyev (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6025
cc @ctornqvi
-
Commit messages:
- 8274122: added to problem list
Changes: https://git.openjdk.java.net/jdk/pull/6025/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=6025=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8275650
Stats: 1 line in 1 file changed: 1 ins;
On Tue, 19 Oct 2021 17:12:16 GMT, Harold Seigel wrote:
> Please review this small fix for JDK-8272614 to remove the unused indexInCP
> argument to linkCallSite() and linkDynamicConstant(). The fix was tested
> with Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and Mach5 tiers 3-6 on
> Linux
On Tue, 19 Oct 2021 17:12:16 GMT, Harold Seigel wrote:
> Please review this small fix for JDK-8272614 to remove the unused indexInCP
> argument to linkCallSite() and linkDynamicConstant(). The fix was tested
> with Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and Mach5 tiers 3-6 on
> Linux
On Tue, 19 Oct 2021 17:12:16 GMT, Harold Seigel wrote:
> Please review this small fix for JDK-8272614 to remove the unused indexInCP
> argument to linkCallSite() and linkDynamicConstant(). The fix was tested
> with Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and Mach5 tiers 3-6 on
> Linux
On Wed, 20 Oct 2021 11:52:38 GMT, Aleksei Efimov wrote:
>> This change implements a new service provider interface for host name and
>> address resolution, so that java.net.InetAddress API can make use of
>> resolvers other than the platform's built-in resolver.
>>
>> The following API
> This PR improves the performance of vector operations that accept masks on
> architectures that support masking in hardware, specifically Intel AVX512 and
> ARM SVE.
>
> On architectures that do not support masking in hardware the same technique
> as before is applied to most operations,
On Tue, 19 Oct 2021 14:22:26 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which addresses
>> https://bugs.openjdk.java.net/browse/JDK-8269336?
>>
>> As noted in that issue, this change will now propagate any exception that
>> occurred during parsing and creation of
On Mon, 18 Oct 2021 13:44:56 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which addresses
> https://bugs.openjdk.java.net/browse/JDK-8269336?
>
> As noted in that issue, this change will now propagate any exception that
> occurred during parsing and creation of the
> This PR contains the API and implementation changes for JEP-419 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/419
Maurizio Cimadamore has updated the pull
I'd like to propose a fix for JDK-8275535. This fix reverts the behavior to the
state previous to JDK-8160768, where an authentication failure stops from
trying other LDAP servers with the same credentials [1]. After JDK-8160768 we
have 2 possible loops to stop: the one that iterates over
On Tue, 19 Oct 2021 14:22:26 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which addresses
>> https://bugs.openjdk.java.net/browse/JDK-8269336?
>>
>> As noted in that issue, this change will now propagate any exception that
>> occurred during parsing and creation of
On Tue, 19 Oct 2021 13:00:01 GMT, Jaikiran Pai wrote:
> The `GlobalFilterTest` has to 2 `@test` tags. One of them has failed with a
> timeout as noted in https://bugs.openjdk.java.net/browse/JDK-8268595. The
> timeout seems to have happened even after the tests had already completed
>
On Sun, 17 Oct 2021 21:03:56 GMT, Mark Sheppard wrote:
> getByName requires a hostname lookup and getByAdress requires (eventually - I
> know the docs says there’s no reverse lookup) an address reverse lookup.
> Thus, a logical mapping is getByName —> lookupHostname, and getByAddr —>
>
> This change implements a new service provider interface for host name and
> address resolution, so that java.net.InetAddress API can make use of
> resolvers other than the platform's built-in resolver.
>
> The following API classes are added to `java.net.spi` package to facilitate
> this:
>
> This PR contains the API and implementation changes for JEP-419 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/419
Maurizio Cimadamore has updated the pull
On Wed, 20 Oct 2021 09:28:30 GMT, Leslie Zhai wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> upgrade the version in GHA config
>>
>> only in patch2:
>> unchanged:
>
> Hi @wangweij
>
> But how to be
On Tue, 19 Oct 2021 17:24:17 GMT, Weijun Wang wrote:
>> As a follow up of JEP 411, we will soon disallow security manager by
>> default. jtreg 6.1 does not set its own security manager if JDK version is
>> >= 18.
>
> Weijun Wang has updated the pull request incrementally with one additional
>
41 matches
Mail list logo
