Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v2]

2021-11-21 Thread David Holmes
On Mon, 22 Nov 2021 04:30:38 GMT, Joe Darcy wrote: >> The time to get JDK 19 underway draws nigh, please review this usual set of >> start-of-release updates, including CSRs for the javac and javax.lang.model >> updates: >> >> JDK-8277512: Add SourceVersion.RELEASE_19 >>

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v2]

2021-11-21 Thread Joe Darcy
On Mon, 22 Nov 2021 04:17:44 GMT, David Holmes wrote: > Hi Joe, > > I looked at all the non-sym file changes. Only one potential issue spotted. > > Thanks, David *sigh* Yep; cut and paste error -- corrected in next push. Well spotted! Thanks David - PR:

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v2]

2021-11-21 Thread Joe Darcy
> The time to get JDK 19 underway draws nigh, please review this usual set of > start-of-release updates, including CSRs for the javac and javax.lang.model > updates: > > JDK-8277512: Add SourceVersion.RELEASE_19 > https://bugs.openjdk.java.net/browse/JDK-8277512 > > JDK-8277514: Add source 19

Re: RFR: JDK-8273146: Start of release updates for JDK 19

2021-11-21 Thread David Holmes
On Mon, 22 Nov 2021 03:15:51 GMT, Joe Darcy wrote: > The time to get JDK 19 underway draws nigh, please review this usual set of > start-of-release updates, including CSRs for the javac and javax.lang.model > updates: > > JDK-8277512: Add SourceVersion.RELEASE_19 >

RFR: JDK-8273146: Start of release updates for JDK 19

2021-11-21 Thread Joe Darcy
The time to get JDK 19 underway draws nigh, please review this usual set of start-of-release updates, including CSRs for the javac and javax.lang.model updates: JDK-8277512: Add SourceVersion.RELEASE_19 https://bugs.openjdk.java.net/browse/JDK-8277512 JDK-8277514: Add source 19 and target 19

Re: RFR: 8276766: Enable jar and jmod to produce deterministic timestamped content

2021-11-21 Thread John Neffenger
On Fri, 19 Nov 2021 16:52:36 GMT, Andrew Leonard wrote: > Add a new --source-date (epoch milliseconds) option to jar and > jmod to allow specification of time to use for created/updated jar/jmod > entries. This then allows the ability to make the content deterministic. > > Signed-off-by:

Re: RFR: JDK-8277451: java.lang.reflect.Field::set on static field with invalid argument type should throw IAE

2021-11-21 Thread Alan Bateman
On Sun, 21 Nov 2021 03:02:53 GMT, Jaikiran Pai wrote: > Hello Mandy, > With this change the `getMessage` may get passed an empty string, so it would > end up printing something like `Can not get ... field on`. Do you > think the `getMessage` implementation should be tweaked not to print the

Re: Feature request: custom default annotation attributes

2021-11-21 Thread Brian Goetz
While I'm the first to admit that the design of annotations incorporated a great deal of optimism about its sufficiency, I think the return-on-complexity for such things is not good enough to warrant working on this. Now I was thinking: wouldn't it be nice to be able to define a custom

Feature request: custom default annotation attributes

2021-11-21 Thread Rob Spoor
Hi all, I've been writing a few annotations lately that have one required attribute and some optional ones. That leaves me with three options: 1) Use value() for the required attribute. That becomes ugly when the optional attributes are given though. 2) Make developers write the attribute

RFR: 8277507: Add jlink.debug system property while launching jpackage tests to help diagonize recent intermittent failures

2021-11-21 Thread Jaikiran Pai
Can I please get a review of this change which proposes to add more diagnostics when a failure occurs in the jlink tool during the jpackage tests? As noted in https://bugs.openjdk.java.net/browse/JDK-8277507, so far 3 failures have been reported in jpackage tests (across different test cases)

Re: RFR: 8272042: java.util.ImmutableCollections$Map1 and MapN should not be @ValueBased [v2]

2021-11-21 Thread Jens Li
On Fri, 19 Nov 2021 20:47:40 GMT, Roger Riggs wrote: >> The `jdk.internal.ValueBased` annotation was incorrectly applied to >> subclasses of java.util.AbstractMap. >> [ValueBased](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/doc-files/ValueBased.html) >> requires that