On Tue, 23 Nov 2021 19:23:40 GMT, Joe Darcy wrote:
>> The time to get JDK 19 underway draws nigh, please review this usual set of
>> start-of-release updates, including CSRs for the javac and javax.lang.model
>> updates:
>>
>> JDK-8277512: Add SourceVersion.RELEASE_19
>>
Might need a CSR as now `computeIfAbsent` `computeIfPresent` `compute` `merge`
would throw CME if the functions modified the map itself, and there are
corresponding specification changes.
-
Commit messages:
- Also test cme for identity hash map
- Fix putIfAbsent
- JDK-8277520:
On Thu, 18 Nov 2021 15:33:26 GMT, Roger Riggs wrote:
>> The ObjectInputStream.GetField.get(String name, Object val) method is
>> returning null instead of throwing an exception when the class of the object
>> is not found. The caller is not able to correctly handle the case where the
>> class
> On Nov 23, 2021, at 7:19 PM, Mandy Chung wrote:
>
> This changes jdeps -cp to ignore files/directories with no permission to
> access. This is consistent with the runtime behavior.
>
> -
>
> Commit messages:
> - JDK-8277375: jdeps errors on a class path with a file path with
This changes jdeps -cp to ignore files/directories with no permission to
access. This is consistent with the runtime behavior.
-
Commit messages:
- JDK-8277375: jdeps errors on a class path with a file path with no permission
Changes:
> This fix intends to honor the type (std/dst/generic) of parsed zone name for
> selecting the offset at the overlap. Corresponding CSR has also been drafted.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Refined wording
On Tue, 23 Nov 2021 21:44:17 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/java/io/ObjectInputFilter.java line 529:
>>
>>> 527: * if the filter string is invalid, an {@link
>>> ExceptionInInitializerError} is thrown
>>> 528: * and the initialization fails; subsequent
On Tue, 23 Nov 2021 04:40:04 GMT, Stuart Marks wrote:
>> The effects of an invalid `jdk.serialFilter` property are not completely
>> documented. If the value of the system property jdk.serialFilter is invalid,
>> deserialization should not be possible and it should be clear in the
>>
On Tue, 23 Nov 2021 20:54:55 GMT, Mandy Chung wrote:
> jdeps intends to report an error if there are multiple versions of the same
> class being parsed. module-info.class should be excluded from such
> detection.
>
> This patch also fixes a data race in `VersionHelper::set` and also unwraps
jdeps intends to report an error if there are multiple versions of the same
class being parsed. module-info.class should be excluded from such detection.
This patch also fixes a data race in `VersionHelper::set` and also unwraps the
`ExecutionException` when FutureTask of parsing the classes
> Add a new --source-date (epoch milliseconds) option to jar and
> jmod to allow specification of time to use for created/updated jar/jmod
> entries. This then allows the ability to make the content deterministic.
>
> Signed-off-by: Andrew Leonard
Andrew Leonard has updated the pull request
> The time to get JDK 19 underway draws nigh, please review this usual set of
> start-of-release updates, including CSRs for the javac and javax.lang.model
> updates:
>
> JDK-8277512: Add SourceVersion.RELEASE_19
> https://bugs.openjdk.java.net/browse/JDK-8277512
>
> JDK-8277514: Add source 19
On Mon, 15 Nov 2021 18:47:34 GMT, Andrew Leonard wrote:
> Both jar and jmod utilise java.io file operations whose methods define no
> ordering of the return file lists, and in fact rely on OS query file
> ordering, which can differ by underlying OS architecture.
> This PR adds sort processing
On Tue, 23 Nov 2021 10:04:51 GMT, Andrew Leonard wrote:
>> Both jar and jmod utilise java.io file operations whose methods define no
>> ordering of the return file lists, and in fact rely on OS query file
>> ordering, which can differ by underlying OS architecture.
>> This PR adds sort
On Sat, 20 Nov 2021 19:13:43 GMT, Mandy Chung wrote:
> java.lang.reflect.Field::set on static field with invalid argument type
> should throw IAE. But this regression is introduced by JEP 416 throwing NPE
> instead.
>
> `ensureObj` is called as the first check of the `Field::set` method to
This fix intends to honor the type (std/dst/generic) of parsed zone name for
selecting the offset at the overlap. Corresponding CSR has also been drafted.
-
Commit messages:
- 8177819: DateTimeFormatterBuilder zone parsing should recognise DST
Changes:
On 23.11.21 15:57, Roger Riggs wrote:
Hi Michael,
As you might expect performance of strings is very sensitive and has
been tuned extensively over the years many times.
Though this improves the performance for 1 character strings. It will
have an impact on *every other* length of string.
> On Nov 22, 2021, at 7:01 PM, Kevin Rushforth
> wrote:
>
> By way of clarification, JNF was never part of the JDK. What we removed was
> the JDK's *usage* of JNF. And we did so because Apple deprecated it and never
> even provide a JNF framework for aarch64.
>
> Applications either need
> Add a new --source-date (epoch milliseconds) option to jar and
> jmod to allow specification of time to use for created/updated jar/jmod
> entries. This then allows the ability to make the content deterministic.
>
> Signed-off-by: Andrew Leonard
Andrew Leonard has updated the pull request
> Add a new --source-date (epoch milliseconds) option to jar and
> jmod to allow specification of time to use for created/updated jar/jmod
> entries. This then allows the ability to make the content deterministic.
>
> Signed-off-by: Andrew Leonard
Andrew Leonard has updated the pull request
On Tue, 23 Nov 2021 14:34:23 GMT, Andrew Leonard wrote:
>>> I've added updates to the jar and jmod man pages, as "Notes" about
>>> ordering, does that sound reasonable?
>>
>> The true source of the man pages are still kept in our closed repository.
>> The copy in the jdk repo is generated
On Tue, 23 Nov 2021 15:08:43 GMT, Daniel D. Daugherty
wrote:
> This reverts commit 12f08ba4d47cb70a0629b17bc3639ce170309f21.
>
> The fix for JDK-8277507 is causing 38 failures per Tier2 job set.
Sorry, I should really have had run that original PR through `tier2` from
someone before merging
On Tue, 23 Nov 2021 15:08:43 GMT, Daniel D. Daugherty
wrote:
> This reverts commit 12f08ba4d47cb70a0629b17bc3639ce170309f21.
>
> The fix for JDK-8277507 is causing 38 failures per Tier2 job set.
This pull request has now been integrated.
Changeset: 64bdc843
Author:Daniel D. Daugherty
This reverts commit 12f08ba4d47cb70a0629b17bc3639ce170309f21.
The fix for JDK-8277507 is causing 38 failures per Tier2 job set.
-
Commit messages:
- Revert "8277507: Add jlink.debug system property while launching jpackage
tests to help diagonize recent intermittent failures"
On Tue, 23 Nov 2021 15:12:43 GMT, Stefan Karlsson wrote:
>> This reverts commit 12f08ba4d47cb70a0629b17bc3639ce170309f21.
>>
>> The fix for JDK-8277507 is causing 38 failures per Tier2 job set.
>
> Marked as reviewed by stefank (Reviewer).
@stefank and @AlanBateman - Thanks for the lightning
On Tue, 23 Nov 2021 15:08:43 GMT, Daniel D. Daugherty
wrote:
> This reverts commit 12f08ba4d47cb70a0629b17bc3639ce170309f21.
>
> The fix for JDK-8277507 is causing 38 failures per Tier2 job set.
Marked as reviewed by stefank (Reviewer).
-
PR:
On Tue, 23 Nov 2021 15:08:43 GMT, Daniel D. Daugherty
wrote:
> This reverts commit 12f08ba4d47cb70a0629b17bc3639ce170309f21.
>
> The fix for JDK-8277507 is causing 38 failures per Tier2 job set.
Marked as reviewed by alanb (Reviewer).
-
PR:
On Tue, 23 Nov 2021 15:09:53 GMT, Claes Redestad wrote:
> Thanks for adding the comment and fixing typos.
sure, thanks to you
-
PR: https://git.openjdk.java.net/jdk/pull/6403
On Tue, 23 Nov 2021 15:05:47 GMT, Vicente Romero wrote:
>> Please review this PR which aims to optimize the implementation of the
>> `toString` method we provide for records. A benchmark comparing the
>> implementation we are providing for records with lombok found out that
>> lombok is much
On Tue, 23 Nov 2021 15:05:47 GMT, Vicente Romero wrote:
>> Please review this PR which aims to optimize the implementation of the
>> `toString` method we provide for records. A benchmark comparing the
>> implementation we are providing for records with lombok found out that
>> lombok is much
> Please review this PR which aims to optimize the implementation of the
> `toString` method we provide for records. A benchmark comparing the
> implementation we are providing for records with lombok found out that lombok
> is much faster mainly because our implementation uses
On Fri, 19 Nov 2021 15:50:47 GMT, Roger Riggs wrote:
> The `jdk.internal.ValueBased` annotation was incorrectly applied to
> subclasses of java.util.AbstractMap.
> [ValueBased](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/doc-files/ValueBased.html)
> requires that
On Tue, 23 Nov 2021 14:34:23 GMT, Andrew Leonard wrote:
>>> I've added updates to the jar and jmod man pages, as "Notes" about
>>> ordering, does that sound reasonable?
>>
>> The true source of the man pages are still kept in our closed repository.
>> The copy in the jdk repo is generated
Hi Michael,
As you might expect performance of strings is very sensitive and has
been tuned extensively over the years many times.
Though this improves the performance for 1 character strings. It will
have an impact on *every other* length of string.
You'll need to show that it does not
On Fri, 19 Nov 2021 21:33:43 GMT, Mandy Chung wrote:
>> @magicus I've added updates to the jar and jmod man pages, as "Notes" about
>> ordering, does that sound reasonable?
>
>> I've added updates to the jar and jmod man pages, as "Notes" about
>> ordering, does that sound reasonable?
>
>
On Sat, 20 Nov 2021 03:26:51 GMT, Alexey Semenyuk wrote:
> 8277429: Conflicting jpackage static library name
Ok, I'm still a bit confused. Are executables converted to static libs (with a
main method?) when doing static builds? I thought this affected only dynamic
libraries. Are we sure that
On Tue, 23 Nov 2021 10:04:51 GMT, Andrew Leonard wrote:
>> Both jar and jmod utilise java.io file operations whose methods define no
>> ordering of the return file lists, and in fact rely on OS query file
>> ordering, which can differ by underlying OS architecture.
>> This PR adds sort
On Mon, 22 Nov 2021 02:36:00 GMT, John Neffenger wrote:
>> Add a new --source-date (epoch milliseconds) option to jar and
>> jmod to allow specification of time to use for created/updated jar/jmod
>> entries. This then allows the ability to make the content deterministic.
>>
>>
> Both jar and jmod utilise java.io file operations whose methods define no
> ordering of the return file lists, and in fact rely on OS query file
> ordering, which can differ by underlying OS architecture.
> This PR adds sort processing to the creation of such jar's and jmod's to
> enable a
On Mon, 22 Nov 2021 14:57:01 GMT, Daniel Fuchs wrote:
>> Andrew Leonard has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8276764: Enable deterministic file content ordering for Jar and Jmod
>>
>> Signed-off-by: Andrew Leonard
>
>
On Wed, 17 Nov 2021 18:48:14 GMT, Volker Simonis wrote:
> In JDK 9, function objects implemented as anonymous inner classes in
> java.util.regex.Pattern have been replaced by lambda functions (see
> [JDK-8151481](https://bugs.openjdk.java.net/browse/JDK-8151481)). This led to
> a significant
On Wed, 17 Nov 2021 18:48:14 GMT, Volker Simonis wrote:
> In JDK 9, function objects implemented as anonymous inner classes in
> java.util.regex.Pattern have been replaced by lambda functions (see
> [JDK-8151481](https://bugs.openjdk.java.net/browse/JDK-8151481)). This led to
> a significant
On Sat, 13 Nov 2021 23:16:22 GMT, Sergey Bylokhov wrote:
> The ZipOutputStream class may create bogus zip data which cannot be opened by
> the ZipFile. The root cause is how the comment field is stored by the
> ZipOutputStream. According to the zip specification, the comment field should
>
On Sun, 21 Nov 2021 12:39:17 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to add more
> diagnostics when a failure occurs in the jlink tool during the jpackage tests?
>
> As noted in https://bugs.openjdk.java.net/browse/JDK-8277507, so far 3
> failures
On Tue, 23 Nov 2021 04:57:57 GMT, Alexander Matveev
wrote:
>> Can I please get a review of this change which proposes to add more
>> diagnostics when a failure occurs in the jlink tool during the jpackage
>> tests?
>>
>> As noted in https://bugs.openjdk.java.net/browse/JDK-8277507, so far 3
45 matches
Mail list logo
