RFR: 8269556: sun/tools/jhsdb/JShellHeapDumpTest.java fails with RuntimeException 'JShellToolProvider' missing from stdout/stderr

2021-12-09 Thread Chris Plummer
The test searches for "JShellToolProvider" in the main thread's stack trace, which is pulled from an SA heap dump. Typically the main thread is blocked in Object.wait(), so SA can determine its stack trace. However, the wait has a 100ms timeout, so the thread does periodically wake up and does a

Re: [jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC

2021-12-09 Thread Jonathan Gibbons
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote: > Please review this semi-automatic update for the nroff man pages for JDK 18. > The changes update the version number, copyright year, and incorporate the > changes from the latest upstream files. hmmm, I thought we had taken care of

Re: [jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC

2021-12-09 Thread David Holmes
On Fri, 10 Dec 2021 02:48:43 GMT, Jonathan Gibbons wrote: >> Please review this semi-automatic update for the nroff man pages for JDK 18. >> The changes update the version number, copyright year, and incorporate the >> changes from the latest upstream files. > > We will also want to regenerate

Request for backport the OpenJDK fix in XSLTC.java to JDK11 & JDK17

2021-12-09 Thread Cheng Jin
Hi there, As for the bug with the class name in XSLTC.java I previously raised at https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-November/083135.html , I notice it has been resolved at https://bugs.openjdk.java.net/browse/JDK-8276657 as follows: https://github.com/openjdk/jdk/blob/

Re: RFR: 8273101: Eliminate the usage of threadgroup sandboxing in the java.util.logging [v2]

2021-12-09 Thread Sergey Bylokhov
> At the time Java supported applets and webstart, a special mechanism for > launching various applications in one JVM was used to reduce memory usage and > each application was isolated from each other. > > This isolation was implemented via ThreadGroups where each application > created its ow

Re: [jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC

2021-12-09 Thread Iris Clark
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote: > Please review this semi-automatic update for the nroff man pages for JDK 18. > The changes update the version number, copyright year, and incorporate the > changes from the latest upstream files. Marked as reviewed by iris (Reviewer)

[jdk18] Integrated: JDK-8273179: Update nroff pages in JDK 18 before RC

2021-12-09 Thread Jonathan Gibbons
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote: > Please review this semi-automatic update for the nroff man pages for JDK 18. > The changes update the version number, copyright year, and incorporate the > changes from the latest upstream files. This pull request has now been integr

Re: [jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC

2021-12-09 Thread Jonathan Gibbons
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote: > Please review this semi-automatic update for the nroff man pages for JDK 18. > The changes update the version number, copyright year, and incorporate the > changes from the latest upstream files. Hi David, The copyright year will na

Re: [jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC

2021-12-09 Thread David Holmes
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote: > Please review this semi-automatic update for the nroff man pages for JDK 18. > The changes update the version number, copyright year, and incorporate the > changes from the latest upstream files. Hi Jon, This all looks good - I'm fa

[jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC

2021-12-09 Thread Jonathan Gibbons
Please review this semi-automatic update for the nroff man pages for JDK 18. The changes update the version number, copyright year, and incorporate the changes from the latest upstream files. - Commit messages: - JDK-8273179: Update nroff pages in JDK 18 before RC Changes: https:

Re: RFR: 8276766: Enable jar and jmod to produce deterministic timestamped content [v21]

2021-12-09 Thread Andrew Leonard
On Thu, 9 Dec 2021 18:14:13 GMT, Lance Andersen wrote: >> Andrew Leonard has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8276766: Enable jar and jmod to produce deterministic timestamped content >> >> Signed-off-by: Andrew Leonard

Re: RFR: 8276766: Enable jar and jmod to produce deterministic timestamped content [v21]

2021-12-09 Thread Lance Andersen
On Thu, 9 Dec 2021 18:07:58 GMT, Andrew Leonard wrote: >> Add a new --source-date (epoch seconds) option to jar and jmod >> to allow specification of time to use for created/updated jar/jmod entries. >> This then allows the ability to make the content deterministic. >> >> Signed-off-by: Andre

Integrated: 8278185: Custom JRE cannot find non-ASCII named module inside

2021-12-09 Thread Toshio Nakamura
On Fri, 3 Dec 2021 07:29:17 GMT, Toshio Nakamura wrote: > Could you review this fix? > > Problem: > Custom JRE generated by jlink cannot find non-ASCII named modules included > inside the JRE. > > Cause and fix: > If module or package name was composed by ASCII then non-ASCII characters, > Im

Re: RFR: 8271079: JavaFileObject#toUri and multi-release jars [v2]

2021-12-09 Thread Alan Bateman
On Thu, 9 Dec 2021 07:58:33 GMT, Christian Stein wrote: >> Prior to this PR, `toUri()` of class `ZipPath` in module `jdk.zipfs` and >> class `PathFileObject` in module `jdk.compiler` were always composed by base >> path names. Even for versioned entries of a multi-release JAR file. >> >> Now,

Re: RFR: 8276766: Enable jar and jmod to produce deterministic timestamped content [v20]

2021-12-09 Thread Andrew Leonard
On Tue, 7 Dec 2021 19:25:05 GMT, Lance Andersen wrote: >> Andrew Leonard has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8276766: Enable jar and jmod to produce deterministic timestamped content >> >> Signed-off-by: Andrew Leonard

Re: RFR: 8276766: Enable jar and jmod to produce deterministic timestamped content [v21]

2021-12-09 Thread Andrew Leonard
> Add a new --source-date (epoch seconds) option to jar and jmod to > allow specification of time to use for created/updated jar/jmod entries. This > then allows the ability to make the content deterministic. > > Signed-off-by: Andrew Leonard Andrew Leonard has updated the pull request increm

Re: RFR: 8276766: Enable jar and jmod to produce deterministic timestamped content [v20]

2021-12-09 Thread Andrew Leonard
On Wed, 8 Dec 2021 16:51:05 GMT, Alan Bateman wrote: >> Andrew Leonard has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8276766: Enable jar and jmod to produce deterministic timestamped content >> >> Signed-off-by: Andrew Leonard >

Re: RFR: 8278185: Custom JRE cannot find non-ASCII named module inside [v4]

2021-12-09 Thread Jim Laskey
On Fri, 3 Dec 2021 12:35:22 GMT, Jim Laskey wrote: >> Toshio Nakamura has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Changed testcase name to JImageNonAsciiNameTest.java > > Change looks reasonable. A regression test should be provided.

Re: RFR: 8278185: Custom JRE cannot find non-ASCII named module inside [v4]

2021-12-09 Thread Naoto Sato
On Fri, 3 Dec 2021 12:35:22 GMT, Jim Laskey wrote: >> Toshio Nakamura has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Changed testcase name to JImageNonAsciiNameTest.java > > Change looks reasonable. A regression test should be provided.

Integrated: JDK-8273146: Start of release updates for JDK 19

2021-12-09 Thread Joe Darcy
On Mon, 22 Nov 2021 03:15:51 GMT, Joe Darcy wrote: > The time to get JDK 19 underway draws nigh, please review this usual set of > start-of-release updates, including CSRs for the javac and javax.lang.model > updates: > > JDK-8277512: Add SourceVersion.RELEASE_19 > https://bugs.openjdk.java.ne