Re: Seeking inputs on 8224794: ZipFile/JarFile should open zip/JAR file with FILE_SHARE_DELETE sharing mode on Windows

2021-12-17 Thread Jaikiran Pai
Would there be interest in moving this forward? Enabling that FILE_SHARE_DELETE option has opened up some questions that I noted in my previous mail below. So in order to move forward I would need some inputs. If we don't want to do this at this time, I'll close the draft PR that's currently

Re: RFR: 8278518: String(byte[], int, int, Charset) constructor and String.translateEscapes() miss bounds check elimination

2021-12-17 Thread Dean Long
On Mon, 13 Dec 2021 09:39:55 GMT, Сергей Цыпанов wrote: > Originally this was spotted by by Amir Hadadi in > https://stackoverflow.com/questions/70272651/missing-bounds-checking-elimination-in-string-constructor > > It looks like in the following code in `String(byte[], int, int, Charset)` >

Integrated: 8261404: Class.getReflectionFactory() is not thread-safe

2021-12-17 Thread liach
On Thu, 16 Dec 2021 21:04:58 GMT, liach wrote: > Simply changes this to only read the static field once to prevent `null` on > second read. This pull request has now been integrated. Changeset: 905b7639 Author:liach Committer: Mandy Chung URL:

[jdk18] Integrated: 8278970: [macos] SigningPackageTest is failed with runtime exception

2021-12-17 Thread Alexander Matveev
On Fri, 17 Dec 2021 03:28:12 GMT, Alexander Matveev wrote: > This is regression from JDK-8263155. MacHelper.java is now calling test > verification callback with all content in DMG root. SigningPackageTest > expects only path with app name in it and thus it fails when trying to verify > app

Re: RFR: 8261404: Class.getReflectionFactory() is not thread-safe [v2]

2021-12-17 Thread liach
On Thu, 16 Dec 2021 21:38:30 GMT, liach wrote: >> Simply changes this to only read the static field once to prevent `null` on >> second read. > > liach has updated the pull request incrementally with two additional commits > since the last revision: > > - sorry, reintroduced the bug in last

Re: RFR: 8278831: Use table lookup for the last two bytes in Integer.getChars

2021-12-17 Thread Roger Riggs
On Wed, 15 Dec 2021 23:04:37 GMT, Claes Redestad wrote: > During TemplatedStrings work Jim has noticed that we could probably profit > from reusing the lookup tables also for the 1 or 2 leftmost bytes: > > // We know there are at most two digits left at this point. >

Re: RFR: 8275535: Retrying a failed authentication on multiple LDAP servers can lead to users blocked

2021-12-17 Thread Michael Osipov
On Thu, 16 Dec 2021 01:23:11 GMT, Martin Balao wrote: >> Hi @AlekseiEfimov >> >> Can you please review the CSR [1]? >> >> Thanks, >> Martin.- >> >> -- >> [1] - https://bugs.openjdk.java.net/browse/JDK-8276959 > >> @martinuy This pull request has been inactive for more than 4 weeks and will

Re: RFR: 8275535: Retrying a failed authentication on multiple LDAP servers can lead to users blocked

2021-12-17 Thread Michael Osipov
On Thu, 16 Dec 2021 01:23:11 GMT, Martin Balao wrote: >> Hi @AlekseiEfimov >> >> Can you please review the CSR [1]? >> >> Thanks, >> Martin.- >> >> -- >> [1] - https://bugs.openjdk.java.net/browse/JDK-8276959 > >> @martinuy This pull request has been inactive for more than 4 weeks and will

Re: [jdk18] RFR: 8278907: JPackage test - SigningPackageTest is failed with runtime exception

2021-12-17 Thread Alexey Semenyuk
On Fri, 17 Dec 2021 03:28:12 GMT, Alexander Matveev wrote: > This is regression from JDK-8263155. MacHelper.java is now calling test > verification callback with all content in DMG root. SigningPackageTest > expects only path with app name in it and thus it fails when trying to verify > app

Re: RFR: 8265891: (ch) InputStream returned by Channels.newInputStream should override transferTo [v13]

2021-12-17 Thread Markus KARG
On Thu, 12 Aug 2021 01:04:29 GMT, Brian Burkhalter wrote: >> Markus KARG has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Draft: Eliminated duplicate code using lambda expressions >> - Draft: Use blocking mode also for target channel

Re: RFR: 8261404: Class.getReflectionFactory() is not thread-safe [v2]

2021-12-17 Thread Roger Riggs
On Thu, 16 Dec 2021 21:38:30 GMT, liach wrote: >> Simply changes this to only read the static field once to prevent `null` on >> second read. > > liach has updated the pull request incrementally with two additional commits > since the last revision: > > - sorry, reintroduced the bug in last

Re: RFR: 8277868: Use Comparable.compare() instead of surrogate code [v6]

2021-12-17 Thread Roger Riggs
On Thu, 9 Dec 2021 13:03:39 GMT, Сергей Цыпанов wrote: >> Instead of something like >> >> long x; >> long y; >> return (x < y) ? -1 : ((x == y) ? 0 : 1); >> >> we can use `return Long.compare(x, y);` >> >> All replacements are done with IDE. > > Сергей Цыпанов has updated the pull request

Re: [jdk18] RFR: 8278907: JPackage test - SigningPackageTest is failed with runtime exception

2021-12-17 Thread Andy Herrick
On Fri, 17 Dec 2021 03:28:12 GMT, Alexander Matveev wrote: > This is regression from JDK-8263155. MacHelper.java is now calling test > verification callback with all content in DMG root. SigningPackageTest > expects only path with app name in it and thus it fails when trying to verify > app

[jdk18] Integrated: 8278587: StringTokenizer(String, String, boolean) documentation bug

2021-12-17 Thread Naoto Sato
On Fri, 17 Dec 2021 13:41:17 GMT, Naoto Sato wrote: > 8278587: StringTokenizer(String, String, boolean) documentation bug This pull request has now been integrated. Changeset: 9cd70906 Author:Naoto Sato URL:

[jdk18] Integrated: 8278587: StringTokenizer(String, String, boolean) documentation bug

2021-12-17 Thread Naoto Sato
8278587: StringTokenizer(String, String, boolean) documentation bug - Commit messages: - Backport 8f5fdd864b6f1cf4a2d9d961d8d4118960f0751e Changes: https://git.openjdk.java.net/jdk18/pull/43/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18=43=00 Issue: