Re: RFR: 8261407: ReflectionFactory.checkInitted() is not thread-safe [v2]

2021-12-19 Thread Alan Bateman
On Sun, 19 Dec 2021 20:34:22 GMT, liach wrote: >> src/java.base/share/classes/jdk/internal/reflect/ReflectionFactory.java line >> 65: >> >>> 63: >>> 64: // volatile ensures static fields set before are published >>> 65: private static volatile boolean initted = false; >> >> I assume y

RFR: JDK-8276302: Locale.filterTags methods ignore actual weight when matching "*" (as if it is 1)

2021-12-19 Thread Daniel Le
Locale.filterTags methods ignore actual weight when matching "*" (as if it is 1) because LocaleMatcher.{filterBasic,filterExtended} do so. Fix the bug and add regression test cases for it as well as existing behavior. - Commit messages: - Locale.filterTags must respect the weight of

Re: RFR: 8261407: ReflectionFactory.checkInitted() is not thread-safe [v2]

2021-12-19 Thread liach
On Sun, 19 Dec 2021 08:45:02 GMT, Alan Bateman wrote: >> liach has updated the pull request incrementally with one additional commit >> since the last revision: >> >> Just use volatile directly to ensure read order > > src/java.base/share/classes/jdk/internal/reflect/ReflectionFactory.java li

Re: RFR: 8261407: ReflectionFactory.checkInitted() is not thread-safe [v2]

2021-12-19 Thread David Holmes
On Sun, 19 Dec 2021 06:51:45 GMT, liach wrote: >> Upon review of [8261407](https://bugs.openjdk.java.net/browse/JDK-8261407), >> by design, duplicate initialization of ReflectionFactory should be safe as >> it performs side-effect-free property read actions, and the suggesting of >> making the

Re: RFR: 8261407: ReflectionFactory.checkInitted() is not thread-safe [v2]

2021-12-19 Thread David Holmes
On Sun, 19 Dec 2021 07:05:31 GMT, liach wrote: >> src/java.base/share/classes/jdk/internal/reflect/ReflectionFactory.java line >> 695: >> >>> 693: >>> 694: // ensure previous fields are visible before initted is >>> 695: Unsafe.getUnsafe().storeStoreFence(); >> >> Ensuring ord

Re: RFR: 8261407: ReflectionFactory.checkInitted() is not thread-safe [v2]

2021-12-19 Thread Alan Bateman
On Sun, 19 Dec 2021 06:51:45 GMT, liach wrote: >> Upon review of [8261407](https://bugs.openjdk.java.net/browse/JDK-8261407), >> by design, duplicate initialization of ReflectionFactory should be safe as >> it performs side-effect-free property read actions, and the suggesting of >> making the