[Ping] RFR: 8275731: CDS archived enums objects are recreated at runtime

2022-01-04 Thread Ioi Lam
Still looking for reviewers Thanks - Ioi On 12/1/21 1:02 PM, Ioi Lam wrote: **Background:** In the Java Language, Enums can be tested for equality, so the constants in an Enum type must be unique. Javac compiles an enum declaration like this: public enum Day { SUNDAY, MONDAY ... } t

Re: [jdk18] RFR: 8279370: jdk.jpackage/share/native/applauncher/JvmLauncher.cpp fails to build with GCC 6.3.0

2022-01-04 Thread Aleksey Shipilev
On Mon, 3 Jan 2022 21:18:12 GMT, Victor Dyakov wrote: > it requires @alexeysemenyukoracle review (owner of JDK-8274856 changeset) Well, this looks trivial to me. Should we really wait @alexeysemenyukoracle, who, I assume, might be on NY holiday break? - PR: https://git.openjdk.jav

Re: RFR: 8273322: Enhance macro logic optimization for masked logic operations. [v3]

2022-01-04 Thread Sandhya Viswanathan
On Tue, 4 Jan 2022 15:11:47 GMT, Jatin Bhateja wrote: >> Patch extends existing macrologic inferencing algorithm to handle masked >> logic operations. >> >> Existing algorithm: >> >> 1. Identify logic cone roots. >> 2. Packs parent and logic child nodes into a MacroLogic node in bottom up >>

Re: RFR: 8279453: Disable tools/jar/ReproducibleJar.java on 32-bit platforms

2022-01-04 Thread Brian Burkhalter
On Tue, 4 Jan 2022 16:46:09 GMT, Aleksey Shipilev wrote: > The real problem is Y2038 > ([JDK-8279444](https://bugs.openjdk.java.net/browse/JDK-8279444)), which does > not look solvable at this time. So for test cleanliness, we might just > disable this test on 32-bit platforms. > > Additional

Re: RFR: 8273322: Enhance macro logic optimization for masked logic operations. [v3]

2022-01-04 Thread Vladimir Kozlov
On Tue, 4 Jan 2022 15:11:47 GMT, Jatin Bhateja wrote: >> Patch extends existing macrologic inferencing algorithm to handle masked >> logic operations. >> >> Existing algorithm: >> >> 1. Identify logic cone roots. >> 2. Packs parent and logic child nodes into a MacroLogic node in bottom up >>

Re: RFR: 8273322: Enhance macro logic optimization for masked logic operations. [v3]

2022-01-04 Thread Vladimir Kozlov
On Tue, 4 Jan 2022 15:11:47 GMT, Jatin Bhateja wrote: >> Patch extends existing macrologic inferencing algorithm to handle masked >> logic operations. >> >> Existing algorithm: >> >> 1. Identify logic cone roots. >> 2. Packs parent and logic child nodes into a MacroLogic node in bottom up >>

Re: RFR: 8273322: Enhance macro logic optimization for masked logic operations. [v2]

2022-01-04 Thread Vladimir Kozlov
On Tue, 4 Jan 2022 15:01:22 GMT, Jatin Bhateja wrote: >> src/hotspot/cpu/x86/x86.ad line 1900: >> >>> 1898: >>> 1899: case Op_MacroLogicV: >>> 1900: if(bt != T_INT && bt != T_LONG) { >> >> Missing `VM_Version::supports_evex()` check? > > Hi @vnkozlov, we already have that check (UseA

Re: RFR: 8279453: Disable tools/jar/ReproducibleJar.java on 32-bit platforms

2022-01-04 Thread Alan Bateman
On Tue, 4 Jan 2022 16:46:09 GMT, Aleksey Shipilev wrote: > The real problem is Y2038 > ([JDK-8279444](https://bugs.openjdk.java.net/browse/JDK-8279444)), which does > not look solvable at this time. So for test cleanliness, we might just > disable this test on 32-bit platforms. > > Additional

RFR: 8279453: Disable tools/jar/ReproducibleJar.java on 32-bit platforms

2022-01-04 Thread Aleksey Shipilev
The real problem is Y2038 ([JDK-8279444](https://bugs.openjdk.java.net/browse/JDK-8279444)), which does not look solvable at this time. So for test cleanliness, we might just disable this test on 32-bit platforms. Additional testing: - [x] Linux x86_64 fastdebug, affected test still passes -

Re: [jdk18] RFR: 8278897: Alignment of heap segments is not enforced correctly [v2]

2022-01-04 Thread Jorn Vernee
On Tue, 4 Jan 2022 11:39:08 GMT, Maurizio Cimadamore wrote: >> This PR fixes an issue with alignment constraints not being enforced >> correctly on on-heap segments dereference/copy operations. Alignment of >> on-heap segments cannot be computed exactly, as alignment of elements in >> arrays

Re: RFR: 8273322: Enhance macro logic optimization for masked logic operations. [v3]

2022-01-04 Thread Jatin Bhateja
> Patch extends existing macrologic inferencing algorithm to handle masked > logic operations. > > Existing algorithm: > > 1. Identify logic cone roots. > 2. Packs parent and logic child nodes into a MacroLogic node in bottom up > traversal if input constraint are met. > i.e. maximum number of

Re: RFR: 8273322: Enhance macro logic optimization for masked logic operations. [v2]

2022-01-04 Thread Jatin Bhateja
On Tue, 4 Jan 2022 02:21:35 GMT, Vladimir Kozlov wrote: >> Jatin Bhateja has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additional >> commi

Re: [jdk18] RFR: 8278897: Alignment of heap segments is not enforced correctly [v2]

2022-01-04 Thread Maurizio Cimadamore
> This PR fixes an issue with alignment constraints not being enforced > correctly on on-heap segments dereference/copy operations. Alignment of > on-heap segments cannot be computed exactly, as alignment of elements in > arrays is, ultimately a VM implementation detail. Because of this, alignme