Re: RFR: 8278065: Refactor subclassAudits to use ClassValue [v3]

2022-01-11 Thread Peter Levart
On Fri, 10 Dec 2021 21:07:37 GMT, Roman Kennke wrote: >> As a follow-up to #6375, this change refactors >> java.io.ObjectInputStream.Caches#subclassAudits and >> java.io.ObjectOutputStream.Caches#subclassAudits to use ClassValue instead >> of SoftReference, similar to what we did in #6375 for

RFR: 8278892: java.naming module description is missing @uses tags to document the services that it uses

2022-01-11 Thread Masanori Yano
I have fixed the javadoc comments as the definition. Could you review this fix? - Commit messages: - 8278892: java.naming module description is missing @uses tags to document the services that it uses Changes: https://git.openjdk.java.net/jdk/pull/7041/files Webrev:

Integrated: 8276694: Pattern trailing unescaped backslash causes internal error

2022-01-11 Thread Masanori Yano
On Mon, 20 Dec 2021 09:57:14 GMT, Masanori Yano wrote: > Could you please review the 8276694 bug fixes? > > A message specific for this exception should be printed instead of an > internal error. This fix adds a new check to output an appropriate exception > message when the regular

Re: RFR: 8276694: Pattern trailing unescaped backslash causes internal error

2022-01-11 Thread Ian Graves
On Mon, 20 Dec 2021 09:57:14 GMT, Masanori Yano wrote: > Could you please review the 8276694 bug fixes? > > A message specific for this exception should be printed instead of an > internal error. This fix adds a new check to output an appropriate exception > message when the regular

Re: jdk11u build failure on Windows

2022-01-11 Thread Daniel Fuchs
Hi Vyom, That's probably a question to ask on the jdk-updates-dev list, which I put in cc: best regards, -- daniel On 11/01/2022 06:50, Vyom Tiwari wrote: Hi, I am facing the build issue with  OpenJDK11(jdk11u). I am trying to build jdk11u on Windows and I am  getting the below error.

Re: RFR: JDK-8277795: ldap connection timeout not honoured under contention [v3]

2022-01-11 Thread Daniel Fuchs
On Tue, 14 Dec 2021 15:26:54 GMT, Rob McKenna wrote: >> This fix attemps to resolve an issue where threads can stack up on each >> other while waiting to get a connection from the ldap pool to an unreachable >> server. It does this by having each thread start a countdown prior to >> holding

Re: jdk11u build failure on Windows

2022-01-11 Thread Hohensee, Paul
Directing to jdk-updates-dev... Paul -Original Message- From: core-libs-dev on behalf of Vyom Tiwari Date: Monday, January 10, 2022 at 10:51 PM To: net-dev , core-libs-dev Cc: "kusriniva...@vmware.com" Subject: jdk11u build failure on Windows Hi, I am facing the build issue with

Re: RFR: JDK-8277795: ldap connection timeout not honoured under contention [v3]

2022-01-11 Thread Daniel Fuchs
On Tue, 14 Dec 2021 15:26:54 GMT, Rob McKenna wrote: >> This fix attemps to resolve an issue where threads can stack up on each >> other while waiting to get a connection from the ldap pool to an unreachable >> server. It does this by having each thread start a countdown prior to >> holding

Integrated: 8279833: Loop optimization issue in String.encodeUTF8_UTF16

2022-01-11 Thread Claes Redestad
On Tue, 11 Jan 2022 12:30:44 GMT, Claes Redestad wrote: > In `String.encodeUTF8_UTF16`, making the `char c` local to each loop helps > the performance of the method by helping C2 optimize each individual loop > better. > > Results on the updated micros: > 19-b04: > > Benchmark

Re: RFR: 8279833: Loop optimization issue in String.encodeUTF8_UTF16 [v4]

2022-01-11 Thread Claes Redestad
On Tue, 11 Jan 2022 12:58:51 GMT, Aleksey Shipilev wrote: >> Claes Redestad has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Happy new year! > > Looks fine, consider touchups in benchmark code. Thanks for reviewing, @shipilev and

Re: RFR: 8279833: Loop optimization issue in String.encodeUTF8_UTF16 [v4]

2022-01-11 Thread Claes Redestad
> In `String.encodeUTF8_UTF16`, making the `char c` local to each loop helps > the performance of the method by helping C2 optimize each individual loop > better. > > Results on the updated micros: > 19-b04: > > Benchmark (charsetName) Mode Cnt Score > Error

Re: RFR: 8279833: Loop optimization issue in String.encodeUTF8_UTF16 [v4]

2022-01-11 Thread Alan Bateman
On Tue, 11 Jan 2022 13:50:48 GMT, Claes Redestad wrote: >> In `String.encodeUTF8_UTF16`, making the `char c` local to each loop helps >> the performance of the method by helping C2 optimize each individual loop >> better. >> >> Results on the updated micros: >> 19-b04: >> >> Benchmark

Re: RFR: 8279833: Loop optimization issue in String.encodeUTF8_UTF16 [v3]

2022-01-11 Thread Alan Bateman
On Tue, 11 Jan 2022 13:09:07 GMT, Claes Redestad wrote: >> In `String.encodeUTF8_UTF16`, making the `char c` local to each loop helps >> the performance of the method by helping C2 optimize each individual loop >> better. >> >> Results on the updated micros: >> 19-b04: >> >> Benchmark

Re: RFR: 8279833: Loop optimization issue in String.encodeUTF8_UTF16 [v3]

2022-01-11 Thread Claes Redestad
> In `String.encodeUTF8_UTF16`, making the `char c` local to each loop helps > the performance of the method by helping C2 optimize each individual loop > better. > > Results on the updated micros: > 19-b04: > > Benchmark (charsetName) Mode Cnt Score > Error

Re: RFR: 8279833: Loop optimization issue in String.encodeUTF8_UTF16 [v2]

2022-01-11 Thread Claes Redestad
On Tue, 11 Jan 2022 12:57:49 GMT, Aleksey Shipilev wrote: >> Claes Redestad has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove unused Blackholes > > test/micro/org/openjdk/bench/java/lang/StringEncode.java line 113: > >> 111: >>

Re: RFR: 8279833: Loop optimization issue in String.encodeUTF8_UTF16 [v2]

2022-01-11 Thread Aleksey Shipilev
On Tue, 11 Jan 2022 13:02:21 GMT, Claes Redestad wrote: >> In `String.encodeUTF8_UTF16`, making the `char c` local to each loop helps >> the performance of the method by helping C2 optimize each individual loop >> better. >> >> Results on the updated micros: >> 19-b04: >> >> Benchmark

Re: RFR: 8279833: Loop optimization issue in String.encodeUTF8_UTF16 [v2]

2022-01-11 Thread Claes Redestad
> In `String.encodeUTF8_UTF16`, making the `char c` local to each loop helps > the performance of the method by helping C2 optimize each individual loop > better. > > Results on the updated micros: > 19-b04: > > Benchmark (charsetName) Mode Cnt Score > Error

RFR: 8279833: Loop optimization issue in String.encodeUTF8_UTF16

2022-01-11 Thread Claes Redestad
In `String.encodeUTF8_UTF16`, making the `char c` local to each loop helps the performance of the method by helping C2 optimize each individual loop better. Results on the updated micros: 19-b04: Benchmark (charsetName) Mode Cnt Score Error Units

Re: RFR: 4511638: Double.toString(double) sometimes produces incorrect results [v5]

2022-01-11 Thread Raffaello Giulietti
On Mon, 15 Nov 2021 19:31:09 GMT, Raffaello Giulietti wrote: >> Hello, >> >> here's a PR for a patch submitted on March 2020 >> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was >> a thing. >> >> The patch has been edited to adhere to OpenJDK code conventions about