On Thu, 11 Nov 2021 14:50:43 GMT, Magnus Ihse Bursie wrote:
> I ran bin/blessed-modifier-order.sh on source owned by Project Panama. This
> scripts verifies that modifiers are in the "blessed" order, and fixes it
> otherwise. I have manually checked the changes made by the script to make
>
On Tue, 14 Dec 2021 15:26:54 GMT, Rob McKenna wrote:
>> This fix attemps to resolve an issue where threads can stack up on each
>> other while waiting to get a connection from the ldap pool to an unreachable
>> server. It does this by having each thread start a countdown prior to
>> holding
On Tue, 14 Dec 2021 15:26:54 GMT, Rob McKenna wrote:
>> This fix attemps to resolve an issue where threads can stack up on each
>> other while waiting to get a connection from the ldap pool to an unreachable
>> server. It does this by having each thread start a countdown prior to
>> holding
If a JAR is signed with multiple digest algorithms and one of the digest
algorithms is disabled, `ManifestEntryVerifier.verify()` was incorrectly
returning null indicating that the jar entry has no signers.
This fixes the issue such that an entry is considered signed if at least one of
the
Hi core-libs-dev,
I am maintaining a module for the popular Jackson JSON library that attempts to
simplify code-generation code without losing performance.
Long ago, it was a huge win to code-generate custom getter / setter / field
accessors rather than use core reflection. Now, the gap is
On Wed, 12 Jan 2022 19:07:00 GMT, Maurizio Cimadamore
wrote:
>> yes, that should be harmless
>
> Actually, no, sorry. If I sharpen the type, then `dup` has to cast, so we go
> back to the original issue.
Ah yes, i see. Maybe it's worth adding a general comment to the class doc of
Thread.java would benefit from a refactoring similar to JDK-8278065 to use
ClassValue instead of the somewhat problematic WeakClassKey mechanism.
Testing:
- [x] tier1
- [x] tier2
- [x] tier3
-
Commit messages:
- 8279917: Refactor subclassAudits in Thread to use ClassValue
On Wed, 5 Jan 2022 22:42:38 GMT, Naoto Sato wrote:
> Please review the changes for upgrading the Unicode support in the JDK, from
> version 13 to version 14. Corresponding CSR has also been drafted.
This pull request has now been integrated.
Changeset: 0a094d7c
Author:Naoto Sato
URL:
On Wed, 12 Jan 2022 19:05:30 GMT, Maurizio Cimadamore
wrote:
>> src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/HeapMemorySegmentImpl.java
>> line 89:
>>
>>> 87: public static class OfByte extends HeapMemorySegmentImpl {
>>> 88:
>>> 89: OfByte(long offset, Object
On Wed, 12 Jan 2022 18:45:11 GMT, Paul Sandoz wrote:
>> When looking at larger benchmarks, I noted a discrepancy between the
>> performance of off-heap segments and on-heap segments. Looking at the
>> assembly for the `MemorySegment::asSlice` method I could see some additional
>> barriers in
On Wed, 5 Jan 2022 22:42:38 GMT, Naoto Sato wrote:
> Please review the changes for upgrading the Unicode support in the JDK, from
> version 13 to version 14. Corresponding CSR has also been drafted.
The CSR is now approved. This comment should be sufficient to wake up the bot.
-
On Wed, 12 Jan 2022 15:48:20 GMT, Maurizio Cimadamore
wrote:
> When looking at larger benchmarks, I noted a discrepancy between the
> performance of off-heap segments and on-heap segments. Looking at the
> assembly for the `MemorySegment::asSlice` method I could see some additional
>
On Wed, 12 Jan 2022 14:22:03 GMT, iaroslavski wrote:
>> Sorting:
>>
>> - adopt radix sort for sequential and parallel sorts on
>> int/long/float/double arrays (almost random and length > 6K)
>> - fix tryMergeRuns() to better handle case when the last run is a single
>> element
>> - minor
On Mon, 3 Jan 2022 08:10:27 GMT, Aleksey Shipilev wrote:
> Seems like a missing include. C++ docs say `offsetof` is from ``,
> adding that include explicitly fixes the build. Seems to only happen with
> older GCCs, but it seems to be a happy accident it works on newer ones,
> probably through
On Wed, 12 Jan 2022 14:27:17 GMT, Roger Riggs wrote:
> I would have appreciated a chance to review the latest changes.
Oh, ok, I'm sorry. I will wait some more next time that I get into a similar
situation. I hope you're ok with the changes?
-
PR:
When looking at larger benchmarks, I noted a discrepancy between the
performance of off-heap segments and on-heap segments. Looking at the assembly
for the `MemorySegment::asSlice` method I could see some additional barriers in
the off-heap case, but could not initially make sense of them. Vlad
On Wed, 12 Jan 2022 11:15:56 GMT, Roman Kennke wrote:
>> As a follow-up to #6375, this change refactors
>> java.io.ObjectInputStream.Caches#subclassAudits and
>> java.io.ObjectOutputStream.Caches#subclassAudits to use ClassValue instead
>> of SoftReference, similar to what we did in #6375 for
> Sorting:
>
> - adopt radix sort for sequential and parallel sorts on int/long/float/double
> arrays (almost random and length > 6K)
> - fix tryMergeRuns() to better handle case when the last run is a single
> element
> - minor javadoc and comment changes
>
> Testing:
> - add new data inputs
Can I please get a review for this change which addresses
https://bugs.openjdk.java.net/browse/JDK-8279921?
The change here builds upon the debugging enhancement that was done in
https://github.com/openjdk/jdk/pull/6696 to try and narrow down the problem
behind intermittent failures on macos
On Wed, 1 Dec 2021 14:45:23 GMT, Roman Kennke wrote:
> As a follow-up to #6375, this change refactors
> java.io.ObjectInputStream.Caches#subclassAudits and
> java.io.ObjectOutputStream.Caches#subclassAudits to use ClassValue instead of
> SoftReference, similar to what we did in #6375 for
>
On Mon, 27 Dec 2021 13:43:12 GMT, Markus KARG wrote:
>> Implementation of JDK-8279283
>
> Markus KARG has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fixed missing BufferedInputStream
On Tue, 14 Dec 2021 15:26:54 GMT, Rob McKenna wrote:
>> This fix attemps to resolve an issue where threads can stack up on each
>> other while waiting to get a connection from the ldap pool to an unreachable
>> server. It does this by having each thread start a countdown prior to
>> holding
On Tue, 11 Jan 2022 13:53:58 GMT, Claes Redestad wrote:
>> In `String.encodeUTF8_UTF16`, making the `char c` local to each loop helps
>> the performance of the method by helping C2 optimize each individual loop
>> better.
>>
>> Results on the updated micros:
>> 19-b04:
>>
>> Benchmark
On Tue, 16 Nov 2021 20:53:26 GMT, kabutz wrote:
>> This is a draft proposal for how we could improve stream performance for the
>> case where the streams are empty. Empty collections are common-place. If we
>> iterate over them with an Iterator, we would have to create one small
>> Iterator
On Mon, 13 Dec 2021 09:39:55 GMT, Сергей Цыпанов wrote:
> Originally this was spotted by by Amir Hadadi in
> https://stackoverflow.com/questions/70272651/missing-bounds-checking-elimination-in-string-constructor
>
> It looks like in the following code in `String(byte[], int, int, Charset)`
>
On Mon, 13 Dec 2021 09:39:55 GMT, Сергей Цыпанов wrote:
> Originally this was spotted by by Amir Hadadi in
> https://stackoverflow.com/questions/70272651/missing-bounds-checking-elimination-in-string-constructor
>
> It looks like in the following code in `String(byte[], int, int, Charset)`
>
On Wed, 12 Jan 2022 06:45:02 GMT, Peter Levart wrote:
> I think this looks good. Reviewed. Only a minor nit if you think it would be
> better, but not necessary if you don't. The following combo:
>
> ```
> Boolean result = Caches.subclassAudits.get(cl);
> assert result != null;
> As a follow-up to #6375, this change refactors
> java.io.ObjectInputStream.Caches#subclassAudits and
> java.io.ObjectOutputStream.Caches#subclassAudits to use ClassValue instead of
> SoftReference, similar to what we did in #6375 for
> java.io.ObjectStreamClass.Caches#localDescs. Then we can
On Thu, 9 Dec 2021 11:50:50 GMT, Сергей Цыпанов wrote:
> `Executable.getParameterTypes()` creates a copy of underlying array which is
> redundant in trusted code when we are sure the action is read-only.
This pull request has now been integrated.
Changeset: ece98d85
Author:Sergey Tsypanov
On Mon, 3 Jan 2022 08:10:27 GMT, Aleksey Shipilev wrote:
> Seems like a missing include. C++ docs say `offsetof` is from ``,
> adding that include explicitly fixes the build. Seems to only happen with
> older GCCs, but it seems to be a happy accident it works on newer ones,
> probably through
On Mon, 29 Nov 2021 21:16:32 GMT, iaroslavski wrote:
>> Sorting:
>>
>> - adopt radix sort for sequential and parallel sorts on
>> int/long/float/double arrays (almost random and length > 6K)
>> - fix tryMergeRuns() to better handle case when the last run is a single
>> element
>> - minor
31 matches
Mail list logo
