On Fri, 25 Feb 2022 06:22:42 GMT, Jatin Bhateja wrote:
>> Summary of changes:
>> - Intrinsify Math.round(float) and Math.round(double) APIs.
>> - Extend auto-vectorizer to infer vector operations on encountering scalar
>> IR nodes for above intrinsics.
>> - Test creation using new IR testing
On Sat, 26 Feb 2022 03:02:51 GMT, Sandhya Viswanathan
wrote:
>> src/hotspot/cpu/x86/x86.ad line 7263:
>>
>>> 7261: __ vector_round_float_avx($dst$$XMMRegister, $src$$XMMRegister,
>>> $xtmp1$$XMMRegister,
>>> 7262: $xtmp2$$XMMRegister,
>>>
On Sat, 26 Feb 2022 03:37:32 GMT, Quan Anh Mai wrote:
>> Clarification, the number in my comments above is (2^w - 1). This is from
>> Intel SDM
>> (https://www.intel.com/content/www/us/en/developer/articles/technical/intel-sdm.html).
>> Also you will need to take care when the valid
On Fri, 25 Feb 2022 04:44:45 GMT, Naoto Sato wrote:
>> That's a very good point. I've updated the PR to now explicitly use a
>> mutable `Set` instead of using `Collectors.toSet()`
>
> This is ok, although `Collectors.toCollection(HashSet::new)` is a bit concise.
Hello Naoto, I've updated the
On Fri, 25 Feb 2022 08:44:42 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test only change which fixes the issue
>> noted in https://bugs.openjdk.java.net/browse/JDK-8282023?
>>
>> As noted in that JBS issue these tests fail when the default locale under
>> which those tests
On Sat, 26 Feb 2022 01:06:21 GMT, Sandhya Viswanathan
wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8279508: Adding descriptive comments.
>
> src/hotspot/cpu/x86/x86.ad line 7263:
>
>> 7261: __
On Fri, 25 Feb 2022 23:27:28 GMT, Yasser Bazzi wrote:
> I prefered to keep the interface explicit to the reader
but this object's goal is to serve as a random than a randomgenerator
-
PR: https://git.openjdk.java.net/jdk/pull/7001
On Fri, 25 Feb 2022 06:22:42 GMT, Jatin Bhateja wrote:
>> Summary of changes:
>> - Intrinsify Math.round(float) and Math.round(double) APIs.
>> - Extend auto-vectorizer to infer vector operations on encountering scalar
>> IR nodes for above intrinsics.
>> - Test creation using new IR testing
On Fri, 25 Feb 2022 19:02:55 GMT, Naoto Sato wrote:
> Refactoring `java.time.ZoneId` class to be a sealed class. A CSR has also
> been drafted.
Marked as reviewed by scolebourne (Author).
-
PR: https://git.openjdk.java.net/jdk/pull/7625
On Fri, 25 Feb 2022 23:05:48 GMT, Marcono1234 wrote:
>> Yasser Bazzi has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use var instead of ArrayList raw
>>
>> Co-authored-by: liach <7806504+li...@users.noreply.github.com>
>
>
> Hi, could i get a review on this implementation proposed by Stuart Marks, i
> decided to use the
> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
> interface to create the default method `asRandom()` that wraps around the
> newer algorithms
On Fri, 25 Feb 2022 22:56:36 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interface to create the default
On Sun, 20 Feb 2022 03:15:22 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interface to create the default
On Tue, 22 Feb 2022 23:19:14 GMT, Marcono1234 wrote:
>> Yasser Bazzi has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove missed whitespace
>
> src/java.base/share/classes/java/util/Random.java line 298:
>
>> 296: */
>> 297:
> Hi, could i get a review on this implementation proposed by Stuart Marks, i
> decided to use the
> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
> interface to create the default method `asRandom()` that wraps around the
> newer algorithms
On Fri, 25 Feb 2022 01:13:41 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interface to create the default
On Fri, 25 Feb 2022 01:13:41 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interface to create the default
On Wed, 12 Jan 2022 14:22:03 GMT, iaroslavski wrote:
>> Sorting:
>>
>> - adopt radix sort for sequential and parallel sorts on
>> int/long/float/double arrays (almost random and length > 6K)
>> - fix tryMergeRuns() to better handle case when the last run is a single
>> element
>> - minor
On Wed, 9 Feb 2022 07:37:42 GMT, Alexander Matveev wrote:
> Added ability to override description for additional launchers via
> "description" property.
This pull request has now been integrated.
Changeset: fb8bf818
Author:Alexander Matveev
URL:
On Thu, 24 Feb 2022 14:47:50 GMT, Jim Laskey wrote:
> Class: ./java.base/share/classes/jdk/internal/util/random/RandomSupport.java
> Method: public static long[] convertSeedBytesToLongs(byte[] seed, int n, int
> z)
>
> The method attempts to create an array of longs by consuming the input
On Fri, 25 Feb 2022 19:02:55 GMT, Naoto Sato wrote:
> Refactoring `java.time.ZoneId` class to be a sealed class. A CSR has also
> been drafted.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7625
On Fri, 25 Feb 2022 19:02:55 GMT, Naoto Sato wrote:
> Refactoring `java.time.ZoneId` class to be a sealed class. A CSR has also
> been drafted.
Thanks for doing this. Looks good.
-
Marked as reviewed by mchung (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/7625
On Fri, 25 Feb 2022 19:02:55 GMT, Naoto Sato wrote:
> Refactoring `java.time.ZoneId` class to be a sealed class. A CSR has also
> been drafted.
Marked as reviewed by bpb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7625
On Fri, 25 Feb 2022 17:45:39 GMT, Ichiroh Takiguchi
wrote:
>> Run jtreg:jdk/java/lang/ProcessBuilder/Basic.java on AIX.
>> The test was failed by:
>> Incorrect handling of envstrings containing NULs
>>
>> According to my investigation, this issue was happened after following
>> change was
On Fri, 25 Feb 2022 19:02:55 GMT, Naoto Sato wrote:
> Refactoring `java.time.ZoneId` class to be a sealed class. A CSR has also
> been drafted.
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7625
On Fri, 25 Feb 2022 19:02:55 GMT, Naoto Sato wrote:
> Refactoring `java.time.ZoneId` class to be a sealed class. A CSR has also
> been drafted.
Associated CSR also reviewed.
-
Marked as reviewed by iris (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/7625
Refactoring `java.time.ZoneId` class to be a sealed class. A CSR has also been
drafted.
-
Commit messages:
- 8282131: java.time.ZoneId should be a sealed abstract class
Changes: https://git.openjdk.java.net/jdk/pull/7625/files
Webrev:
On Fri, 25 Feb 2022 15:03:19 GMT, Roger Riggs wrote:
>> Ichiroh Takiguchi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add null check
>
> My preference is to pass the unmodified LIBPATH in the environment in each of
> the three
> Run jtreg:jdk/java/lang/ProcessBuilder/Basic.java on AIX.
> The test was failed by:
> Incorrect handling of envstrings containing NULs
>
> According to my investigation, this issue was happened after following change
> was applied.
> JDK-8272600: (test) Use native "sleep" in Basic.java
>
>
On Fri, 25 Feb 2022 11:08:49 GMT, Claes Redestad wrote:
>> Splitting out these micro changes from #7231
>>
>> - Clean up and simplify setup and code
>> - Add variants with different inputs with varying lengths and encoding
>> weights, but also relevant mixes of each so that we both cover
On Wed, 23 Feb 2022 18:49:22 GMT, Ichiroh Takiguchi
wrote:
>> Run jtreg:jdk/java/lang/ProcessBuilder/Basic.java on AIX.
>> The test was failed by:
>> Incorrect handling of envstrings containing NULs
>>
>> According to my investigation, this issue was happened after following
>> change was
IMHO this is not hard to fix (we already have multiple proposals) and we'd
should have this test on AIX too.
Cheers, Thomas
On Fri, Feb 25, 2022 at 6:23 PM Joe Darcy wrote:
> How about excluding the test from running on AIX?
>
> -Joe
>
> On 2/25/2022 7:07 AM, Roger Riggs wrote:
> > On Wed, 23
How about excluding the test from running on AIX?
-Joe
On 2/25/2022 7:07 AM, Roger Riggs wrote:
On Wed, 23 Feb 2022 18:49:22 GMT, Ichiroh Takiguchi
wrote:
Run jtreg:jdk/java/lang/ProcessBuilder/Basic.java on AIX.
The test was failed by:
Incorrect handling of envstrings containing NULs
On Fri, 18 Feb 2022 17:21:48 GMT, Olga Mikhaltsova
wrote:
>> This fix made equal processing of strings such as ""C:\\Program
>> Files\\Git\\"" before and after JDK-8250568.
>>
>> For example, it's needed to execute the following command on Windows:
>> `C:\Windows\SysWOW64\WScript.exe
Hi Raffaello,
Runtime.exec and ProcessBuilder have been a challenge from the
beginning, on one hand
to have a reasonably cross-platform way to invoke processes and on the
other to accommodate
the platform differences, mostly on Windows due to the various command
line parsing decoding of
On Fri, 25 Feb 2022 01:27:52 GMT, Alexander Matveev
wrote:
>> Added ability to override description for additional launchers via
>> "description" property.
>
> Alexander Matveev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8279995:
On Wed, 23 Feb 2022 18:49:22 GMT, Ichiroh Takiguchi
wrote:
>> Run jtreg:jdk/java/lang/ProcessBuilder/Basic.java on AIX.
>> The test was failed by:
>> Incorrect handling of envstrings containing NULs
>>
>> According to my investigation, this issue was happened after following
>> change was
On Wed, 19 Jan 2022 05:44:10 GMT, Ioi Lam wrote:
>> src/hotspot/share/cds/heapShared.cpp line 433:
>>
>>> 431: oop mirror = k->java_mirror();
>>> 432: int i = 0;
>>> 433: for (JavaFieldStream fs(k); !fs.done(); fs.next()) {
>>
>> This seems like it should also use
On Wed, 23 Feb 2022 04:15:28 GMT, Ioi Lam wrote:
>> **Background:**
>>
>> In the Java Language, Enums can be tested for equality, so the constants in
>> an Enum type must be unique. Javac compiles an enum declaration like this:
>>
>>
>> public enum Day { SUNDAY, MONDAY ... }
>>
>>
>> to
On Fri, 25 Feb 2022 09:41:09 GMT, Andrew Haley wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Brent review
>
> test/micro/org/openjdk/bench/java/lang/StringDecode.java line 72:
>
>> 70: public void setup()
On Fri, 25 Feb 2022 10:19:17 GMT, Claes Redestad wrote:
>> test/micro/org/openjdk/bench/java/lang/StringDecode.java line 72:
>>
>>> 70: public void setup() {
>>> 71: charset = Charset.forName(charsetName);
>>> 72: asciiString = LOREM.substring(0, 32).getBytes(charset);
>>
> Splitting out these micro changes from #7231
>
> - Clean up and simplify setup and code
> - Add variants with different inputs with varying lengths and encoding
> weights, but also relevant mixes of each so that we both cover interesting
> corner cases but also verify that performance behave
On Fri, 25 Feb 2022 09:19:33 GMT, Claes Redestad wrote:
>> Splitting out these micro changes from #7231
>>
>> - Clean up and simplify setup and code
>> - Add variants with different inputs with varying lengths and encoding
>> weights, but also relevant mixes of each so that we both cover
> Splitting out these micro changes from #7231
>
> - Clean up and simplify setup and code
> - Add variants with different inputs with varying lengths and encoding
> weights, but also relevant mixes of each so that we both cover interesting
> corner cases but also verify that performance behave
On Thu, 24 Feb 2022 19:01:32 GMT, Brent Christian wrote:
>> Splitting out these micro changes from #7231
>>
>> - Clean up and simplify setup and code
>> - Add variants with different inputs with varying lengths and encoding
>> weights, but also relevant mixes of each so that we both cover
> Can I please get a review of this test only change which fixes the issue
> noted in https://bugs.openjdk.java.net/browse/JDK-8282023?
>
> As noted in that JBS issue these tests fail when the default locale under
> which those tests are run isn't `en_US`. Both these tests were introduced as
>
On Thu, 24 Feb 2022 18:51:08 GMT, Roger Riggs wrote:
>> Ichiroh Takiguchi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add null check
>
> The piece I was missing is that the HotSpot AIX specific code, computes and
> sets LIBPATH
47 matches
Mail list logo
