On Wed, 30 Mar 2022 00:12:59 GMT, Stuart Marks wrote:
>> XenoAmess has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - update jmh
>> - refine javadoc; refine implement when expectedSize < 0
>
> OK, finally got some time to look at this.
> 8186958: Need method to create pre-sized HashMap
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
update codes
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7928/files
- new:
> Implements x86 intrinsics for compare() method in java.lang.Integer and
> java.lang.Long.
Vamsi Parasa has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request
On Wed, 30 Mar 2022 21:51:16 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-424 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
On Wed, 30 Mar 2022 20:59:34 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-424 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
On Wed, 30 Mar 2022 12:06:39 GMT, Claes Redestad wrote:
> A few integer divisions and multiplications can be replaced with test +
> addition, leading to a decent speed-up on java.time microbenchmarks such as
> `GetYearBench`. Numbers from my local x86 workstation, seeing similar
> speed-up on
On Tue, 16 Nov 2021 20:53:26 GMT, kabutz wrote:
>> This is a draft proposal for how we could improve stream performance for the
>> case where the streams are empty. Empty collections are common-place. If we
>> iterate over them with an Iterator, we would have to create one small
>> Iterator
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull
On Sun, 20 Mar 2022 13:20:31 GMT, Andrey Turbanov wrote:
> String.toString() calls doesn't make much sense. Only one place, where it
> could be used - to generate NPE. But in a few places of JDK codebase it's
> called, even when NPE will happen anyway.
> I propose to cleanup such places.
>
On Sun, 20 Mar 2022 13:20:31 GMT, Andrey Turbanov wrote:
> String.toString() calls doesn't make much sense. Only one place, where it
> could be used - to generate NPE. But in a few places of JDK codebase it's
> called, even when NPE will happen anyway.
> I propose to cleanup such places.
>
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull
On Fri, 18 Mar 2022 18:59:16 GMT, Sean Mullan wrote:
>> I don't know what the motivation for this change is but there is more to
>> this story and I think will require agreement from the security area before
>> removing it.
>
> I agree with @AlanBateman. Please don't proceed with this fix
On Wed, 30 Mar 2022 12:06:39 GMT, Claes Redestad wrote:
> A few integer divisions and multiplications can be replaced with test +
> addition, leading to a decent speed-up on java.time microbenchmarks such as
> `GetYearBench`. Numbers from my local x86 workstation, seeing similar
> speed-up on
On Wed, 30 Mar 2022 16:46:40 GMT, Naoto Sato wrote:
> Fixes test failures caused by depending on the default locale. Specifying
> explicit `Locale.US` will do.
Marked as reviewed by scolebourne (Author).
-
PR: https://git.openjdk.java.net/jdk/pull/8045
On Wed, 30 Mar 2022 12:06:39 GMT, Claes Redestad wrote:
> A few integer divisions and multiplications can be replaced with test +
> addition, leading to a decent speed-up on java.time microbenchmarks such as
> `GetYearBench`. Numbers from my local x86 workstation, seeing similar
> speed-up on
On Wed, 30 Mar 2022 11:38:59 GMT, Aleksey Shipilev wrote:
> See bug report for more details. This change improves
> SPECjvm2008:xml.validation for about +3%:
>
>
> baseline: 298.353 ± 1.008 ops/min
> patched: 309.912 ± 1.347 ops/min
>
> Of course, the real improvements might be even
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull
On Wed, 30 Mar 2022 16:46:40 GMT, Naoto Sato wrote:
> Fixes test failures caused by depending on the default locale. Specifying
> explicit `Locale.US` will do.
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8045
On Wed, 23 Mar 2022 16:27:29 GMT, Mandy Chung wrote:
> This patch changes VarHandle and its implementation hierarchy to use sealed
> classes. All VarHandle permitted classes are package-private and either
> final or sealed abstract classes.
>
> Please also review the CSR:
On Wed, 30 Mar 2022 13:21:41 GMT, Jaikiran Pai wrote:
>> A small improvement to `RawNativeLibraries`. `RawNativeLibraries::load`
>> returns the same `NativeLibrary` instance of a given path if it's called
>> multiple times. This means that multiple clients have to coordinate that the
>>
On Wed, 30 Mar 2022 16:46:40 GMT, Naoto Sato wrote:
> Fixes test failures caused by depending on the default locale. Specifying
> explicit `Locale.US` will do.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8045
On Wed, 30 Mar 2022 16:08:15 GMT, Brian Burkhalter wrote:
> Looks all right assuming tests pass.
Thanks! Tier1+2 testing passed.
-
PR: https://git.openjdk.java.net/jdk/pull/8039
On Wed, 30 Mar 2022 02:56:41 GMT, Vicente Romero wrote:
>> Please review this PR which is updating the ASM included in the JDK to ASM
>> 9.2. This version should be included in JDK19. There are basically two
>> commits here, one that was automatically generated and that mostly changes
>> file
Fixes test failures caused by depending on the default locale. Specifying
explicit `Locale.US` will do.
-
Commit messages:
- 8283842: TestZoneTextPrinterParser.test_roundTripAtOverlap fails:
DateTimeParseException
Changes: https://git.openjdk.java.net/jdk/pull/8045/files
Webrev:
On Wed, 30 Mar 2022 02:56:41 GMT, Vicente Romero wrote:
>> Please review this PR which is updating the ASM included in the JDK to ASM
>> 9.2. This version should be included in JDK19. There are basically two
>> commits here, one that was automatically generated and that mostly changes
>> file
On Wed, 30 Mar 2022 02:56:41 GMT, Vicente Romero wrote:
>> Please review this PR which is updating the ASM included in the JDK to ASM
>> 9.2. This version should be included in JDK19. There are basically two
>> commits here, one that was automatically generated and that mostly changes
>> file
On Wed, 30 Mar 2022 16:28:16 GMT, Brian Burkhalter wrote:
>> Minimal version of possible fixes: make the bulk read `@return` verbiage
>> consistent in the `java.io` package.
>
> Brian Burkhalter has refreshed the contents of this pull request, and
> previous commits have been removed. The
> Minimal version of possible fixes: make the bulk read `@return` verbiage
> consistent in the `java.io` package.
Brian Burkhalter has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous
On Wed, 30 Mar 2022 10:31:59 GMT, Xiaohong Gong wrote:
> Currently the vector load with mask when the given index happens out of the
> array boundary is implemented with pure java scalar code to avoid the IOOBE
> (IndexOutOfBoundaryException). This is necessary for architectures that do
> not
On Wed, 30 Mar 2022 16:05:03 GMT, Brian Burkhalter wrote:
> Minimal version of possible fixes: make the bulk read `@return` verbiage
> consistent in the `java.io` package.
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8044
On Wed, 30 Mar 2022 12:06:39 GMT, Claes Redestad wrote:
> A few integer divisions and multiplications can be replaced with test +
> addition, leading to a decent speed-up on java.time microbenchmarks such as
> `GetYearBench`. Numbers from my local x86 workstation, seeing similar
> speed-up on
Minimal version of possible fixes: make the bulk read `@return` verbiage
consistent in the `java.io` package.
-
Commit messages:
- 5087440: (ch spec) java.io,nio bulk read(...) end-of-stream return value
descriptions ambiguous
Changes:
On Tue, 29 Mar 2022 01:07:33 GMT, Stuart Marks wrote:
> Pretty much just what it says.
This pull request has now been integrated.
Changeset: ae57258b
Author:Stuart Marks
URL:
https://git.openjdk.java.net/jdk/commit/ae57258b46b8b6953148cd8cf71faf75eef118da
Stats: 10 lines in 2
On Wed, 30 Mar 2022 00:43:49 GMT, Alisen Chung wrote:
> redo of 8280400
I believe
`src/jdk.localedata/share/classes/sun/util/resources/ext/CurrencyNames_zh_CN.properties`
and `test/jdk/sun/text/resources/LocaleData` have to be adjusted according to
the l10n changes.
-
PR:
On Tue, 29 Mar 2022 20:05:50 GMT, Mandy Chung wrote:
> A small improvement to `RawNativeLibraries`. `RawNativeLibraries::load`
> returns the same `NativeLibrary` instance of a given path if it's called
> multiple times. This means that multiple clients have to coordinate that the
> last one
On Wed, 30 Mar 2022 00:46:49 GMT, Joe Wang wrote:
>> Resets state of a Catalog instance on each matching call so that it can be
>> reused. Adjusts CatalogResolver's resolve routine so that it continues to
>> observes the PREFER feature in a resolution process. Without the adjustment,
>>
A few integer divisions and multiplications can be replaced with test +
addition, leading to a decent speed-up on java.time microbenchmarks such as
`GetYearBench`. Numbers from my local x86 workstation, seeing similar speed-up
on aarch64 and other x86 setups.
Baseline:
Benchmark
On Tue, 29 Mar 2022 20:05:50 GMT, Mandy Chung wrote:
> A small improvement to `RawNativeLibraries`. `RawNativeLibraries::load`
> returns the same `NativeLibrary` instance of a given path if it's called
> multiple times. This means that multiple clients have to coordinate that the
> last one
See bug report for more details. This change improves
SPECjvm2008:xml.validation for about +3%:
baseline: 298.353 ± 1.008 ops/min
patched: 309.912 ± 1.347 ops/min
Of course, the real improvements might be even higher, as exception might be
thrown from much deeper call hierarchy.
On Wed, 30 Mar 2022 10:31:59 GMT, Xiaohong Gong wrote:
> Currently the vector load with mask when the given index happens out of the
> array boundary is implemented with pure java scalar code to avoid the IOOBE
> (IndexOutOfBoundaryException). This is necessary for architectures that do
> not
On Wed, 30 Mar 2022 00:43:49 GMT, Alisen Chung wrote:
> redo of 8280400
Since this is identical to the original fix, I would expect the same Tier2 test
failure as reported in
[JDK-8283804](https://bugs.openjdk.java.net/browse/JDK-8283804).
-
PR:
Currently the vector load with mask when the given index happens out of the
array boundary is implemented with pure java scalar code to avoid the IOOBE
(IndexOutOfBoundaryException). This is necessary for architectures that do not
support the predicate feature. Because the masked load is
On Tue, 29 Mar 2022 12:45:51 GMT, Volker Simonis wrote:
> > Hello Volker, An additional thing that we might have to consider here is
> > whether adding this javadoc change to `InflaterInputStream` is ever going
> > to "show up" to end user applications. What I mean is, I think in many
> >
On Tue, 25 May 2021 15:32:40 GMT, gregcawthorne wrote:
>> Glibc 2.29 onwards provides optimised versions of log,log10,exp.
>> These functions have an accuracy of 0.9ulp or better in glibc
>> 2.29.
>>
>> Therefore this patch adds code to parse, store and check
>> the runtime glibcs version in
On Sun, 20 Mar 2022 12:45:34 GMT, Andrey Turbanov wrote:
> In a few places String.indexOf/lastIndexOf methods are called with default
> parameter for index: `0` for `indexOf`, length() for `lastIndexOf`.
> I propose to cleanup such calls. It makes code a bit easier to read. In case
> of
On Tue, 29 Mar 2022 09:15:01 GMT, Andrey Turbanov wrote:
> It was no longer used due to JDK-4479184 long ago.
This pull request has now been integrated.
Changeset: b323f54f
Author:Andrey Turbanov
URL:
https://git.openjdk.java.net/jdk/commit/b323f54feef13a47bb02af608eb1f6474692d905
On Wed, 30 Mar 2022 00:43:57 GMT, Jaikiran Pai wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adjust nonfinal CSMs and rework error reporting in CheckCSMs.java test
>
> Hello Stuart, the test change looks fine to
On Wed, 30 Mar 2022 06:17:54 GMT, Stuart Marks wrote:
>> Pretty much just what it says.
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update copyright year.
Marked as reviewed by jpai (Committer).
-
PR:
> Pretty much just what it says.
Stuart Marks has updated the pull request incrementally with one additional
commit since the last revision:
Update copyright year.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8009/files
- new:
49 matches
Mail list logo
