RFR: 8283870: jdeprscan --help causes an exception when the locale is ja or zh_CN

2022-04-10 Thread Koichi Sakata
# Summary Running jdeprscan with --help option causes an exception on any OSs when the locale is ja or zh_CN. # How to reproduce this issue $ jdeprscan -J-Duser.language=ja --help Exception in thread "main" java.lang.IllegalArgumentException: can't parse argument number: dir|jar|class

Re: RFR: 8282221: x86 intrinsics for divideUnsigned and remainderUnsigned methods in java.lang.Integer and java.lang.Long [v13]

2022-04-10 Thread Srinivas Vamsi Parasa
On Mon, 11 Apr 2022 02:01:17 GMT, David Holmes wrote: > This change appears to be causing crashes in tier4 - possibly Xcomp related: > > # assert(ctrl == kit.control()) failed: Control flow was added although the > intrinsic bailed out > I will file a new bug. Thank you for informing this

Re: RFR: 8284579: Improve VarHandle checks for interpreter [v2]

2022-04-10 Thread David Holmes
On Fri, 8 Apr 2022 12:20:32 GMT, Claes Redestad wrote: >> A few additional enhancements aiming to improve VH performance in the >> interpreter: >> >> - Flatten `TypeAndInvokers`: adds a pointer to `VarHandle` (a small increase >> 40->48) but removes an object and an indirection on any

Re: RFR: 8282221: x86 intrinsics for divideUnsigned and remainderUnsigned methods in java.lang.Integer and java.lang.Long [v13]

2022-04-10 Thread David Holmes
On Fri, 8 Apr 2022 22:17:23 GMT, Srinivas Vamsi Parasa wrote: >> Optimizes the divideUnsigned() and remainderUnsigned() methods in >> java.lang.Integer and java.lang.Long classes using x86 intrinsics. This >> change shows 3x improvement for Integer methods and upto 25% improvement for >>

Integrated: 8284036: Make ConcurrentHashMap.CollectionView a sealed hierarchy

2022-04-10 Thread Jaikiran Pai
On Mon, 4 Apr 2022 06:55:10 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which now marks `CollectionView` as > a `sealed` class with only `EntrySetView`, `KeySetView` and `ValuesView` as > the sub-classes? This change corresponds to >

Re: RFR: 8284036: Make ConcurrentHashMap.CollectionView a sealed hierarchy

2022-04-10 Thread Jaikiran Pai
On Mon, 4 Apr 2022 06:55:10 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which now marks `CollectionView` as > a `sealed` class with only `EntrySetView`, `KeySetView` and `ValuesView` as > the sub-classes? This change corresponds to >

Re: RFR: JDK-8281006 Module::getResourceAsStream should check if the resource is open unconditionally when caller is null [v4]

2022-04-10 Thread Tim Prinzing
> Created a test called NullCallerGetResource to test > Module::getResourceAsStream and Class::getResourceAsStream from the native > level. > > At the java level the test builds a test module called 'n' which opens the > package 'open' to everyone. There is also a package 'closed' which is

Re: RFR: 8284161: Implementation of Virtual Threads (Preview)

2022-04-10 Thread Magnus Ihse Bursie
On Fri, 8 Apr 2022 13:43:39 GMT, Alan Bateman wrote: > This is the implementation of JEP 425: Virtual Threads (Preview); TBD which > JDK version to target. > > We will refresh this PR periodically to pick up changes and fixes from the > loom repo. > > Most of the new mechanisms in the

Re: RFR: 8186958: Need method to create pre-sized HashMap [v14]

2022-04-10 Thread XenoAmess
> 8186958: Need method to create pre-sized HashMap XenoAmess has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 17 commits: - Merge branch 'master' into fix_8186958 - variable nameToReferenceSize rename to moduleCount - use (double)

Re: RFR: 8186958: Need method to create pre-sized HashMap [v12]

2022-04-10 Thread XenoAmess
On Sun, 10 Apr 2022 07:41:05 GMT, Alan Bateman wrote: >> XenoAmess has updated the pull request incrementally with one additional >> commit since the last revision: >> >> use (double) DEFAULT_LOAD_FACTOR instead of 0.75 > > src/java.base/share/classes/java/lang/module/Resolver.java line 501:

Re: RFR: 8186958: Need method to create pre-sized HashMap [v13]

2022-04-10 Thread XenoAmess
> 8186958: Need method to create pre-sized HashMap XenoAmess has updated the pull request incrementally with one additional commit since the last revision: variable nameToReferenceSize rename to moduleCount - Changes: - all: https://git.openjdk.java.net/jdk/pull/7928/files -

Re: RFR: JDK-8281006 Module::getResourceAsStream should check if the resource is open unconditionally when caller is null [v3]

2022-04-10 Thread Alan Bateman
On Thu, 7 Apr 2022 21:08:34 GMT, Tim Prinzing wrote: >> Created a test called NullCallerGetResource to test >> Module::getResourceAsStream and Class::getResourceAsStream from the native >> level. >> >> At the java level the test builds a test module called 'n' which opens the >> package

Re: RFR: 8279283 - BufferedInputStream should override transferTo [v5]

2022-04-10 Thread Markus KARG
On Mon, 27 Dec 2021 13:43:12 GMT, Markus KARG wrote: >> Implementation of JDK-8279283 > > Markus KARG has updated the pull request incrementally with one additional > commit since the last revision: > > fixed missing BufferedInputStream Please keep this PR open; I will continune work on it

Re: RFR: 8240903: Add test to check that jmod hashes are reproducible [v5]

2022-04-10 Thread Alan Bateman
On Wed, 30 Mar 2022 01:55:30 GMT, Dongbo He wrote: >> This creates a regression test for >> [JDK-8240734](https://bugs.openjdk.java.net/browse/JDK-8240734). This was >> once blocked >> by a time stamp issue which has been resolved by: [JDK-8276766 >>

Re: RFR: 8186958: Need method to create pre-sized HashMap [v12]

2022-04-10 Thread Alan Bateman
On Wed, 6 Apr 2022 16:02:31 GMT, XenoAmess wrote: >> 8186958: Need method to create pre-sized HashMap > > XenoAmess has updated the pull request incrementally with one additional > commit since the last revision: > > use (double) DEFAULT_LOAD_FACTOR instead of 0.75

Re: RFR: 8283892: Compress and expand bits [v6]

2022-04-10 Thread Alan Bateman
On Fri, 8 Apr 2022 19:13:35 GMT, Paul Sandoz wrote: >> Add support to compress bits and expand bits of `int` and `long` values, see >> Hacker's Delight (2nd edition), section 7.4. >> >> Compressing or expanding bits of an `int` or `long` value can be composed to >> enable general

Re: RFR: 8282221: x86 intrinsics for divideUnsigned and remainderUnsigned methods in java.lang.Integer and java.lang.Long [v4]

2022-04-10 Thread Srinivas Vamsi Parasa
On Wed, 6 Apr 2022 06:23:47 GMT, Jatin Bhateja wrote: >>> Also need a jtreg test for this. >> >> Thanks Sandhya for the review. Made the suggested changes and added jtreg >> tests as well. > > Hi @vamsi-parasa , thanks for addressing my comments, looks good to me > otherwise apart from the