Re: RFR: 8287363: null pointer should use NULL instead of 0

2022-05-28 Thread Kim Barrett
On Sat, 28 May 2022 03:31:30 GMT, Yasumasa Suenaga wrote: > We found using `0` as `NULL` in java_md_common.c . `0` is not a pointer, so > we should use `NULL` where we want to handle it. > > https://github.com/openjdk/jdk/pull/8646#discussion_r882294076 > > Also I found using `0` as NUL char

Re: RFR: 8287440: Typo in package-info.java of java.util.random [v2]

2022-05-28 Thread Jaikiran Pai
On Sat, 28 May 2022 12:05:31 GMT, Anthony Vanelverdinghe wrote: >> The change is trivial, but I'll need help from someone to create a JBS issue >> & sponsor this PR. > > Anthony Vanelverdinghe has updated the pull request incrementally with one > additional commit since the last revision: >

Re: RFR: 8287440: Typo in package-info.java of java.util.random

2022-05-28 Thread Anthony Vanelverdinghe
On Sat, 28 May 2022 10:00:50 GMT, Jaikiran Pai wrote: >> The change is trivial, but I'll need help from someone to create a JBS issue >> & sponsor this PR. > > @anthonyvdotbe, can you also please change the copyright year on that file > from `Copyright (c) 2021,` to `Copyright (c) 2021, 2022,`

Re: RFR: 8287440: Typo in package-info.java of java.util.random [v2]

2022-05-28 Thread Anthony Vanelverdinghe
> The change is trivial, but I'll need help from someone to create a JBS issue > & sponsor this PR. Anthony Vanelverdinghe has updated the pull request incrementally with one additional commit since the last revision: Correct copyright year Signed-off-by: Anthony Vanelverdinghe

RFR: 8287171: Refactor null caller tests to a single directory

2022-05-28 Thread Tim Prinzing
Created a test at test/jdk/jdk/nullCaller called NullCallerTest that creates a test module with some resources in it for the actual tests that occur at the native level. The native part was switched to c++ instead of c to make it easier to create helper objects that reduce the redundant code

Re: RFR: 8287440: Typo in package-info.java of java.util.random

2022-05-28 Thread Jaikiran Pai
On Wed, 18 May 2022 11:45:46 GMT, Anthony Vanelverdinghe wrote: > The change is trivial, but I'll need help from someone to create a JBS issue > & sponsor this PR. @anthonyvdotbe, can you also please change the copyright year on that file from `Copyright (c) 2021,` to `Copyright (c) 2021,

Re: RFR: 8287363: null pointer should use NULL instead of 0

2022-05-28 Thread kristylee88
On Sat, 28 May 2022 03:31:30 GMT, Yasumasa Suenaga wrote: > We found using `0` as `NULL` in java_md_common.c . `0` is not a pointer, so > we should use `NULL` where we want to handle it. > > https://github.com/openjdk/jdk/pull/8646#discussion_r882294076 > > Also I found using `0` as NUL char

RFR: 8287363: null pointer should use NULL instead of 0

2022-05-28 Thread Yasumasa Suenaga
We found using `0` as `NULL` in java_md_common.c . `0` is not a pointer, so we should use `NULL` where we want to handle it. https://github.com/openjdk/jdk/pull/8646#discussion_r882294076 Also I found using `0` as NUL char in java_md_common.c , so I replaced it to `\0` in this PR.