On Sun, 22 May 2022 05:58:25 GMT, Christian Stein wrote:
> Commit
> https://github.com/openjdk/jdk/commit/655500a4f5e3abcff176599604deceefb6ca6640
> for issue [JDK-8286654](https://bugs.openjdk.java.net/browse/JDK-8286654)
> added an optional description accessor on the `
On Tue, 24 May 2022 04:58:44 GMT, Jaikiran Pai wrote:
>> Commit
>> https://github.com/openjdk/jdk/commit/655500a4f5e3abcff176599604deceefb6ca6640
>> for issue [JDK-8286654](https://bugs.openjdk.java.net/browse/JDK-8286654)
>> added an optional description accessor on the `ToolProvider`
On Tue, 24 May 2022 04:50:58 GMT, Jaikiran Pai wrote:
>> Christian Stein has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update src/java.base/share/classes/java/util/spi/ToolProvider.java
>>
On Mon, 23 May 2022 10:32:09 GMT, Anthony Vanelverdinghe
wrote:
>> Christian Stein has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update src/java.base/share/classes/java/util/spi/ToolProvider.java
>>
> This commit adds an API note to ToolProvider about being reusable/reentrant.
Christian Stein has updated the pull request incrementally with one additional
commit since the last revision:
Update src/java.base/share/classes/java/util/spi/ToolProvider.java
Co-authored-by: Anth
This commit adds an API note to ToolProvider about being reusable/reentrant.
-
Commit messages:
- 8286815: Add API note to ToolProvider about being reusable/reentrant
Changes: https://git.openjdk.java.net/jdk/pull/8833/files
Webrev:
Commit
https://github.com/openjdk/jdk/commit/655500a4f5e3abcff176599604deceefb6ca6640
for issue [JDK-8286654](https://bugs.openjdk.java.net/browse/JDK-8286654) added
an optional description accessor on the `ToolProvider` interface. It included a
typo in` jlink`'s description resource key
On Wed, 18 May 2022 14:56:47 GMT, Christian Stein wrote:
> This PR adds an optional description accessor on `ToolProvider` interface.
>
> This PR also adds short description for each of the listed tool:
> - `jar`
> - `javac`
> - `javadoc`
> - `javap` and `jdeps`
On Thu, 19 May 2022 06:21:40 GMT, Christian Stein wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac.properties
>> line 387:
>>
>>> 385:
>>> 386: javac.description=Read Java declarations and compile them into class
>>
On Wed, 18 May 2022 21:47:25 GMT, Jonathan Gibbons wrote:
>> This PR adds an optional description accessor on `ToolProvider` interface.
>>
>> This PR also adds short description for each of the listed tool:
>> - `jar`
>> - `javac`
>> - `javadoc`
>> - `javap` and `jdeps`
>> - `jlink` and `jmod`
This PR adds an optional description accessor on `ToolProvider` interface.
This PR also adds short description for each of the listed tool:
- `jar`
- `javac`
- `javadoc`
- `javap` and `jdeps`
- `jlink` and `jmod`
- `jpackage`
-
Commit messages:
- Add localized description for
On Wed, 9 Feb 2022 16:37:00 GMT, Christian Stein wrote:
> A number of modules declare that the "provide" ToolProvider.
>
> These modules now specify the "name" of the argument used by
> `ToolProvider.findFirst` to access an instance of the tool provide
> A number of modules declare that the "provide" ToolProvider.
>
> These modules now specify the "name" of the argument used by
> `ToolProvider.findFirst` to access an instance of the tool provider within
> the description part of a `@provides` API tag.
C
> A number of modules declare that the "provide" ToolProvider.
>
> These modules now specify the "name" of the argument used by
> `ToolProvider.findFirst` to access an instance of the tool provider within
> the description part of a `@provides` API tag.
C
On Thu, 10 Feb 2022 17:24:17 GMT, Jonathan Gibbons wrote:
>>> Perhaps like this?
>>>
>>> ```java
>>> /**
>>> * ...
>>> * @provides java.util.spi.ToolProvider
>>> * Module {@code jdk.jartool} provides a tool named {@code "jar"}.
>>> * Invoke {@link
On Thu, 10 Feb 2022 02:19:36 GMT, Jonathan Gibbons wrote:
>> src/jdk.jartool/share/classes/module-info.java line 45:
>>
>>> 43: * Pass {@code "jar"} as the name to
>>> 44: * {@link java.util.spi.ToolProvider#findFirst
>>> ToolProvider.findFirst}
>>> 45: * in order to
On Wed, 9 Feb 2022 16:37:00 GMT, Christian Stein wrote:
> A number of modules declare that the "provide" ToolProvider.
>
> These modules now specify the "name" of the argument used by
> `ToolProvider.findFirst` to access an instance of the tool provide
A number of modules declare that the "provide" ToolProvider.
These modules now specify the "name" of the argument used by
`ToolProvider.findFirst` to access an instance of the tool provider within the
description part of a `@provides` API tag.
-
Commit messages:
- Separate
On Wed, 9 Feb 2022 06:42:51 GMT, Christian Stein wrote:
> This PR removes the redundant and failing test-case.
> It also removes the test class from the problem list.
>
> Adds additional test-cases using long form option names of `jar`.
This pull request has now been integrated
This PR removes the redundant and failing test-case.
It also removes the test class from the problem list.
Adds additional test-cases using long form option names of `jar`.
-
Commit messages:
- Only assert non-zero exit code on failure
- 8281470:
On Wed, 2 Feb 2022 20:21:54 GMT, Christian Stein wrote:
> Calling `jar --create --file a/b/foo.jar INPUT-FILES` should create missing
> parent directories (here `a/b`) on the default file system before storing the
> JAR file (here `foo.jar`) in the destination directory.
This pull re
> Calling `jar --create --file a/b/foo.jar INPUT-FILES` should create missing
> parent directories (here `a/b`) on the default file system before storing the
> JAR file (here `foo.jar`) in the destination directory.
Christian Stein has updated the pull request incrementally with one a
On Wed, 2 Feb 2022 20:21:54 GMT, Christian Stein wrote:
> Calling `jar --create --file a/b/foo.jar INPUT-FILES` should create missing
> parent directories (here `a/b`) on the default file system before storing the
> JAR file (here `foo.jar`) in the destination directory.
Should I al
> Calling `jar --create --file a/b/foo.jar INPUT-FILES` should create missing
> parent directories (here `a/b`) on the default file system before storing the
> JAR file (here `foo.jar`) in the destination directory.
Christian Stein has updated the pull request incrementally with one a
On Thu, 3 Feb 2022 21:43:30 GMT, Lance Andersen wrote:
> I think this would be the appropriate place for documenting the behavior.
Like this?
-c, --create Create the archive. When the path specified by -f,
--file
contains a path, missing parent
On Wed, 2 Feb 2022 20:21:54 GMT, Christian Stein wrote:
> Calling `jar --create --file a/b/foo.jar INPUT-FILES` should create missing
> parent directories (here `a/b`) on the default file system before storing the
> JAR file (here `foo.jar`) in the destination directory.
Thanks for t
Calling `jar --create --file a/b/foo.jar INPUT-FILES` should create missing
parent directories (here `a/b`) on the default file system before storing the
JAR file (here `foo.jar`) in the destination directory.
-
Commit messages:
- Expect at least jar file's name in error message
On Wed, 8 Dec 2021 15:26:23 GMT, Christian Stein wrote:
> Prior to this PR, `toUri()` of class `ZipPath` in module `jdk.zipfs` and
> class `PathFileObject` in module `jdk.compiler` were always composed by base
> path names. Even for versioned entries of a multi-release JAR file.
On Fri, 10 Dec 2021 16:33:33 GMT, Jonathan Gibbons wrote:
>> Christian Stein has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Turn `getRealPath()` into a no-arg helper method
>
> test/langtools/tools/javac/T
ath names using an
> existing lookup function in the associated zip file system object.
>
> This PR also removes a superseded work around for
> [JDK-8134451](https://bugs.openjdk.java.net/browse/JDK-8134451).
>
> Fixes https://bugs.openjdk.java.net/browse/JDK-8271079
Chr
On Fri, 10 Dec 2021 16:37:35 GMT, Jonathan Gibbons wrote:
> javac changes look good. I suggest adding this bug number to the test to
> check that URIs are not double-encoded.
I can't find [`8134451`](https://bugs.openjdk.java.net/browse/JDK-8134451) as
noted in the now removed comment
On Fri, 10 Dec 2021 16:30:37 GMT, Jonathan Gibbons wrote:
>> Christian Stein has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Turn `getRealPath()` into a no-arg helper method
>
> test/langtools/tools/javac/T
On Thu, 9 Dec 2021 18:37:11 GMT, Alan Bateman wrote:
>> Christian Stein has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Clean up reproducer test case
>> - Keep helper in ZipFileSystem simple
>
>
ath names using an
> existing lookup function in the associated zip file system object.
>
> This PR also removes a superseded work around for
> [JDK-8134451](https://bugs.openjdk.java.net/browse/JDK-8134451).
>
> Fixes https://bugs.openjdk.java.net/browse/JDK-8271079
Chr
On Thu, 4 Nov 2021 13:10:37 GMT, Christian Stein wrote:
> This PR implements the fix as suggested by Adam Farley, which reads:
>
>> Note: Looks to be as simple as adding `jaccessinspector-32` and
>> `jaccesswalker-32` to `TOOLS_NOT_TO_TEST` at the top of
>> `HelpFla
This PR implements the fix as suggested by Adam Farley, which reads:
> Note: Looks to be as simple as adding `jaccessinspector-32` and
> `jaccesswalker-32` to `TOOLS_NOT_TO_TEST` at the top of `HelpFlagsTest.java`,
> as the non-32bit versions are already there.
-
Commit messages:
On Thu, 16 Sep 2021 09:06:20 GMT, Christian Stein wrote:
> This commit appends the name of the JAR file to the exception message for
> when automatic module lists a non-existing provider class.
This pull request has now been integrated.
Changeset: c10de353
Author:Christian
> This commit appends the name of the JAR file to the exception message for
> when automatic module lists a non-existing provider class.
Christian Stein has updated the pull request incrementally with one additional
commit since the last revision:
Add JBS issue `8262944` to the `@bug
> This commit appends the name of the JAR file to the exception message for
> when automatic module lists a non-existing provider class.
Christian Stein has updated the pull request incrementally with one additional
commit since the last revision:
Assert that only the name of the JA
On Thu, 23 Sep 2021 11:26:26 GMT, Alan Bateman wrote:
>> This commit appends the name of the JAR file to the exception message for
>> when automatic module lists a non-existing provider class.
>
> src/java.base/share/classes/jdk/internal/module/ModulePath.java line 554:
>
>> 552:
Hi,
jar --create (and --update) perform type API validation checks when used in
combination with --release option. This detects invalid "version overlays"
at package time, where the API doesn't match a previous one.
Having a jar --verify mode that performs the same checks consuming an
already
41 matches
Mail list logo
