Re: RFR (S): JDK-8164086: Checked JNI pending exception check should be cleared when returning to Java frame

2016-09-06 Thread David Simms
Updated webrev: http://cr.openjdk.java.net/~dsimms/8164086/webrev3/ On 06/09/16 01:20, David Holmes wrote: Hi David, On 5/09/2016 6:02 PM, David Simms wrote: Hi David, I can make the checks silent, but the launcher itself produces warnings from checked JNI (it's use of unchecked Java

Re: RFR (S): JDK-8164086: Checked JNI pending exception check should be cleared when returning to Java frame

2016-09-05 Thread David Simms
/TestCheckedJniExceptionCheck.java.html) to fail, with unchecked exception warnings popping up in the output. But yeah, I could adjust the test the ignore any start-up warnings and drop the changes to the launcher... Thanks /David Simms On 29/08/2016 9:24 a.m., David Holmes wrote: Hi David, I still do not understand why

Re: RFR (S): JDK-8164086: Checked JNI pending exception check should be cleared when returning to Java frame

2016-08-26 Thread David Simms
Hi David, Updated webrev: http://cr.openjdk.java.net/~dsimms/8164086/webrev2/ On 26/08/16 02:27, David Holmes wrote: Hi David, I'm missing some pieces of this puzzle I'm afraid. On 25/08/2016 8:05 PM, David Simms wrote: Updated the webrev here: http://cr.openjdk.java.net/~dsimms/8164086

Re: RFR (S): JDK-8164086: Checked JNI pending exception check should be cleared when returning to Java frame

2016-08-25 Thread David Simms
avid On 23/08/2016 8:24 PM, David Simms wrote: Reply in-line... On 19/08/16 14:29, David Holmes wrote: Hi David, The changes in the native wrapper seem okay though I'm not an expert on the machine specific encodings. I'm a little surprised there are not more things that need changing though.