Re: RFR 8159245: Loggers created by system classes are not initialized correctly when configured programmatically from application code.

Hi Daniel, Got you point. Thank you -Hamlin On 2016/6/22 13:24, Daniel Fuchs wrote: Hi Hamlin, On 22/06/16 02:40, Hamlin Li wrote: Just another minor comment, I'm not sure if following line is necessary in Logger.java, as it's already been checked in LogManager.java line 577: 439 if (cfg

Re: RFR 8159245: Loggers created by system classes are not initialized correctly when configured programmatically from application code.

Hi Daniel, Thank you for detailed explanation, new version makes sense to me. Just another minor comment, I'm not sure if following line is necessary in Logger.java, as it's already been checked in LogManager.java line 577: 439 if (cfg == other) return cfg; Thank you -Hamlin On 2016/6/21

RFR of JDK-8159785: Add test that tests ClassLoader.getResource/getResources in Multi-Release Jar

Would you please review the following patch? bug: https://bugs.openjdk.java.net/browse/JDK-8159785 webrev: http://cr.openjdk.java.net/~mli/8159785/webrev.00/ JDK-8151542 fixed bugs and added test to verify Class.getResource works as expected,

Re: JDK 9 RFR of JDK-8157211: Mark tools/launcher/FXLauncherTest.java as intermittently failing

Would you please help to review the code change? Thank you -Hamlin On 2016/5/18 12:52, Hamlin Li wrote: tools/launcher/FXLauncherTest.java This test is known to fail intermittently (JDK-8130392 <https://bugs.openjdk.java.net/browse/JDK-8130392>), it should be marked accordingly wi

JDK 9 RFR of JDK-8151904: test/java/lang/StackWalker/VerifyStackTrace.java needs to handle update releases

The test currently hardcodes the version number "9". We should build a JDK with a different release number e.g. 9.1 and checks if this test handles it properly. Test run successfully on 9-ea+118, dummybundles(9-ea+255, 9.1-ea+255, 9.0.1-ea+255, 9.0.0.1-ea+255). bug:

JDK 9 RFR of JDK-8157211: Mark tools/launcher/FXLauncherTest.java as intermittently failing

tools/launcher/FXLauncherTest.java This test is known to fail intermittently (JDK-8130392 ), it should be marked accordingly with@key intermittentjtreg tag in the test file. bug: https://bugs.openjdk.java.net/browse/JDK-8157211 webrev:

Re: JDK 9 RFR of JDK-8157006/8157011: Problem list java/io/pathNames/GeneralWin32.java and tools/pack200/TestNormal.java

Would you please review the change to problem list 2 frequently failing tests. Thank you -Hamlin On 2016/5/16 15:39, Hamlin Li wrote: java/io/pathNames/GeneralWin32.java has been seen to fail with high frequency on windows. Until JDK-8156595 is addressed, the test should be problem listed

JDK 9 RFR of JDK-8157006/8157011: Problem list java/io/pathNames/GeneralWin32.java and tools/pack200/TestNormal.java

java/io/pathNames/GeneralWin32.java has been seen to fail with high frequency on windows. Until JDK-8156595 is addressed, the test should be problem listed. bug: https://bugs.openjdk.java.net/browse/JDK-8157006 tools/pack200/TestNormal.java has been seen to fail with some frequency on windows.

JDK 9 RFR of JDK-8156189: Problem list tools/jdeps/modules/GenModuleInfo.java and ModuleTest.java until JDK-8153481 is resolved

JDK-8153481 is being fixed, so put tools/jdeps/modules/GenModuleInfo.java and ModuleTest.java in Problem list. bug: https://bugs.openjdk.java.net/browse/JDK-8156189 webrev: http://cr.openjdk.java.net/~mli/8156189/webrev.00/ Thank you -Hamlin

JDK 9 RFR of JDK-8151785: Doc typo in src/../java/util/stream/PipelineHelper.java

Please help to review the tiny doc typo fix for bug https://bugs.openjdk.java.net/browse/JDK-8151785 it should be "copyInto(wrapSink(sink), spliterator);", but it is "intoWrapped(wrapSink(sink), spliterator);", there is no method called intoWrapped. diff -r 25e8c082d7ef

RFR: 8148928: java/util/stream/test/**/SequentialOpTest.java timed out intermittently

Hi everyone, Would you please help to review the fix for bug https://bugs.openjdk.java.net/browse/JDK-8148928, java/util/stream/test/**/SequentialOpTest.java timed out intermittently. webrev: http://cr.openjdk.java.net/~mli/8148928/webrev.00/ Thank you -Hamlin

Re: RFR: 8076458: java/util/stream/test/org/openjdk/tests/java/util/stream/FlatMapOpTest.java timeout

).limit(10))); } I prefer the latter approach (applied to ref and primitive data sets). It’s more work, but i think the right direction. Paul. On 26 Jan 2016, at 08:08, Hamlin Li <huaming...@oracle.com> wrote: Hi everyone, Would you please help to review the fix for bug https://bugs.openjdk.java.n

Re: RFR: 8076458: java/util/stream/test/org/openjdk/tests/java/util/stream/FlatMapOpTest.java timeout

On 2016/1/29 20:53, Paul Sandoz wrote: On 29 Jan 2016, at 13:43, Hamlin Li <huaming...@oracle.com> wrote: Hi Paul, Sorry for delayed response, have been occupied by other higher priority task. Thanks for your review, I agree with you that your second approach is better. New webrev

RFR: 8076458: java/util/stream/test/org/openjdk/tests/java/util/stream/FlatMapOpTest.java timeout

Hi everyone, Would you please help to review the fix for bug https://bugs.openjdk.java.net/browse/JDK-8076458, java/util/stream/test/org/openjdk/tests/java/util/stream/FlatMapOpTest.java timeout. webrev: http://cr.openjdk.java.net/~mli/8076458/webrev.00/ Thank you -Hamlin

Re: JDK 9 RFR of JDK-8144321: Improve existent tests to check the exact line numbers in Stack Frame.

est even better ideas :-) best regards, -- daniel On 12/5/15 6:00 AM, Hamlin Li wrote: Hi all, Would you please help to review the test development of https://bugs.openjdk.java.net/browse/JDK-8144321. webrev : http://cr.openjdk.java.net/~mli/8144321/webrev.00/ Thank you -Hamlin

JDK 9 RFR of JDK-8144321: Improve existent tests to check the exact line numbers in Stack Frame.

Hi all, Would you please help to review the test development of https://bugs.openjdk.java.net/browse/JDK-8144321. webrev : http://cr.openjdk.java.net/~mli/8144321/webrev.00/ Thank you -Hamlin

Re: RFR: 8144214 Some log messages will be discarded when VM is bootstrapping.

a sponsor for this fix, it will be great if you could help to push the code. :-) Please check the push message below : 8144214: Some log messages will be discarded when VM is bootstrapping Summary: use logp rather than log. Reviewed-by: dfuchs Contributed-by: Hamlin Li <huaming...@oracle.com>

Re: JDK 9 RFR of JDK-8144215: Test development task for : JEP-JDK-8046565: SQE Test Plan for Platform Logging API and Service

up the stub that pretend that the VM is not yet booted. In other words - in BootstrapLoggerAPIsTest lines 53-56 should preferably be moved after line 74. best regards, -- daniel On 01/12/15 04:37, Hamlin Li wrote: Hi all, Would you please help to review the test development of JDK-8144215

JDK 9 RFR of JDK-8144215: Test development task for : JEP-JDK-8046565: SQE Test Plan for Platform Logging API and Service

Hi all, Would you please help to review the test development of JDK-8144215 : Test development task for : JEP-JDK-8046565: SQE Test Plan for Platform Logging API and Service. webrev : http://cr.openjdk.java.net/~mli/8144215/webrev.00/ Thank

RFR: 8144214 Some log messages will be discarded when VM is bootstrapping.

Hi all, Would you please help to review for http://cr.openjdk.java.net/~mli/8144214/webrev.00/, which fixes bug https://bugs.openjdk.java.net/browse/JDK-8144214. Thank you -Hamlin

<    1   2   3