On Fri, 22 Oct 2021 08:03:34 GMT, Hendrik Schreiber
wrote:
> Trivial improvement.
>
> Explicitly show how to create a `Cleaner` instance using `Cleaner.create()`.
> Repeat (again) in the code example that the `State` `Runnable `should be
> implemented as static class and no
On Tue, 9 Nov 2021 14:39:49 GMT, Roger Riggs wrote:
>> Trivial improvement.
>>
>> Explicitly show how to create a `Cleaner` instance using `Cleaner.create()`.
>> Repeat (again) in the code example that the `State` `Runnable `should be
>> implemented as static class and not reference the instanc
On Wed, 10 Nov 2021 11:40:28 GMT, Anthony Vanelverdinghe
wrote:
>> This is getting too complicated...
>>
>> It's a code *example* with a very clear comment that explains a best
>> practice:
>>
>> // A cleaner, preferably one shared within a library
>> private static final Cleaner cleaner = Cl
even more clear to those people who never read the javadoc
> *prose*.
>
> I have signed the OCA a while back as
> [hschreiber](https://openjdk.java.net/census#hschreiber).
Hendrik Schreiber has updated the pull request incrementally with one
additional commit since the last revision:
On Wed, 10 Nov 2021 09:41:44 GMT, Alan Bateman wrote:
>> Hendrik Schreiber has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update src/java.base/share/classes/java/lang/ref/Cleaner.java
>>
>&g
even more clear to those people who never read the javadoc
> *prose*.
>
> I have signed the OCA a while back as
> [hschreiber](https://openjdk.java.net/census#hschreiber).
Hendrik Schreiber has updated the pull request incrementally with one
additional commit since the last revision:
On Tue, 9 Nov 2021 11:14:37 GMT, Anthony Vanelverdinghe
wrote:
>> Let me add, why I have raised this issue.
>>
>> I was going to migrate some older code which uses the `finalize()` method to
>> the `Cleaner` mechanism. New it it, there seemed to be two pitfalls:
>>
>> 1. Understanding the who
On Mon, 8 Nov 2021 23:21:49 GMT, Brent Christian wrote:
>> This is what I suggested and makes it clear that *must hold no reference to
>> the instance being cleaned*. Maybe you didn't notice it's still there?
>>
>>
>> *// State class captures information necessary for cleanup.
>>
even more clear to those people who never read the javadoc
> *prose*.
>
> I have signed the OCA a while back as
> [hschreiber](https://openjdk.java.net/census#hschreiber).
Hendrik Schreiber has updated the pull request incrementally with one
additional commit since the last revision:
On Tue, 9 Nov 2021 00:31:36 GMT, Brent Christian wrote:
>> A cleaner can/should be shared within some scope and purpose, in this case
>> the example class .
>> Each cleaner has a dedicated Thread so its not a lightweight object and
>> should not be proliferated.
>> (Loom may be able to use Virt
On Mon, 8 Nov 2021 18:31:11 GMT, Anthony Vanelverdinghe
wrote:
>> Trivial improvement.
>>
>> Explicitly show how to create a `Cleaner` instance using `Cleaner.create()`.
>> Repeat (again) in the code example that the `State` `Runnable `should be
>> implemented as static class and not reference
On Fri, 5 Nov 2021 22:22:12 GMT, Mandy Chung wrote:
>> Trivial improvement.
>>
>> Explicitly show how to create a `Cleaner` instance using `Cleaner.create()`.
>> Repeat (again) in the code example that the `State` `Runnable `should be
>> implemented as static class and not reference the instanc
On Fri, 5 Nov 2021 10:13:47 GMT, Aleksey Shipilev wrote:
>> Trivial improvement.
>>
>> Explicitly show how to create a `Cleaner` instance using `Cleaner.create()`.
>> Repeat (again) in the code example that the `State` `Runnable `should be
>> implemented as static class and not reference the in
Trivial improvement.
Explicitly show how to create a `Cleaner` instance using `Cleaner.create()`.
Repeat (again) in the code example that the `State` `Runnable `should be
implemented as static class and not reference the instance to be cleaned, to
make the point even more clear to those people w
Jim,
if there isn’t a dedicated bug report for this (meaning: lack of optimization
for macOS), please do create one so that it at least is documented somewhere.
Thank you,
-hendrik
> On Jun 5, 2020, at 13:59, Jim Laskey wrote:
>
> I know there was a discussion about this elsewhere but I woul
15 matches
Mail list logo
