Re: RFR: 8243587: Missing comma in copyright header

LGTM — Igor > On Apr 26, 2020, at 7:14 PM, Kim Barrett wrote: > > Please review this fix for a missing comma in the copyright > header for > src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/DottedVersion.java. > > CR: > https://bugs.openjdk.java.net/browse/JDK-8243587

Re: RFR(XS): 8174768: Make ProcessTools print executed process output into a separate file

You can use %n in printf to get a system-specific newline. — Igor > On Apr 8, 2020, at 8:12 AM, Evgeny Nikitin wrote: > > Hi David, > > > > You can use printf rather than making a separate call to format. > > Good point, I've missed that method. I'll fix it and ask Igor to change > > the web

Re: RFR(S) : 8238943: switch to jtreg 5.0

Oh, I’m sorry I actually changed it to 5.0 when were (re)doing testing, and apparently forgot to replace the webrev, the right is http://cr.openjdk.java.net/~iignatyev//8238943/webrev.01 ; with version field value being the only difference b/w .00 and .01 Thanks, — Igor > On Feb 13, 2020, at 9

Re: RFR: JDK-8235453: tools/jpackage/junit/junit.java failed due to "module not found: jdk.incubator.jpackage"

As far as I can see only junit.java test is executed on Solaris and is the only one failing. jtreg uses @modules during test selection/filtering phase, so tests which have @modules A won’t be run on jdk which doesn’t have module A, hence it should be sufficient. If it’s not, we have a bug in jtr

Re: [JDK 14] RFR 8232922: Add java/math/BigInteger/largeMemory/SymmetricRangeTests.java to ProblemList-Xcomp

LGTM — Igor > On Oct 24, 2019, at 1:49 AM, Amy Lu wrote: > > java/math/BigInteger/largeMemory/SymmetricRangeTests.java > > Please review the patch to add above test to ProblemList-Xcomp.txt while > JDK-8232840 is being investigated/fixed. > > bug: https://bugs.openjdk.java.net/browse/JDK-82

Re: RFR: 8227642: [TESTBUG] Make docker tests podman compatible

We definitely should do it as a separate RFE, I meant to write it in my email, but was interrupted by a fire drill, and forgot about it when returned. — Igor > On Jul 17, 2019, at 6:38 PM, mikhailo.seledt...@oracle.com wrote: > > However, I would recommend to do this work as part of a new RFE.

Re: RFR (XS): 8225305: ProblemList java/lang/invoke/VarHandles tests

LGTM! — Igor > On Jun 4, 2019, at 7:29 PM, Mikael Vidstedt > wrote: > > > I, too, agree. :) > > New webrev which adds a new ProblemList-aot.txt to be used when running tests > with AOT. > > Webrev: > http://cr.openjdk.java.net/~mikael/webrevs/8225305/webrev.01/open/webrev/ > > Cheers, >