Re: JEP 330 class loader getResourceAsStream

On 8/27/18 10:51 AM, Peter Levart wrote: On 08/27/2018 04:47 PM, David Lloyd wrote: On Mon, Aug 27, 2018 at 9:41 AM Alan Bateman wrote: On 24/08/2018 18:27, David Lloyd wrote: Why not go ahead and implement getResource as well?  It's not *that* big of a deal to add a URL handler, and it

Re: JEP 330 class loader getResourceAsStream

This is now being tracked in JDK-8210009. https://bugs.openjdk.java.net/browse/JDK-8210009 -- Jon On 8/27/18 10:24 AM, seth lytle wrote: david lloyd wrote: AFAIK any code would expect that resources available as streams would generally also be available as URLs starting with java 9, the

Re: JVMInit function call - where is it located the source?

On 8/21/18 9:21 AM, mr rupplin wrote: Inside java.c there is a JLI_Launch which purports to be the launching or entry point for the JVM. The last line shows: return JVMInit(, threadStackSize, argc, argv, mode, what, ret); This is given apparently as a function call that will return an

Re: Deprecate java.io.File or at least some methods

I'd venture to suggest File is more widely used because it was around from the beginning, whereas Path is significantly more recent. Once you know to look on the Files API, using Path is generally easy and way preferable. -- Jon On 08/10/2018 08:23 AM, Stephen Colebourne wrote: From what I

Re: RFR 8208364: java/lang/reflect/callerCache/ReflectionCallerCacheTest.java missing module dependencies declaration

You might check the indentation of the modified lines. -- Jon On 08/06/2018 03:10 PM, mandy chung wrote: +1 Mandy On 8/6/18 1:51 PM, Alexandre (Shura) Iline wrote: Hi, Please taka a quick look on this fix: $ hg diff ---

Re: API for parsing path strings

.  There is an additional exception that can occur when creating a Path (InvalidPathException) and the caller may want to handle it individually. Adding another method that returns List is a straightforward addition. Keeping the string version may make adoption easier. Thanks, Roger On 7/23/18 1:53 PM, Jonathan

Re: API for parsing path strings

Roger, Having written internal library code for both javac and jtreg to do what you suggest, I would support such an API. I note that as well as parsing system properties, it would also be a useful API for command-line tools that accept paths as options. However, I would suggest that it is

Re: javac --release 11 not support by jdk 12

Remi, This should go to compiler-dev. It requires an update to make the historical data available for an earlier release. -- Jon On 07/13/2018 11:31 AM, Remi Forax wrote: There is a weird bug with javac of jdk 12. /usr/jdk/jdk-12/bin/javac --release 11 error: release version 11 not

Re: RFR(JDK12/JAXP/java.xml) 8194680: StartElement#getAttributes and getNamespaces refer to incorrect package

On 7/10/18 4:27 PM, Joe Wang wrote: Hi, Please review a javadoc fix for a couple of incorrect references to the javax.xml.stream package. Attribute and Namespace are both in the javax.xml.stream.events, and so is StartElement where they are referenced. JBS:

Re: [PATCH] AbstractStringBuilder.append()

In that specific snippet, I would expect the compiler (javac) to fold the constants together. -- Jon On 06/29/2018 01:02 PM, Isaac Levy wrote: Would this snippet end up merging two StringBuilders? String x = "bar" + "foo"; x += "baz" + "biz"; I had trouble reading stringopts.cpp. I was

RFR: 8205438: Re-enable shebang tests in test/jdk/tools/launchers/SourceMode.java

Please review a test fix to re-enable shebang tests in test/jdk/tools/launchers/SourceMode.java . The test cases for invoking the source launcher via the shebang mechanism have been disabled because they were adversely affected by the very long pathnames on our internal test infastructure,

RFR: JDK-8204588: Test failures after "Launch Single-File Source-Code Programs"

Please review two test fixes related to the source launcher feature. In one test, the fix is to use File.separator to construct "golden output" for comparison. In the other test, the failure was caused by excessively long paths to the Java launcher in some test execution environments,

Re: (XS) Review Request JDK-8204584: jdeps generates illegal dot file containing ranksep=0,600000

Looks OK to me. -- Jon On 06/07/2018 04:06 PM, mandy chung wrote: The dot files are generated and used as module graph in the docs build. The format of double should use no localization; otherwise an illegal ranksep attribute. Mandy diff --git

Re: Locale languageTag anomaly

;no", country "NO", and variant "NY", representing Norwegian Nynorsk (Norway), is converted to a language tag "nn-NO". --- So in short, that is the expected behavior. Naoto On 6/7/18 2:19 PM, Jonathan Gibbons wrote: Regarding Locale.toLanguageTag, Locale.forLanguageT

Locale languageTag anomaly

Regarding Locale.toLanguageTag, Locale.forLanguageTag Should I be surprised (i.e. is it a bug) that out of 736 installed locales in a standard build of JDK, exactly 1 locale fails the following round-trip test: locale.equals(Locale.forLanguageTag(locale.toLanguageTag())) The locale

Re: RFR: 8201274: Launch Single-File Source-Code Programs

/browse/JDK-8201274 CSR: https://bugs.openjdk.java.net/browse/JDK-8201275 Webrev: http://cr.openjdk.java.net/~jjg/8201274/webrev.mq/ -- Jon [1] http://mail.openjdk.java.net/pipermail/jdk-dev/2018-May/001248.html On 04/12/2018 01:15 PM, Jonathan Gibbons wrote: Please review an initial implementation for th

Re: RFR: 8201274: Launch Single-File Source-Code Programs

be: or java [options] [args] (to launch a single-file source-codeprogram) to be consistent with the rest of the usage text? -Jaikiran On 05/05/18 3:29 AM, Jonathan Gibbons wrote: Here's an update to the previously proposed patch for JEP 330: Launch Single-File Source-Code Programs

Re: RFR: 8201274: Launch Single-File Source-Code Programs

is in place. -- Jon On 04/12/2018 01:15 PM, Jonathan Gibbons wrote: Please review an initial implementation for the feature described in JEP 330: Launch Single-File Source-Code Programs. The work is described in the JEP and CSR, and falls into various parts: * The part to handle the new

Re: RFR(JDK11/NIO) 8202285: (fs) Add a method to Files for comparing file contents

At the risk of triggering a #bikeshed on the relative merits of "content" vs. "contents", I note that String has put a stake in the ground for the singular form, with contentEquals. https://docs.oracle.com/javase/9/docs/api/java/lang/String.html#contentEquals-java.lang.CharSequence- -- Jon

Re: RFR: 8201274: Launch Single-File Source-Code Programs

ed at the launcher tests, very nice. Thanks Kumar On 4/12/2018 1:15 PM, Jonathan Gibbons wrote: Please review an initial implementation for the feature described in JEP 330: Launch Single-File Source-Code Programs. The work is described in the JEP and CSR, and falls into various parts:

Re: JDK 11 RFR of 8200478: For boxing conversion javac uses Long.valueOf which does not guarantee caching according to its javadoc

Joe, While I note that the primary text has been modified to include long types, the italic comment that follows still ends with the following: Notice that integer literals of type|long|are allowed, but not required, to be shared. -- Jon On 4/25/18 8:18 AM, joe darcy wrote: Hi David,

Re: RFR: 8201274: Launch Single-File Source-Code Programs

On 04/12/2018 10:20 PM, mandy chung wrote: On 4/13/18 4:15 AM, Jonathan Gibbons wrote: Please review an initial implementation for the feature described in JEP 330: Launch Single-File Source-Code Programs. The work is described in the JEP and CSR, and falls into various parts: * The part

RFR: 8201274: Launch Single-File Source-Code Programs

Please review an initial implementation for the feature described in JEP 330: Launch Single-File Source-Code Programs. The work is described in the JEP and CSR, and falls into various parts: * The part to handle the new command-line options is in the native Java launcher code. * The part

Re: RFR: 8178867: tools/jlink/multireleasejar/JLinkMultiReleaseJarTest.java failed to clean up files

+1 On 4/10/18 11:44 AM, Andrey Nazarov wrote: Anyone? On 6 Apr 2018, at 17:10, Andrey Nazarov wrote: Hi, Please review fix in Jlink test. The fix is to close the Stream which works with a file system. Review:

Re: RFR: 8200888: typo in name of exception in @throws

with @throws :-) -Joe On 4/4/2018 5:21 PM, Jonathan Gibbons wrote: Please review this tiny fix to a typo in the name of an exception in @throws: No webrev; here's the change: NullPointerExcpetion -> NullPointerException diff -r 3930c4d4f805 src/java.base/share/classes/java/t

RFR: 8200888: typo in name of exception in @throws

Please review this tiny fix to a typo in the name of an exception in @throws: No webrev; here's the change: NullPointerExcpetion -> NullPointerException diff -r 3930c4d4f805 src/java.base/share/classes/java/text/ChoiceFormat.java --- a/src/java.base/share/classes/java/text/ChoiceFormat.java

RFR: 8200664: fix broken links in java.base docs

Please review a small update to fix some broken links in the java.base API docs. The change is necessary because when generating HTML 5 output, javadoc no longer has to encode method signatures into the restricted set of characters available in HTML 4 names. JBS:

Re: Clean-room implementation of Double::toString(double) and Float::toString(float)

On 03/30/2018 01:42 PM, Brian Burkhalter wrote: Per the JDK 11 schedule [5] there could well be sufficient time to run this submission through the review processes. I suggest, once your OCA has been processed, to proceed by posting your proposed changes for review on this mailing list. Note

Re: RFR: {@docRoot} reference need to be updated to reflect new module structure

On 3/27/18 9:07 AM, Martin Buchholz wrote: On Tue, Mar 27, 2018 at 8:34 AM, Jonathan Gibbons <jonathan.gibb...@oracle.com <mailto:jonathan.gibb...@oracle.com>> wrote: On 3/27/18 8:30 AM, Martin Buchholz wrote: On Tue, Mar 27, 2018 at 2:00 AM, Alan Bateman

Re: RFR: {@docRoot} reference need to be updated to reflect new module structure

On 3/27/18 8:30 AM, Martin Buchholz wrote: On Tue, Mar 27, 2018 at 2:00 AM, Alan Bateman <alan.bate...@oracle.com <mailto:alan.bate...@oracle.com>> wrote: On 27/03/2018 01:01, Jonathan Gibbons wrote: This is fixing up some links in the java.base module,

RFR: {@docRoot} reference need to be updated to reflect new module structure

This is fixing up some links in the java.base module, following a recent change in javadoc to the organization of the generated files. While the change was mostly transparent, links within the documentation using {@docRoot} need to be updated. All the changes were done automatically, by the

Re: RFR (JDK11/doc-only) 8199176: Accessibility issues in java.base docs

On 3/21/18 2:28 PM, Alan Bateman wrote: On 21/03/2018 19:08, Joe Wang wrote: : *Item 3*: Heading leavels should only increase by one     This is due to the javadoc tool generates a header with an addition of headings, in this particular case, . The fix for this particular case is to

Re: [11] [PATCH] 9053056: Anchor name conflict in ClassLoader JavaDoc

On 3/21/18 2:18 PM, Martin Buchholz wrote: On Wed, Mar 21, 2018 at 1:59 PM, Jonathan Gibbons <jonathan.gibb...@oracle.com <mailto:jonathan.gibb...@oracle.com>> wrote: I think that maybe we should establish a convention such that user-defined anchors can ne

Re: [11] [PATCH] 9053056: Anchor name conflict in ClassLoader JavaDoc

On 03/21/2018 01:39 PM, mandy chung wrote: On 3/21/18 10:26 AM, David Lloyd wrote: I see it with IntelliJ IDEA when I pop up "quick JavaDoc" on, say, defineClass and then click on "binary name"; it's actually using the sources, rather than generated JavaDoc. I don't object to do this

Re: RFR 8199616: Fix @module declarations in tier1 tests

Martin, I have been following this work that Shura is doing. The checks are fairly expensive, and we would not want to perform them during routine test execution. However, one option would be to include a separate binary in the jtreg family, that can be run separately. There are no plans

Re: Bug in javac release flag?

Forwarding to compiler-dev, which is a better place to discuss this issue. -- Jon On 1/22/18 7:11 AM, Stephen Colebourne wrote: I think I have a problem with the java release flag, reported by a user here: https://github.com/ThreeTen/threeten-extra/issues/91 The particular case that is a

Re: RFR(XXS) : 8195067 : problem list tools/javac/jvm/VerboseOutTest.java

OK. Sorry for the bad test. -- Jon On 01/12/2018 02:29 PM, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8195067/webrev.00/index.html 2 lines changed: 1 ins; 0 del; 1 mod; Hi all, could you please review this tiny fix which put tools/javac/jvm/VerboseOutTest.java into the

Re: 8193758: Update copyright headers of files in src tree that are missing "Classpath" exception

OK for JavacTaskPool. -- Jon On 12/18/17 12:00 PM, Alan Bateman wrote: There are a small number of files in jdk/jdk10 that have the GPL header rather than the GPL and "Classpath" exception. This came up last week on jdk-dev. I need a Reviewer to adjust these files. The webrev with the

Re: RFR 4358774: Add null InputStream and OutputStream

"null" is a significant term in the Java ecosystem, and the relationship here, to /dev/null or NUL seems somewhat tenuous. Have any other names been considered?  At least for the InputStream, calling it an "empty stream" seems more intuitive than a "null stream". -- Jon On 12/6/17 11:00

Re: RFR (JDK10/JAXP) 8191938: Fix lint warnings in JAXP repo: a few Deprecation warrnings and enable -Xlint:all

Joe, I presume javadoc is OK with this not-quite-a-doc-comment-tag, when you do "make docs" ... -- Jon On 11/29/2017 10:58 AM, Joe Wang wrote: Hi Joe, I moved the LastModified to the bottom of the class comment block. Please let me know what you think:

Re: RFR 8191736: replace javah w/ javac in jdk tests

Shura, Looks OK to me, although I'm not normally a Reviewer for AWT tests. -- Jon On 11/21/17 3:58 PM, Alexandre (Shura) Iline wrote: Hi. Please take look on this quick fix of removing remains of javah usages from test/jdk. Bug: https://bugs.openjdk.java.net/browse/JDK-8191736 Webrev:

Re: RFR: 8189102: All tools should support -?, -h and --help

We are already in a hybrid world of old-style and new-style options :-( All the new module-related options added in JDK 9 are "new style", following the guidelines of JEP 293. It does not make sense to add "--" to some of the older tools, that may be going away at some point, and while we

Re: RFR: 8189102: All tools should support -?, -h and --help

On 11/18/17 12:41 AM, Alan Bateman wrote: A question for Jon Gibbons: In JEP 293 the guideline is that tools should support `--help`. Do you think this should be expanded to include `-help`, and `-?` (and maybe `-h` where it make sense)? I think we should standardize on --help, and -h

Re: RFR: 8189102: All tools should support -?, -h and --help

Goetz, I understand why you might want to ensure that a basic set of help options is supported, but I don't understand why that justifies removing older options, like "-help" for many tools. In addition, I notice the CSR says: *Compatibility Risk Description:*

Re: [10] RFR of JDK-8173411: Some testng tests check nothing in java time

FWIW, this is a side-effect of taking jtreg having to take some corner cases into account when determining what are "jtreg" tests in a hierarchy of TestNG tests. The underlying problem is that there is no easy reliable way to determine if a source file contains test cases or if it is just a

Re: RFR (XS) 8188828 Intermittent ClassNotFoundException: jdk.test.lib.Platform for compiler tests

Another possibility is to design the libraries so that they can be built with a wildcard build, as in @build mypackage.* I don't see that we will (or want to) ever get to a point in jtreg where each library class can identify its own dependencies, such as suggested below. If the libraries

Update: Re: RFR: JDK-8186946: Fix accessibility and other issues in the java.xml.bind module

if necessary. -- Jon On 09/01/2017 01:34 PM, Jonathan Gibbons wrote: Please review these changes to address accessibility and other minor issues in the API docs for the java.xml.bind module. JBS: https://bugs.openjdk.java.net/browse/JDK-8186946 Webrev: http://cr.openjdk.java.net/~jjg/8186946/webrev

RFR: JDK-8186946: Fix accessibility and other issues in the java.xml.bind module

Please review these changes to address accessibility and other minor issues in the API docs for the java.xml.bind module. JBS: https://bugs.openjdk.java.net/browse/JDK-8186946 Webrev: http://cr.openjdk.java.net/~jjg/8186946/webrev API:

RFR: JDK-8186947: Fix accessibility and other issues in the java.xml.ws module

Please review this small change to fix a broken link in the API docs for the java.xml.ws module. Although I've also posted a full webrev and API, the change is more easily seen here: --- old/src/java.xml.ws/share/classes/javax/xml/ws/wsaddressing/W3CEndpointReferenceBuilder.java

Re: RFR: JDK-8186924: Fix accessibility and other HTML issues in java.corba module

Thanks. I'll tweak the caption. -- Jon On 08/31/2017 02:45 PM, mandy chung wrote: On 8/29/17 11:42 AM, Jonathan Gibbons wrote: Please review these mostly simple changes to address some accessibility and other minor HTML issues in the java.corba module. JBS: https://bugs.openjdk.java.net

RFR: JDK-8187021: Remove 2 redundant tags in java.base API docs

Please review this small fix to remove two redundant tags from the java.base API docs. This fix will address the remaining issues reported by tidy for this module. JBS: https://bugs.openjdk.java.net/browse/JDK-8187021 No webrev; here is the patch: $ hg diff -R jdk diff -r 5a28f7ef36da

RFR: JDK-8186934: Fix accessibility issues in the java.naming module

Please review a simple fix for accessibility issues in a file in the java.naming module. JBS: https://bugs.openjdk.java.net/browse/JDK-8186934 Webrev: http://cr.openjdk.java.net/~jjg/8186934/webrev.00/ API: http://cr.openjdk.java.net/~jjg/8186934/api.00/javax/naming/CompositeName.html Two

RFR: JDK-8186924: Fix accessibility and other HTML issues in java.corba module

Please review these mostly simple changes to address some accessibility and other minor HTML issues in the java.corba module. JBS: https://bugs.openjdk.java.net/browse/JDK-8186924 Webrev: http://cr.openjdk.java.net/~jjg/8186924/webrev.00/ API:

Re: RFR: JDK-8186684: Fix broken links in java.base API docs

Fixed broken link in Configuration.java Webrev: http://cr.openjdk.java.net/~jjg/8186684/webrev.02/index.html API: http://cr.openjdk.java.net/~jjg/8186684/api.02/overview-summary.html -- Jon On 08/23/2017 04:16 PM, mandy chung wrote: On 8/23/17 4:02 PM, Jonathan Gibbons wrote: Removed

Re: RFR: JDK-8186684: Fix broken links in java.base API docs

fix it separately by renaming the private add method. On Wed, Aug 23, 2017 at 3:17 PM, Jonathan Gibbons <jonathan.gibb...@oracle.com <mailto:jonathan.gibb...@oracle.com>> wrote: On 08/23/2017 03:12 PM, Martin Buchholz wrote: On Wed, Aug 23, 2017 at 3:04 PM, Jona

Re: RFR: JDK-8186684: Fix broken links in java.base API docs

Martin, Understood. Do you want to file a followup JBS issue, or shall I? -- Jon On 08/23/2017 03:29 PM, Martin Buchholz wrote: Jon, please just drop ArrayDeque. We'll fix it separately by renaming the private add method. On Wed, Aug 23, 2017 at 3:17 PM, Jonathan Gibbons <jonathan.g

Re: RFR: JDK-8186684: Fix broken links in java.base API docs

On 08/23/2017 03:16 PM, Martin Buchholz wrote: On Wed, Aug 23, 2017 at 3:04 PM, Jonathan Gibbons <jonathan.gibb...@oracle.com <mailto:jonathan.gibb...@oracle.com>> wrote: javadoc is at fault for not giving the warning, and if we fixed the tool first, we wo

Re: RFR: JDK-8186684: Fix broken links in java.base API docs

On 08/23/2017 03:12 PM, Martin Buchholz wrote: On Wed, Aug 23, 2017 at 3:04 PM, Jonathan Gibbons <jonathan.gibb...@oracle.com <mailto:jonathan.gibb...@oracle.com>> wrote: Although it is not immediately clear in the webrev, the underlying characteristic of all places

Re: RFR: JDK-8186684: Fix broken links in java.base API docs

Hi Martin, On 08/23/2017 02:41 PM, Martin Buchholz wrote: I would be inclined to "fix the tool first" if it's not too hard. Both should be fixed. Going back in time, the spec has long said: http://docs.oracle.com/javase/7/docs/technotes/tools/windows/javadoc.html#specifyingname If any

RFR: JDK-8186684: Fix broken links in java.base API docs

Please review a reasonably simple patch to fix most of the broken links in the API docs for java.base module. All the fixes are in the small "typo" category, and so should not materially affect the specification. I've provided a copy of the API, in case folk want to test the updated links.

Re: RFR: JDK-8186466: Fix accessibility and other minor issues in java.base

On 08/22/2017 01:54 PM, mandy chung wrote: On 8/18/17 5:03 PM, Jonathan Gibbons wrote: Please review these fixes for various minor documentation issues in the java.base module. I reviewed the following files and the other files are already covered by Naoto and Martin. Here are more

Re: RFR: JDK-8186466: Fix accessibility and other minor issues in java.base

On 08/21/2017 09:38 AM, Jonathan Gibbons wrote: On 8/20/17 4:11 PM, Martin Buchholz wrote: Again, I am happy to take the current state of this change. On Sat, Aug 19, 2017 at 2:19 PM, Jonathan Gibbons <jonathan.gibb...@oracle.com <mailto:jonathan.gibb...@oracle.com>

Re: RFR: JDK-8186466: Fix accessibility and other minor issues in java.base

On 8/21/17 9:46 AM, Martin Buchholz wrote: On Mon, Aug 21, 2017 at 9:38 AM, Jonathan Gibbons <jonathan.gibb...@oracle.com <mailto:jonathan.gibb...@oracle.com>> wrote: On 8/20/17 4:11 PM, Martin Buchholz wrote: Again, I am happy to take the current state of

Re: RFR: JDK-8186466: Fix accessibility and other minor issues in java.base

On 8/20/17 4:11 PM, Martin Buchholz wrote: Again, I am happy to take the current state of this change. On Sat, Aug 19, 2017 at 2:19 PM, Jonathan Gibbons <jonathan.gibb...@oracle.com <mailto:jonathan.gibb...@oracle.com>> wrote: Actually, thead and tbody have no direct

Re: RFR: JDK-8186466: Fix accessibility and other minor issues in java.base

On 8/19/17 11:55 AM, Martin Buchholz wrote: I don't know how hard it would be to make the header rows in BlockingDeque presented like the ones in e.g. Deque. Deque uses striped thead, which gets the #DDD background from the stylesheet. And having s is probably itself an accessibility

Re: RFR: JDK-8186466: Fix accessibility and other minor issues in java.base

On 8/19/17 12:04 PM, Martin Buchholz wrote: can one do something like ? Not the way the styles are currently set up. The style was set up so that you just have to declare the table to be striped, and the contents follow suit. This avoids having to declare a class on all the nodes in

Re: RFR: JDK-8186466: Fix accessibility and other minor issues in java.base

r text is centered". 139 * Insert I might have chosen centered here as well. I'll make those two changes for you. On Sat, Aug 19, 2017 at 9:10 AM, Jonathan Gibbons <jonathan.gibb...@oracle.com <mailto:jonathan.gibb...@oracle.com>> wrote: On 8/18/17 6:35 PM, Martin

Re: RFR: JDK-8186466: Fix accessibility and other minor issues in java.base

On 8/18/17 6:35 PM, Martin Buchholz wrote: Thanks as usual for the modern html lessons. Looks good. Things I wonder about: - I expected to find scope= attributes in BlockingDeque.java tables. TIL about colgroup and rowgroup. (or does headers=... make that redundant?) - I see "font-style:

Re: RFR: JDK-8186466: Fix accessibility and other minor issues in java.base

java.class * Locale(""), java.properties (In my mail client, that looks like a bulleted list; I don't know how well it will travel through the mail system.) -- Jon Naoto On 8/18/17 5:03 PM, Jonathan Gibbons wrote: Please review these fixes for various minor do

RFR: JDK-8186466: Fix accessibility and other minor issues in java.base

Please review these fixes for various minor documentation issues in the java.base module. The changes are mostly in java.util and its subpackages, but there is some minor cleanup in previously updated packages as well. The primary focus is on addressing accessibility issues. In addition, some

RFR: JDK-8186156: Fix a11y and HTML issues in java.net and javax.net packages

Please review the following fix for accessibility and HTML issues in the java.net and javax.net packages. The only edit of note is that a table was simply removed from the top of URLConnection. The table was an "HTML art" depiction of actions on a timeline, complete with an ASCII-art time

Re: RFR: JDK-8186153, , Fix a11y and HTML issues in the java.math, java.text and java.time packages

On 08/11/2017 01:32 PM, Lance Andersen wrote: Hi Jon On Aug 11, 2017, at 3:10 PM, Jonathan Gibbons <jonathan.gibb...@oracle.com <mailto:jonathan.gibb...@oracle.com>> wrote: Lance, I was in two minds about changing the layout of the columns in RoundingMode. It can sometimes har

Re: RFR: JDK-8186153, , Fix a11y and HTML issues in the java.math, java.text and java.time packages

/ for some value of N -- Jon On 08/11/2017 11:44 AM, Lance Andersen wrote: Hi Jon, Looks OK overall Any thoughts on centering some of the column values such as in RoundingMode at some point? DateTimeFormatter looks much nicer :-) Best Lance On Aug 11, 2017, at 2:28 PM, Jonath

RFR: JDK-8186153, , Fix a11y and HTML issues in the java.math, java.text and java.time packages

Please review the following changes to fix accessibility and HTML issues in the java.math, java.text and java.time packages. Mostly, it's "more of the same", setting scope=row|col on tables. One bigger change is in DateTimeFormatter, to change a preformatted ASCII table into a standard HTML

Re: RFR: JDK-8186052: Fix a11y and HTML issues in the java.base/java.lang[.*] packages

Update: addresses Stuart's comment for String.split Webrev: http://cr.openjdk.java.net/~jjg/8186052/webrev.01/index.html API: http://cr.openjdk.java.net/~jjg/8186052/api.01/index.html -- Jon On 08/09/2017 06:28 PM, Stuart Marks wrote: On 8/9/17 5:11 PM, Jonathan Gibbons wrote: Please review

Re: RFR: JDK-8185994: Fix a11y and HTML issues in the java.base/java.io and java.base/java.nio packages

Ooops ... forgot the updated links: Webrev: http://cr.openjdk.java.net/~jjg/8185994/webrev.01/index.html API: http://cr.openjdk.java.net/~jjg/8185994/api.01/index.html -- Jon On 08/10/2017 01:59 PM, Jonathan Gibbons wrote: I have posted an update to the webrev and API. The change

Re: RFR: JDK-8185994: Fix a11y and HTML issues in the java.base/java.io and java.base/java.nio packages

correctness issues. -- Jon On 08/10/2017 01:00 PM, Brian Burkhalter wrote: On Aug 9, 2017, at 6:56 PM, Stuart Marks <stuart.ma...@oracle.com <mailto:stuart.ma...@oracle.com>> wrote: On 8/9/17 5:14 PM, Jonathan Gibbons wrote: Please review this proposed change to address a

Re: RFR: JDK-8186052: Fix a11y and HTML issues in the java.base/java.lang[.*] packages

On 08/09/2017 06:28 PM, Stuart Marks wrote: On 8/9/17 5:11 PM, Jonathan Gibbons wrote: Please review this proposed change to address accessibility and HTML issues in the java.base java.lang[.*] packages. In general, the changes consist of * update tables to add scope=row|col as appropriate

RFR: JDK-8185994: Fix a11y and HTML issues in the java.base/java.io and java.base/java.nio packages

Please review this proposed change to address accessibility and HTML issues in the java.base java.io and java.nio[.*] packages. In general, the changes consist of * update tables to add scope=row|col as appropriate. In some cases, slightly more surgery was needed on the table * fix issues

RFR: JDK-8186052: Fix a11y and HTML issues in the java.base/java.lang[.*] packages

Please review this proposed change to address accessibility and HTML issues in the java.base java.lang[.*] packages. In general, the changes consist of * update tables to add scope=row|col as appropriate. In some cases, slightly more surgery was needed on the table * fix issues reported by

Greek characters in java.lang.String

The method String.toLowerCase(Locale) contains some Greek letters in its doc comment. But the characters are presented with images, instead of native Unicode characters. See http://download.java.net/java/jdk9/docs/api/java/lang/String.html#toLowerCase-java.util.Locale- Has the time come to

RFR: JDK-8185984: fix a11y and html issues in java.logging module

Please review a few small changes for accessibility and HTML issue in the API docs for the java.logging module. JBS: https://bugs.openjdk.java.net/browse/JDK-8185984 Webrev: http://cr.openjdk.java.net/~jjg/8185984/webrev.00/ -- Jon

RFR: JDK-8185758: jdk.smartcardio has broken docs for exceptions

(I'm not sure if there is a better list for this request, but the request is so simple, I'm hoping it will be sufficient. Please review this very simple fix to replace two uses of ... with {@code...}. The underlying problem being fixed is incorrect handling of the first sentence in a couple

Re: RFR: JDK-8185669: Doc issues in assorted small jdk.* modules

the actual HTML. Brian On Aug 1, 2017, at 1:22 PM, Jonathan Gibbons <jonathan.gibb...@oracle.com> wrote: Please review another small set of doc fixes in some minor jdk.* modules. JBS: https://bugs.openjdk.java.net/browse/JDK-8185669 Webrev: http://cr.openjdk.java.net/~jjg/8185669/web

RFR: JDK-8185669: Doc issues in assorted small jdk.* modules

Please review another small set of doc fixes in some minor jdk.* modules. JBS: https://bugs.openjdk.java.net/browse/JDK-8185669 Webrev: http://cr.openjdk.java.net/~jjg/8185669/webrev.00/ -- Jon

Re: RFR: JDK-8185464: Link issues in java.xml module

On 07/27/2017 04:58 PM, huizhe wang wrote: Looks good to me too. A side issue, the 'fixedNav' block is preventing the browser from showing the exact content of an inner anchor, the Nav section covers that much of content as its height. If I click on the link to CatalogFeatures.html#PREFER

Re: RFR: JDK-8185464: Link issues in java.xml module

/27/2017 01:49 PM, Lance Andersen wrote: Hi Jon, Overall it looks good. Maybe it is my browser, but I do not see the Author tag in the DataType package summary though it is there in JDK 8 and looks like it should still display unless I am missing something… Best Lance On Jul 27, 2017,

RFR: JDK-8185464: Link issues in java.xml module

Continuing the documentation cleanup: Please review the following simple changes to the API documentation for the java.xml module, to address issues with links in these files. Some missing ids have been declared as appropriate. The issue with a mailto: link in the public API to an obsolete

RFR: JDK-8185359: Unnecessary in module doc comment

Continuing the ongoing docs cleanup, please review this fix to remove a superfluous in the docs for the java.scripting module. No webrev; just one line deleted, as shown here: $ hg diff -R jdk diff -r d93f2fd542b7 src/java.scripting/share/classes/module-info.java ---

RFR: JDK-8184217: Redundant tag before list

Please review a small fix to the documentation for the java.rmi module. No webrev; here is the patch to remove an unnecessary line: $ hg diff -R jdk diff -r 13119f57b8da src/java.rmi/share/classes/module-info.java --- a/src/java.rmi/share/classes/module-info.javaMon Jul 24 10:18:33 2017

Re: RFR: 8185150: javax/activation/CommandInfo.html has empty

Thanks, Lance. -- Jon On 07/24/2017 01:16 PM, Lance Andersen wrote: +1 On Jul 24, 2017, at 4:07 PM, Jonathan Gibbons <jonathan.gibb...@oracle.com <mailto:jonathan.gibb...@oracle.com>> wrote: Please review a trivial fix to remove a superfluous in a javadoc comment. No

RFR: 8185150: javax/activation/CommandInfo.html has empty

Please review a trivial fix to remove a superfluous in a javadoc comment. No webrev; here is the patch: $ hg diff -R jaxws diff -r 97e67df03f88 src/java.activation/share/classes/javax/activation/CommandInfo.java --- a/src/java.activation/share/classes/javax/activation/CommandInfo.java Thu

Re: RFR: 8184311: Update java.sql and java.sql.rowset API docs for accessibility

Thanks, Lance -- Jon On 7/13/17 3:20 AM, Lance Andersen wrote: looks fine Jon On Jul 12, 2017, at 10:06 PM, Jonathan Gibbons <jonathan.gibb...@oracle.com <mailto:jonathan.gibb...@oracle.com>> wrote: Please review ... More noreg-doc API cleanup for accessibility, etc

RFR: 8184311: Update java.sql and java.sql.rowset API docs for accessibility

Please review ... More noreg-doc API cleanup for accessibility, etc. This time for java.sql and java.sql.rowset. One of the tables ought to be restructured a bit, because there is no single unique column to use for a rowheader, but that is a bigger change than I want to do in this round of

RFR: 8184304: make tables in jdk.sctp module accessible

Continuing the work to improve the accessibility and markup of our docs, please review a small update to make the tables in the jdk.sctp module accessible. JBS: https://bugs.openjdk.java.net/browse/JDK-8184304 Webrev: http://cr.openjdk.java.net/~jjg/8184304/webrev.00/index.html API:

Re: RFR: 8184208: update class="striped" tables for accessibility

On 07/11/2017 04:02 PM, Brian Burkhalter wrote: On Jul 11, 2017, at 2:39 PM, Jonathan Gibbons <jonathan.gibb...@oracle.com <mailto:jonathan.gibb...@oracle.com>> wrote: Please review this auto-generated update to improve the accessibility of many of the tables in

RFR: 8184208: update class="striped" tables for accessibility

Please review this auto-generated update to improve the accessibility of many of the tables in the API docs for the java.base module. The changes are just to the HTML markup for selected tables; there is no change to the wording of any documentation. This update was generated by a utility

Re: RFR: 8184021: Fix tables in jaxp doc comments to be accessible

need to re-generate the webrevs. Thanks, Joe On 7/10/2017 3:52 PM, Jonathan Gibbons wrote: Here is the amended webrev for the work on fixing the tables (and other nits) in the jaxp docs. As we discussed, I changed the two manually edited tables, in CatalogFeatures and XMLStreamWriter,

Re: RFR: 8184021: Fix tables in jaxp doc comments to be accessible

-8183984 Finally, I fixed one more excess , in XMLReaderFactory. As a result of all this, the java.xml module gets a clean bill of documentary health, for all the checks we are currently tracking. -- Jon On 07/08/2017 09:58 AM, Jonathan Gibbons wrote: Joe, Thanks for the feedback. I've done

Re: RFR: 8184021: Fix tables in jaxp doc comments to be accessible

ceURI bound 54 * namespaceURI unbound add scope="row" to the first column of the rows in the body. Would that make sense? Thanks, Joe On 7/7/2017 2:53 PM, Jonathan Gibbons wrote: Sorry, I meant to include that; will post shortly, beside the webrev. -- Jon On 07/07/2017 01:33 PM, Lance A

<    1   2   3   4   5   6   7   8   9   >