hg: jdk8/tl/langtools: 6921494: provide way to print javac tree tag values

2011-11-08 Thread jonathan . gibbons
Changeset: ca49d50318dc Author:jjg Date: 2011-11-08 11:51 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ca49d50318dc 6921494: provide way to print javac tree tag values Reviewed-by: jjg, mcimadamore Contributed-by: vicent...@yahoo.es !

hg: jdk8/tl/langtools: 7104039: refactor/cleanup javac Paths class

2011-10-25 Thread jonathan . gibbons
Changeset: d830d28fc72e Author:jjg Date: 2011-10-25 10:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d830d28fc72e 7104039: refactor/cleanup javac Paths class Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/apt/main/Main.java !

hg: jdk8/tl/langtools: 7101146: Paths should more directly managed by BaseFileManager

2011-10-19 Thread jonathan . gibbons
Changeset: d2cbb77469ed Author:jjg Date: 2011-10-19 15:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d2cbb77469ed 7101146: Paths should more directly managed by BaseFileManager Reviewed-by: mcimadamore !

hg: jdk8/tl/langtools: 7075721: javac should have public enum for exit codes

2011-09-22 Thread jonathan . gibbons
Changeset: 497571d34112 Author:jjg Date: 2011-09-22 09:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/497571d34112 7075721: javac should have public enum for exit codes Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/Main.java !

hg: jdk8/tl/langtools: 7092965: javac should not close processorClassLoader before end of compilation

2011-09-21 Thread jonathan . gibbons
Changeset: b0d5f00e69f7 Author:jjg Date: 2011-09-21 21:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b0d5f00e69f7 7092965: javac should not close processorClassLoader before end of compilation Reviewed-by: darcy !

hg: jdk8/tl/langtools: 7030473: Remove dead field JCCompilationUnit.flags

2011-09-20 Thread jonathan . gibbons
Changeset: ac964af3b5e7 Author:jjg Date: 2011-09-20 12:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ac964af3b5e7 7030473: Remove dead field JCCompilationUnit.flags Reviewed-by: dlsmith ! src/share/classes/com/sun/tools/javac/tree/JCTree.java

hg: jdk8/tl/langtools: 7091528: javadoc attempts to parse .class files

2011-09-16 Thread jonathan . gibbons
Changeset: dea82aa3ca4f Author:jjg Date: 2011-09-16 16:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/dea82aa3ca4f 7091528: javadoc attempts to parse .class files Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/JavadocTool.java +

hg: jdk8/tl/langtools: 7080267: Call to toString() from an ExpressionStatementTree doesn't take in consideration the ; at the end

2011-09-14 Thread jonathan . gibbons
Changeset: 0f3da6af9799 Author:jjg Date: 2011-09-14 12:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0f3da6af9799 7080267: Call to toString() from an ExpressionStatementTree doesn't take in consideration the ; at the end Reviewed-by: mcimadamore !

hg: jdk8/tl/langtools: 7090249: IllegalStateException from Trees.getScope when called from JSR 199

2011-09-14 Thread jonathan . gibbons
Changeset: 1807fc3fd33c Author:jjg Date: 2011-09-14 12:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1807fc3fd33c 7090249: IllegalStateException from Trees.getScope when called from JSR 199 Reviewed-by: mcimadamore !

hg: jdk8/tl/langtools: 7090700: fix for 7080267 breaks two tests

2011-09-14 Thread jonathan . gibbons
Changeset: a6e2c1840ea1 Author:jjg Date: 2011-09-14 15:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a6e2c1840ea1 7090700: fix for 7080267 breaks two tests Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javac/tree/JCTree.java

hg: jdk8/tl/langtools: 7068437: Regression: Filer.getResource(SOURCE_OUTPUT, ...) no longer works in JDK 7 w/o -s

2011-09-14 Thread jonathan . gibbons
Changeset: 826ae6a2f27d Author:jjg Date: 2011-09-14 18:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/826ae6a2f27d 7068437: Regression: Filer.getResource(SOURCE_OUTPUT, ...) no longer works in JDK 7 w/o -s Reviewed-by: darcy !

hg: jdk8/tl/langtools: 2 new changesets

2011-09-12 Thread jonathan . gibbons
Changeset: edd7d9bd32dd Author:jjg Date: 2011-09-12 11:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/edd7d9bd32dd 7068451: Regression: javac compiles fixed sources against previous, not current, version of generated sources Reviewed-by: mcimadamore !

hg: jdk8/tl/langtools: 7073508: Regression: NullPointerException at com.sun.tools.javac.code.Lint$AugmentVisitor.augment

2011-09-09 Thread jonathan . gibbons
Changeset: 1ee9f9a91e9c Author:jjg Date: 2011-09-09 17:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1ee9f9a91e9c 7073508: Regression: NullPointerException at com.sun.tools.javac.code.Lint$AugmentVisitor.augment Reviewed-by: darcy !

hg: jdk8/tl/jdk: 7077389: Reflection classes do not build with javac -Xlint:all -Werror

2011-08-17 Thread jonathan . gibbons
Changeset: e59aad6ed600 Author:jjg Date: 2011-08-15 17:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e59aad6ed600 7077389: Reflection classes do not build with javac -Xlint:all -Werror Reviewed-by: darcy Contributed-by: alexandre.boulga...@oracle.com !

hg: jdk8/tl/jdk: 7064075: Security libraries don't build with javac -Xlint:all, -deprecation -Werror

2011-08-15 Thread jonathan . gibbons
Changeset: afb6f2370cd3 Author:jjg Date: 2011-08-15 11:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/afb6f2370cd3 7064075: Security libraries don't build with javac -Xlint:all,-deprecation -Werror Reviewed-by: xuelei, mullan Contributed-by:

Re: Code review request: 7077672 jdk8_tl nightly fail in step-2 build on 8/10/11

2011-08-12 Thread Jonathan Gibbons
On 08/12/2011 05:28 AM, Rémi Forax wrote: On 08/12/2011 01:29 AM, Jonathan Gibbons wrote: If you see any more opportunities for cleanup, I hope you'll let us know. Patches (or even changesets) would be even better :-) You could even have fun with the compiler and tree API to find examples

hg: jdk8/tl/jdk: 7077672: jdk8_tl nightly fail in step-2 build on 8/10/11

2011-08-11 Thread jonathan . gibbons
Changeset: 79bd5691d85f Author:jjg Date: 2011-08-11 13:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/79bd5691d85f 7077672: jdk8_tl nightly fail in step-2 build on 8/10/11 Reviewed-by: mchung, jjg Contributed-by: alexandre.boulga...@oracle.com !

Re: Code review request: 7077672 jdk8_tl nightly fail in step-2 build on 8/10/11

2011-08-11 Thread Jonathan Gibbons
Rémi, you wrote: On 08/11/2011 09:07 PM, Alexandre Boulgakov wrote: / Please review the attached patch to fix a build break. // // The fix changes new Class[] to new Class?[] in two places. // // Thanks, // Sasha / Hi Sasha, you can rewrite: connectMethod =

Re: Code review request: 7077672 jdk8_tl nightly fail in step-2 build on 8/10/11

2011-08-11 Thread Jonathan Gibbons
On 08/11/2011 02:56 PM, Rémi Forax wrote: On 08/11/2011 10:55 PM, Jonathan Gibbons wrote: Rémi, you wrote: On 08/11/2011 09:07 PM, Alexandre Boulgakov wrote: / Please review the attached patch to fix a build break. // // The fix changes new Class[] to new Class?[] in two places

hg: jdk8/tl/jdk: 7072353: JNDI libraries do not build with javac -Xlint:all -Werror

2011-08-10 Thread jonathan . gibbons
Changeset: 18329abcdb7c Author:jjg Date: 2011-08-10 13:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/18329abcdb7c 7072353: JNDI libraries do not build with javac -Xlint:all -Werror Reviewed-by: xuelei Contributed-by: alexandre.boulga...@oracle.com !

hg: jdk8/tl/langtools: 7074189: some javac tests fail with latest jtreg 4.1 b03

2011-08-05 Thread jonathan . gibbons
Changeset: c0d5f93af048 Author:jjg Date: 2011-08-05 15:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c0d5f93af048 7074189: some javac tests fail with latest jtreg 4.1 b03 Reviewed-by: darcy + test/tools/javac/lib/CompileFail.java !

hg: jdk8/tl/jdk: 7072523: java.math should be built with javac -Xlint:all -Werror

2011-07-29 Thread jonathan . gibbons
Changeset: 4030297803eb Author:jjg Date: 2011-07-29 16:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4030297803eb 7072523: java.math should be built with javac -Xlint:all -Werror Reviewed-by: darcy Contributed-by: alexandre.boulga...@oracle.com ! make/java/math/Makefile

hg: jdk8/tl/jdk: 7068616: NIO libraries do not build with javac -Xlint:all, -deprecation -Werror

2011-07-28 Thread jonathan . gibbons
Changeset: 7525866a4046 Author:jjg Date: 2011-07-28 13:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7525866a4046 7068616: NIO libraries do not build with javac -Xlint:all,-deprecation -Werror Reviewed-by: alanb, chegar Contributed-by: alexandre.boulga...@oracle.com !

Re: hg: jdk8/tl/jdk: 7068616: NIO libraries do not build with javac -Xlint:all, -deprecation -Werror

2011-07-28 Thread Jonathan Gibbons
On 07/28/2011 05:03 PM, Dr Andrew John Hughes wrote: On 16:47 Thu 28 Jul , Alexandre Boulgakov wrote: I'm working on removing javac warnings throughout the security, networking, and core libraries for a summer internship. Oh nice one! Very welcome work. But I guess that's not even the

hg: jdk8/tl/jdk: 7069870: Parts of the JDK erroneously rely on generic array initializers with diamond

2011-07-26 Thread jonathan . gibbons
Changeset: c563e8060adf Author:jjg Date: 2011-07-25 16:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c563e8060adf 7069870: Parts of the JDK erroneously rely on generic array initializers with diamond Reviewed-by: ksrini, mcimadamore Contributed-by:

hg: jdk8/tl/langtools: 7061125: Proposed javac argument processing performance improvement

2011-07-07 Thread jonathan . gibbons
Changeset: 7337295434b6 Author:jjg Date: 2011-07-07 13:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7337295434b6 7061125: Proposed javac argument processing performance improvement Reviewed-by: jjg, dlsmith, mcimadamore, forax Contributed-by: schlo...@gmail.com !

hg: jdk8/tl: 7061195: Clean up makefiles for JDK 8

2011-07-01 Thread jonathan . gibbons
Changeset: 0b615980879e Author:jjg Date: 2011-06-30 16:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/0b615980879e 7061195: Clean up makefiles for JDK 8 Reviewed-by: ohair, jjg Contributed-by: alexandre.boulga...@oracle.com ! make/sanity-rules.gmk

hg: jdk8/tl/jdk: 3 new changesets

2011-07-01 Thread jonathan . gibbons
Changeset: e4c936c28960 Author:jjg Date: 2011-06-30 16:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e4c936c28960 7061190: Update boot JDK version for JDK 8 Reviewed-by: ohair, jjg Contributed-by: alexandre.boulga...@oracle.com ! make/common/shared/Defs-versions.gmk

hg: jdk8/tl/langtools: 7060926: Attr.PostAttrAnalyzer misses a case

2011-06-30 Thread jonathan . gibbons
Changeset: 858ae8fec72f Author:jjg Date: 2011-06-30 12:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/858ae8fec72f 7060926: Attr.PostAttrAnalyzer misses a case Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Attr.java +

hg: jdk8/tl/langtools: 7058174: Reduce langtools build warnings

2011-06-23 Thread jonathan . gibbons
Changeset: 18002d039806 Author:jjg Date: 2011-06-23 11:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/18002d039806 7058174: Reduce langtools build warnings Reviewed-by: jjg Contributed-by: alexandre.boulga...@oracle.com ! make/build.xml !

hg: jdk7/tl/langtools: 7042623: Regression: javac silently crash when attributing non-existent annotation

2011-06-01 Thread jonathan . gibbons
Changeset: 6762754eb7c0 Author:jjg Date: 2011-06-01 11:25 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/6762754eb7c0 7042623: Regression: javac silently crash when attributing non-existent annotation Reviewed-by: mcimadamore !

hg: jdk7/tl/langtools: 7043867: docs/jdk/api/javac have html files that have issues with HTML4 compliance

2011-05-11 Thread jonathan . gibbons
Changeset: bdfa48f80c82 Author:jjg Date: 2011-05-11 14:55 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/bdfa48f80c82 7043867: docs/jdk/api/javac have html files that have issues with HTML4 compliance Reviewed-by: darcy !

hg: jdk7/tl/langtools: 7029150: Project Coin: present union types from the tree API through to javax.lang.model

2011-04-28 Thread jonathan . gibbons
Changeset: 7ae6c0fd479b Author:jjg Date: 2011-04-28 15:05 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/7ae6c0fd479b 7029150: Project Coin: present union types from the tree API through to javax.lang.model Reviewed-by: mcimadamore !

hg: jdk7/tl/langtools: 7038363: cast from object to primitive should be for source = 1.7

2011-04-26 Thread jonathan . gibbons
Changeset: 4c5f13798b8d Author:jjg Date: 2011-04-25 15:56 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4c5f13798b8d 7038363: cast from object to primitive should be for source = 1.7 Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/code/Source.java !

hg: jdk7/tl/langtools: 7031108: NPE in javac.jvm.ClassReader.findMethod in PackageElement.enclosedElements from AP in incr build

2011-03-30 Thread jonathan . gibbons
Changeset: 02ba4ff98742 Author:jjg Date: 2011-03-30 18:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/02ba4ff98742 7031108: NPE in javac.jvm.ClassReader.findMethod in PackageElement.enclosedElements from AP in incr build Reviewed-by: darcy, mcimadamore !

hg: jdk7/tl/langtools: 7031005: javap prints extends java.lang.Object

2011-03-30 Thread jonathan . gibbons
Changeset: c55928005af4 Author:jjg Date: 2011-03-30 18:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c55928005af4 7031005: javap prints extends java.lang.Object Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/classfile/Type.java !

hg: jdk7/tl/langtools: 6437138: JSR 199: Compiler doesn't diagnose crash in user code; ...

2011-03-25 Thread jonathan . gibbons
Changeset: 31e5cfc5a990 Author:jjg Date: 2011-03-25 07:58 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/31e5cfc5a990 6437138: JSR 199: Compiler doesn't diagnose crash in user code 6482554: uncaught exception from annotation processor not reported through

hg: jdk7/tl/langtools: 6597678: JavaCompiler.getStandardFileManager always uses default charset not the one that user specifies

2011-03-24 Thread jonathan . gibbons
Changeset: 83260b3305ac Author:jjg Date: 2011-03-24 16:14 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/83260b3305ac 6597678: JavaCompiler.getStandardFileManager always uses default charset not the one that user specifies Reviewed-by: mcimadamore !

hg: jdk7/tl/langtools: 6930508: Passing nested class names on javac command line interfere with subsequent name - class lookup

2011-03-16 Thread jonathan . gibbons
Changeset: a2399c8db703 Author:jjg Date: 2011-03-16 17:21 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/a2399c8db703 6930508: Passing nested class names on javac command line interfere with subsequent name - class lookup Reviewed-by: darcy !

hg: jdk7/tl/langtools: 6993311: annotations on packages are not validated

2011-03-15 Thread jonathan . gibbons
Changeset: c9432f06d9bc Author:jjg Date: 2011-03-15 11:04 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c9432f06d9bc 6993311: annotations on packages are not validated Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Attr.java !

hg: jdk7/tl/langtools: 6987384: -XprintProcessorRoundsInfo message printed with different timing than previous

2011-03-15 Thread jonathan . gibbons
Changeset: edf03ca74991 Author:jjg Date: 2011-03-15 11:41 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/edf03ca74991 6987384: -XprintProcessorRoundsInfo message printed with different timing than previous Reviewed-by: darcy !

hg: jdk7/tl/langtools: 6988079: Errors reported via Messager.printMessage(ERROR, error message) are not tallied correctly

2011-03-15 Thread jonathan . gibbons
Changeset: 0f9e5b7f0d7e Author:jjg Date: 2011-03-15 11:48 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/0f9e5b7f0d7e 6988079: Errors reported via Messager.printMessage(ERROR,error message) are not tallied correctly Reviewed-by: darcy !

hg: jdk7/tl/langtools: 7026414: Types.asElement() returns null for ErrorType

2011-03-14 Thread jonathan . gibbons
Changeset: 307b065ff2af Author:jjg Date: 2011-03-14 11:33 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/307b065ff2af 7026414: Types.asElement() returns null for ErrorType Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/model/JavacTypes.java !

hg: jdk7/tl/langtools: 7010608: the string 'error' should appear in error messages

2011-03-14 Thread jonathan . gibbons
Changeset: e2890b8369f7 Author:jjg Date: 2011-03-14 11:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e2890b8369f7 7010608: the string 'error' should appear in error messages Reviewed-by: mcimadamore !

hg: jdk7/tl/langtools: 7026509: Cannot use JavaCompiler to create multiple CompilationTasks for partial compilations

2011-03-14 Thread jonathan . gibbons
Changeset: cb119107aeea Author:jjg Date: 2011-03-14 11:48 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/cb119107aeea 7026509: Cannot use JavaCompiler to create multiple CompilationTasks for partial compilations Reviewed-by: mcimadamore !

hg: jdk7/tl/langtools: 6980021: javac should document @file command line option

2011-03-07 Thread jonathan . gibbons
Changeset: cb9493a80341 Author:jjg Date: 2011-03-07 13:45 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/cb9493a80341 6980021: javac should document @file command line option Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/main/OptionName.java !

hg: jdk7/tl/langtools: 6966736: javac verbose output is inconsistent

2011-03-04 Thread jonathan . gibbons
Changeset: 7798e3a5ecf5 Author:jjg Date: 2011-03-04 11:33 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/7798e3a5ecf5 6966736: javac verbose output is inconsistent Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/apt/main/AptJavaCompiler.java !

hg: jdk7/tl/langtools: 6866185: Util.getPackageSourcePath should use lastIndexOf not indexOf and related cleanup

2011-03-04 Thread jonathan . gibbons
Changeset: ebf7c13df6c0 Author:jjg Date: 2011-03-04 19:53 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ebf7c13df6c0 6866185: Util.getPackageSourcePath should use lastIndexOf not indexOf and related cleanup Reviewed-by: bpatel !

hg: jdk7/tl/langtools: 6227454: package.html and overview.html may not be read fully

2011-03-04 Thread jonathan . gibbons
Changeset: 4ee7de0684f5 Author:jjg Date: 2011-03-04 19:56 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4ee7de0684f5 6227454: package.html and overview.html may not be read fully Reviewed-by: bpatel ! src/share/classes/com/sun/tools/javadoc/DocImpl.java !

hg: jdk7/tl/langtools: 6964914: javadoc does not output number of warnings using user written doclet

2011-03-04 Thread jonathan . gibbons
Changeset: 5e6c661891da Author:jjg Date: 2011-03-04 19:59 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/5e6c661891da 6964914: javadoc does not output number of warnings using user written doclet Reviewed-by: bpatel !

hg: jdk7/tl/langtools: 6986895: compiler gives misleading message for no input files

2011-03-02 Thread jonathan . gibbons
Changeset: 2a5c919f20b8 Author:jjg Date: 2011-03-02 14:03 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2a5c919f20b8 6986895: compiler gives misleading message for no input files Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java !

hg: jdk7/tl/langtools: 6986892: confusing warning given after errors in annotation processing

2011-03-02 Thread jonathan . gibbons
Changeset: 3085d0089546 Author:jjg Date: 2011-03-02 21:06 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/3085d0089546 6986892: confusing warning given after errors in annotation processing Reviewed-by: darcy !

hg: jdk7/tl/langtools: 6639645: Modeling type implementing missing interfaces

2011-03-02 Thread jonathan . gibbons
Changeset: 4baab658f357 Author:jjg Date: 2011-03-02 21:13 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4baab658f357 6639645: Modeling type implementing missing interfaces Reviewed-by: darcy, mcimadamore ! src/share/classes/com/sun/tools/javac/code/Flags.java !

hg: jdk7/tl/langtools: 7021183: 269: assertion failure getting enclosing element of an undefined name

2011-03-01 Thread jonathan . gibbons
Changeset: 938dda0bec17 Author:jjg Date: 2011-03-01 12:00 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/938dda0bec17 7021183: 269: assertion failure getting enclosing element of an undefined name Reviewed-by: mcimadamore !

hg: jdk7/tl/langtools: 7022337: repeated warnings about bootclasspath not set

2011-02-28 Thread jonathan . gibbons
Changeset: 9029f694e5df Author:jjg Date: 2011-02-28 12:19 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/9029f694e5df 7022337: repeated warnings about bootclasspath not set Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java -

hg: jdk7/tl/langtools: 7022741: warning counts are wrong after anno processing

2011-02-28 Thread jonathan . gibbons
Changeset: bf9f162c7104 Author:jjg Date: 2011-02-28 13:37 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/bf9f162c7104 7022741: warning counts are wrong after anno processing Reviewed-by: mcimadamore !

hg: jdk7/tl/langtools: 7022711: compiler crash in try-with-resources

2011-02-28 Thread jonathan . gibbons
Changeset: 67d6b2df47ba Author:jjg Date: 2011-02-28 13:42 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/67d6b2df47ba 7022711: compiler crash in try-with-resources Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/code/Kinds.java +

hg: jdk7/tl/langtools: 7021650: fix Context issues

2011-02-25 Thread jonathan . gibbons
Changeset: 8f0dcb9499db Author:jjg Date: 2011-02-25 12:09 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/8f0dcb9499db 7021650: fix Context issues Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/apt/util/Bark.java !

hg: jdk7/tl/langtools: 7022310: test/tools/javac/diags/Example: args added twice

2011-02-25 Thread jonathan . gibbons
Changeset: 23b64ad3eec8 Author:jjg Date: 2011-02-25 12:19 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/23b64ad3eec8 7022310: test/tools/javac/diags/Example: args added twice Reviewed-by: mcimadamore ! test/tools/javac/diags/Example.java

hg: jdk7/tl/langtools: 7008433: Minor copyright changes

2011-02-14 Thread jonathan . gibbons
Changeset: ef6c66215a93 Author:jjg Date: 2011-02-14 14:27 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ef6c66215a93 7008433: Minor copyright changes Reviewed-by: jjg Contributed-by: kelly.oh...@oracle.com ! test/tools/javac/4917091/Test255.java !

hg: jdk7/tl/langtools: 6505047: javax.lang.model.element.Element.getEnclosingElement() doesn't return null for type parameter

2011-02-11 Thread jonathan . gibbons
Changeset: bfeed79c70aa Author:jjg Date: 2011-02-11 17:10 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/bfeed79c70aa 6505047: javax.lang.model.element.Element.getEnclosingElement() doesn't return null for type parameter Reviewed-by: darcy +

hg: jdk7/tl/langtools: 7018098: CacheFSInfo persists too long

2011-02-10 Thread jonathan . gibbons
Changeset: a19b1f4f23c9 Author:jjg Date: 2011-02-10 14:24 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/a19b1f4f23c9 7018098: CacheFSInfo persists too long Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/file/CacheFSInfo.java !

hg: jdk7/tl/langtools: 6485027: javac incorrectly handles relative paths in manifest classpath

2011-02-10 Thread jonathan . gibbons
Changeset: e0c16199b2e0 Author:jjg Date: 2011-02-10 15:05 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e0c16199b2e0 6485027: javac incorrectly handles relative paths in manifest classpath Reviewed-by: mcimadamore !

hg: jdk7/tl/langtools: 7016750: tools/javac/nio/CompileTest failing in nightly test

2011-02-09 Thread jonathan . gibbons
Changeset: c6cb387190ee Author:jjg Date: 2011-02-09 14:04 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c6cb387190ee 7016750: tools/javac/nio/CompileTest failing in nightly test Reviewed-by: mcimadamore ! test/tools/javac/nio/compileTest/CompileTest.java

hg: jdk7/tl/langtools: 7010792: remove bad debugging method from javac

2011-02-09 Thread jonathan . gibbons
Changeset: 3ce4e1a07e92 Author:jjg Date: 2011-02-09 14:10 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/3ce4e1a07e92 7010792: remove bad debugging method from javac Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/parser/Scanner.java

hg: jdk7/tl/langtools: 7018447: langtools launcher template fails if tools run from their own directory

2011-02-09 Thread jonathan . gibbons
Changeset: bfa59f3e84bd Author:jjg Date: 2011-02-09 18:26 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/bfa59f3e84bd 7018447: langtools launcher template fails if tools run from their own directory Reviewed-by: jjg Contributed-by: daniel.sm...@oracle.com !

hg: jdk7/tl/langtools: 7017675: typo in JavacParser for allowUnderscoresInLiterals

2011-02-07 Thread jonathan . gibbons
Changeset: 56b77a38618c Author:jjg Date: 2011-02-07 11:42 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/56b77a38618c 7017675: typo in JavacParser for allowUnderscoresInLiterals Reviewed-by: dlsmith Contributed-by: peter.b.kess...@oracle.com !

hg: jdk7/tl/langtools: 7013272: Automatically generate info about how compiler resource keys are used

2011-01-26 Thread jonathan . gibbons
Changeset: 3da26790ccb7 Author:jjg Date: 2011-01-26 13:45 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/3da26790ccb7 7013272: Automatically generate info about how compiler resource keys are used Reviewed-by: mcimadamore ! make/build.xml !

hg: jdk7/tl/langtools: 6963934: JCCompilationUnit.getImports does not report all imports

2011-01-24 Thread jonathan . gibbons
Changeset: 73ab0b128918 Author:jjg Date: 2011-01-24 16:17 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/73ab0b128918 6963934: JCCompilationUnit.getImports does not report all imports Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/tree/JCTree.java +

hg: jdk7/tl/langtools: 6988106: javac report 'java.lang.IllegalMonitorStateException'

2011-01-24 Thread jonathan . gibbons
Changeset: a8437c34fdc7 Author:jjg Date: 2011-01-24 16:38 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/a8437c34fdc7 6988106: javac report 'java.lang.IllegalMonitorStateException' Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javac/file/CacheFSInfo.java !

hg: jdk7/tl/langtools: 6419926: JSR 199: FileObject.toUri() generates URI without schema (Solaris)

2011-01-14 Thread jonathan . gibbons
Changeset: 7c7c1787fbbe Author:jjg Date: 2011-01-14 11:45 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/7c7c1787fbbe 6419926: JSR 199: FileObject.toUri() generates URI without schema (Solaris) Reviewed-by: mcimadamore + test/tools/javac/api/T6419926.java

hg: jdk7/tl/langtools: 6571165: Minor doc bugs in JavaCompiler.java

2011-01-14 Thread jonathan . gibbons
Changeset: 0a509c765657 Author:jjg Date: 2011-01-14 11:55 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/0a509c765657 6571165: Minor doc bugs in JavaCompiler.java Reviewed-by: mcimadamore ! src/share/classes/javax/tools/JavaCompiler.java

hg: jdk7/tl/langtools: 6993305: starting position of a method without modifiers and with type parameters is incorrect

2011-01-11 Thread jonathan . gibbons
Changeset: 17b271281525 Author:jjg Date: 2011-01-11 08:05 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/17b271281525 6993305: starting position of a method without modifiers and with type parameters is incorrect Reviewed-by: mcimadamore !

hg: jdk7/tl/langtools: 6992999: fully remove JSR 308 from langtools

2011-01-10 Thread jonathan . gibbons
Changeset: d17f37522154 Author:jjg Date: 2011-01-10 14:57 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d17f37522154 6992999: fully remove JSR 308 from langtools Reviewed-by: mcimadamore ! src/share/classes/com/sun/source/tree/MethodTree.java !

hg: jdk7/tl/langtools: 6396503: javac should not require assertions enabled

2011-01-10 Thread jonathan . gibbons
Changeset: 7c537f4298fb Author:jjg Date: 2011-01-10 15:08 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/7c537f4298fb 6396503: javac should not require assertions enabled Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/Main.java !

hg: jdk7/tl/langtools: 7006564: NPE in javac running test/tools/javac/nio/compileTest/CompileTest.java

2010-12-15 Thread jonathan . gibbons
Changeset: cff0b8694633 Author:jjg Date: 2010-12-15 06:39 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/cff0b8694633 7006564: NPE in javac running test/tools/javac/nio/compileTest/CompileTest.java Reviewed-by: mcimadamore, alanb !

hg: jdk7/tl/langtools: 6990134: minor (but red) findbugs warnings

2010-12-12 Thread jonathan . gibbons
Changeset: 878c8f760ded Author:jjg Date: 2010-12-12 10:05 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/878c8f760ded 6990134: minor (but red) findbugs warnings Reviewed-by: mcimadamore + src/share/classes/com/sun/tools/apt/main/AptJavaCompiler.java -

hg: jdk7/tl/langtools: 6504896: TreeMaker.Literal(Object) does not support Booleans

2010-12-10 Thread jonathan . gibbons
Changeset: 8ec3a824f925 Author:jjg Date: 2010-12-10 07:38 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/8ec3a824f925 6504896: TreeMaker.Literal(Object) does not support Booleans Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java

hg: jdk7/tl/langtools: 4917091: javac rejects array over 128 in length

2010-12-09 Thread jonathan . gibbons
Changeset: bcf44475aeee Author:jjg Date: 2010-12-09 08:24 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/bcf44475aeee 4917091: javac rejects array over 128 in length Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/jvm/Gen.java +

hg: jdk7/tl/langtools: 6985202: no access to doc comments from Tree API

2010-12-09 Thread jonathan . gibbons
Changeset: 90914ac50868 Author:jjg Date: 2010-12-09 08:48 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/90914ac50868 6985202: no access to doc comments from Tree API Reviewed-by: mcimadamore ! src/share/classes/com/sun/source/util/Trees.java !

hg: jdk7/tl/langtools: 6986242: cut-n-paste error in javadoc for Trees.instance(ProcessingEnvironment)

2010-12-09 Thread jonathan . gibbons
Changeset: 65820d0d4a97 Author:jjg Date: 2010-12-09 19:53 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/65820d0d4a97 6986242: cut-n-paste error in javadoc for Trees.instance(ProcessingEnvironment) Reviewed-by: darcy ! src/share/classes/com/sun/source/util/Trees.java

hg: jdk7/tl/langtools: 7004698: javap does not output CharacterRangeTable attributes correctly

2010-12-08 Thread jonathan . gibbons
Changeset: acb02e1d5119 Author:jjg Date: 2010-12-08 13:42 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/acb02e1d5119 7004698: javap does not output CharacterRangeTable attributes correctly Reviewed-by: mcimadamore !

hg: jdk7/tl/langtools: 6999210: javac should be able to warn of anomalous conditions in classfiles

2010-12-07 Thread jonathan . gibbons
Changeset: 3c32c90031fd Author:jjg Date: 2010-12-07 14:13 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/3c32c90031fd 6999210: javac should be able to warn of anomalous conditions in classfiles Reviewed-by: mcimadamore, darcy !

hg: jdk7/tl/jdk: 7004021: docs should not assume -source 1.5

2010-12-05 Thread jonathan . gibbons
Changeset: fe9ead37938c Author:jjg Date: 2010-12-05 20:46 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fe9ead37938c 7004021: docs should not assume -source 1.5 Reviewed-by: ohair ! make/docs/Makefile

hg: jdk7/tl/langtools: 7003477: Paths.isDefaultBootClassPath needs to be public

2010-11-30 Thread jonathan . gibbons
Changeset: bcbc86cc5b31 Author:jjg Date: 2010-11-30 09:38 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/bcbc86cc5b31 7003477: Paths.isDefaultBootClassPath needs to be public Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/file/Paths.java

hg: jdk7/tl/langtools: 7003006: add option to list directory in deterministic order

2010-11-29 Thread jonathan . gibbons
Changeset: d44d6d8493ad Author:jjg Date: 2010-11-29 10:09 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d44d6d8493ad 7003006: add option to list directory in deterministic order Reviewed-by: mcimadamore !

hg: jdk7/tl/langtools: 6900037: javac should warn if earlier -source is used and bootclasspath not set

2010-11-29 Thread jonathan . gibbons
Changeset: c44234f680da Author:jjg Date: 2010-11-29 14:15 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c44234f680da 6900037: javac should warn if earlier -source is used and bootclasspath not set Reviewed-by: darcy !

hg: jdk7/tl/langtools: 6942366: javadoc no longer inherits doc from sourcepath

2010-11-23 Thread jonathan . gibbons
Changeset: 285896f2227a Author:jjg Date: 2010-11-23 13:32 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/285896f2227a 6942366: javadoc no longer inherits doc from sourcepath Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javadoc/JavadocClassReader.java +

hg: jdk7/tl/langtools: 7002346: javap test relies on location of scratch directory

2010-11-23 Thread jonathan . gibbons
Changeset: 79d0c48d361e Author:jjg Date: 2010-11-23 15:28 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/79d0c48d361e 7002346: javap test relies on location of scratch directory Reviewed-by: ksrini ! test/tools/javap/T6729471.java

hg: jdk7/tl/langtools: 6999438: remove support for exotic identifiers from JDK 7

2010-11-18 Thread jonathan . gibbons
Changeset: 03177f49411d Author:jjg Date: 2010-11-18 16:13 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/03177f49411d 6999438: remove support for exotic identifiers from JDK 7 Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/code/Source.java !

hg: jdk7/tl/langtools: 7000973: isBogus needs to be called on the to-be-returned entry, not on the current entry

2010-11-17 Thread jonathan . gibbons
Changeset: abaceae7c9f8 Author:jjg Date: 2010-11-17 15:07 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/abaceae7c9f8 7000973: isBogus needs to be called on the to-be-returned entry, not on the current entry Reviewed-by: jjg Contributed-by: jan.lah...@oracle.com !

hg: jdk7/tl/langtools: 6997958: test tools/javac/api/T6412669.java fails in PIT

2010-11-09 Thread jonathan . gibbons
Changeset: a0d9d642f65b Author:jjg Date: 2010-11-09 17:49 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/a0d9d642f65b 6997958: test tools/javac/api/T6412669.java fails in PIT Reviewed-by: darcy ! test/tools/javac/api/T6412669.java

hg: jdk7/tl/langtools: 6998063: new Scope impl to fix Scope performance issues

2010-11-06 Thread jonathan . gibbons
Changeset: 9427a3c795fc Author:jjg Date: 2010-11-06 13:53 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/9427a3c795fc 6998063: new Scope impl to fix Scope performance issues Reviewed-by: jjg Contributed-by: per.both...@oracle.com !

hg: jdk7/tl/langtools: 6996626: Scope fix issues for ImportScope

2010-11-01 Thread jonathan . gibbons
Changeset: 6ce6ee1b831a Author:jjg Date: 2010-11-01 19:28 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/6ce6ee1b831a 6996626: Scope fix issues for ImportScope Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/code/Scope.java

hg: jdk7/tl/langtools: 6949587: rename DisjointType to DisjunctType

2010-10-26 Thread jonathan . gibbons
Changeset: 7755f47542a0 Author:jjg Date: 2010-10-26 14:29 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/7755f47542a0 6949587: rename DisjointType to DisjunctType Reviewed-by: mcimadamore - src/share/classes/com/sun/source/tree/DisjointTypeTree.java +

hg: jdk7/tl/langtools: 6987760: remove 308 support from JDK7

2010-10-19 Thread jonathan . gibbons
Changeset: 4851ff2ffc10 Author:jjg Date: 2010-10-19 15:02 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4851ff2ffc10 6987760: remove 308 support from JDK7 Reviewed-by: darcy, mcimadamore - src/share/classes/com/sun/source/tree/AnnotatedTypeTree.java !

hg: jdk7/tl/langtools: 6989457: javadoc test file test/tools/javadoc/T4994049/FileWithTabs.java probably does not

2010-10-12 Thread jonathan . gibbons
Changeset: 68cf07910d74 Author:jjg Date: 2010-10-12 12:55 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/68cf07910d74 6989457: javadoc test file test/tools/javadoc/T4994049/FileWithTabs.java probably does not Reviewed-by: mcimadamore !

hg: jdk7/tl/langtools: 6988407: javac crashes running processor on errant code; it used to print error message

2010-10-12 Thread jonathan . gibbons
Changeset: 14a707f8ce84 Author:jjg Date: 2010-10-12 13:15 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/14a707f8ce84 6988407: javac crashes running processor on errant code; it used to print error message Reviewed-by: darcy !

hg: jdk7/tl/langtools: 4942232: missing param class processes without error

2010-10-12 Thread jonathan . gibbons
Changeset: a1d31ab7b525 Author:jjg Date: 2010-10-12 13:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/a1d31ab7b525 4942232: missing param class processes without error Reviewed-by: darcy ! src/share/classes/com/sun/tools/javah/JNI.java !

hg: jdk7/tl/langtools: 6990133: AnnotationProxyMaker.ValueVisitor$1 contains non-transient non-serializable field

2010-10-12 Thread jonathan . gibbons
Changeset: ea92d1e275b6 Author:jjg Date: 2010-10-12 14:22 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ea92d1e275b6 6990133: AnnotationProxyMaker.ValueVisitor$1 contains non-transient non-serializable field Reviewed-by: darcy !

<    2   3   4   5   6   7   8   9   >