Re: RFR: 8272614: Unused parameters in MethodHandleNatives linking methods

On Tue, 19 Oct 2021 17:12:16 GMT, Harold Seigel wrote: > Please review this small fix for JDK-8272614 to remove the unused indexInCP > argument to linkCallSite() and linkDynamicConstant(). The fix was tested > with Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and Mach5 tiers 3-6 on > Linux

Re: RFR: 8260193: Remove JVM_GetInterfaceVersion() and JVM_DTraceXXX

On Mon, 1 Feb 2021 18:40:54 GMT, Ioi Lam wrote: > - JVM_GetInterfaceVersion() was used by "HotSpot Express" (HSX) which allowed > the same JDK library to use different version of HotSpot. However, HSX is no > longer supported so this API should be removed. > - Implementations of APIs such as JV

Re: RFR: 8256867: Classes with empty PermittedSubclasses attribute cannot be extended

On Mon, 7 Dec 2020 19:51:38 GMT, Harold Seigel wrote: > Please review this fix for JDK-8256867. This change no longer throws a > ClassFormatError exception when loading a class whose PermittedSubclasses > attribute is empty (contains no classes). Instead, the class is treated as a > sealed c

Re: RFR: 8252180: [JEP 390] Deprecate wrapper class constructors for removal

On Mon, 7 Dec 2020 15:50:55 GMT, Harold Seigel wrote: >> Integration of [JEP 390](https://bugs.openjdk.java.net/browse/JDK-8249100). >> >> Development has been broken into 5 tasks, each with its own JBS issue: >> - Deprecate wrapper class constructors for removal (rriggs) >> - Revise "value-base

Re: RFR: 8246778: Compiler implementation for Sealed Classes (Second Preview) [v3]

On Wed, 2 Dec 2020 14:40:15 GMT, Jan Lahoda wrote: >> This pull request replaces https://github.com/openjdk/jdk/pull/1227. >> >> From the original PR: >> >>> Please review the code for the second iteration of sealed classes. In this >>> iteration we are: >>> >>> * Enhancing narrowing refe

Re: RFR: 8244778: Archive full module graph in CDS

On Tue, 8 Sep 2020 15:59:33 GMT, Ioi Lam wrote: > This is the same patch as > [8244778-archive-full-module-graph.v03](http://cr.openjdk.java.net/~iklam/jdk16/8244778-archive-full-module-graph.v03/) > published in > [hotspot-runtime-...@openjdk.java.net](https://mail.openjdk.java.net/pipermail/hot

Re: RFR(L) 8244778 Archive full module graph in CDS

ate that they are used for both reading/writing a ModuleEntry's reads list and a PackageEntry's exports list. Please see my comments in-line. On 8/25/20 7:58 AM, Lois Foltan wrote: Hi Ioi, Changes looks really good.  Comments interspersed below. Thanks, Lois On 8/12/2020 6:06

Re: RFR(L) 8244778 Archive full module graph in CDS

odulesTest.java     would fail as it sees a partially restored set of modules. On 8/7/20 12:06 PM, Lois Foltan wrote: Hi Ioi, Overall looks promising.  I have some review comments below, but not a complete review.  I concentrated on the JVM side primarily how the archived module graph is read

Re: Review Request JDK-8244090: public lookup should find public members of public exported types

On 8/11/2020 2:00 PM, Mandy Chung wrote: It was agreed in an offline discussion with Lois, Kim and John that this work should wait for the integration of JDK-8247938 and JEP 347 Enable C++ 14 features. This patch is updated to use scoped enum consistent with JDK-8247938. Updated webrev: http

Re: RFR(L) 8244778 Archive full module graph in CDS

Hi Ioi, Overall looks promising.  I have some review comments below, but not a complete review.  I concentrated on the JVM side primarily how the archived module graph is read in, how the ModuleEntry and PackageEntry tables are created from the archive for the 3 builtin loaders and potential

Re: RFR: JDK-8225056 VM support for sealed classes

On 5/21/2020 2:33 PM, Harold Seigel wrote: Hi David, Thanks for looking at this!  Please review this new webrev:    http://cr.openjdk.java.net/~hseigel/webrev.01/webrev/ Hi Harold, I think this webrev looks good!  A couple of minor comments: - oops/instanceKlass.cpp:   line #236, do you nee

Re: RFR(S) 8241815: Unnecessary calls to SystemDictionaryShared::define_shared_package

Looks good Calvin. Lois On 4/27/2020 3:21 PM, Calvin Cheung wrote: JBS: https://bugs.openjdk.java.net/browse/JDK-8241815 webrev: http://cr.openjdk.java.net/~ccheung/jdk15/8241815/webrev.00/ This change is to avoid java up call of definePackage() while loading a shared app/platform class origin

Re: Review Request: 8238358: Implementation of JEP 371: Hidden Classes

On 4/2/2020 2:56 PM, Mandy Chung wrote: Hi David, Thank you for checking thoroughly.   I now grep on src/hotspot and clean all of them. Updated delta webrev: http://cr.openjdk.java.net/~mchung/valhalla/webrevs/hidden-classes/webrev.04-delta/ Patch looks good Mandy. Lois On 4/1/20 11:21

Re: RFR 8235359: Simplify method Class.getRecordComponents()

Looks good. Lois On 12/5/2019 9:36 AM, Harold Seigel wrote: Hi, Please review this small change to simplify Class.getRecordComponents() by changing the return type of getRecordComponents0() to RecordComponent[]. Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8235359/webrev/index.html

Re: RFR: JEP 359: Records (Preview) (full code)

I've looked over the hotspot code again as well.  Looks good, you have my review! Lois On 12/2/2019 11:52 AM, coleen.phillim...@oracle.com wrote: (resending to all the lists) Hi, I've looked at the hotspot code again, and it looks good. Nice work, Harold and Vincente! Coleen On 11/27/19 1

Re: RFR: 8232613: Move Object.registerNatives into HotSpot

On 10/22/2019 11:03 AM, Claes Redestad wrote: On 2019-10-22 15:55, David Holmes wrote: With your change interface I's registerNatives default method is invoked successfully.  I don't think this is a major backward compatibilty issue but we should have someone from core-libs okay the removal

Re: RFR: 8232613: Move Object.registerNatives into HotSpot

On 10/22/2019 7:13 AM, Claes Redestad wrote: On 2019-10-22 13:05, Andrew Dinn wrote: On 22/10/2019 12:05, Claes Redestad wrote: On 2019-10-22 12:44, Andrew Dinn wrote: Why not leave it void? I guess: http://cr.openjdk.java.net/~redestad/8232613/open.02/ Ship it ;-) No wait, I missed th

Re: RFR: 8200238: Reduce number of exceptions created when calling MemberName$Factory::resolveOrNull

On 3/27/2018 2:49 AM, Claes Redestad wrote: On 2018-03-26 17:51, Claes Redestad wrote: Karen, On 2018-03-26 17:15, Karen Kinnear wrote: Claes, Discussed with Lois. We think that it would make more sense to pass the new argument into MethodHandles::resolve_MemberName and at all three plac

Re: [11] 8196583 Update jib and test jtreg version to 4.2 b12

Looks good. Lois On 2/1/2018 1:44 PM, Paul Sandoz wrote: Hi, The constant dynamic test i recently updated and pushed to hs [*] requires a later version of jtreg to execute correctly (it requires an updated version of asmtools bundled with jtreg). Here are the changes: diff -r 11920d5d14a8 m

Re: RFR: JDK-8166748 Clean out Windows IA64 support

Looks good George. Lois On 6/7/2017 2:50 PM, George Triantafillou wrote: Please review this fix to clean out Windows IA64 support: JBS: https://bugs.openjdk.java.net/browse/JDK-8166748 open webrev (jdk): http://cr.openjdk.java.net/~gtriantafill/8166748-webrev/jdk/webrev/index.html

Re: RFR 8165634: Support multiple --add-module options on the command line

On 9/8/2016 9:23 AM, harold seigel wrote: Hi, Please review this fix for JDK-8165634. The fix changes the --add-modules option from being a 'last one wins' option to a cumulative one. With this change, if multiple --add-modules options are specified, the VM accumulates all the options' val

Re: RFR [9] 8153498: Update the PostVMInitHook mechanism to use an internal package in the base module

Hotspot changes look good. Lois On 4/5/2016 5:51 AM, Chris Hegarty wrote: sun.misc.PostVMInitHook::run is called by the VM once its initialization is complete, when jdk_version_info.post_vm_init_hook_enabled bit is true. Since sun.misc will be moved out of the base module, the VM should look for

RFR (XS) JDK-8033584: Remove java/lang/reflect/Method/invoke/TestPrivateInterfaceMethodReflect.java from exclude list

Please review the following change to remove a test from ProblemList.txt. Webrev: http://cr.openjdk.java.net/~lfoltan/bug_jdk8033584/ Bug: Remove java/lang/reflect/Method/invoke/TestPrivateInterfaceMethodReflect.java from exclude list https://bugs.openjdk.java.net/browse/JDK-8033584 Summary