ot;100")
private int size;
@Param
private MapType mapType;
public enum MapType {
HASH_MAP,
LINKED_HASH_MAP,
}
On Thu, Jan 3, 2019 at 12:31 PM Michal Vala wrote:
Hi Martin,
can we please finish this review?
On 12/19/18 6:32 PM, Michal Va
Hi Martin,
I'd like to finish this review. Are you still willing to sponsor this?
Thanks!
On 1/9/19 11:39 AM, Michal Vala wrote:
ping
On 1/3/19 9:31 PM, Michal Vala wrote:
Hi Martin,
can we please finish this review?
On 12/19/18 6:32 PM, Michal Vala wrote:
On 12/19/18 4:15 PM, M
ping
On 1/3/19 9:31 PM, Michal Vala wrote:
Hi Martin,
can we please finish this review?
On 12/19/18 6:32 PM, Michal Vala wrote:
On 12/19/18 4:15 PM, Martin Buchholz wrote:
On Wed, Dec 19, 2018 at 6:59 AM Roger Riggs wrote:
Hi Martin,
It is also useful and conventional to print the
Hi Martin,
can we please finish this review?
On 12/19/18 6:32 PM, Michal Vala wrote:
On 12/19/18 4:15 PM, Martin Buchholz wrote:
On Wed, Dec 19, 2018 at 6:59 AM Roger Riggs wrote:
Hi Martin,
It is also useful and conventional to print the seed of the random
so that if necessary it can
the issue, but then we have to know how to
reproduce and what we're searching for.
If this case would not require ThreadLocalRandom and Random is enough, I'd like
to use that because of benefits I've mentioned.
--
Michal Vala
OpenJDK QE
Red Hat Czech
r : suppliers) {
+HashMap map = supplier.get();
+assertNull(table(map));
+
+map.put(1, 1);
+ assertEquals(capacity(map), tableSizeFor(initialCapacity));
+}
+}
}
--
Michal Vala
OpenJDK QE
Red Hat Czech
On 12/19/18 3:01 PM, Martin Buchholz wrote:
On Tue, Dec 18, 2018 at 10:48 PM Michal Vala wrote:
Randomized test is not deterministic now. Can we have also original one?
We may have an irreconcilable difference of testing philosophy.
(yes, mainstream testing thought has embraced
TODO to randomize testBug8210280
On Mon, Dec 17, 2018 at 7:40 AM Michal Vala wrote:
All tests I've run passed, benchmarks show ~15% performance boost for
putAllWithBigMapToNonEmptyMap.
On 12/17/18 7:32 AM, Michal Vala wrote:
Hi,
thanks Doug, this is nice reduction.
Here's the ne
All tests I've run passed, benchmarks show ~15% performance boost for
putAllWithBigMapToNonEmptyMap.
On 12/17/18 7:32 AM, Michal Vala wrote:
Hi,
thanks Doug, this is nice reduction.
Here's the new webrev:
http://cr.openjdk.java.net/~mvala/jdk/jdk/JDK-8210280/webrev.03/
Just
ht be
confising. I've updated the comment s/LinkedHashMap/linked-list buckets/.
I'm just running tier1 tests and benchmarks.
On 12/16/18 3:23 PM, Doug Lea wrote:
On 12/14/18 1:37 AM, Michal Vala wrote:
Thanks Martin for finding this serious issue and the testcase.
Sorry that I wasn't
d tail pointers just where needed, but I
couldn't find effective solution for now (without e.g. having second table of
the same size, which is killer).
I'm still looking into removeEldestEntry with LinkedHashMap.
On 12/14/18 7:37 AM, Michal Vala wrote:
Thanks Martin for finding t
but it's such a
corner case this may not be worth doing.
--
Michal Vala
OpenJDK QE
Red Hat Czech
ut(7 + i * 16, 0);
Map more = impl.emptyMap();
for (int i = 0; i < 128; i++) more.put(-i, 42);
m.putAll(more);
for (int i = 0; i < 4; i++) assertEquals(0, m.get(7 + i * 16));
}
--
Michal Vala
OpenJDK QE
Red Hat Czech
modules ... did this test actually pass?
- you should have some kind of @summary that includes the word "whitebox"
- why not "throws ReflectiveOperationException" ?
- your reviewer is a bit on the autistic side, so please change /** to /*
on the @test comment (it's not javado
test comment (it's not javadoc!)
fixed (other tests in HashMap have also /**. I guess it does not worth the
separate fix. or?)
On Tue, Dec 11, 2018 at 11:06 AM Michal Vala wrote:
Hi,
I've been looking into this bug in HashMap where resize() is called
multiple
times when putting w
);
map.putAll(mapTocopy);
return map.size();
}
}
Any ideas for missed corner-cases or some good tests?
--
Michal Vala
OpenJDK QE
Red Hat Czech
think you have made your last set of tweaks.
Best
Lance
On May 31, 2018, at 6:09 AM, Michal Vala wrote:
Hi Lance, David,
I've found few more javadoc line length issues, so I've fixed that.
Regarding to linking methods, I guess all links should have arguments. Now when
I link `#appen
* Returns this matcher's input character at index i.
*
* @return A char from the specified index
*/
-----
On May 30, 2018, at 11:10 AM, Michal Vala wrote:
Hi Lance,
thanks, I'd appreciate that
On 05/30/2018 04:32 PM, Lance Andersen wrote:
I can spon
Hi Lance,
thanks, I'd appreciate that
On 05/30/2018 04:32 PM, Lance Andersen wrote:
I can sponsor this for you
On May 30, 2018, at 7:17 AM, Michal Vala wrote:
Hi,
please review and eventually sponsor this small doc patch fixing method links
in java.util.regex.Matcher
webrev:
Hi,
please review and eventually sponsor this small doc patch fixing method links in
java.util.regex.Matcher
webrev: http://cr.openjdk.java.net/~mvala/jdk/jdk/JDK-8190417/webrev.00/
Thanks!
--
Michal Vala
OpenJDK QE
Red Hat Czech
20 matches
Mail list logo
