Re: Review Request: 7164376 Replace use of sun.security.action.LoadLibraryAction

2012-04-26 Thread Phil Race
All looks good to me. Compiler won't spot misspelled library names so I did try to check all those are still the same. -phil. On 4/26/2012 2:20 PM, Mandy Chung wrote: Thanks, Sean. I have fixed the 3 files per your comment. Mandy On 4/26/2012 1:59 PM, Sean Mullan wrote: Looks fine, just a c

Re: Problem of using malloc() without including stdlib.h

2012-01-18 Thread Phil Race
Its arguable, whether harmless or not, that each file needs to include it. Its not unreasonable for an area of the code to have a header file such as "awt.h" that is supposed to be the one that's included by the other files in that area of the code, and which takes care of common includes. jni_u

Re: [OpenJDK 2D-Dev] RFR 7116946: JSSecurityManager should use java.util.ServiceLoader to lookup service providers

2011-12-01 Thread Phil Race
Looks good to me. I thought we'd squished all the uses of this internal class a long time ago. -phil. On 12/1/11 8:09 AM, Chris Hegarty wrote: This is a follow up to an issue that came up during discussion of another fix. Essentially, JDK classes should use j.u.ServiceLoader rather than sun

Re: Fwd: Re: Miscellaneous minor patches: javadoc typos, javac warnings, etc.

2011-11-09 Thread Phil Race
Martin, Please do register on 2d-dev and propose the 2D changes there. The hashcode change definitely needs discussion, I think there may be views on the NaN comparison as my understanding is that this is supposed to always be not equal. Could be a spec. change for the class if its admissible.

Re: Request for review: [NEW BUG] Printer spoolers ignore result from spool process

2011-10-20 Thread Phil Race
Neil, Can you please redirect this over to 2d-dev. Printing has nothing to do with core-libs. Its Java2D. -phil. On 10/20/2011 11:15 AM, Neil Richards wrote: Hi all, Whilst trying to debug a printing problem, I noticed that the (Unix and PostScript) printer spoolers in Java do not check what t

Re: FontConfig fails when optional system library is missing

2011-07-18 Thread Phil Race
Ah you said it was AIX, not Linux. Still, it should have that library installed even if the de-ref is fixed. -phil. On 7/18/2011 3:12 PM, Phil Race wrote: Steve, There's no attachment .. and this should be discussed on 2d-dev, not core-libs. I do see in the code where the null de-re

Re: FontConfig fails when optional system library is missing

2011-07-18 Thread Phil Race
Steve, There's no attachment .. and this should be discussed on 2d-dev, not core-libs. I do see in the code where the null de-ref can happen. This is some new JDK 7 code. Although a system where the library is missing is basically DOA for client use. I'd suspect you are running 32 bit JDK o

Re: Urgent Request for review: 7035109 Regression: awt SplashScreen/test18.sh fails - missing mapfile entry

2011-04-10 Thread Phil Race
On 4/10/2011 3:22 PM, David Holmes wrote: Just so there's no misunderstanding these changes were all approved by AWT. All of the SE Embedded integration work was done in full cooperation with the TL, Build and AWT folk and I've immensely grateful for their assistance in getting this all pus

Re: Urgent Request for review: 7035109 Regression: awt SplashScreen/test18.sh fails - missing mapfile entry

2011-04-10 Thread Phil Race
I think that there can be times when something is extremely cross-area and that makes it more of a pain if it can't easily be divided up. But I completely agree that running the right tests is a vital part of making sure there are no problems. I don't know if that would have happened any faster

Re: Support for Turkish locale

2011-03-01 Thread Phil Race
I should clarify that Alan is correct that the i18n-dev list is the more appropriate place to raise this as its the right place to discuss I18N and L10N .. since I don't know of any L10N list. -phil. On 3/1/2011 7:40 AM, Phil Race wrote: This is a localisation issue (not internationalis

Re: Support for Turkish locale

2011-03-01 Thread Phil Race
This is a localisation issue (not internationalisation issue as Alan suggested). but the bottom line is whilst many locales are supported that does not mean that user interface messages are translated into all those locales. There's a huge cost issue behind that. There was an openjdk project to a

Re: Zlib level in JDK7

2011-02-22 Thread Phil Race
On 2/22/2011 3:51 PM, Dr Andrew John Hughes wrote: On 22 February 2011 17:26, Phil Race wrote: We believe LCMS 2.0 should pass JCK, but I don't know if a full JCK run has been performed against a fully open 7 build since it went in. A 6-open backport would find any problems there. I w

Re: java.awt.Graphics: not a candidate for AutoCloseable?

2011-02-22 Thread Phil Race
Aside from the fact that its weird, if not downright wrong to think of a Graphics instance as "closeable", Graphics instances are not used in the same way as all the stream type resources for which AutoCloseable is intended. In most cases they are provided to you in a call to paint() Releasing a

Re: Zlib level in JDK7

2011-02-22 Thread Phil Race
On 2/20/2011 9:39 AM, Dr Andrew John Hughes wrote: On 15 February 2011 20:23, Phil Race wrote: On 2/15/2011 6:07 AM, Dr Andrew John Hughes wrote: Yes, IcedTea uses system libraries for everything bar LCMS, where local changes in OpenJDK mean we are still forced to use the in-tree version

Re: Zlib level in JDK7

2011-02-15 Thread Phil Race
On 2/15/2011 6:07 AM, Dr Andrew John Hughes wrote: Yes, IcedTea uses system libraries for everything bar LCMS, where local changes in OpenJDK mean we are still forced to use the in-tree version. There hasn't been any success upstreaming these changes, though I haven't looked at LCMS 2.x. L

Re: Is com.sun.image.codec.jpeg.JPEGCodec Included in OpenJDK?

2008-10-09 Thread Phil Race
Alan is right that the 2D list is the right place for this. But that bug report is mainly about a migration plan for removing it from even the "closed" JDK, which then aligns better with openjdk. A principal reason this is not in openjdk is that the code is encumbered, and given that is not part

Re: String.ltrim() and rtrim() methods RFE

2007-11-13 Thread Phil Race
Nick, I note this has just two customer records and just a single jdc vote despite having over eight years to accumulate these whilst it was open, whereas popular issues quickly accumulate hundreds of votes. Furthermore only one person has found it important enough to comment in the bug parade

<    1   2   3