Re: [13] RFR: 8218948: SimpleDateFormat :: format - Zone Names are not reflected correctly during run time

Hi Naoto, This fix looks good to me. Thanks, Rachna On 3/6/19 4:50 AM, Naoto Sato wrote: Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8218948 The proposed changeset is located at: http://cr.openjdk.java.net/~naoto/8218948/webrev.00/ This

Re: [12] RFR: 8216176: Clarify the singleton description in j.t.c.JapaneseEra class

Looks good to me. On 1/8/19 11:16 PM, Naoto Sato wrote: Hello, Please review the change for the following issue: Issue: https://bugs.openjdk.java.net/browse/JDK-8216176 CSR: https://bugs.openjdk.java.net/browse/JDK-8216177 The proposed changeset is located at:

Re: [13] RFR 8215913: [Test_bug]java/util/Locale/LocaleProvidersRun.java failed on de_DE and ja_JP locale.

Looks good to me. Thanks, Rachna On 1/7/19 12:36 PM, Dora Zhou wrote: Hi Rachna, Updated the webrev: http://cr.openjdk.java.net/~dzhou/8215913/webrev.01/ Regards, Dora On 2019/1/4 17:44, Rachna Goel wrote: Hi Dora, Kindly update copyright years in both files and add bug id

Re: [12] RFR: 8215303: Allowing additional currency code points from later Unicode updates

Hi Naoto, just one nit, copyright year need to be updated in Character.java. Thanks, Rachna On 1/3/19 10:26 PM, Naoto Sato wrote: Hello, Please review the fix to the following issue (and its approved CSR): https://bugs.openjdk.java.net/browse/JDK-8215303

Re: [12] RFR: 8215303: Allowing additional currency code points from later Unicode updates

Hi Naoto, Your fix looks good to me. Thanks, Rachna On 1/3/19 10:26 PM, Naoto Sato wrote: Hello, Please review the fix to the following issue (and its approved CSR): https://bugs.openjdk.java.net/browse/JDK-8215303 https://bugs.openjdk.java.net/browse/JDK-8215305 The proposed changeset is

Re: [13] RFR 8215913: [Test_bug]java/util/Locale/LocaleProvidersRun.java failed on de_DE and ja_JP locale.

Hi Dora, Kindly update copyright years in both files and add bug id in LocaleProvidersRun.java. Other than that, it looks good to me. Thanks, Rachna On 1/4/19 7:58 AM, Dora Zhou wrote: Hello, Please help review the fix for the test bug java/util/Locale/LocaleProvidersRun.java failed on

Re: [12] RFR: 8215194: Initial size of UnicodeBlock map is incorrect

Hi Naoto, Thanks for fixing this. Your fix looks good to me. Thanks, Rachna On 12/11/18 8:21 PM, Naoto Sato wrote: Hi, Please review the fix for the following issue: https://bugs.openjdk.java.net/browse/JDK-8215194 The proposed fix is located at:

RFR: [12] JDK-8209923 : Unicode 11.0.0

Hi, Kindly review this enhancement to support Unicode version in JDK to 11.0.0. Bug: https://bugs.openjdk.java.net/browse/JDK-8209923 patch: http://cr.openjdk.java.net/~rgoel/JDK-8209923/webrev.02/ -- Thanks, Rachna

[12] RFR:8210490:TimeZone.getDisplayName given Locale.US doesn't always honor the Locale

Hi, Kindly review fix to JDK-8210490. Bug: https://bugs.openjdk.java.net/browse/JDK-8210490 Webrev: http://cr.openjdk.java.net/~rgoel/JDK-8210490/webrev.05/ This is a regression caused by JDK-8202537, where for timezones such as Etc/GMT-5, display names got formatted according to default

[11] RFR: 8209047:"Illegal pattern character 'B'" IllegalArgumentException with Burmese locales

Hi, Kindly review the fix to JDK-8209047. Bug: https://bugs.openjdk.java.net/browse/JDK-8209047 webrev: http://cr.openjdk.java.net/~rgoel/JDK-8209047/webrev.03/ It is a regression caused by JDK-8202537. Because of the 'B' character introduced in the CLDR time patterns "B HH:mm:ss", "B H:mm"

[11]RFR:JDK-8206965: java/util/TimeZone/Bug8149452.java failed on de_DE and ja_JP locale.

Hi, Kindly review fix for JDK-8206965. Bug: https://bugs.openjdk.java.net/browse/JDK-8206965 patch: http://cr.openjdk.java.net/~rgoel/JDK-8206965/webrev.06/ This is a regression caused by JDK-8181157 due to which for some locales, timezone display names were not getting generated. Generating

[11] Review Request: 8204603: Short week days, NaN value and timezone name are inconsistent between CLDR and Java in zh_CN, zh_TW locales.

Hi, Kindly review fix to JDK-8204603. Bug: https://bugs.openjdk.java.net/browse/JDK-8204603 Fix: http://cr.openjdk.java.net/~rgoel/JDK-8204603/webrev.04/ This is a regression caused by JDK-8179071, where locale data is getting incorrectly retrieved (not following languageAliases of CLDR) for

Re: RFR: JDK-8205158: Update the .md files for 3rd party software Unicode 10.0, ICU 60.1, and CLDR v33

wrote: On 6/22/18 6:54 AM, Rachna Goel wrote: Hi, Kindly review fix to update legal files for Unicode, CLDR and ICU. Issue: https://bugs.openjdk.java.net/browse/JDK-8205158 Patch :http://cr.openjdk.java.net/~rgoel/JDK-8205158/webrev.02/ Looks okay. What are the issues that upgrades

Re: RFR: JDK-8205158: Update the .md files for 3rd party software Unicode 10.0, ICU 60.1, and CLDR v33

Hi, Kindly ignore patch mentioned in previous mail. patch for review is : http://cr.openjdk.java.net/~rgoel/JDK-8205158/webrev.01/ Thanks, Rachna On 6/22/18 7:24 PM, Rachna Goel wrote: Hi, Kindly review fix to update legal files for Unicode, CLDR and ICU. Issue: https

RFR: JDK-8205158: Update the .md files for 3rd party software Unicode 10.0, ICU 60.1, and CLDR v33

Hi, Kindly review fix to update legal files for Unicode, CLDR and ICU. Issue: https://bugs.openjdk.java.net/browse/JDK-8205158 Patch :http://cr.openjdk.java.net/~rgoel/JDK-8205158/webrev.02/ -- Thanks, Rachna

Re: RFR: [11] 8202537: CLDR 33

...@oracle.com wrote: Hi Rachna, A couple of comments: - NumberingSystemsParseHandler.java Since the code substitutes latin digits for supplementary digits, it can skip line 68-79. - A test should be written for the above substitution. Naoto On 6/12/18 10:33 PM, Rachna Goel wrote: Hi, Kindly

Re: RFR: [11] 8202537: CLDR 33

retrieved by APIs. Thanks, Rachna* * On 6/13/18 8:06 PM, Roger Riggs wrote: Hi Rachna, How much of the updates are done mechanically between the CLDR data and the .xml files? Manually reviewing that many files is likely to be error prone. Thanks, Roger On 6/13/2018 1:33 AM, Rachna Goel

RFR: [11] 8202537: CLDR 33

Hi, Kindly review fix for JDK-8202537. Fix is to upgrade Unicode consortium's CLDR data into JDK from current version 29 to 33. For more info : http://cldr.unicode.org/index/downloads/cldr-33 Bug : https://bugs.openjdk.java.net/browse/JDK-8202537 Patch:

[11] RFR JDK-8203474: Update description of "Cyrillic Supplementary" block name in Character.UnicodeBlock class.

Hi, Kindly review this small doc fix to Character.UnicodeBlock class. Bug: https://bugs.openjdk.java.net/browse/JDK-8203474 Patch: --- a/src/java.base/share/classes/java/lang/Character.javaSun May 27 12:00:16 2018 +0530 +++ b/src/java.base/share/classes/java/lang/Character.java Mon May

[11] RFR: JDK-8202582 : DateTimeFormatterBuilder.parseOffsetBased unnecessarily calls toString()

Hi, Kindly review this small patch for JDK-8202582. https://bugs.openjdk.java.net/browse/JDK-8202582 http://cr.openjdk.java.net/~rgoel/JDK-8202582/webrev/ Fix is to call text.subSequence() before calling toString() on input string, for more performance. -- Thanks, Rachna

Re: [11] RFR:JDK-8179071:Month value is inconsistent between CLDR and Java in some special locales

One correction: E.g "pa-PK" wil be replaced by "pa-Arab-PK", as former is a deprecated/legacy tag. On 4/27/18 12:05 PM, Rachna Goel wrote: Hi, Kindly review the fix for JDK-8179071. Bug : https://bugs.openjdk.java.net/browse/JDK-8179071 Patch: http://cr.openjdk

[11] RFR:JDK-8179071:Month value is inconsistent between CLDR and Java in some special locales

Hi, Kindly review the fix for JDK-8179071. Bug : https://bugs.openjdk.java.net/browse/JDK-8179071 Patch: http://cr.openjdk.java.net/~rgoel/JDK-8179071/webrev.03/index.html Fix is to parse and store language aliases( Deprecated and Legacy ) from CLDR's SupplemetalMetaData file. At run time,

Re: [11] RFR: 8191410 : Unicode 10.0.0

accidental changes: the space should not be removed and the trailing "{" doesn't make sense in a comment. Regards, Roger On 3/8/2018 6:56 AM, Rachna Goel wrote: Hi, Please review the proposed changes for JDK-819410. Bug : https://bugs.openjdk.java.net/browse/JDK-8191410 proposed

[11] RFR: 8191410 : Unicode 10.0.0

Hi, Please review the proposed changes for JDK-819410. Bug : https://bugs.openjdk.java.net/browse/JDK-8191410 proposed changeset is located at : http://cr.openjdk.java.net/~rgoel/JDK-8191410/webrev/ This serves as the implementation for JEP 327. -- Thanks, Rachna

Re: [11] RFR of 8146656: Wrong Months Array for DateFormatSymbols

tag switch is acceptable, but also think providing more text to describe this situation would be helpful to programmers unaware of a 13 month possibility. Cheers, -Joe On 12/19/2017 2:08 AM, Rachna Goel wrote: Hi Joe, Thanks for the comments. I have updated the CSR to have @implSpec

Re: [11] RFR of 8146656: Wrong Months Array for DateFormatSymbols

Rachna, I think the revised version with the @implSpec tag switch is acceptable, but also think providing more text to describe this situation would be helpful to programmers unaware of a 13 month possibility. Cheers, -Joe On 12/19/2017 2:08 AM, Rachna Goel wrote: Hi Joe, Thanks

Re: [11] RFR of 8146656: Wrong Months Array for DateFormatSymbols

12/17 2:55 PM, joe darcy wrote: Hi Rachna, On 12/19/2017 1:13 AM, Rachna Goel wrote: Hello Joe, Thanks for the review. Reason I added @implNote is that it's the case for the default implementation. Not added as a part of spec, as some implementation can just return 12 element array for sa

Re: [11] RFR of 8146656: Wrong Months Array for DateFormatSymbols

ks, Rachna On 19/12/17 2:07 PM, joe darcy wrote: Hello Rachna, On 12/18/2017 10:35 PM, Rachna Goel wrote: Hi, Kindly review API Doc fix for java.text.DateFormatSymbols. JBS Issue : https://bugs.openjdk.java.net/browse/JDK-8146656 Webrev: http://cr.openjdk.java.net/~rgoel/8146656/webrev/

[11] RFR of 8146656: Wrong Months Array for DateFormatSymbols

Hi, Kindly review API Doc fix for java.text.DateFormatSymbols. JBS Issue : https://bugs.openjdk.java.net/browse/JDK-8146656 Webrev: http://cr.openjdk.java.net/~rgoel/8146656/webrev/ CSR: https://bugs.openjdk.java.net/browse/JDK-8191414 -- Thanks, Rachna

JDK10 RFR of JDK-8185841:Values from getFirstDayOfWeek() are inconsistent with CLDR

Hi, Kindly review the fix to JDK-8185841. Bug : https://bugs.openjdk.java.net/browse/JDK-8185841. patch : http://cr.openjdk.java.net/~rgoel/JDK-8185841/webrev.08/ Fix is to relocate this region dependent data. New Bundle will be generated when Locale id has non empty script and country code

Re: RFR(s): 8171958: Several tests from java/time/test/java/time/format requiring jdk.localedata for execution

properties file. I recreated the review by adding TEST.properties modification: http://cr.openjdk.java.net/~skovalev/8171958/webrev.01/ 27.12.16 13:55, Rachna Goel wrote: Hi Sergei, Though I am not a reviewer, But I have one comment on this fix. test/java/time/TEST.properties declares "module

Re: RFR(s): 8171958: Several tests from java/time/test/java/time/format requiring jdk.localedata for execution

Hi Sergei, Though I am not a reviewer, But I have one comment on this fix. test/java/time/TEST.properties declares "modules = jdk.localedata" , so that all tests for java.time can have access to "jdk.localedata" module. If we are restricting usage of jdk.localedata module for different

Re: RFR: JDK-8075577: java.time does not support HOST provider

ta are yet to be discussed. If Masayoshi is satisfied and you have tested it in the target configuration then perhaps it is not worthwhile to invest in a special case regression test. Thanks, Roger On 11/30/2016 4:39 AM, Masayoshi Okutsu wrote: Looks good to me. Masayoshi On 11/22/2016 6:30 P

RFR: JDK-8075577: java.time does not support HOST provider

Hi, Please review fix for JDK-8075577. Bug : https://bugs.openjdk.java.net/browse/JDK-8075577 webrev : http://cr.openjdk.java.net/~rgoel/JDK-8075577/webrev.01/ Fix is to introduce new private spi "sun.text.spi.JavaTimeDateTimePatternProvider.java" to retrieve LocaleProvider specific

Re: RFR:JDK-8168906-Tighten permissions granted to the jdk.localedata module

sorry, correction to typo As jdk.localedata module does *not* read any system properties, tightened permissions for same. On 14/11/16 12:42 PM, Rachna Goel wrote: Hi, Kindly review fix for JDK-8168906. https://bugs.openjdk.java.net/browse/JDK-8168906 Patch :http://cr.openjdk.java.net

RFR:JDK-8168906-Tighten permissions granted to the jdk.localedata module

Hi, Kindly review fix for JDK-8168906. https://bugs.openjdk.java.net/browse/JDK-8168906 Patch :http://cr.openjdk.java.net/~rgoel/JDK-8168906/webrev/ fix: As jdk.localedata module does read any system properties, tightened permissions for same. Thanks, Rachna

RFR: JDK-8146750:java.time.Month.getDisplayName() return incorrect narrow names with JRE provider on locale de,de_DE,en_US.

Hi, Please review fix for JDK-8146750. Bug : https://bugs.openjdk.java.net/browse/JDK-8146750 webrev : http://cr.openjdk.java.net/~rgoel/JDK-8146750/webrev.09/ Fix is to retrieve Narrow and Narrow_Standalone Month names and Day names one by one, as they can be duplicate. Thanks, Rachna

RFR:JDK-8146750:java.time.Month.getDisplayName() return incorrect narrow names with JRE provider.

Hi, Please review fix for JDK-8146750. Bug : https://bugs.openjdk.java.net/browse/JDK-8146750 Fix: http://cr.openjdk.java.net/~rgoel/JDK-8146750/webrev.04/ Fix is to retrieve Narrow and Narrow_Standalone Month names as well as Day names one by one, as they can be duplicate. Thanks, Rachna