Re: RFR: 8265421: java/lang/String/StringRepeat.java test is missing a memory requirement [v2]

On Mon, 19 Apr 2021 12:50:07 GMT, Christoph Göttschkes wrote: >> Please review the following patch, which fixes the mentioned test case for >> memory constrained devices. This can be tested on a linux based development >> machine, using systemd as follows: >> >> >> $ systemd-run --user --scop

Re: RFR: 8263668: Update java.time to use instanceof pattern variable

On Wed, 24 Mar 2021 09:56:16 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my code for updating the code in the `java.time` > package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick LGTM! - Marked as reviewed by ryadav (Commit

Integrated: 8255214: Unsupported 'valign' attribute for 'th' tag used in j.u.l.LogManager

On Wed, 4 Nov 2020 21:52:56 GMT, Rahul Yadav wrote: > Hello, > > Request to review this small change, as HTML4 support has been dropped from > javadoc. > Have replaced valign="top" with style="vertical-align:top". This pull request has now been inte

RFR: 8255214 : Unsupported 'valign' attribute for 'th' tag used in j.u.l.LogManager

Hello, Request to review this small change, as HTML4 support has been dropped from javadoc. Have replaced valign="top" with style="vertical-align:top". - Commit messages: - JDK-8255214 : Unsupported 'valign' attribute for 'th' tag used in j.u.l.LogManager Changes: https://git.ope

Re: RFR 8245302: Upgrade LogRecord to support long thread ids and remove its usage of ThreadLocal

Hello, I have added comments @Serial based on csr feedback for read/writeObject methods. webrev: http://cr.openjdk.java.net/~ryadav/webrev_8245302/webrev.00/ - rahul On 25/06/2020 10:22, Rahul Yadav wrote: Hello, Deprecated tag in LogRecord getter and setter for threadID was missing

Re: RFR 8245302: Upgrade LogRecord to support long thread ids and remove its usage of ThreadLocal

st regards, -- daniel On 19/06/2020 10:00, Rahul Yadav wrote: Thank you Alan, updated webrev. webrev : http://cr.openjdk.java.net/~ryadav/webrev_8245302/webrev.00/index.html - rahul On 19/06/2020 08:43, Alan Bateman wrote: On 18/06/2020 23:37, Rahul Yadav wrote: Hi Alan, Thank y

Re: RFR 8245302: Upgrade LogRecord to support long thread ids and remove its usage of ThreadLocal

can be deserialized in those versions.   You should probably log a JBS issue to follow-up on that. best regards, -- daniel On 18/06/2020 23:37, Rahul Yadav wrote: Hi Alan, Thank you for the feedback.I have updated the webrev. webrev : http://cr.openjdk.java.net/~ryadav/webrev_8245302/web

Re: RFR 8245302: Upgrade LogRecord to support long thread ids and remove its usage of ThreadLocal

Thank you Alan, updated webrev. webrev : http://cr.openjdk.java.net/~ryadav/webrev_8245302/webrev.00/index.html - rahul On 19/06/2020 08:43, Alan Bateman wrote: On 18/06/2020 23:37, Rahul Yadav wrote: Hi Alan, Thank you for the feedback.I have updated the webrev. webrev : http

Re: RFR 8245302: Upgrade LogRecord to support long thread ids and remove its usage of ThreadLocal

Hi Alan, Thank you for the feedback.I have updated the webrev. webrev : http://cr.openjdk.java.net/~ryadav/webrev_8245302/webrev.00/index.html - rahul On 14/06/2020 14:22, Alan Bateman wrote: On 10/06/2020 16:06, Rahul wrote:    Hello,    Request to have my fix reviewed for the issue: