Re: RFR: 8284638: store skip buffers in InputStream Object [v15]

2022-05-29 Thread Sergey Kuksenko
On Tue, 24 May 2022 20:40:51 GMT, XenoAmess wrote: >> @jmehrens what about this then? >> I think it safe now(actually this mechanism is learned from Reader) > > XenoAmess has updated the pull request incrementally with one additional > commit since the last revision: > > invert if; refine

Re: RFR: 8284638: store skip buffers in InputStream Object [v15]

2022-05-29 Thread Sergey Kuksenko
On Tue, 24 May 2022 20:40:51 GMT, XenoAmess wrote: >> @jmehrens what about this then? >> I think it safe now(actually this mechanism is learned from Reader) > > XenoAmess has updated the pull request incrementally with one additional > commit since the last revision: > > invert if; refine

Re: RFR: 8284638: store skip buffers in InputStream Object [v15]

2022-05-29 Thread Sergey Kuksenko
On Thu, 26 May 2022 15:43:57 GMT, XenoAmess wrote: > > Is there any practical scenario where the current code (skip buffer > > allocation on each invocation) creates issues? > > @kuksenko Not found any yet :) In that case, what is the value of this PR? Do we need a code change for the sake

Re: RFR: 8284638: store skip buffers in InputStream Object [v15]

2022-05-25 Thread Sergey Kuksenko
On Tue, 24 May 2022 20:40:51 GMT, XenoAmess wrote: >> @jmehrens what about this then? >> I think it safe now(actually this mechanism is learned from Reader) > > XenoAmess has updated the pull request incrementally with one additional > commit since the last revision: > > invert if; refine

Re: RFR(s): 8176894 Provide specialized implementation for default methods putIfAbsent, computeIfAbsent, computeIfPresent, compute, merge in TreeMap

2019-11-22 Thread Sergey Kuksenko
e spec. No changes in code/tests. Also please review the associated CSR: https://bugs.openjdk.java.net/browse/JDK-8227666 I updated it, according to Joe Darcy's comments. An additional explanation and background is copied below from my original e-mail [2] for your convenience: The patch was

Re: JDK 10 RFR of 8176894: Provide specialized implementation for default methods putIfAbsent, computeIfAbsent, computeIfPresent, compute in TreeMap

2017-04-10 Thread Sergey Kuksenko
; } On 2017-03-28 21:22, Sergey Kuksenko wrote: Friendly reminder. Have you have chance to review the latest version? On 03/17/2017 12:45 PM, Sergey Kuksenko wrote: Hi, All. I realized (thanks Tagir V.) that if we don't check modCount after calling mapping function we may get corrupt

Re: JDK 10 RFR of 8176894: Provide specialized implementation for default methods putIfAbsent, computeIfAbsent, computeIfPresent, compute in TreeMap

2017-03-28 Thread Sergey Kuksenko
Friendly reminder. Have you have chance to review the latest version? On 03/17/2017 12:45 PM, Sergey Kuksenko wrote: Hi, All. I realized (thanks Tagir V.) that if we don't check modCount after calling mapping function we may get corrupted tree structure. new webrev for review: http

Re: JDK 10 RFR of 8176894: Provide specialized implementation for default methods putIfAbsent, computeIfAbsent, computeIfPresent, compute in TreeMap

2017-03-17 Thread Sergey Kuksenko
probably not your job though (it may be mine!) I would probably try hand-injecting some bugs into a copy of the code and seeing if our jtreg tests catch it, to increase coverage confidence. On Thu, Mar 16, 2017 at 12:04 PM, Sergey Kuksenko <sergey.kukse...@oracle.com <mailto:sergey.kuks

Re: JDK 10 RFR of 8176894: Provide specialized implementation for default methods putIfAbsent, computeIfAbsent, computeIfPresent, compute in TreeMap

2017-03-17 Thread Sergey Kuksenko
SK> http://cr.openjdk.java.net/~skuksenko/corelibs/utils/8176894/webrev.00/ SK> The issue was created for JDK10 in order to don't disturb JDK9 before SK> launch. -- Best regards, Sergey Kuksenko

Re: JDK 10 RFR of 8176894: Provide specialized implementation for default methods putIfAbsent, computeIfAbsent, computeIfPresent, compute in TreeMap

2017-03-17 Thread Sergey Kuksenko
review: SK> https://bugs.openjdk.java.net/browse/JDK-8176894 SK> http://cr.openjdk.java.net/~skuksenko/corelibs/utils/8176894/webrev.00/ SK> The issue was created for JDK10 in order to don't disturb JDK9 before SK> launch. -- Best regards, Sergey Kuksenko

JDK 10 RFR of 8176894: Provide specialized implementation for default methods putIfAbsent, computeIfAbsent, computeIfPresent, compute in TreeMap

2017-03-16 Thread Sergey Kuksenko
Hi All, Please, review: https://bugs.openjdk.java.net/browse/JDK-8176894 http://cr.openjdk.java.net/~skuksenko/corelibs/utils/8176894/webrev.00/ The issue was created for JDK10 in order to don't disturb JDK9 before launch. -- Best regards, Sergey Kuksenko

Re: JDK 9 RFR of 6375303: Review use of caching in BigDecimal

2014-03-11 Thread Sergey Kuksenko
and multiple string instances being returned. The new implementation, at small cost, prevents multiple different instances from being returned. Mike -- Best regards, Sergey Kuksenko

Re: JDK 9 RFR of 6375303: Review use of caching in BigDecimal

2014-03-11 Thread Sergey Kuksenko
regards, Sergey Kuksenko

Re: RFR (M): 8024635: Caching MethodType's descriptor string improves lambda linkage performance

2013-09-27 Thread Sergey Kuksenko
. On 09/26/2013 11:09 PM, John Rose wrote: (Quick note on format: I have changed the subject line to include the conventional bug number and size estimate. The bug number makes it easier to track in mailers.) On Sep 26, 2013, at 9:22 AM, Sergey Kuksenko sergey.kukse...@oracle.com wrote

Re: RFR: Caching MethodType's descriptor string improves lambda linkage performance

2013-09-17 Thread Sergey Kuksenko
the discussion. — John On Sep 11, 2013, at 12:03 PM, Sergey Kuksenko sergey.kukse...@oracle.com wrote: On 09/11/2013 09:01 PM, Aleksey Shipilev wrote: On 09/11/2013 08:23 PM, Sergey Kuksenko wrote: http://cr.openjdk.java.net/~skuksenko/jsr335/8024635/webrev.00/ As much as I hate to see the hand

RFR: Direct LambdaMetaFactory invocation from CallSite significantly improves lambda linkage performance

2013-09-11 Thread Sergey Kuksenko
to LambdaMetafactory. The modification gives +10% - +35% to lambda linkage performance (depends on amount of lambdas). -- Best regards, Sergey Kuksenko

RFR: Caching MethodType's descriptor string improves lambda linkage performance

2013-09-11 Thread Sergey Kuksenko
% to lambda linkage performance. Minor performance improvement: private method checkPtype was inlined and eliminated. checkRtype and checkPtypes were refactored for better perfomance in HotSpot interpreter (important for lambda linkage). overall result +1%. -- Best regards, Sergey Kuksenko

Re: RFR: Direct LambdaMetaFactory invocation from CallSite significantly improves lambda linkage performance

2013-09-11 Thread Sergey Kuksenko
On 09/11/2013 08:23 PM, Sergey Kuksenko wrote: http://cr.openjdk.java.net/~skuksenko/jsr335/8024630/webrev.00/ * webrev metadata: invokation - invocation misprint. Should I fix it right now, or may it be done later? * Why $caller is MethodHandles.Lookup now? Is it known to have that type

Re: RFR: Caching MethodType's descriptor string improves lambda linkage performance

2013-09-11 Thread Sergey Kuksenko
On 09/11/2013 09:01 PM, Aleksey Shipilev wrote: On 09/11/2013 08:23 PM, Sergey Kuksenko wrote: http://cr.openjdk.java.net/~skuksenko/jsr335/8024635/webrev.00/ As much as I hate to see the hand code tweaking instead of relying on compiler to do it's job, I understand this is about interpreter

Re: RFR: 8015522 - CharSequence.codePoints can be faster

2013-06-04 Thread Sergey Kuksenko
of operation, for example, inline block.accept instead of store the character to a local var also helps. Cheers, Henry -- Best regards, Sergey Kuksenko

Re: Measuring performance changes from applying 4837946 patch

2013-06-04 Thread Sergey Kuksenko
there is the liberty of distributing N threads over M hardware threads (N M) -Aleksey. -- Best regards, Sergey Kuksenko

Re: RFR: 4837946 - Faster multiplication and exponentiation of large integers

2013-05-17 Thread Sergey Kuksenko
naturally. -- Best regards, Sergey Kuksenko