please review patch for 8026854: java.time.temporal.TemporalQueries doesn't compile after javac modification to lambda flow analysis

2013-10-18 Thread Vicente-Arturo Romero-Zaldivar
Hi, Please review this patch, which modifies java.time.temporal.TemporalQueries so it compiles after last changes to javac lambda flow analysis. The webrev is here: http://cr.openjdk.java.net/~vromero/8026854/webrev_01/ The bug report is here:

Re: please review patch for 8026854: java.time.temporal.TemporalQueries doesn't compile after javac modification to lambda flow analysis

2013-10-18 Thread Vicente-Arturo Romero-Zaldivar
On 18/10/13 13:00, Paul Sandoz wrote: On Oct 18, 2013, at 12:58 PM, Vicente-Arturo Romero-Zaldivar vicente.rom...@oracle.com wrote: Hi, Please review this patch, which modifies java.time.temporal.TemporalQueries so it compiles after last changes to javac lambda flow analysis. The webrev

Re: RFR: 8022343: j.l.Class.getAnnotatedSuperclass() doesn't return null in some cases

2013-08-16 Thread Vicente-Arturo Romero-Zaldivar
It looks OK for me, Vicente On 16/08/13 13:17, Joel Borggren-Franck wrote: Hi Please review this small fix for a type annotation reflection issue. The javadoc spec for Class.getAnnotatedSuperclass says: * If this Class represents either the Object class, an interface type, an * array

code review request: JDK-8015780: java/lang/reflect/Method/GenericStringTest.java failing

2013-08-06 Thread Vicente-Arturo Romero-Zaldivar
Hello, Please review this patch, which updates test jdk/test/java/lang/reflect/Method/GenericStringTest.java for it to pass after changes introduced to generation of bridge methods. Now if a bridge method is generated, all annotations present in the related standard method are copied to the

Re: hg: jdk8/tl/langtools: 8006212: javac, convert jtreg tests from shell script to java

2013-02-20 Thread Vicente-Arturo Romero-Zaldivar
On 19/02/13 18:50, Jonathan Gibbons wrote: Woohoo -- 23 shell tests replaced with equivalent Java code: that's over 2/3 of the shell tests in langtools/test. And lots of files removed, less is more :) Vicente -- Jon On 02/19/2013 09:54 AM, vicente.rom...@oracle.com wrote: Changeset: