> This is a follow up update per comments in [JDK-8287384
> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
> open part looks good to me. Please help to run Mach5 just case the closed
> test cases are impacted.
Xue-Lei Andrew Fan has updated the
> This is a follow up update per comments in [JDK-8287384
> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
> open part looks good to me. Please help to run Mach5 just case the closed
> test cases are impacted.
Xue-Lei Andrew Fan has updated the
On Wed, 1 Jun 2022 21:09:15 GMT, Mandy Chung wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> back to wait 1 second
>
> No, it doesn't work. You can build a fastdebug build wit
> This is a follow up update per comments in [JDK-8287384
> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
> open part looks good to me. Please help to run Mach5 just case the closed
> test cases are impacted.
Xue-Lei Andrew Fan has updated the
On Fri, 3 Jun 2022 18:05:52 GMT, Mandy Chung wrote:
> This reapplies JDK-8287384 and adjust the number of GCs for negative case,
> i.e. the condition is never met that is used to verify a reference is not
> GC'ed.
Marked as reviewed by xuelei (Reviewer).
@mlchung Thank you for pick up and
> This is a follow up update per comments in [JDK-8287384
> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
> open part looks good to me. Please help to run Mach5 just case the closed
> test cases are impacted.
Xue-Lei Andrew Fan has updated the
On Wed, 1 Jun 2022 19:08:03 GMT, Xue-Lei Andrew Fan wrote:
> This is a follow up update per comments in [JDK-8287384
> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
> open part looks good to me. Please help to run Mach5 just case the closed
>
> This is a follow up update per comments in [JDK-8287384
> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
> open part looks good to me. Please help to run Mach5 just case the closed
> test cases are impacted.
Xue-Lei Andrew Fan has updated the
On Wed, 1 Jun 2022 21:07:16 GMT, Xue-Lei Andrew Fan wrote:
>> This is a follow up update per comments in [JDK-8287384
>> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
>> open part looks good to me. Please help to run Mach5 just case the clo
On Wed, 1 Jun 2022 20:45:07 GMT, Mandy Chung wrote:
> JDK-8287384 causes
> `test/jdk/java/lang/invoke/defineHiddenClass/UnloadingTest.java` to timeout
> when running with fastdebug VM. I think this might be caused by more frequent
> GCs.
>
> I tried your patch and the test fails.
I updated
> This is a follow up update per comments in [JDK-8287384
> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
> open part looks good to me. Please help to run Mach5 just case the closed
> test cases are impacted.
Xue-Lei Andrew Fan has updated the
This is a follow up update per comments in [JDK-8287384
PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
open part looks good to me. Please help to run Mach5 just case the closed test
cases are impacted.
-
Commit messages:
- Remove trailing white space
On Thu, 26 May 2022 18:50:07 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this test update reviewed?
>
> The ForceGC could be enhanced by using smaller wait/sleep time, and shared
> cleaner.
>
> Thanks,
> Xuelei
Sorry, I was working on a history webpage
On Thu, 26 May 2022 18:50:07 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this test update reviewed?
>
> The ForceGC could be enhanced by using smaller wait/sleep time, and shared
> cleaner.
>
> Thanks,
> Xuelei
This pull request has now been integrated.
On Thu, 26 May 2022 21:40:42 GMT, Xue-Lei Andrew Fan wrote:
> > Even using a Cleaner is a more overhead than necessary. I would have
> > skipped the overhead of a cleaner and Atomic classes with something more
> > self contained as a static method:
>
> I agreed t
On Thu, 26 May 2022 21:22:23 GMT, Roger Riggs wrote:
> Even using a Cleaner is a more overhead than necessary. I would have skipped
> the overhead of a cleaner and Atomic classes with something more self
> contained as a static method:
I agreed that the using of Cleaner is still heavy, but
Hi,
May I have this test update reviewed?
The ForceGC could be enhanced by using smaller wait/sleep time, and shared
cleaner.
Thanks,
Xuelei
-
Commit messages:
- 8287384: Speed up ForceGC
Changes: https://git.openjdk.java.net/jdk/pull/8907/files
Webrev:
On Thu, 19 May 2022 09:31:07 GMT, Kevin Walls wrote:
>> Replaces usages of articles that follow each other in all combinations:
>> a/the, an?/an?, the/the…
>>
>> Also, I fixed a couple of spelling mistakes.
>
> test/jdk/sun/security/tools/jarsigner/OldSig.java line 32:
>
>> 30: /*
>> 31: *
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
The security/crypto parts look good to me.
-
Marked as reviewed by xuelei
On Tue, 10 May 2022 21:32:10 GMT, Roger Riggs wrote:
> PR#8599 8244681: proposes to add compiler warnings for possible lossy
> conversions
> From the CSR:
>
> "If the type of the right-hand operand of a compound assignment is not
> assignment compatible with the type of the variable, a cast
On Sun, 20 Mar 2022 12:45:34 GMT, Andrey Turbanov wrote:
> In a few places String.indexOf/lastIndexOf methods are called with default
> parameter for index: `0` for `indexOf`, length() for `lastIndexOf`.
> I propose to cleanup such calls. It makes code a bit easier to read. In case
> of
On Wed, 23 Mar 2022 21:59:02 GMT, Valerie Peng wrote:
>> I see.
>>
>> Would you mind add a comment about the provider loading impact, just in case
>> someone else have similar questions in the future?
>
> Sure, I can do that. Will add a comment about this.
Thank you. I have no more comment
On Wed, 23 Mar 2022 22:48:41 GMT, Valerie Peng wrote:
>> It's been several years since we increased the default key sizes. Before
>> shifting to PQC, NSA replaced its Suite B cryptography recommendations with
>> the Commercial National Security Algorithm Suite which suggests:
>>
>> - SHA-384
On Wed, 23 Mar 2022 20:45:22 GMT, Valerie Peng wrote:
>> src/java.base/share/classes/sun/security/util/SecurityProviderConstants.java
>> line 129:
>>
>>> 127: return currVal;
>>> 128: }
>>> 129:
>>
>> I'm not very sure of this method. Is it performance friendly if making the
>>
On Tue, 22 Mar 2022 21:25:28 GMT, Valerie Peng wrote:
>> It's been several years since we increased the default key sizes. Before
>> shifting to PQC, NSA replaced its Suite B cryptography recommendations with
>> the Commercial National Security Algorithm Suite which suggests:
>>
>> - SHA-384
On Sun, 20 Mar 2022 13:30:01 GMT, Andrey Turbanov wrote:
> Fix repeated type `exeption`
Looks good to me. Thanks!
-
Marked as reviewed by xuelei (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/7879
On Fri, 8 Jan 2021 16:26:09 GMT, Roger Riggs wrote:
>> Followup to the addition of java.util.HexFormat.
>> Uses of adhoc hexadecimal conversions are replaced with HexFormat.
>> Redundant utility methods are modified or removed.
>> In a few places the data being printed is ASN.1 and the test
On Thu, 7 Jan 2021 18:26:12 GMT, Rajan Halade wrote:
> 8039278: console.sh failed Automatically with exit code 1
Marked as reviewed by xuelei (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/1981
On Wed, 2 Dec 2020 18:42:36 GMT, Christoph Langer wrote:
>> test/jdk/sun/security/ssl/SSLSocketImpl/SSLSocketLeak.java line 37:
>>
>>> 35: * will not leave leaking socket file descriptors
>>> 36: * @library /test/lib
>>> 37: * @run main/othervm SSLSocketLeak
>>
>> See bellow
On Sun, 22 Nov 2020 18:27:56 GMT, Christoph Langer wrote:
>> There is a flaw in sun.security.ssl.SSLSocketImpl::close() which leads to
>> leaking socket resources after JDK-8224829.
>>
>> The close method calls duplexCloseOutput() and duplexCloseInput(). In case
>> of an exception in any of
On Sun, 22 Nov 2020 18:27:56 GMT, Christoph Langer wrote:
>> There is a flaw in sun.security.ssl.SSLSocketImpl::close() which leads to
>> leaking socket resources after JDK-8224829.
>>
>> The close method calls duplexCloseOutput() and duplexCloseInput(). In case
>> of an exception in any of
On Fri, 27 Nov 2020 15:46:08 GMT, Christoph Langer wrote:
>> I changed the check for when to do duplexClose to only do it when socket
>> isConnected().
>>
>> I also added a testcase which should work on all platforms. For windows I
>> borrowed some functionality introduced lately with test
32 matches
Mail list logo
