Re: RFR: JDK-8284858: Start of release updates for JDK 20 [v6]

2022-06-08 Thread Iris Clark
On Thu, 9 Jun 2022 01:03:47 GMT, Joe Darcy wrote: >> Time to start getting ready for JDK 20... > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request

Re: RFR: 8288068: Javadoc contains spurious reference to CLinker

2022-06-08 Thread Iris Clark
On Wed, 8 Jun 2022 21:07:13 GMT, Maurizio Cimadamore wrote: > This simple patch fixes a bunch of references to "CLinker" and replaces them > with "Linker", following the API name changes. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/9094

Re: CFV: new Core Libraries Group member: Roger Riggs

2022-06-07 Thread Iris Clark
Vote: yes Iris

Re: CVF: new Core Libraries Group member: Naoto Sato

2022-06-06 Thread Iris Clark
Vote yes Iris From: core-libs-dev on behalf of Stuart Marks Sent: Monday, June 6, 2022 5:52 PM To: core-libs-dev Subject: CVF: new Core Libraries Group member: Naoto Sato I hereby nominate Naoto Sato [1] to membership in the Core Libraries Group [2]. Naoto S

Re: RFR: 8287541: Files.writeString fails to throw IOException for charset "windows-1252"

2022-06-03 Thread Iris Clark
On Fri, 3 Jun 2022 16:48:46 GMT, Naoto Sato wrote: > The code path calls `String.getBytesNoRepl()`, but it blindly replaces > unmappable characters with replacements if the encoder is an `ArrayEncoder`. > Changed only to do so if `doReplace` is `true` in > `String.encodeWithEncoder()`. Marked

Re: RFR: JDK-8284858: Start of release updates for JDK 20 [v5]

2022-06-02 Thread Iris Clark
On Thu, 2 Jun 2022 17:00:35 GMT, Joe Darcy wrote: >> Time to start getting ready for JDK 20... > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request

Re: RFR: JDK-8284858: Start of release updates for JDK 20 [v3]

2022-05-31 Thread Iris Clark
On Tue, 31 May 2022 20:32:13 GMT, Joe Darcy wrote: >> Time to start getting ready for JDK 20... > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull reques

Re: RFR: 8287340: Refactor old code using StringTokenizer in locale related code

2022-05-31 Thread Iris Clark
On Tue, 31 May 2022 17:46:18 GMT, Naoto Sato wrote: > Refactoring some old code in locale providers. The test case data have also > been modified due to: > - There's a bug in `LocaleProviderAdapter.toLocaleArray()` where it did not > handle the case for `no-NO-NY`. > - `Locale.toLanguageTag()`

Re: RFR: 8287440: Typo in package-info.java of java.util.random

2022-05-27 Thread Iris Clark
On Wed, 18 May 2022 11:45:46 GMT, Anthony Vanelverdinghe wrote: > The change is trivial, but I'll need help from someone to create a JBS issue > & sponsor this PR. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8766

Re: RFR: JDK-8284858: Start of release updates for JDK 20 [v2]

2022-05-27 Thread Iris Clark
On Thu, 26 May 2022 23:05:32 GMT, Joe Darcy wrote: >> Time to start getting ready for JDK 20... > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Respond to review feedback. Marked as reviewed by iris (Reviewer). -

Re: RFR: JDK-8284858: Start of release updates for JDK 20 [v2]

2022-05-26 Thread Iris Clark
On Thu, 26 May 2022 23:05:32 GMT, Joe Darcy wrote: >> Time to start getting ready for JDK 20... > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Respond to review feedback. Marked as reviewed by iris (Reviewer). -

Re: RFR: 8284209: Replace remaining usages of 'a the' in source code

2022-05-18 Thread Iris Clark
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > It's the last issue in the series, and it still touches different areas of > the code. Marked as reviewed by iris (Reviewer). --

Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base

2022-05-18 Thread Iris Clark
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > Also, I fixed a couple of spelling mistakes. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/j

Re: RFR: 8284213: Replace usages of 'a the' in xml

2022-05-18 Thread Iris Clark
On Wed, 18 May 2022 13:58:22 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > I tried to avoid changing external libraries, there are quite a few such > typos. > Let me know if I should revert any files. Marked

Re: RFR: 8286858: Remove dead code in sun.reflect.misc.MethodUtil

2022-05-17 Thread Iris Clark
On Sun, 15 May 2022 12:47:10 GMT, Andrey Turbanov wrote: > They are unused and leftover since JDK 7. It's good to remove them. Nice clean up. - Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8715

Re: RFR: JDK-8286615: Small refactor to SerializedLambda

2022-05-11 Thread Iris Clark
On Thu, 12 May 2022 00:10:28 GMT, Joe Darcy wrote: > Noticed by inspection during a CSR review, small refactoring to use a > message-cause exception constructor when one is available. > > Will update the copyright before a push. Marked as reviewed by iris (Reviewer). - PR: https:

Re: RFR: JDK-8286604: Update InputStream and OutputStream to use @implSpec

2022-05-11 Thread Iris Clark
On Wed, 11 May 2022 20:40:30 GMT, Joe Darcy wrote: > While doing a CSR review of another issue, I noticed some cases in > InputStream and OutputStream what would benefit from being upgraded to > implSpec and related javadoc tags. > > The "A subclass must provide an implementation of this metho

Re: RFR: JDK-8286347: incorrect use of `{@link}`

2022-05-06 Thread Iris Clark
On Fri, 6 May 2022 23:30:44 GMT, Jonathan Gibbons wrote: > Please review a small doc fix to update incorrect use of `{@link}` on arrays > of primitive types. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8584

Re: RFR: JDK-8285497: Add system property for Java SE specification maintenance version [v7]

2022-05-05 Thread Iris Clark
On Wed, 4 May 2022 23:10:06 GMT, Joe Darcy wrote: >> Add a new system property, java.specification.maintenance.version, to return >> the maintenance release number of the Java SE specification being >> implemented. The property is unset, optional in the terminology of >> System.getProperties,

Re: RFR: 8286154: Fix 3rd party notices in test files

2022-05-05 Thread Iris Clark
On Thu, 5 May 2022 16:13:59 GMT, Naoto Sato wrote: > Trivial fix to 3rd party copyright notices. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8558

Re: RFR: JDK-8285497: Add system property for Java SE specification maintenance version [v6]

2022-05-02 Thread Iris Clark
On Mon, 2 May 2022 20:31:18 GMT, Joe Darcy wrote: >> Add a new system property, java.specification.maintenance.version, to return >> the maintenance release number of the Java SE specification being >> implemented. The property is unset, optional in the terminology of >> System.getProperties,

Re: RFR: JDK-8285977: Add links to IEEE 754 specification

2022-05-02 Thread Iris Clark
On Mon, 2 May 2022 22:55:43 GMT, Joe Darcy wrote: > Please review the addition of @-see links from classes that mention the IEEE > 754 floating-point standard to an IEEE page about the standard. The URL in > the initial version of the PR is the top search result on the IEEE home page > for "75

Re: RFR: JDK-8285497: Add system property for Java SE specification maintenance version [v5]

2022-04-28 Thread Iris Clark
On Fri, 29 Apr 2022 01:20:17 GMT, Joe Darcy wrote: >> Add a new system property, java.specification.maintenance.version, to return >> the maintenance release number of the Java SE specification being >> implemented. The property is unset, optional in the terminology of >> System.getProperties,

Re: RFR: JDK-8285614: Fix typo in java.lang.Float

2022-04-25 Thread Iris Clark
On Mon, 25 Apr 2022 22:22:29 GMT, Joe Darcy wrote: > Fix typo introduced in JDK-8261123. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8390

Re: RFR: 8284922: Fix some doc-comment issues on methods with package access in JDK API

2022-04-15 Thread Iris Clark
On Fri, 15 Apr 2022 19:34:33 GMT, Pavel Rappo wrote: > People rarely include JDK elements with package access in a javadoc run. That > is why bugs in those elements' doc comments tend to remain unnoticed. > > There are many more bugs in the doc comments of the JDK elements with the > package a

Re: RFR: 8284856: Add a test case for checking UnicodeScript entity numbers [v2]

2022-04-14 Thread Iris Clark
On Thu, 14 Apr 2022 22:27:20 GMT, Naoto Sato wrote: >> Added the test case, and eliminated the immediate hashmap value, replaced >> with the ordinal number of `Character.UnicodeScript.UNKNOWN`. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last

Re: RFR: 8284856: Add a test case for checking UnicodeScript entity numbers

2022-04-14 Thread Iris Clark
On Thu, 14 Apr 2022 20:52:44 GMT, Naoto Sato wrote: > Added the test case, and eliminated the immediate hashmap value, replaced > with the ordinal number of `Character.UnicodeScript.UNKNOWN`. Nice catch in the review for 8186958. - Marked as reviewed by iris (Reviewer). PR: https

Re: RFR: 8284893: Fix typos in java.base

2022-04-14 Thread Iris Clark
On Thu, 14 Apr 2022 19:07:09 GMT, Magnus Ihse Bursie wrote: > I ran `codespell` on the `src/java.base` directory, and accepted those > changes where it indeed discovered real typos. > > (Due to false positives this can unfortunately not be run automatically) > > The majority of fixes are in c

Re: RFR: 8284702: Add @since for java.time.LocalDate.EPOCH

2022-04-12 Thread Iris Clark
On Tue, 12 Apr 2022 03:21:00 GMT, Glavo wrote: > `java.time.LocalDate.EPOCH` was introduced in Java 9, but there is no > corresponding `@since` in the javadoc. The absence of `@since` makes it > impossible for IDEs to check for misuse of it, it may be misused by users > targeting Java 8 and cr

Re: RFR: 8265315: Support for CLDR version 41 [v2]

2022-04-08 Thread Iris Clark
On Fri, 8 Apr 2022 20:17:52 GMT, Naoto Sato wrote: >> This is to upgrade the CLDR data from version 39 to version 41 which was >> released yesterday. The vast majority of the changes are basically replacing >> the CLDR data, along with tools/testcase alignments. Here is the link to >> CLDR v41

Re: RFR: 8284567: Collapse identical catch branches in java.base

2022-04-08 Thread Iris Clark
On Sat, 2 Apr 2022 16:05:06 GMT, Andrey Turbanov wrote: > Let's take advantage of Java 7 language feature - "Catching Multiple > Exception Types". > It simplifies code. Reduces duplication. > Found by IntelliJ IDEA inspection Identical 'catch' branches in 'try' > statement Marked as reviewed b

Re: RFR: 8265315: Support for CLDR version 41

2022-04-07 Thread Iris Clark
On Thu, 7 Apr 2022 21:20:20 GMT, Naoto Sato wrote: > This is to upgrade the CLDR data from version 39 to version 41 which was > released yesterday. The vast majority of the changes are basically replacing > the CLDR data, along with tools/testcase alignments. Here is the link to CLDR > v41's r

Re: RFR: 8283698: Refactor Locale constructors used in src/test

2022-04-06 Thread Iris Clark
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote: > This is a follow-on task after deprecating the Locale constructors > (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are > simple replacements to Locale constructors with `Locale.of()` or Locale > constants, such as `

Re: RFR: 8283842: TestZoneTextPrinterParser.test_roundTripAtOverlap fails: DateTimeParseException

2022-03-30 Thread Iris Clark
On Wed, 30 Mar 2022 16:46:40 GMT, Naoto Sato wrote: > Fixes test failures caused by depending on the default locale. Specifying > explicit `Locale.US` will do. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8045

Re: RFR: 8283889: Fix typo in package-info.java

2022-03-29 Thread Iris Clark
On Tue, 29 Mar 2022 18:23:31 GMT, Lance Andersen wrote: > Hi all, > > Please review this trivial fix which addresses a typo in > src/java.sql/share/classes/java/sql/package-info.java > > make docs is clean and I am also running mach5 tier1 as an extra sanity check > so there are no surprises

Re: RFR: 8283846: Remove unused jdk.internal.reflect.SignatureIterator

2022-03-29 Thread Iris Clark
On Tue, 29 Mar 2022 09:15:01 GMT, Andrey Turbanov wrote: > It was no longer used due to JDK-4479184 long ago. Nice clean-up. - Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8013

Re: RFR: JDK-8283668: Update IllegalFormatException to use sealed classes

2022-03-24 Thread Iris Clark
On Fri, 25 Mar 2022 04:17:57 GMT, Joe Darcy wrote: > Working down the list of candidates to be sealed, this time > IllegalFormatException. > > Please also review the companion CSR: > https://bugs.openjdk.java.net/browse/JDK-8283669 Marked as reviewed by iris (Reviewer). - PR: ht

Re: RFR: 8283465: Character.UnicodeBlock.NUM_ENTITIES is out of date [v2]

2022-03-22 Thread Iris Clark
On Tue, 22 Mar 2022 22:02:22 GMT, Naoto Sato wrote: >> Fixing the out-of-date number of entries in >> `Character.UnicodeBlock.NUM_ENTITIES` field. The regression test has been >> renamed and now repurposed just to examine whether the `NUM_ENTITIES` >> correctly has the `map.size()` value. > >

Re: RFR: 8283465: Character.UnicodeBlock.NUM_ENTITIES is out of date

2022-03-22 Thread Iris Clark
On Tue, 22 Mar 2022 18:44:09 GMT, Naoto Sato wrote: > Fixing the out-of-date number of entries in > `Character.UnicodeBlock.NUM_ENTITIES` field. The regression test has been > renamed and now repurposed just to examine whether the `NUM_ENTITIES` > correctly has the `map.size()` value. Marked

Re: RFR: 8283426: Fix 'exeption' typo

2022-03-20 Thread Iris Clark
On Sun, 20 Mar 2022 13:30:01 GMT, Andrey Turbanov wrote: > Fix repeated type `exeption` Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7879

Re: RFR: 8283277: ISO 4217 Amendment 171 Update

2022-03-17 Thread Iris Clark
On Thu, 17 Mar 2022 18:10:17 GMT, Naoto Sato wrote: > This is to incorporate the ISO 4217 amendment 171 for Sierra Leonean LEONE > redenomination (removing 3 zeros). Its effective date is 4/1, but I went > ahead as JDK19 won't be released by 4/1. Marked as reviewed by iris (Reviewer). ---

Re: RFR: JDK-8283274: Improve @jvms usage in java.base

2022-03-16 Thread Iris Clark
On Wed, 16 Mar 2022 16:57:12 GMT, Joe Darcy wrote: > As was done for JLS references under JDK-8283234, now the analogous update > for JVMS references. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7844

Re: RFR: JDK-8283234: Improve @jls usage in java.base

2022-03-15 Thread Iris Clark
On Wed, 16 Mar 2022 03:03:23 GMT, Joe Darcy wrote: > Checking the java.bases sources revealed a number of other instances where > conceptual links into the JLS (or JVMS) could be upgraded to actual links. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jd

Re: RFR: JDK-8283230: Improve @jls usage in ElementType

2022-03-15 Thread Iris Clark
On Wed, 16 Mar 2022 00:33:57 GMT, Joe Darcy wrote: > Improve some semantic links into JLS with actual links. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7831

Re: RFR: JDK-8283124: Add constant for tau to Math and StrictMath [v2]

2022-03-14 Thread Iris Clark
On Mon, 14 Mar 2022 23:21:26 GMT, Joe Darcy wrote: >> Add a constant for tau, 2*pi, to Math and StrictMath. Since 2*pi is a very >> common value in mathematical formulas, it is helpful to give it a distinct >> constant. >> >> Please also review the CSR https://bugs.openjdk.java.net/browse/JDK-

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

2022-03-04 Thread Iris Clark
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo Nice tidy of the code. Is there anything that can be done to prevent re-introduction of this trivial problem? Perhaps a new S

Re: RFR: 8282583: Update BCEL md to include the copyright notice [v2]

2022-03-03 Thread Iris Clark
On Thu, 3 Mar 2022 22:34:43 GMT, Joe Wang wrote: >> Update BCEL md to include the copyright notice. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > remove the section that's no longer in the notice file Marked as reviewed by i

Re: RFR: 8282583: Update BCEL md to include the copyright notice

2022-03-03 Thread Iris Clark
On Thu, 3 Mar 2022 17:51:31 GMT, Joe Wang wrote: > Update BCEL md to include the copyright notice. Confirm 2020, not 2022. Otherwise, looks good. - Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7681

Re: RFR: 8282131: java.time.ZoneId should be a sealed abstract class

2022-02-25 Thread Iris Clark
On Fri, 25 Feb 2022 19:02:55 GMT, Naoto Sato wrote: > Refactoring `java.time.ZoneId` class to be a sealed class. A CSR has also > been drafted. Associated CSR also reviewed. - Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7625

Re: RFR: 8282190: Typo in javadoc of java.time.format.DateTimeFormatter#getDecimalStyle

2022-02-21 Thread Iris Clark
On Mon, 21 Feb 2022 12:42:37 GMT, Jaikiran Pai wrote: > Can I please get a review of this trivial change to the javadoc of > `DateTimeFormatter.getDecimalStyle()` method which fixes the typo noted in > https://bugs.openjdk.java.net/browse/JDK-8282190? Marked as reviewed by iris (Reviewer). --

Re: RFR: 8276686: Malformed Javadoc inline tags in JDK source in /java/util/regex/Pattern.java

2022-02-17 Thread Iris Clark
On Thu, 17 Feb 2022 18:02:20 GMT, Ian Graves wrote: > Adding a missing period per this doc bug. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7521

Re: RFR: JDK-8281082: Improve javadoc references to JOSS

2022-02-01 Thread Iris Clark
On Tue, 1 Feb 2022 21:11:39 GMT, Joe Darcy wrote: > The references to JOSS, the Java Object Serialization Specification, are not > done consistently in the API javadoc. This should be improved. > > I'll update copyright years before pushing. Marked as reviewed by iris (Reviewer).

Re: RFR: JDK-8280534: Enable compile-time doclint reference checking [v2]

2022-01-28 Thread Iris Clark
On Fri, 28 Jan 2022 02:15:59 GMT, Joe Darcy wrote: >> The changes in this PR on top of the out-for-review changes in >> https://git.openjdk.java.net/jdk/pull/7222 allow compile-time doclint >> checking to be enabled in all JDK modules. >> >> Typically, a @SuppressWarnings("doclint:refernce") a

Re: RFR: JDK-8280744: Allow SuppressWarnings to be used in package declarations [v4]

2022-01-27 Thread Iris Clark
On Thu, 27 Jan 2022 23:27:54 GMT, Joe Darcy wrote: >> The SuppressWarnings annotation type is declared have multiple targets, >> including modules; however, "package" is left off of its target list. As >> package-info file are another kind of declaration where a compiler could >> give warnings

Re: RFR: JDK-8279242: Reflection newInstance() error message when constructor has no access modifiers could use improvement [v4]

2022-01-25 Thread Iris Clark
On Tue, 25 Jan 2022 18:25:14 GMT, Joe Darcy wrote: >> Making the exception message friendlier to users. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Fix typo. Marked as reviewed by iris (Reviewer). - PR: http

Re: RFR: JDK-8279242: Reflection newInstance() error message when constructor has no access modifiers could use improvement [v2]

2022-01-24 Thread Iris Clark
On Tue, 25 Jan 2022 05:25:12 GMT, Joe Darcy wrote: >> Making the exception message friendlier to users. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Respond to review feedback. Marked as reviewed by iris (Reviewer). -

Re: RFR: 8280531: Remove unused DeferredCloseInputStream

2022-01-24 Thread Iris Clark
On Tue, 18 Jan 2022 20:51:06 GMT, Andrey Turbanov wrote: > Class DeferredCloseInputStream is unused since removing of Solaris support > https://github.com/openjdk/jdk/blob/9fe4b69c1a1120e1d761730495c3cfac8f179d13/src/java.base/unix/classes/java/lang/ProcessImpl.java#L80-L81 Marked as reviewed by

Re: RFR: 8280403: RegEx: String.split can fail with NPE in Pattern.CharPredicate::match

2022-01-24 Thread Iris Clark
On Mon, 24 Jan 2022 17:21:57 GMT, Ian Graves wrote: > Replacing a buggy NullPointerException in `Pattern.compile()` with the proper > PatternSyntaxException Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7201

Re: RFR: JDK-8280492: Address remaining doclint issues in JDK build

2022-01-22 Thread Iris Clark
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote: > Use presumed syntax that will be introduced by JDK-8280488. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7189

Re: [jdk18] RFR: JDK-8279179: Update nroff pages in JDK 18 before RC

2022-01-21 Thread Iris Clark
On Fri, 21 Jan 2022 18:37:50 GMT, Jonathan Gibbons wrote: > Please review this semi-automated update to the nroff man pages from the > upstream repo. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk18/pull/112

Re: RFR: 8280470: Confusing instanceof check in HijrahChronology.range

2022-01-21 Thread Iris Clark
On Mon, 17 Jan 2022 21:02:35 GMT, Andrey Turbanov wrote: > Parameter `ChronoField field` is checked by `if (field instanceof > ChronoField)`. Such check is confusing, because only one case, when this > could be `false` is when `field == null`. > But if condition is not satisfied we will get imm

Re: RFR: 8268081: Upgrade Unicode Data Files to 14.0.0

2022-01-05 Thread Iris Clark
On Wed, 5 Jan 2022 22:42:38 GMT, Naoto Sato wrote: > Please review the changes for upgrading the Unicode support in the JDK, from > version 13 to version 14. Corresponding CSR has also been drafted. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull

Re: RFR: 8278587: StringTokenizer(String, String, boolean) documentation bug [v2]

2021-12-16 Thread Iris Clark
On Thu, 16 Dec 2021 18:41:32 GMT, Naoto Sato wrote: >> This is a doc fix to `StringTokenizer`, where the original spec does not >> account for the delimiter's length in the case of a supplementary character. >> Corresponding CSR has been drafted: >> https://bugs.openjdk.java.net/browse/JDK-827

Re: RFR: 8278587: StringTokenizer(String, String, boolean) documentation bug

2021-12-14 Thread Iris Clark
On Tue, 14 Dec 2021 18:25:45 GMT, Naoto Sato wrote: > This is a doc fix to `StringTokenizer`, where the original spec does not > account for the delimiter's length in the case of a supplementary character. > Corresponding CSR has been drafted: > https://bugs.openjdk.java.net/browse/JDK-8278814

Re: [jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC

2021-12-09 Thread Iris Clark
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote: > Please review this semi-automatic update for the nroff man pages for JDK 18. > The changes update the version number, copyright year, and incorporate the > changes from the latest upstream files. Marked as reviewed by iris (Reviewer)

Re: RFR: JDK-8278273: Remove unnecessary exclusion of doclint accessibility checks

2021-12-05 Thread Iris Clark
On Sun, 5 Dec 2021 23:45:32 GMT, Joe Darcy wrote: > Exploratory builds indicate it is not currently necessary to exclude the > doclint accessibility checks; this patch enables them. > > (Enabling the reference checks is left for future work.) Marked as reviewed by iris (Reviewer). ---

Re: RFR: 8278071: typos in MemorySegment::set, MemorySegment::setAtIndex javadoc

2021-12-01 Thread Iris Clark
On Wed, 1 Dec 2021 13:49:42 GMT, Maurizio Cimadamore wrote: > There are some truncated statements in > MemorySegment::get/MemorySegment::getAtIndex javadoc, more specifically in > the `@throws` for `IndexOutOfBoundsException`. Trivial fix for an apparent cut-and-paste error. - M

Re: RFR: 8277986: Typo in javadoc of java.util.zip.ZipEntry#setTime

2021-11-30 Thread Iris Clark
On Tue, 30 Nov 2021 14:28:05 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which fixes a typo in the javadoc > of `java.util.zip.ZipEntry.setTime()` method? Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6615

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v5]

2021-11-29 Thread Iris Clark
On Mon, 29 Nov 2021 18:38:35 GMT, Joe Darcy wrote: >> The time to get JDK 19 underway draws nigh, please review this usual set of >> start-of-release updates, including CSRs for the javac and javax.lang.model >> updates: >> >> JDK-8277512: Add SourceVersion.RELEASE_19 >> https://bugs.openjdk.j

Re: RFR: 8277322: Document that setting an invalid property `jdk.serialFilter` disables deserialization

2021-11-22 Thread Iris Clark
On Mon, 22 Nov 2021 19:57:25 GMT, Roger Riggs wrote: > The effects of an invalid `jdk.serialFilter` property are not completely > documented. If the value of the system property jdk.serialFilter is invalid, > deserialization should not be possible and it should be clear in the > specification.

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v2]

2021-11-22 Thread Iris Clark
On Mon, 22 Nov 2021 04:30:38 GMT, Joe Darcy wrote: >> The time to get JDK 19 underway draws nigh, please review this usual set of >> start-of-release updates, including CSRs for the javac and javax.lang.model >> updates: >> >> JDK-8277512: Add SourceVersion.RELEASE_19 >> https://bugs.openjdk.j

Re: RFR: 8276141: XPathFactory set/getProperty method [v10]

2021-11-19 Thread Iris Clark
On Thu, 18 Nov 2021 23:43:20 GMT, Joe Wang wrote: >> Add setProperty/getProperty methods to the XPath API so that properties can >> be supported in the future. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > update as commente

Re: RFR: 8272042: java.util.ImmutableCollections$Map1 and MapN should not be @ValueBased

2021-11-19 Thread Iris Clark
On Fri, 19 Nov 2021 15:50:47 GMT, Roger Riggs wrote: > The `jdk.internal.ValueBased` annotation was incorrectly applied to > subclasses of java.util.AbstractMap. > [ValueBased](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/doc-files/ValueBased.html) > requires that supe

Re: RFR: 8274333: Redundant null comparison after Pattern.split

2021-11-18 Thread Iris Clark
On Sun, 26 Sep 2021 15:10:52 GMT, Andrey Turbanov wrote: > In couple of classes, result part of arrays of Pattern.split is compared with > `null`. Pattern.split (and hence String.split) never returns `null` in array > elements. Such comparisons are redundant. Marked as reviewed by iris (Review

Re: RFR: 8275386: Change nested classes in jdk.jlink to static nested classes

2021-11-18 Thread Iris Clark
On Sun, 17 Oct 2021 21:06:44 GMT, Andrey Turbanov wrote: > Non-static classes hold a link to their parent classes, which can be avoided. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5983

Re: RFR: 8275007: Java fails to start with null charset if LC_ALL is set to certain locales [v8]

2021-11-17 Thread Iris Clark
On Wed, 17 Nov 2021 17:48:39 GMT, Naoto Sato wrote: >> Please review the subject fix. In light of JEP400, Java runtime can/should >> start in UTF-8 charset if the underlying native encoding is not supported. > > Naoto Sato has updated the pull request incrementally with one additional > commit

Re: RFR: 8277048: Tiny improvements to the specification text for java.util.Properties.load

2021-11-12 Thread Iris Clark
On Fri, 12 Nov 2021 12:25:20 GMT, Pavel Rappo wrote: > Please review this simple two-hunk fix to the documentation comment of > java.util.Properties#load(java.io.Reader). The first hunk (line/lines) is a > suggestion. I believe it reads better since the plurality is more idiomatic; > native En

Re: RFR: 8276186: Require getAvailableLocales() methods to include Locale.ROOT [v2]

2021-11-10 Thread Iris Clark
On Wed, 10 Nov 2021 19:05:17 GMT, Naoto Sato wrote: >> This fix is to require to include `Locale.ROOT` in the returned arrays/set >> from `getAvailableLocales()` methods in various locale-sensitive classes. >> The implementation has been including `Locale.ROOT` since its inception, it >> is si

Re: RFR: 8276775: ZonedDateTime/OffsetDateTime.toString return invalid ISO-8601 for years <= 1893

2021-11-09 Thread Iris Clark
On Tue, 9 Nov 2021 22:29:12 GMT, Naoto Sato wrote: > Simple doc clarification where the `toString()` output only conforms to ISO > 8601 if the seconds in the offset are zero. CSR also Reviewed. - Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/632

Re: RFR: 8275007: Java fails to start with null charset if LC_ALL is set to certain locales [v2]

2021-11-09 Thread Iris Clark
On Tue, 9 Nov 2021 19:38:01 GMT, Naoto Sato wrote: >> Please review the subject fix. In light of JEP400, Java runtime can/should >> start in UTF-8 charset if the underlying native encoding is not supported. > > Naoto Sato has updated the pull request incrementally with one additional > commit s

Re: RFR: 8275007: Java fails to start with null charset if LC_ALL is set to certain locales

2021-11-05 Thread Iris Clark
On Fri, 5 Nov 2021 17:31:50 GMT, Naoto Sato wrote: > Please review the subject fix. In light of JEP400, Java runtime can/should > start in UTF-8 charset if the underlying native encoding is not supported. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jd

Re: RFR: JDK-8276650: GenGraphs does not produce deterministic output

2021-11-04 Thread Iris Clark
On Thu, 4 Nov 2021 19:28:58 GMT, Mandy Chung wrote: > The dot graph should print the edges in alphatical order. A simple fix to > sort the edges before printing them. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6266

Re: RFR: 8276629: Use blessed modifier order in core-libs code

2021-11-04 Thread Iris Clark
On Thu, 4 Nov 2021 11:09:42 GMT, Magnus Ihse Bursie wrote: > I ran bin/blessed-modifier-order.sh on source owned by core-libs. This > scripts verifies that modifiers are in the "blessed" order, and fixes it > otherwise. I have manually checked the changes made by the script to make > sure they

Re: RFR: 8276348: Use blessed modifier order in java.base

2021-11-02 Thread Iris Clark
On Tue, 2 Nov 2021 16:30:56 GMT, Pavel Rappo wrote: > This PR follows up one of the recent PRs, where I used a non-canonical > modifier order. Since the problem was noticed [^1], why not to address it at > mass? > > As far as I remember, the first mass-canonicalization of modifiers took place

Re: RFR: 8276188: Clarify "default charset" descriptions in String class

2021-11-01 Thread Iris Clark
On Mon, 1 Nov 2021 18:31:17 GMT, Naoto Sato wrote: > This is a leftover document fix to `String` class for the JEP 400. > Corresponding CSR has also been drafted: > https://bugs.openjdk.java.net/browse/JDK-8276238 Diffs align with the corresponding CSR, which I have also reviewed. ---

Re: RFR: JDK-8276236: Table headers missing in Formatter api docs

2021-11-01 Thread Iris Clark
On Mon, 1 Nov 2021 15:59:22 GMT, Ludvig Janiuk wrote: > Adds table headers to all tables in Formatter api docs. I inferred the header > "Unicode" for the columns that contained unicode > codepoints. > > Formatter api docs: > https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/uti

Re: RFR: 8276234: Trivially clean up locale-related code [v2]

2021-11-01 Thread Iris Clark
On Mon, 1 Nov 2021 16:51:36 GMT, Pavel Rappo wrote: >> Please review this PR. A comprehensive test job has been scheduled; I'll >> notify this thread once that job has completed. > > Pavel Rappo has updated the pull request incrementally with one additional > commit since the last revision: >

Re: RFR: 8275766: (tz) Update Timezone Data to 2021e

2021-10-28 Thread Iris Clark
On Thu, 28 Oct 2021 01:02:27 GMT, Yoshiki Sato wrote: > Please review the integration of tzdata2021e (including tzdata2021d) to the > JDK. > The fix has passed all relevant JTREG regression tests and JCK tests. > > 8275754: (tz) Update Timezone Data to 2021d > 8275849: TestZoneInfo310.java fai

Re: RFR: 8275767: JDK source code contains redundant boolean operations in jdk.charsets

2021-10-25 Thread Iris Clark
On Mon, 25 Oct 2021 16:08:29 GMT, Naoto Sato wrote: > Trivial clean-up. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6110

Re: RFR: JDK-8275686: Suppress warnings on non-serializable non-transient instance fields in java.rmi

2021-10-20 Thread Iris Clark
On Thu, 21 Oct 2021 01:06:33 GMT, Joe Darcy wrote: > Another serialization warnings cleanup; this time in java.rmi. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6055

Re: RFR: 7008363: TEST_BUG: test/java/lang/StringCoding/CheckEncodings.sh does nothing and is very slow at that

2021-10-18 Thread Iris Clark
On Mon, 18 Oct 2021 20:49:07 GMT, Naoto Sato wrote: > Removing a problem-listed test case, which has little value in itself. > Confirmed it did succeed on all platforms before the removal. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5996

Re: RFR: 8275145: file.encoding system property has an incorrect value on Windows

2021-10-14 Thread Iris Clark
On Thu, 14 Oct 2021 15:50:28 GMT, Naoto Sato wrote: > Fixing a regression in which `file.encoding` was initialized by > `sprops->encoding` instead of `sprops->sun_jnu_encoding` on non macOS > platforms. tier1-3 tests passed on all platforms. Marked as reviewed by iris (Reviewer).

Re: RFR: 8275197: Remove unused fields in ThaiBuddhistChronology

2021-10-14 Thread Iris Clark
On Tue, 12 Oct 2021 21:10:12 GMT, Andrey Turbanov wrote: > Remove 3 unused HashMap's. > Reported here > https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-September/081866.html > I did the similar PR to treetenbp and it was merged > https://github.com/ThreeTen/threetenbp/pull/155 Marke

Re: RFR: JDK-8275249: Suppress warnings on non-serializable array component types in jdk.jlink

2021-10-13 Thread Iris Clark
On Wed, 13 Oct 2021 21:08:41 GMT, Joe Darcy wrote: > After a refinement to the checks under development in #5709, the new checks > examine array types of serial fields and warn if the underlying component > type is not serializable. Per the JLS, all array types are serializable, but > if the b

Re: RFR: 8275163: Deflater::deflate methods omit javadoc for ReadOnlyBufferException

2021-10-13 Thread Iris Clark
On Wed, 13 Oct 2021 17:43:29 GMT, Lance Andersen wrote: > Hi all, > > Please review the fix to address a javadoc issue for the Deflater::deflate > methods that were added as part of JDK-6341887 that could throw a > ReadOnlyBufferException. > > The` @throws ` clause for `ReadOnlyBufferExcep

Re: RFR: 8274946: Cleanup unnecessary calls to Throwable.initCause() in java.rmi

2021-10-08 Thread Iris Clark
On Thu, 7 Oct 2021 18:00:33 GMT, Andrey Turbanov wrote: > Pass cause exception as constructor parameter is shorter and easier to read. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5854

Re: RFR: 8274864: Remove Amman/Cairo hacks in ZoneInfoFile

2021-10-07 Thread Iris Clark
On Thu, 7 Oct 2021 21:30:22 GMT, Naoto Sato wrote: > While working on tzdata2021c update, I noticed there is a dead code in > `sun.util.calendar.ZoneInfoFile`, which was used to tweak the rules for > `endOfDay` for certain cases. These are no longer needed as JDK's code is > already capable of

Re: RFR: 8274407: (tz) Update Timezone Data to 2021c

2021-10-06 Thread Iris Clark
On Wed, 6 Oct 2021 01:24:49 GMT, Naoto Sato wrote: > This PR is to upgrade the time zone data in the JDK to IANA's tzdata2021c > level. Note that the tz data is "as is", as released by IANA. No `merged > links` are retracted. > The PR also fixes two issues along with the 2021c upgrade. Marked

Re: RFR: 8274658: ISO 4217 Amendment 170 Update

2021-10-01 Thread Iris Clark
On Fri, 1 Oct 2021 18:57:28 GMT, Naoto Sato wrote: > This is to incorporate the ISO 4217 amendment #170, which has been released > today, effective immediately. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5790

Re: RFR: 8274525: Replace uses of StringBuffer with StringBuilder in java.xml

2021-09-30 Thread Iris Clark
On Wed, 29 Sep 2021 17:56:49 GMT, Andrey Turbanov wrote: > StringBuffer is a legacy synchronized class. There are more modern > alternatives which perform better: > 1. Plain String concatenation should be preferred > 2. StringBuilder is a direct replacement to StringBuffer which generally have

  1   2   3   4   >