Re: RFR [16]: 8250665 : Wrong translation for the month of May in ar_JO, ar_LB and ar_SY

Thank you Naoto, pushed. -Leo On 8/7/20 2:18 AM, naoto.s...@oracle.com wrote: Looks good to me. Naoto On 8/6/20 9:47 AM, li.ji...@oracle.com wrote: Hi, Pls review the fix for month names in COMPAT provider data for ar_JO/LB/SY. Customer reported some month names are incorrect in JDK8

RFR [16]: 8250665 : Wrong translation for the month of May in ar_JO, ar_LB and ar_SY

Hi, Pls review the fix for month names in COMPAT provider data for ar_JO/LB/SY. Customer reported some month names are incorrect in JDK8 code according to latest CLDR definition. Bug: https://bugs.openjdk.java.net/browse/JDK-8250665 Webrev:

Re: RFR: 8249086: JDK 15 L10n resource file update - msg drop 10

Thank you Naoto! The patch was pushed into jdk/jdk15. Thanks, Leo On 7/9/20 3:53 AM, naoto.s...@oracle.com wrote: Hi Leo, Looks good to me. Naoto On 7/8/20 10:58 AM, li.ji...@oracle.com wrote: Hi, Pls review the l10n resource files update for JDK 15 msg drop 10. Bug:

RFR: 8249086: JDK 15 L10n resource file update - msg drop 10

Hi, Pls review the l10n resource files update for JDK 15 msg drop 10. Bug: https://bugs.openjdk.java.net/browse/JDK-8249086 Webrev: http://cr.openjdk.java.net/~ljiang/8249086/read/ Thanks, Leo

Re: [14] RFR (l10n) 8238377 : JDK 14 L10n resource files update - msg drop 20

Hi Naoto, Seems the tool parsed the version and encoding attributes, and wrote back with the values. Actually I don't know how they works, but since this is a minor issue from t9n tool side, I had added a post-edit script to fix the xml version/encoding line and the CR dos format issue.

Re: [14] RFR (l10n) 8238377 : JDK 14 L10n resource files update - msg drop 20

Hi Naoto, For wxl file, the mentioned problems are not issue. 1. The wxl files are only working for window installer, so DOS format is good for these files, or even better. 2. The localized wxl is generated by t9n system, so they may normalize (in their standard) the text. If we keep the

[14] RFR (l10n) 8238377 : JDK 14 L10n resource files update - msg drop 20

Hi, Please review the update for L10n resource files in JDK 14 msg drop 20. In this fix, we cover l10n resource files for the MSI installer of jpackage and the latest update from jdeps and jshell. https://bugs.openjdk.java.net/browse/JDK-8238377

Re: RFR: 8237465: JDK 14 L10N resource files update - msg drop 10

Hi Naoto, Thank you for reviewing. The eol characters were removed by t9n system, if I correct the format manually the next time we run the msg drop it would be back. Considering we need to kick off the next msg drop soon, I prefer not to fix it this time. Regards, Leo On 1/18/20 2:31 AM,

RFR: 8237465: JDK 14 L10N resource files update - msg drop 10

Hi, Please review the L10N resource files update for JDK 14 msg drop 10. https://bugs.openjdk.java.net/browse/JDK-8237465 http://cr.openjdk.java.net/~ljiang/8237465/webrev/read/ This is the first msg drop for JDK 14 L10N resources files update, so this webrev would cover most of update for

RFR: 8228778: JDK 13 L10n resource files update - msg drop 20

Hi, Please help to review the update of L10n resource files in JDK13 msg drop 20. Bug: https://bugs.openjdk.java.net/browse/JDK-8228778 Webrev: http://cr.openjdk.java.net/~ljiang/8228778/webrev/read/ Thanks, Leo

RFR: 8228623 : Update copyright year to 2019 for several java properties file

Hi, Please review this trivial change to correct the copyright year in several java properties file. I updated the copyright year in English, Simplified Chinese and Japanese resource files. Bug: https://bugs.openjdk.java.net/browse/JDK-8228623 Webrev:

Re: RFR: 8228397: Missing license copyright header in some resource properties files

Thank you for your reviewing. Updated the webrev: http://cr.openjdk.java.net/~ljiang/8228397/webrev.01/ I know the update is trivial, if no more suggestion I will push the patch tomorrow. Thanks, Leo On 7/23/19 3:55 AM, Mandy Chung wrote: Hi Leo, Thanks for adding the copyright and

RFR: 8228397: Missing license copyright header in some resource properties files

Hi all, Please review this change. We found the license copyright header are missing in some resource properties files, some of them are very old and no hg log since code forest consolidation. In this change, I added the license copyright header in the English and its localized resource

Re: RFR: 8218781 : Localized names for Japanese Era Reiwa in COMPAT provider

Thank you, pushed. /Leo On 5/19/19 9:55 PM, naoto.s...@oracle.com wrote: Looks good. Naoto On 5/18/19 6:23 AM, li.ji...@oracle.com wrote: Hi Naoto, Please review the updated webrev: http://cr.openjdk.java.net/~ljiang/8218781/webrev.01/ In this update, renamed the data provider names and

Re: RFR: 8218781 : Localized names for Japanese Era Reiwa in COMPAT provider

Hi Naoto, Please review the updated webrev: http://cr.openjdk.java.net/~ljiang/8218781/webrev.01/ In this update, renamed the data provider names and test case name to improve the readability. Thanks, Leo On 5/18/19 12:39 AM, naoto.s...@oracle.com wrote: Hi Leo, Overall looks good. One

RFR: 8218781 : Localized names for Japanese Era Reiwa in COMPAT provider

Hi all, Please review the change to update the l10n names for Japanese era Reiwa in JDK COMPAT provider. The l10n names come from the CLDR 35.1, please refer this unicode chart[1] for l10n definitions. Bug: https://bugs.openjdk.java.net/browse/JDK-8218781 Webrev:

Re: UnicodeDecoder U+FFFE handling

Sounds this request is reasonable since Unicode 7: do not consider the U+FFFE in the middle of stream as malformed. FAQ about private use characters and non-characters. [1] http://www.unicode.org/faq/private_use.html Q: Are noncharacters invalid in Unicode strings and UTFs? A: Absolutely

Re: RFR of JDK-8214431: tests failed because can not find removed library folder at test/jdk/lib/testlibrary/jdk/testlibrary

Just read the webrev, already covered :) -Leo On 11/28/18 9:09 PM, li.ji...@oracle.com wrote: Hi Hamlin, You can find some tests under sun/management/jmxremote/ failed on this issue too. Thanks, Leo On 11/28/18 7:15 PM, Hamlin Li wrote: Hi David, Thank a lot for double checking the

Re: RFR of JDK-8214431: tests failed because can not find removed library folder at test/jdk/lib/testlibrary/jdk/testlibrary

Hi Hamlin, You can find some tests under sun/management/jmxremote/ failed on this issue too. Thanks, Leo On 11/28/18 7:15 PM, Hamlin Li wrote: Hi David, Thank a lot for double checking the usage of testlibrary. I have updated the patch, http://cr.openjdk.java.net/~mli/8214431/webrev.00/

RFR: 8210153 : java/text/Format/NumberFormat/CurrencyFormat.java failed

Hi Naoto, Please review the fix to update the currency symbol for VES. Bug: https://bugs.openjdk.java.net/browse/JDK-8210153 Webrev: http://cr.openjdk.java.net/~ljiang/8210153/webrev/ Built and tier1~tier3 tests passed on mach5. Thanks, Leo

RFR: 8208746 8209775 : ISO 4217 Amendment #168 #169 Update

Hi, Please review the changes for ISO 4217 Amendment #168 #169. Bugs: https://bugs.openjdk.java.net/browse/JDK-8208746 168 https://bugs.openjdk.java.net/browse/JDK-8209775 169 Only in amendment #168 has real currency data update for Java, but I also updated the data version to #169 for

Re: [11] RFR: 8202026 8193552 8204269 : ISO 4217 Amendment #165 # 166 #167 Update

Hi Naoto, I removed the obsoleted currency LTL and LVL from tablea1.txt, added them into otherCodes in ValidateISO4217.java. new webrev as below: http://cr.openjdk.java.net/~ljiang/8202026/webrev.03/ Thanks, Leo On 05/06/2018 2:27 AM, naoto.s...@oracle.com wrote: Hi Leo, Change looks

Re: [11] RFR: 8202026 8193552 8204269 : ISO 4217 Amendment #165 # 166 #167 Update

Hi Naoto, Pls review the updated code: http://cr.openjdk.java.net/~ljiang/8202026/webrev.02/ - As suggested, clean up the old transition dates. - Update copyright year. - ISO 4217 Amendment #167 was published today, which discards the #166, so withdraw the change for #166 in webrev.02. Bug