Re: (10) RFR of JDK-8181478, Refactor java/io shell tests to plain java tests

2017-06-19 Thread Paul Sandoz
> On 18 Jun 2017, at 19:47, Hamlin Li wrote: > > > > On 2017/6/17 1:31, Paul Sandoz wrote: >>> On 14 Jun 2017, at 23:29, Hamlin Li wrote: >>> >>> Hi Alan, Paul, >>> >>> Thank you for review, new webrev at: >>>

Re: (10) RFR of JDK-8181478, Refactor java/io shell tests to plain java tests

2017-06-18 Thread Hamlin Li
On 2017/6/17 1:31, Paul Sandoz wrote: On 14 Jun 2017, at 23:29, Hamlin Li wrote: Hi Alan, Paul, Thank you for review, new webrev at: http://cr.openjdk.java.net/~mli/8181478/webrev.01/ Please also check my comments inline. On 2017/6/15 1:28, Alan Bateman wrote: On

Re: (10) RFR of JDK-8181478, Refactor java/io shell tests to plain java tests

2017-06-16 Thread Paul Sandoz
> On 14 Jun 2017, at 23:29, Hamlin Li wrote: > > Hi Alan, Paul, > > Thank you for review, new webrev at: > http://cr.openjdk.java.net/~mli/8181478/webrev.01/ > > Please also check my comments inline. > > > On 2017/6/15 1:28, Alan Bateman wrote: >> >> On 14/06/2017

Re: (10) RFR of JDK-8181478, Refactor java/io shell tests to plain java tests

2017-06-16 Thread Hamlin Li
Ping. Thank you -Hamlin On 2017/6/15 14:29, Hamlin Li wrote: Hi Alan, Paul, Thank you for review, new webrev at: http://cr.openjdk.java.net/~mli/8181478/webrev.01/ Please also check my comments inline. On 2017/6/15 1:28, Alan Bateman wrote: On 14/06/2017 18:20, Paul Sandoz wrote: On

Re: (10) RFR of JDK-8181478, Refactor java/io shell tests to plain java tests

2017-06-15 Thread Hamlin Li
Hi Alan, Paul, Thank you for review, new webrev at: http://cr.openjdk.java.net/~mli/8181478/webrev.01/ Please also check my comments inline. On 2017/6/15 1:28, Alan Bateman wrote: On 14/06/2017 18:20, Paul Sandoz wrote: On 12 Jun 2017, at 01:00, Hamlin Li wrote:

Re: (10) RFR of JDK-8181478, Refactor java/io shell tests to plain java tests

2017-06-14 Thread Alan Bateman
On 14/06/2017 18:20, Paul Sandoz wrote: On 12 Jun 2017, at 01:00, Hamlin Li wrote: Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8181478 webrev: http://cr.openjdk.java.net/~mli/8181478/webrev.00/ It took me a few moments to

Re: (10) RFR of JDK-8181478, Refactor java/io shell tests to plain java tests

2017-06-14 Thread Paul Sandoz
> On 12 Jun 2017, at 01:00, Hamlin Li wrote: > > Would you please review the below patch? > > bug: https://bugs.openjdk.java.net/browse/JDK-8181478 > > webrev: http://cr.openjdk.java.net/~mli/8181478/webrev.00/ > It took me a few moments to grok the NonExistentDriver

(10) RFR of JDK-8181478,Refactor java/io shell tests to plain java tests

2017-06-12 Thread Hamlin Li
Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8181478 webrev: http://cr.openjdk.java.net/~mli/8181478/webrev.00/ Thank you -Hamlin