Hi,
Thanks for all the feedback.
I have updated the webrev
http://cr.openjdk.java.net/~dfuchs/webrev_8173111/webrev.01
The test now uses assertEquals as suggested by Lance and Aleksej
(thanks for the suggestion).
I also fixed the missing white space in the code that Christoph
spotted at line
111: Excessive recursion in EventFilterSupport when
> filtering over large number of XML events can cause StackOverflow
>
> Hi,
>
> Please find below a fix for:
>
> 8173111: Excessive recursion in EventFilterSupport when filtering
> over large numb
Hi,
I would keep the main, it is handy to debug the test standalone. (It
will still need testng.jar).
$02, Roger
On 1/23/17 3:24 PM, Aleks Efimov wrote:
Hi Daniel, Lance,
It looks like Assert.assertEquals(String actual, String expected,
String message) suites better and lines 73-77 can
Hi Aleks,
> On Jan 23, 2017, at 3:24 PM, Aleks Efimov wrote:
>
> Hi Daniel, Lance,
>
> It looks like Assert.assertEquals(String actual, String expected, String
> message) suites better and lines 73-77 can be replaced with:
> assertEquals(sb.toString(), SMOKE, "Smoke
Hi Daniel, Lance,
It looks like Assert.assertEquals(String actual, String expected, String
message) suites better and lines 73-77 can be replaced with:
assertEquals(sb.toString(), SMOKE, "Smoke test failed" ).
And do we really need 'main' here? All test methods are annotated with
@Test tags
Hi Daniel,
The changes look fine.
Did you give any consideration to using assertFalse in the smokeTest at line
73?
Probably want to consider a back port at some point to 8u when time permits.
Best
Lance
> On Jan 23, 2017, at 12:48 PM, Daniel Fuchs wrote:
>
> Hi,
>
Hi,
Please find below a fix for:
8173111: Excessive recursion in EventFilterSupport when filtering
over large number of XML events can cause StackOverflow
https://bugs.openjdk.java.net/browse/JDK-8173111
The fix is almost trivial: it replaces a recursion by a loop in
two places.