Hello.
I'm not reviewer, but I tested your fix with some locales (non-UTF8
locales) on AIX platform.
$ LANG=C javac TestIBMBugs.java
$ LANG=ko_KR javac TestIBMBugs.java
$ LANG=zh_CN javac TestIBMBugs.java
Also testcase worked fine as expected.
Thanks,
Ichiroh Takiguchi
IBM Japan, Ltd.
On
Hi Mikael, Thomas, Alan,
thanks a lot for the quick reviews.
I've just fixed the typo and pushed the fix.
Sorry for the trouble,
Volker
On Fri, Jul 6, 2018 at 9:06 AM, Alan Bateman wrote:
> On 06/07/2018 08:03, Mikael Vidstedt wrote:
>>
>> Fix the typo while at it?
>>
>> +// and [yen]
On 06/07/2018 08:03, Mikael Vidstedt wrote:
Fix the typo while at it?
+// and [yen] an [overscore] are encoded to 0x5c and 0x7e
an -> and
I agree, otherwise looks okay to me.
-Alan
Hi Volker, looks good and trivial. I did not test-compile it, but I
trust you did that already.
Best Regards, Thomas
On Fri, Jul 6, 2018 at 8:56 AM, Volker Simonis wrote:
> Hi,
>
> can I please have a review for this trivial test fix?
>
>
Fix the typo while at it?
+// and [yen] an [overscore] are encoded to 0x5c and 0x7e
an -> and
Cheers,
Mikael
> On Jul 5, 2018, at 11:56 PM, Volker Simonis wrote:
>
> Hi,
>
> can I please have a review for this trivial test fix?
>
>
Hi,
can I please have a review for this trivial test fix?
http://cr.openjdk.java.net/~simonis/webrevs/2018/8206436/
https://bugs.openjdk.java.net/browse/JDK-8206436
The problem is that the test contains some non-ASCII characters in
comments which makes the compilation fail for non-Unicode
